Re: [FFmpeg-devel] [PATCH v4 0/7] Support Dolby Vision

2020-04-19 Thread myp...@gmail.com
On Sun, Apr 19, 2020 at 9:08 AM Jun Zhao wrote: > > From: Jun Zhao > > V4: > - change the DOVI dump message (tks Jan Ekström) > - fix the file order in Makefile > > V3: > - rename the file name for Dolby Vision trademark risk(tks Jean-Baptiste > Kempf) > - fix other typo issue > > V2: > - used

Re: [FFmpeg-devel] [PATCH V1 2/4] lavc/hevcdec: fix the HEVC decoder crash when memory over-read

2020-04-19 Thread myp...@gmail.com
On Sun, Apr 12, 2020 at 9:18 AM myp...@gmail.com wrote: > > On Sat, Apr 11, 2020 at 10:48 PM Carl Eugen Hoyos wrote: > > > > Am Sa., 11. Apr. 2020 um 16:24 Uhr schrieb myp...@gmail.com > > : > > > > > > On Mon, Mar 30, 2020 at 4:52 PM myp...@gmail.com wrote: > > > > > > > > On Mon, Mar 30,

[FFmpeg-devel] [PATCH] avformat/rtsp: Put strings instead of pointers to strings into array

2020-04-19 Thread Andreas Rheinhardt
In this example, the difference in length between the shortest and longest string is three, so that not using pointers to strings saves space even on 32bit systems. Moreover, there is no need to use a sentinel here; it can be replaced with FF_ARRAY_ELEMS. Signed-off-by: Andreas Rheinhardt --- I

[FFmpeg-devel] [PATCH] avformat/rtsp: Don't free uninitialized AVBPrint

2020-04-19 Thread Andreas Rheinhardt
Fixes Coverity ID 1462307. Signed-off-by: Andreas Rheinhardt --- I intend to apply this soon if there are no objections. libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 49f7644fab..0a6462000d 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-04-19 Thread Michael Niedermayer
On Sun, Apr 19, 2020 at 05:52:01PM +0200, Lynne wrote: > Apr 19, 2020, 16:05 by mich...@niedermayer.cc: > > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in > > type 'int' > > Fixes: > >

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_mp4toannexb_bsf: Check nalu_size

2020-04-19 Thread Michael Niedermayer
Fixes: Timeout (29sec -> 5ms) Fixes: 20237/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5165615044362240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Reduce maxpixels for HEVC

2020-04-19 Thread Michael Niedermayer
high resolutions with only small blocks appear to be rather slow with the fuzzer + sanitizers. A solution which makes this run faster is welcome. Fixes: Timeout (did not wait -> 17sec) Fixes: 21006/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6002552539971584 Found-by:

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:44, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:53, Wolfgang Haupt wrote: Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to review this patch? It's an attempt to fix rtsp streams that use udp multicasts as the

Re: [FFmpeg-devel] [PATCH] swscale: aarch64: Avoid using the x18 register

2020-04-19 Thread Martin Storsjö
On Sun, 19 Apr 2020, Martin Storsjö wrote: The x18 is a reserved platform register on Darwin and Windows. x8/w8 seems to be unused in this function though (and same about x10 and x14), so there's really no reason to use x18 here - just change the uses of x18/w18 into x8/w8 instead without any

[FFmpeg-devel] [PATCH v2] swscale: aarch64: Don't clobber callee-saved registers v8-v15

2020-04-19 Thread Martin Storsjö
--- If there would have been checkasm tests for these functions, it would have been caught immediately. Fixed one missed case (because the code used mixed upper/lower case for register names, mixing v8 with V8, so I missed one with search/replace, and as there's no dedicated checkasm test, it can

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Ross Nicholson
> On 19 Apr 2020, at 20:30, Carl Eugen Hoyos wrote: > > Am So., 19. Apr. 2020 um 20:45 Uhr schrieb Ross Nicholson > : >> >> That’s really strange all my git config’s are just phunkyfish. >> >> I don’t really mind which name is used but I guess I’ll update >> everything to my real name going

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: Improve mimetype search

2020-04-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Use the mime_types of the corresponding AVCodecDescriptor instead of > tables specific to Matroska. The former are generally more encompassing: > They contain every item of the current lists except "text/plain" for > AV_CODEC_ID_TEXT and "binary" for AV_CODEC_ID_BIN_DATA. >

[FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-19 Thread gautamramk
From: Gautam Ramakrishnan I have attempted to write a JPEG2000 Parser. Need help on testing the code and some tips on how to document this code. The variable names are also a bit hard to understand. Would appreciate some tips. The sample from #7445 seems to get decoded now. Additionally, I have

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
On 4/19/2020 4:59 PM, Andreas Rheinhardt wrote: >> int av_bsf_receive_packet(AVBSFContext *ctx, AVPacket *pkt) >> { >> -return ctx->filter->filter(ctx, pkt); >> +AVBSFInternal *bsfi = ctx->internal; >> +int ret; >> + >> +if (!bsfi->out_pkt->data &&

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread Andreas Rheinhardt
James Almer: > Process input data as soon as it's fed to av_bsf_send_packet(), instead of > storing a single packet and expecting the user to call av_bsf_receive_packet() > in order to trigger the decoding process before they are allowed to feed more > data. > > This puts the bsf API more in line

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
On 4/19/2020 4:32 PM, Marton Balint wrote: > > > On Sun, 19 Apr 2020, James Almer wrote: > >> On 4/19/2020 3:26 PM, Marton Balint wrote: >>> >>> >>> On Sun, 19 Apr 2020, James Almer wrote: >>> On 4/19/2020 1:01 PM, Marton Balint wrote: > > > On Sun, 19 Apr 2020, James Almer

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, James Almer wrote: On 4/19/2020 3:26 PM, Marton Balint wrote: On Sun, 19 Apr 2020, James Almer wrote: On 4/19/2020 1:01 PM, Marton Balint wrote: On Sun, 19 Apr 2020, James Almer wrote: Process input data as soon as it's fed to av_bsf_send_packet(), instead of

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Carl Eugen Hoyos
Am So., 19. Apr. 2020 um 19:55 Uhr schrieb Jean-Baptiste Kempf : > > On Sun, Apr 19, 2020, at 16:28, Ross Nicholson wrote: > > How do you mean? What’s that problem? > > You've used Ross Nicholson for committing It looks to me as if he has not done that. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Carl Eugen Hoyos
Am So., 19. Apr. 2020 um 20:45 Uhr schrieb Ross Nicholson : > > That’s really strange all my git config’s are just phunkyfish. > > I don’t really mind which name is used but I guess I’ll update > everything to my real name going forward now that you mention it. It is completely your decision

[FFmpeg-devel] [PATCH] avcodec/bsf: Use macro for "packet is empty"

2020-04-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index b9fc771a88..68fee82e0d 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -28,6 +28,8 @@ #include "avcodec.h"

Re: [FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-19 Thread James Almer
On 4/19/2020 2:57 PM, Andreas Rheinhardt wrote: > James Almer: >> On 4/19/2020 2:45 PM, Andreas Rheinhardt wrote: >>> James Almer: Signed-off-by: James Almer --- tests/fate/truehd.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/truehd.mak

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
On 4/19/2020 3:26 PM, Marton Balint wrote: > > > On Sun, 19 Apr 2020, James Almer wrote: > >> On 4/19/2020 1:01 PM, Marton Balint wrote: >>> >>> >>> On Sun, 19 Apr 2020, James Almer wrote: >>> Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Ross Nicholson
That’s really strange all my git config’s are just phunkyfish. I don’t really mind which name is used but I guess I’ll update everything to my real name going forward now that you mention it. > On 19 Apr 2020, at 18:55, Jean-Baptiste Kempf wrote: > > On Sun, Apr 19, 2020, at 16:28, Ross

Re: [FFmpeg-devel] [PATCH] avformat/oggenc: Don't free AVStream's priv_data, fix memleak

2020-04-19 Thread Andreas Rheinhardt
Andreas Rheinhardt: > For FLAC, Speed, Opus and VP8 the Ogg muxer allocates two buffers > for building the headers: The first for extradata in an Ogg-specific > format and the second contains a Vorbiscomment. These buffers are > reachable via pointers in the corresponding AVStream's priv_data. >

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, James Almer wrote: On 4/19/2020 1:01 PM, Marton Balint wrote: On Sun, 19 Apr 2020, James Almer wrote: Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a single packet and expecting the user to call av_bsf_receive_packet() in order to

Re: [FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-19 Thread Andreas Rheinhardt
James Almer: > On 4/19/2020 2:45 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>> tests/fate/truehd.mak | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak >>> index 6c8b1220f1..e672716527

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Jean-Baptiste Kempf
On Sun, Apr 19, 2020, at 16:28, Ross Nicholson wrote: > How do you mean? What’s that problem? You've used Ross Nicholson for committing, and now you only use phunkyfish . Since you are not anonymous, why not use your actual name? -- Jean-Baptiste Kempf - President +33 672 704 734

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-19 Thread Wolfgang Haupt
On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to review this patch? It's an attempt to fix rtsp streams that use udp multicasts as the underlying transmission protocol. The idea was

Re: [FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-19 Thread James Almer
On 4/19/2020 2:45 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> tests/fate/truehd.mak | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak >> index 6c8b1220f1..e672716527 100644 >> ---

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Wolfgang Haupt
On 19.04.20 14:44, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:53, Wolfgang Haupt wrote: Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. ---   libavformat/rtsp.c | 5 -   1

[FFmpeg-devel] [PATCH] swscale: aarch64: Don't clobber callee-saved registers v8-v15

2020-04-19 Thread Martin Storsjö
--- If there would have been checkasm tests for these functions, it would have been caught immediately. --- libswscale/aarch64/hscale.S | 20 ++-- libswscale/aarch64/output.S | 6 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libswscale/aarch64/hscale.S

Re: [FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-19 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > tests/fate/truehd.mak | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak > index 6c8b1220f1..e672716527 100644 > --- a/tests/fate/truehd.mak > +++ b/tests/fate/truehd.mak > @@ -8,5 +8,10

Re: [FFmpeg-devel] [PATCH] avcodec/truehd_core_bsf: Remove unused AVClass pointer

2020-04-19 Thread Andreas Rheinhardt
James Almer: > On 4/17/2020 9:57 PM, Andreas Rheinhardt wrote: >> The context structure of the truehd_core bsf had a pointer to a const >> AVClass as its first member; yet this bsf does not have any AVClass >> associated with it, so that this pointer is always NULL. So remove it. >> >>

[FFmpeg-devel] [PATCH v2] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Wolfgang Haupt
Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. --- libavformat/rtsp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 07ac371903..b56bebfde6

[FFmpeg-devel] [PATCH] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Wolfgang Haupt
Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. --- libavformat/rtsp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 07ac371903..b56bebfde6

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
On 4/19/2020 11:34 AM, James Almer wrote: > Process input data as soon as it's fed to av_bsf_send_packet(), instead of > storing a single packet and expecting the user to call av_bsf_receive_packet() > in order to trigger the decoding process before they are allowed to feed more > data. This is

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
On 4/19/2020 1:01 PM, Marton Balint wrote: > > > On Sun, 19 Apr 2020, James Almer wrote: > >> Process input data as soon as it's fed to av_bsf_send_packet(), >> instead of >> storing a single packet and expecting the user to call >> av_bsf_receive_packet() >> in order to trigger the decoding

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Carl Eugen Hoyos
Am So., 19. Apr. 2020 um 17:33 Uhr schrieb Ross Nicholson : > > How do you mean? What’s that problem? > > I generally just use phunkyfish as the name and it’s corresponding gmail > address for stuff. > > Do you require my real name for git? No, absolutely not. Carl Eugen

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-04-19 Thread Lynne
Apr 19, 2020, 16:05 by mich...@niedermayer.cc: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 19950/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_DCT_fuzzer-5765514337189888 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, James Almer wrote: Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a single packet and expecting the user to call av_bsf_receive_packet() in order to trigger the decoding process before they are allowed to feed more data. This puts the

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Ross Nicholson
How do you mean? What’s that problem? I generally just use phunkyfish as the name and it’s corresponding gmail address for stuff. Do you require my real name for git? > On 19 Apr 2020, at 14:23, Jean-Baptiste Kempf wrote: > > Ross, > > Could you, please, fix your git email and name? > >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-04-19 Thread Zhong Li
Fu, Linjie 于2020年2月29日周六 下午5:35写道: > > > -Original Message- > > From: Zhong Li > > Sent: Saturday, February 29, 2020 13:14 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Cc: Fu, Linjie > > Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the

[FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-19 Thread James Almer
Signed-off-by: James Almer --- tests/fate/truehd.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak index 6c8b1220f1..e672716527 100644 --- a/tests/fate/truehd.mak +++ b/tests/fate/truehd.mak @@ -8,5 +8,10 @@ fate-truehd-5.1-downmix-2.0:

[FFmpeg-devel] [PATCH 1/2] fate: move TrueHD tests to their own file

2020-04-19 Thread James Almer
Signed-off-by: James Almer --- tests/Makefile | 1 + tests/fate/lossless-audio.mak | 6 -- tests/fate/truehd.mak | 12 tests/ref/fate/lossless-truehd-5.1 | 1 -

[FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Error out on double init of vp

2020-04-19 Thread Michael Niedermayer
Fixes: memleak Fixes: 19949/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5743636058210304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/oggparsevorbis.c | 7 ++- 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/truehd_core_bsf: Remove unused AVClass pointer

2020-04-19 Thread James Almer
On 4/17/2020 9:57 PM, Andreas Rheinhardt wrote: > The context structure of the truehd_core bsf had a pointer to a const > AVClass as its first member; yet this bsf does not have any AVClass > associated with it, so that this pointer is always NULL. So remove it. > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-04-19 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 19950/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_DCT_fuzzer-5765514337189888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/rv40dsp: Fix integer overflows in rv40_weight_func_*()

2020-04-19 Thread Michael Niedermayer
On Sun, Feb 02, 2020 at 10:52:02PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 40550400 * 128 cannot be represented in type > 'int' > Fixes: > 20331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV40_fuzzer-5676685725007872 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v2] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-19 Thread James Almer
Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a single packet and expecting the user to call av_bsf_receive_packet() in order to trigger the decoding process before they are allowed to feed more data. This puts the bsf API more in line with the decoupled

Re: [FFmpeg-devel] [PATCH 3/8] lavc/qsvenc: Add hardware config metadata

2020-04-19 Thread Zhong Li
Mark Thompson 于2020年4月13日周一 下午11:34写道: > > All of these encoders can accept libmfx surfaces directly in a hardware > frames context, or they can accept software frames if a suitable device > is supplied to use. > --- > libavcodec/qsvenc.c | 7 +++ > libavcodec/qsvenc.h | 3 +++ >

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Jean-Baptiste Kempf
Ross, Could you, please, fix your git email and name? Thanks On Fri, Apr 17, 2020, at 13:07, Ross Nicholson wrote: > Ping > > > On 15 Apr 2020, at 17:21, Ross Nicholson wrote: > > > >  > > Ping to hopefully apply this patch! > > > >>> On 12 Apr 2020, at 16:54, Ross Nicholson wrote: > >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_{apc, ssi, oki}: replace while() with for()

2020-04-19 Thread Zane van Iperen
On Sat, 18 Apr 2020 00:59:25 + "Zane van Iperen" wrote: > Per discussion at > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260854.html > > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Ping. Zane

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to review this patch? It's an attempt to fix rtsp streams that use udp multicasts as the underlying transmission protocol. The idea was taken from live555 as the said stream

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: adapt to the new internal encode API

2020-04-19 Thread Timo Rothenpieler
On 09.04.2020 20:27, James Almer wrote: Signed-off-by: James Almer --- Version with the flush() callback left in place. But it will need the changes i originally added to avcodec_flush_buffers() and then removed for the latest iteration of this set, in some form or another.

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Marton Balint
On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:53, Wolfgang Haupt wrote: Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. --- libavformat/rtsp.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-19 Thread Gautam Ramakrishnan
On Sun, Apr 19, 2020 at 3:17 PM Michael Niedermayer wrote: > > On Sun, Apr 19, 2020 at 01:00:02AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > I have attempted to write a JPEG2000 Parser. Need > > help on testing the code and some tips on how to > > document this

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-19 Thread Marton Balint
On Tue, 7 Apr 2020, phunkyfish wrote: --- libavformat/rtsp.c | 48 +- 1 file changed, 39 insertions(+), 9 deletions(-) Thanks, applied. Regards, Marton diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..07ac371903 100644 ---

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-19 Thread Wolfgang Haupt
ping On 03.04.20 08:53, Wolfgang Haupt wrote: Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. --- libavformat/rtsp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-19 Thread Wolfgang Haupt
ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to review this patch? It's an attempt to fix rtsp streams that use udp multicasts as the underlying transmission protocol. The idea was taken from live555 as the said stream worked in VLC. It still applies cleanly on current

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-19 Thread Gautam Ramakrishnan
On Sun, Apr 19, 2020 at 8:20 AM Carl Eugen Hoyos wrote: > > Am Sa., 18. Apr. 2020 um 21:54 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > I have attempted to write a JPEG2000 Parser. > > Does it work both for format j2k and jp2 as written > by FFmpeg's encoder? > I have tried to make it

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-19 Thread myp...@gmail.com
On Sun, Apr 19, 2020 at 4:25 PM Jean-Baptiste Kempf wrote: > > I'd like to ask opinions whether a installed header for just one structure is > a good idea. > It's follow the style like AVReplayGain, so add a new file in libavutil > On Sun, Apr 19, 2020, at 03:07, Jun Zhao wrote: > > From:

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-19 Thread Michael Niedermayer
On Sun, Apr 19, 2020 at 01:00:02AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > I have attempted to write a JPEG2000 Parser. Need > help on testing the code and some tips on how to > document this code. The variable names are also > a bit hard to understand. Would

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: >> On April 19, 2020 9:11 AM Andreas Rheinhardt >> wrote: >> >> >> Steve Lhomme: >>> Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in >>> mkv_init and keep using it when needed ? >>> >>> Then you can still update UIDs in the location you really need to create

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-19 Thread Jean-Baptiste Kempf
I'd like to ask opinions whether a installed header for just one structure is a good idea. On Sun, Apr 19, 2020, at 03:07, Jun Zhao wrote: > From: vacingfang > > add DOVI related struct > > Signed-off-by: vacingfang > --- > libavutil/Makefile| 1 + > libavutil/dovi_meta.h | 58 >

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: > LGTM. > > In general it would be nice if this was "automatic". In other words when > writing any element the value is automatically checked against the default > value. Maybe using a macro that would also check the default value like this > > PUT_EBML_VALUE(cp,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Don't write elements with their default value

2020-04-19 Thread Steve Lhomme
LGTM. In general it would be nice if this was "automatic". In other words when writing any element the value is automatically checked against the default value. Maybe using a macro that would also check the default value like this PUT_EBML_VALUE(cp, EDITIONFLAGHIDDEN, value) doing : if (value

Re: [FFmpeg-devel] [PATCH 12/20] avformat/matroskaenc: Improve Cues in case of no video

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: >> On April 5, 2020 5:59 PM Andreas Rheinhardt >> wrote: >> >> >> The Matroska muxer currently only adds CuePoints in three cases: >> a) For video keyframes. b) For the first audio frame in a new Cluster if >> in DASH-mode. c) For subtitles. This means that ordinary Matroska

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Steve Lhomme
> On April 19, 2020 9:11 AM Andreas Rheinhardt > wrote: > > > Steve Lhomme: > > Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in > > mkv_init and keep using it when needed ? > > > > Then you can still update UIDs in the location you really need to create > > them. > > >

Re: [FFmpeg-devel] [PATCH 06/20] avformat/matroskaenc: Make output more deterministic

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: > Not sure how FATE works but I suppose the pseudo-random becomes deterministic > ? In that case the size should always be the same. And if not having a fixed > size will make no difference. > > If FATE can skip random parts of a file (which your patch would solve) it > will miss

Re: [FFmpeg-devel] [PATCH 12/20] avformat/matroskaenc: Improve Cues in case of no video

2020-04-19 Thread Steve Lhomme
> On April 5, 2020 5:59 PM Andreas Rheinhardt > wrote: > > > The Matroska muxer currently only adds CuePoints in three cases: > a) For video keyframes. b) For the first audio frame in a new Cluster if > in DASH-mode. c) For subtitles. This means that ordinary Matroska audio > files won't have

Re: [FFmpeg-devel] [PATCH 06/20] avformat/matroskaenc: Make output more deterministic

2020-04-19 Thread Steve Lhomme
Not sure how FATE works but I suppose the pseudo-random becomes deterministic ? In that case the size should always be the same. And if not having a fixed size will make no difference. If FATE can skip random parts of a file (which your patch would solve) it will miss inconsitencies of UIDs

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: > Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in mkv_init > and keep using it when needed ? > > Then you can still update UIDs in the location you really need to create them. > What other UIDs do I need? UIDs for tracks and attachments are created in init as

Re: [FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Reuse random seed

2020-04-19 Thread Steve Lhomme
Wouldn't it be better to set the AVLFG in the MatroskaMuxContext in mkv_init and keep using it when needed ? Then you can still update UIDs in the location you really need to create them. > On April 5, 2020 5:59 PM Andreas Rheinhardt > wrote: > > > This commit reuses the random seed

Re: [FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Ensure that ChapterUID are != 0

2020-04-19 Thread Andreas Rheinhardt
Steve Lhomme: >> On April 5, 2020 5:59 PM Andreas Rheinhardt >> wrote: >> >> >> AVChapters have an int as id field and therefore this value can appear >> <= 0. When remuxing from Matroska, this value actually contains >> the lower 32 bits of the original ChapterUID (which can be 64 bits). >>

Re: [FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Ensure that ChapterUID are != 0

2020-04-19 Thread Steve Lhomme
> On April 5, 2020 5:59 PM Andreas Rheinhardt > wrote: > > > AVChapters have an int as id field and therefore this value can appear > <= 0. When remuxing from Matroska, this value actually contains > the lower 32 bits of the original ChapterUID (which can be 64 bits). > > In order to ensure