Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-11 Thread Neil Birkbeck
On Wed, May 6, 2020 at 8:45 AM James Almer wrote: > On 5/6/2020 12:22 PM, Neil Birkbeck wrote: > > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary > > wrote: > > > >> Hi, > >> > >> I broke the threading with my last reply, i apologise. Here goes another > >> attempt: > >> > >> On Tue, Apr 28,

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-11 Thread Neil Birkbeck
On Thu, May 7, 2020 at 10:21 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Neil Birkbeck: > > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > > > >> Andreas Rheinhardt (12020-04-28): > >>> That's expected. The patch provided only provides the structure in > which > >>>

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: Don't use heap allocated array to store pids

2020-05-11 Thread Andriy Gelman
On Fri, 01. May 17:54, Marton Balint wrote: > > > On Thu, 30 Apr 2020, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > A temporary heap array currently stores pids from all streams. It is > > used to make sure there are no duplicated pids. However, this array is > > not needed because

[FFmpeg-devel] [PATCH v3 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-11 Thread lance . lmwang
From: Limin Wang These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO & FF_ALLOCZ_ARRAY_OR_GOTO, but the elsize is calcuated by sizeof(*p) Signed-off-by: Limin Wang --- libavutil/internal.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/internal.h

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo: cosmetics

2020-05-11 Thread lance . lmwang
On Mon, May 11, 2020 at 06:59:15PM +0200, Michael Niedermayer wrote: > On Sun, May 10, 2020 at 11:39:30PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/mpegvideo.c | 27 ++- > > 1 file changed, 18

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mpegvideo: use FF_ALLOC{Z}_TYPED_ARRAY_OR_GOTO instead

2020-05-11 Thread lance . lmwang
On Mon, May 11, 2020 at 01:27:36PM -0300, James Almer wrote: > On 5/11/2020 12:52 PM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/mpegvideo.c | 60 > > ++ > > 1 file changed, 26

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-11 Thread lance . lmwang
On Mon, May 11, 2020 at 08:34:49PM +0200, Marton Balint wrote: > > > On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO & > > FF_ALLOCZ_ARRAY_OR_GOTO, > > but the elsize is calcuated by sizeof(*p) > > >

Re: [FFmpeg-devel] [PATCH] avformat/mux: Check pkt->stream_index before using it

2020-05-11 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-05-10 21:35:54) >> Anton Khirnov: >>> Quoting Marton Balint (2020-05-10 19:45:04) On Sun, 10 May 2020, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-05-08 00:55:00) >> This commit fixes two recent regressions

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/utvideodec: Fix integer overflow in decode_plane()

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:19PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483594 + 142 cannot be represented in > type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_UTVIDEO_fuzzer-5658568101724160 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/ttadsp: Fix several integer overflows in tta_filter_process_c()

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:18PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1931744255 + 252497024 cannot be represented > in type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5763348114440192 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/ralf: Fix integer overflow in decode_block()

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:15PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 289082077 - -200314 cannot be represented > in type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5196077752123392 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/nuv: widen buf_size type

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:14PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65312 * 65312 cannot be represented in type > 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5740176118906880 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_spp: Remove unused AVCodecContext

2020-05-11 Thread Michael Niedermayer
On Sun, Apr 19, 2020 at 12:37:44AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_spp.c | 7 +-- > libavfilter/vf_spp.h | 2 -- > 2 files changed, 1 insertion(+), 8 deletions(-) will apply patchset [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] libswscale: fix for floating point formats, require full chroma

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 04:17:48PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > upon more floating point testing, looks like I missed adding this bit. > > --- > libswscale/utils.c | 2 ++ > 1 file changed, 2 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: add AV_OPT_FLAG_CHILD_CONSTS

2020-05-11 Thread Michael Niedermayer
On Mon, May 11, 2020 at 09:35:17PM +0200, Marton Balint wrote: > This will be used for AVCodecContext->profile. By specifying constants in the > encoders we won't have to use the common AVCodecContext options table and > different encoders can use the same profile name even with different values.

[FFmpeg-devel] [PATCH] libavcodec/decode: Mark decode_simple_internal() as inline

2020-05-11 Thread Michael Niedermayer
This was suggested in https://github.com/google/oss-fuzz/issues/3787 to reduce the grouping errors by oss-fuzz Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread James Almer
On 5/11/2020 6:27 PM, Marton Balint wrote: > > > On Mon, 11 May 2020, James Almer wrote: > >> On 5/11/2020 4:35 PM, Marton Balint wrote: >>> We don't have a dts encoder. >> >> We do, but it's called dca, same as the decoder. > > Indeed. But as far as I see it does not use avctx->profile, so it

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, James Almer wrote: On 5/11/2020 4:35 PM, Marton Balint wrote: We don't have a dts encoder. We do, but it's called dca, same as the decoder. Indeed. But as far as I see it does not use avctx->profile, so it still seems OK to remove these, right? Thanks, Marton

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cdtoons: Check sprite_offset is within the packet

2020-05-11 Thread Paul B Mahol
probably ok On 5/11/20, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDTOONS_fuzzer-5754518731227136 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH 1/3] avcodec/cdtoons: Check sprite_offset is within the packet

2020-05-11 Thread Michael Niedermayer
Fixes: out of array read Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDTOONS_fuzzer-5754518731227136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cdtoons.c | 3 +++ 1

[FFmpeg-devel] [PATCH 3/3] avcodec/ralf: Check num_blocks before use

2020-05-11 Thread Michael Niedermayer
Fixes: out of array access Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5739471895265280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ralf.c | 2 ++ 1 file

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: Test video_size being non zero

2020-05-11 Thread Michael Niedermayer
Fixes: Out of array access Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5658548592967680 Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5723561177382912 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread James Almer
On 5/11/2020 4:35 PM, Marton Balint wrote: > We don't have a dts encoder. We do, but it's called dca, same as the decoder. > > Signed-off-by: Marton Balint > --- > doc/codecs.texi| 10 -- > libavcodec/options_table.h | 5 - > 2 files changed, 15 deletions(-) > > diff

[FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread Marton Balint
We don't have a dts encoder. Signed-off-by: Marton Balint --- doc/codecs.texi| 10 -- libavcodec/options_table.h | 5 - 2 files changed, 15 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 8f62cfaace..c08229ba7e 100644 --- a/doc/codecs.texi +++

[FFmpeg-devel] [PATCH 3/6] avcodec: move aacenc profiles to profiles.h

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/codecs.texi| 20 libavcodec/aacenc.c| 2 ++ libavcodec/libfdk-aacenc.c | 2 ++ libavcodec/options_table.h | 10 -- libavcodec/profiles.h | 16 5 files changed, 20 insertions(+), 30

[FFmpeg-devel] [PATCH 6/6] avcodec: move mpeg4 profiles to profiles.h

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/codecs.texi| 17 ++--- libavcodec/mpeg4videoenc.c | 2 ++ libavcodec/options_table.h | 4 libavcodec/profiles.h | 6 ++ libavcodec/v4l2_m2m_enc.c | 34 ++ 5 files changed, 32

[FFmpeg-devel] [PATCH 5/6] avcodec: move msbc profile to encoder

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/options_table.h | 1 - libavcodec/sbcenc.c| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index cc3224b01a..4c7dca696b 100644 --- a/libavcodec/options_table.h +++

[FFmpeg-devel] [PATCH 2/6] avcodec/options_table: make AVCodecContext->profile search for child constants

2020-05-11 Thread Marton Balint
This change makes it possible for child encoders to define custom profile option names which can be used for setting the AVCodecContext->profile. Also rename unit name to something rather unique, so it won't be used elsewhere. Signed-off-by: Marton Balint --- doc/codecs.texi| 2 ++

[FFmpeg-devel] [PATCH 1/6] avutil/opt: add AV_OPT_FLAG_CHILD_CONSTS

2020-05-11 Thread Marton Balint
This will be used for AVCodecContext->profile. By specifying constants in the encoders we won't have to use the common AVCodecContext options table and different encoders can use the same profile name even with different values. Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO & FF_ALLOCZ_ARRAY_OR_GOTO, but the elsize is calcuated by sizeof(*p) Signed-off-by: Limin Wang --- libavutil/internal.h | 18 ++ 1 file changed, 18

Re: [FFmpeg-devel] [PATCH] doc/encoders: ffaacenc does not output CBR

2020-05-11 Thread Lynne
May 11, 2020, 14:34 by guillaume.kh@gmail.com: > The documentation and wiki imply the native AAC encoder can output CBR and > VBR files : > >b > >Set bit rate in bits/s. Setting this automatically activates constant bit > >rate (CBR) mode. If this option is unspecified it is set to 128kbps.

Re: [FFmpeg-devel] [PATCH] hwcontext: add av_hwdevice_ctx_create_derived2

2020-05-11 Thread Lynne
May 11, 2020, 13:55 by jamr...@gmail.com: > On 5/11/2020 7:25 AM, Lynne wrote: > >> This allows for users who derive devices to set options for the >> new device context they derive. >> The main use case of this is to allow users to enable extensions >> (such as surface drawing extensions) in

[FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-11 Thread Thierry Foucu
If you have a file with multiple Metadata Keys, the second time you parse the keys, you will re-alloc c->meta_keys without freeing the old one. This change will avoid parsing all the consecutive Metadata keys. --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/adpcm: Clip predictor for IMA_APM

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 12:40:55PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483647 - 61436 cannot be represented in > type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_APM_fuzzer-5092176004644864 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo: cosmetics

2020-05-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 11:39:30PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mpegvideo.c | 27 ++- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/mpegvideo.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/ivfenc: move bsf insertion to the init function

2020-05-11 Thread James Almer
On 5/11/2020 8:59 AM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavformat/ivfenc.c | 24 ++-- >> 1 file changed, 10 insertions(+), 14 deletions(-) >> >> diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c >> index

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mpegvideo: use FF_ALLOC{Z}_TYPED_ARRAY_OR_GOTO instead

2020-05-11 Thread James Almer
On 5/11/2020 12:52 PM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mpegvideo.c | 60 > ++ > 1 file changed, 26 insertions(+), 34 deletions(-) > > diff --git a/libavcodec/mpegvideo.c

[FFmpeg-devel] [PATCH v2 2/4] avcodec/mpegvideo: use FF_ALLOC{Z}_TYPED_ARRAY_OR_GOTO instead

2020-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 60 ++ 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 49fd1c9..6f52e75 100644 ---

[FFmpeg-devel] [PATCH v2 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-11 Thread lance . lmwang
From: Limin Wang These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO & FF_ALLOCZ_ARRAY_OR_GOTO, but the elsize is calcuated by sizeof(*p) Signed-off-by: Limin Wang --- libavutil/internal.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavutil/internal.h

[FFmpeg-devel] [PATCH v2 4/4] avcodec/h264dec: use FF_ALLOCZ_TYPED_ARRAY_OR_GOTO instead

2020-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 48 ++-- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 4c355fe..4e223c1 100644 --- a/libavcodec/h264dec.c +++

[FFmpeg-devel] [PATCH v2 3/4] avcodec/mpegvideo_enc: use FF_ALLOCZ_TYPED_ARRAY_OR_GOTO instead

2020-05-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo_enc.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 50ae57e..81542b8 100644 --- a/libavcodec/mpegvideo_enc.c +++

Re: [FFmpeg-devel] [PATCH 0/2] avformat movenc add flag to allow disabling limit on timescale

2020-05-11 Thread Gyan Doshi
On 11-05-2020 06:44 pm, vectronic wrote: On 5 May 2020, at 06:19, Gyan Doshi wrote: On 05-05-2020 03:16 am, vectronic wrote: On 4 May 2020, at 17:56, Gyan Doshi wrote: On 04-05-2020 09:54 pm, vectronic wrote: I needed to encode to mov/mp4 with a timebase of 1/600 and the output was

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/vf_colorbalance:: Fix for framecrc bitexact for 32bit and 64bit system

2020-05-11 Thread lance . lmwang
On Fri, Nov 15, 2019 at 11:12:48PM +0800, lance.lmw...@gmail.com wrote: > Signed-off-by: Limin Wang > --- > libavfilter/vf_colorbalance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_colorbalance.c b/libavfilter/vf_colorbalance.c > index

[FFmpeg-devel] [PATCH] fate: add a test for vp9 video enc parameters export

2020-05-11 Thread Anton Khirnov
--- libavformat/Makefile |1 + tests/fate/vpx.mak |4 + tests/ref/fate/vp9-encparams | 3279 ++ tools/venc_data_dump.c | 186 ++ 4 files changed, 3470 insertions(+) create mode 100644 tests/ref/fate/vp9-encparams create mode

Re: [FFmpeg-devel] [PATCH] avformat/mux: Check pkt->stream_index before using it

2020-05-11 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-05-10 21:35:54) > Anton Khirnov: > > Quoting Marton Balint (2020-05-10 19:45:04) > >> > >> > >> On Sun, 10 May 2020, Anton Khirnov wrote: > >> > >>> Quoting Andreas Rheinhardt (2020-05-08 00:55:00) > This commit fixes two recent regressions both of which are

[FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-11 Thread David Andreoletti
drawtext allows a file to be reloaded per frame. However, the file to be reloaded is constant across frame. With textfile now supporting text expansion, a different file can be reloaded per frame. Eg: textfile=/path/fo/file{frame_num}.txt Signed-off-by: David Andreoletti --- doc/filters.texi

[FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: export frame sample aspect ratio

2020-05-11 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libdav1d.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 72f06c550e..a265a487d8 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -335,6 +335,12 @@ static int

[FFmpeg-devel] [PATCH 1/2] avcodec/libdav1d: try to set decoder context parameters during init()

2020-05-11 Thread James Almer
If extradata is available, use it to initialize the AVCodecContext before packet data is seen. Also, don't constantly overwrite it after it's set. Signed-off-by: James Almer --- The main benefit from this is using ff_decode_frame_props() to fill frame props, which includes copying any relevant

[FFmpeg-devel] [PATCH] hwcontext: add av_hwdevice_ctx_create_derived2

2020-05-11 Thread Lynne
This allows for users who derive devices to set options for the new device context they derive. The main use case of this is to allow users to enable extensions (such as surface drawing extensions) in Vulkan while deriving from the device their frames are on. That way, users don't need to write

Re: [FFmpeg-devel] [PATCH 0/2] avformat movenc add flag to allow disabling limit on timescale

2020-05-11 Thread vectronic
> On 5 May 2020, at 06:19, Gyan Doshi wrote: > > > > On 05-05-2020 03:16 am, vectronic wrote: >> >>> On 4 May 2020, at 17:56, Gyan Doshi wrote: >>> >>> >>> >>> On 04-05-2020 09:54 pm, vectronic wrote: I needed to encode to mov/mp4 with a timebase of 1/600 and the output was

Re: [FFmpeg-devel] [PATCH] fate: add adpcm_ima_cunning tests

2020-05-11 Thread Zane van Iperen
On Sat, 09 May 2020 14:00:04 + "Zane van Iperen" wrote: > > single: Single-track > track{0,1}: Dual-track > trunc-t1: Truncated track 1 > trunc-t2-track{0,1}: Fully-truncated track 2 > trunc-t2a-track{0,1}: Partially-truncated track 2 > trunc-h2:

[FFmpeg-devel] [PATCH] doc/encoders: ffaacenc does not output CBR

2020-05-11 Thread Guillaume Khayat
The documentation and wiki imply the native AAC encoder can output CBR and VBR files : >b >Set bit rate in bits/s. Setting this automatically activates constant bit rate >(CBR) mode. If this option is unspecified it is set to 128kbps. > >q >Set quality for variable bit rate (VBR) mode. This

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: prefer to use variable instead of type for sizeof

2020-05-11 Thread lance . lmwang
On Mon, May 11, 2020 at 09:16:39AM +0200, Marton Balint wrote: > > > On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: > > > On Mon, May 11, 2020 at 01:22:24AM +0200, Marton Balint wrote: > > > > > > > > > On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Sun, May 10, 2020

Re: [FFmpeg-devel] [PATCH] hwcontext: add av_hwdevice_ctx_create_derived2

2020-05-11 Thread James Almer
On 5/11/2020 7:25 AM, Lynne wrote: > This allows for users who derive devices to set options for the > new device context they derive. > The main use case of this is to allow users to enable extensions > (such as surface drawing extensions) in Vulkan while deriving from > the device their frames

[FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded (and then reloaded) every frame

2020-05-11 Thread David Andreoletti
Signed-off-by: David Andreoletti --- doc/filters.texi | 16 +--- libavfilter/vf_drawtext.c | 19 --- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d19fd346ae..3a127369ea 100644 --- a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/ivfenc: move bsf insertion to the init function

2020-05-11 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-05-11 13:59:27) > James Almer: > > Signed-off-by: James Almer > > --- > > libavformat/ivfenc.c | 24 ++-- > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > > index

Re: [FFmpeg-devel] [PATCH 2/2] avformat/ivfenc: move bsf insertion to the init function

2020-05-11 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/ivfenc.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 0ce4a85171..0951f56c92 100644 > --- a/libavformat/ivfenc.c > +++

[FFmpeg-devel] [PATCH] vp9dec: support exporting QP tables through the AVVideoEncParams API

2020-05-11 Thread Anton Khirnov
--- Now the nb_block_structure reset is moved to decode_frame_header(), which fixes block-structure export with frame threading. No idea how I didn't notice this before --- libavcodec/vp9.c | 72 libavcodec/vp9block.c| 8

Re: [FFmpeg-devel] [PATCH 1/9] libavutil: add API for exporting video frame quantizers

2020-05-11 Thread Anton Khirnov
Quoting Thierry Foucu (2020-05-07 21:14:15) > On Sat, Apr 18, 2020 at 5:02 AM Lynne wrote: > > > Apr 18, 2020, 11:14 by an...@khirnov.net: > > > > > From: Juan De León > > > > > > This is intended to replace the deprecated the AV_FRAME_DATA_QP_TABLE* > > > API and extend it to a wider range of

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: prefer to use variable instead of type for sizeof

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: On Mon, May 11, 2020 at 01:22:24AM +0200, Marton Balint wrote: On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: > On Sun, May 10, 2020 at 06:30:41PM +0200, Marton Balint wrote: > > > > > > On Sun, 10 May 2020, lance.lmw...@gmail.com