May 12, 2020, 23:42 by s...@jkqxz.net:
> On 12/05/2020 22:42, Lynne wrote:
>
>> Apr 22, 2020, 06:28 by fei.w.w...@intel.com:
>>
-Original Message-
From: Wang, Fei W
Sent: Wednesday, April 22, 2020 1:23 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Wang, Fei W
Subject:
May 12, 2020, 23:16 by s...@jkqxz.net:
> On 12/05/2020 20:16, Lynne wrote:
>
>> From 45ec8f730a183cd98b1d2d705e7a9582ef2f3f28 Mon Sep 17 00:00:00 2001
>> From: Lynne
>> Date: Mon, 11 May 2020 11:02:19 +0100
>> Subject: [PATCH] hwcontext: add av_hwdevice_ctx_create_derived_opts
>>
>
> Can you make
On Tue, May 12, 2020 at 10:09 PM James Almer wrote:
>
> It's not meant for audio or subtitles, or for encoders of any kind.
>
> Signed-off-by: James Almer
> ---
> libavcodec/options_table.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/options_table.h b/liba
Apr 22, 2020, 06:28 by fei.w.w...@intel.com:
>> -Original Message-
>> From: Wang, Fei W
>> Sent: Wednesday, April 22, 2020 1:23 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Wang, Fei W
>> Subject: [PATCH v2 1/3] lavu/pix_fmt: add new pixel format x2rgb10
>>
>> The format is packed RGB with e
On Wed, May 13, 2020 at 12:12 AM Jan Ekström wrote:
>
> Until now, we would have only attempted to utilize already decrypted
> data if it was enough to fill the size of buffer requested, that could
> very well be up to 32 kilobytes.
>
> With keep-alive connections this would just lead to recv bloc
On Tue, May 12, 2020 at 06:58:34PM +0200, Marton Balint wrote:
>
>
> On Wed, 13 May 2020, lance.lmw...@gmail.com wrote:
>
> >From: Limin Wang
> >
> >Please refer to the details here:
> >https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/
>
May 11, 2020, 14:09 by d...@lynne.ee:
> May 11, 2020, 13:55 by jamr...@gmail.com:
>
>> On 5/11/2020 7:25 AM, Lynne wrote:
>>
>>> This allows for users who derive devices to set options for the
>>> new device context they derive.
>>> The main use case of this is to allow users to enable extensions
Fixes: assertion failure
Fixes:
21666/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO4_fuzzer-5706468994318336
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/ivi.c | 2 ++
1 file chan
On Wed, Feb 12, 2020 at 11:03:19PM +0100, Michael Niedermayer wrote:
> The reference (thp.txt) uses floats so wrap around would seem incorrect.
>
> Fixes: signed integer overflow: 1073741824 + 1073741824 cannot be represented
> in type 'int'
> Fixes:
> 20658/clusterfuzz-testcase-minimized-ffmpeg
On Tue, May 12, 2020 at 07:58:29PM +0200, Nicolas George wrote:
> Marton Balint (12020-05-12):
> > And you assume that I want to assign the error code to ret. Wrong. What if I
> > want to return it as is?
>
> Assign it to ret and forward ret.
>
> >Or what if I want to retu
On 12/05/2020 22:42, Lynne wrote:
> Apr 22, 2020, 06:28 by fei.w.w...@intel.com:
>>> -Original Message-
>>> From: Wang, Fei W
>>> Sent: Wednesday, April 22, 2020 1:23 PM
>>> To: ffmpeg-devel@ffmpeg.org
>>> Cc: Wang, Fei W
>>> Subject: [PATCH v2 1/3] lavu/pix_fmt: add new pixel format x2rg
On Wed, May 13, 2020 at 12:35 AM Jan Ekström wrote:
>
> The dec_buf seems to be properly managed between read calls,
> and we have no logic to decrypt before attempting socket I/O.
> Thus - until now - such data would not be decrypted in case of
> connections such as HTTP keep-alive, as the recv c
The dec_buf seems to be properly managed between read calls,
and we have no logic to decrypt before attempting socket I/O.
Thus - until now - such data would not be decrypted in case of
connections such as HTTP keep-alive, as the recv call would
always get executed first, block until rw_timeout, an
On 12/05/2020 20:16, Lynne wrote:
> From 45ec8f730a183cd98b1d2d705e7a9582ef2f3f28 Mon Sep 17 00:00:00 2001
> From: Lynne
> Date: Mon, 11 May 2020 11:02:19 +0100
> Subject: [PATCH] hwcontext: add av_hwdevice_ctx_create_derived_opts
>
> This allows for users who derive devices to set options for th
Until now, we would have only attempted to utilize already decrypted
data if it was enough to fill the size of buffer requested, that could
very well be up to 32 kilobytes.
With keep-alive connections this would just lead to recv blocking
until rw_timeout had been reached, as the connection would
Without these two changes, keep-alive utilizing functionality as well as
other connectivity that does not close the connection would not get all
the available data, and instead would be in a loop of recv waiting to be
stopped by the retry wrapper (which would then promptly call read
again).
Quite
On Tue, May 12, 2020 at 10:04:13PM +0300, Martin Storsjö wrote:
> On Tue, 12 May 2020, Michael Niedermayer wrote:
>
> >On Tue, May 12, 2020 at 11:25:34AM +0300, Martin Storsjö wrote:
> >>Use this in vf_spp.c, where the get_pixels operation is done on
> >>unaligned source addresses.
> >>
> >>This f
On Tue, 12 May 2020, Michael Niedermayer wrote:
On Tue, May 12, 2020 at 11:25:34AM +0300, Martin Storsjö wrote:
Use this in vf_spp.c, where the get_pixels operation is done on
unaligned source addresses.
This fixes fate-filter-spp on armv7.
LGTM
---
People more familiar with the other ass
On Tue, May 12, 2020 at 12:46:35AM +0200, Michael Niedermayer wrote:
> This was suggested in
> https://github.com/google/oss-fuzz/issues/3787
> to reduce the grouping errors by oss-fuzz
>
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/decode.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Mon, May 11, 2020 at 10:30:46PM +0200, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes:
> 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5739471895265280
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffm
On Mon, May 11, 2020 at 10:30:45PM +0200, Michael Niedermayer wrote:
> Fixes: Out of array access
> Fixes:
> 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5658548592967680
> Fixes:
> 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5723561177382912
On Mon, May 11, 2020 at 11:12:45PM +0200, Paul B Mahol wrote:
> probably ok
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the con
On Tue, May 12, 2020 at 11:25:34AM +0300, Martin Storsjö wrote:
> Use this in vf_spp.c, where the get_pixels operation is done on
> unaligned source addresses.
>
> This fixes fate-filter-spp on armv7.
LGTM
> ---
> People more familiar with the other assembly implementations of
> get_pixels (in
Marton Balint (12020-05-12):
> Then I guess this patch got bikeshedded to pieces with no clear resolution.
> It was a cleanup attempt anyway, so I suggest the author to simply abandon
> it.
Do you mean you prefer to kill the patch than reach a consensus?
Regards,
--
Nicolas George
signature
On Tue, 12 May 2020, Nicolas George wrote:
Marton Balint (12020-05-12):
I think you want to force your preferred pattern to cases which clearly do
not benefit from it.
I want to prevent any pattern where the error code is lost or invented.
We already had enough work old cases where we were
Marton Balint (12020-05-12):
> I think you want to force your preferred pattern to cases which clearly do
> not benefit from it.
I want to prevent any pattern where the error code is lost or invented.
We already had enough work old cases where we were not careful enough
with it, I oppose to anythi
On Tue, 12 May 2020, Nicolas George wrote:
Marton Balint (12020-05-12):
And you assume that I want to assign the error code to ret. Wrong. What if I
want to return it as is?
Assign it to ret and forward ret.
Or what if I want to return NULL beacuse the
function
Marton Balint (12020-05-12):
> And you assume that I want to assign the error code to ret. Wrong. What if I
> want to return it as is?
Assign it to ret and forward ret.
> Or what if I want to return NULL beacuse the
> function returns a pointer?
Bad design, fix it.
>
On Tue, 12 May 2020, Nicolas George wrote:
Marton Balint (12020-05-12):
-FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->buffer.samples, s->channels, 3 * 1024 *
sizeof(s->buffer.samples[0]), alloc_fail);
-FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->cpe, s->chan_map[0],
sizeof(ChannelElement), alloc_fail);
Marton Balint (12020-05-12):
> > -FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->buffer.samples, s->channels, 3 *
> > 1024 * sizeof(s->buffer.samples[0]), alloc_fail);
> > -FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->cpe, s->chan_map[0],
> > sizeof(ChannelElement), alloc_fail);
> > +int ret, ch;
> > +FF
On Tue, 12 May 2020, Michael Niedermayer wrote:
On Mon, May 11, 2020 at 09:35:17PM +0200, Marton Balint wrote:
This will be used for AVCodecContext->profile. By specifying constants in the
encoders we won't have to use the common AVCodecContext options table and
different encoders can use the
On Fri, May 8, 2020 at 5:21 PM Dale Curtis wrote:
> On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer
> wrote:
>
>> On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote:
>> > On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer
>>
>> > wrote:
>> >
>> > > On Mon, May 04, 2020 at 02:19:47PM
On Wed, 13 May 2020, lance.lmw...@gmail.com wrote:
From: Limin Wang
Please refer to the details here:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/
Suggested-by: Nicolas George
Signed-off-by: Limin Wang
---
libavcodec/aacenc.c
From: Limin Wang
Please refer to the details here:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/
Suggested-by: Nicolas George
Signed-off-by: Limin Wang
---
libavcodec/aacenc.c | 8 ++--
libavcodec/ac3enc.c | 102
On Wed, May 13, 2020 at 12:01:22AM +0800, lance.lmw...@gmail.com wrote:
Sorry, ignore this for wrong patch.
> From: Limin Wang
>
> Please refer to the details here:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/
>
> Suggested-by: Ni
From: Limin Wang
Please refer to the details here:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/
Suggested-by: Nicolas George
Signed-off-by: Limin Wang
---
libavcodec/aacenc.c | 8 ++--
libavcodec/ac3enc.c | 102
On Tue, May 12, 2020 at 05:29:13PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-12):
> > return the error code directly? I recall some goto have extra cleanup
> > function,
> > I'm not sure whether it's OK to return error code directly without goto.
>
> There are many places th
lance.lmw...@gmail.com (12020-05-12):
> return the error code directly? I recall some goto have extra cleanup
> function,
> I'm not sure whether it's OK to return error code directly without goto.
There are many places that do. Forcing them to use a goto just to be
able to benefit from that macro
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mv30.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
index fed9bcd..7e67133 100644
--- a/libavcodec/mv30.c
+++ b/libavcodec/mv30.c
@@ -421,7 +421,7 @@ static int decode_intr
On Tue, May 12, 2020 at 04:11:34PM +0200, Nicolas George wrote:
> Marton Balint (12020-05-12):
> > You mean this?
> >
> > #define FF_ALLOC_ARRAY_OR_ERROR(p, nelem, elsize, errstatement)\
> > {\
> > p = av_malloc_array(nelem, elsize);\
> > if (!p) {\
> > errstatement; \
> >
On Tue, May 12, 2020 at 03:58:24PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-12):
> > No, it's not hard-coded, you can name your own goto label.
>
> The label is not hard-coded. The goto is hard-coded. It should not be.
> Frequently, a return would be enough.
return the erro
Marton Balint (12020-05-12):
> You mean this?
>
> #define FF_ALLOC_ARRAY_OR_ERROR(p, nelem, elsize, errstatement)\
> {\
> p = av_malloc_array(nelem, elsize);\
> if (!p) {\
> errstatement; \
> }\
> }
Exactly.
But I am rather in favor of making "something = AVERROR(ENOME
It's not meant for audio or subtitles, or for encoders of any kind.
Signed-off-by: James Almer
---
libavcodec/options_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h
index 695fa5c211..573675351b 100644
--- a/liba
On Tue, 12 May 2020, Nicolas George wrote:
lance.lmw...@gmail.com (12020-05-12):
No, it's not hard-coded, you can name your own goto label.
The label is not hard-coded. The goto is hard-coded. It should not be.
Frequently, a return would be enough.
You mean this?
#define FF_ALLOC_ARRAY
> From: ffmpeg-devel On Behalf Of
> Martin Storsjö
> Sent: Tuesday, May 12, 2020 17:36
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Fu, Linjie
> Subject: Re: [FFmpeg-devel] [PATCH v5 1/3] lavc/libopenh264enc: Rewrite
> profile handling
>
> On Wed, 6 May 2020, Linjie
lance.lmw...@gmail.com (12020-05-12):
> No, it's not hard-coded, you can name your own goto label.
The label is not hard-coded. The goto is hard-coded. It should not be.
Frequently, a return would be enough.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
On Tue, May 12, 2020 at 11:49:01AM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-11):
> > From: Limin Wang
> >
> > These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO &
> > FF_ALLOCZ_ARRAY_OR_GOTO,
> > but the elsize is calcuated by sizeof(*p)
> >
> > Signed-off-by: Limin
Default to enable uniform_spacing_flag. Guess level by the tile
rows/cols. Supported for ICL+ platforms.
Also add documentations.
To encode with 4 rows 2 columns:
ffmpeg ... -c:v hevc_vaapi -tiles 4x2 ...
ffmpeg ... -c:v hevc_vaapi -tile_rows 4 -tile_cols 2 ...
Suggested-by: Jun Zhao
Si
This is accidentally missed while rebasing.
Signed-off-by: Linjie Fu
---
libavcodec/vaapi_hevc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
index c83d481..9083331 100644
--- a/libavcodec/vaapi_hevc.c
+++ b/libavcodec/vaapi_hevc.c
@@ -505
Add functions to initialize tile slice structure and make tile slice:
- vaapi_encode_init_tile_slice_structure
- vaapi_encode_make_tile_slice
Tile slice is not allowed to cross the boundary of a tile due to
the constraints of media-driver. Currently adding support for one
slice per tile.
N x N
Wrap current whole-row slice codes into following functions:
- vaapi_encode_make_row_slice()
- vaapi_encode_init_row_slice_structure()
Signed-off-by: Linjie Fu
---
libavcodec/vaapi_encode.c | 190 ++
1 file changed, 109 insertions(+), 81 deletions(-)
VA_ENC_SLICE_STRUCTURE_EQUAL_MULTI_ROWS is added to in the latest
libva (1.8.0) which matches the hardware behaviour:
/** \brief Driver supports any number of rows per slice but they must be the
same
* for all slices except for the last one, which must be equal or smaller
* to the pre
From: Xu Guangxin
Currently find_ref_idx() would trigger 2 scans in DPB to find the
requested POC:
1. Firstly, ignore MSB of ref->poc and search for the requested POC;
2. Secondly, compare the entire ref->poc with requested POC;
For long term reference, we are able to only check LSB if MSB is no
From: Xu Guangxin
delta_poc_msb_present_flag is needed in find_ref_idx() to
indicate whether MSB of POC should be taken into account.
Details in 8.3.2.
Signed-off-by: Xu Guangxin
Signed-off-by: Linjie Fu
---
libavcodec/hevc_ps.h | 1 +
libavcodec/hevcdec.c | 5 ++---
2 files changed, 3 inser
Hi, any chance to get this merged?
On Sun, May 3, 2020 at 12:32 PM Mattias Wadman wrote:
>
> Sorry for nagging, something left to fix?
>
> On Mon, Apr 27, 2020 at 10:10 AM Mattias Wadman
> wrote:
> >
> > Hi again, looks ok?
> >
> > On Fri, Apr 24, 2020 at 12:54 PM Mattias Wadman
> > wrote:
> >
From: wm4
This contains encoder wrappers for H264, HEVC, AAC, AC3 and MP3.
This is based on top of an original patch by wm4
. The original patch supported both encoding
and decoding, but this patch only includes encoding.
The patch contains further changes by Paweł Wegner
(primarily for splitt
On Sun, 10 May 2020, Lou Logan wrote:
On Sat, May 9, 2020, at 1:41 PM, Martin Storsjö wrote:
+ --enable-mf enable decoding via MediaFoundation [auto]
encoding/decoding typo I presume.
Good catch, thanks. (The original patch supported both, but for now it's
thinned down to on
On Sun, 10 May 2020, James Almer wrote:
On 5/9/2020 6:41 PM, Martin Storsjö wrote:
+#define MF_ENCODER(MEDIATYPE, NAME, ID, OPTS, EXTRA) \
+static const AVClass ff_ ## NAME ## _mf_encoder_class = {
\
+.class_name = #NAME "_mf",
On Sun, 10 May 2020, Marton Balint wrote:
On Sun, 10 May 2020, Martin Storsjö wrote:
From: wm4
This contains encoder wrappers for H264, HEVC, AAC, AC3 and MP3.
This is based on top of an original patch by wm4
. The original patch supported both encoding
and decoding, but this patch only i
lance.lmw...@gmail.com (12020-05-11):
> From: Limin Wang
>
> These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO &
> FF_ALLOCZ_ARRAY_OR_GOTO,
> but the elsize is calcuated by sizeof(*p)
>
> Signed-off-by: Limin Wang
> ---
> libavutil/internal.h | 18 ++
> 1 file changed,
On Wed, 6 May 2020, Linjie Fu wrote:
Set DEPRECATED flag to option cabac, replace with coder. The
priority logic is:
1. s->coder; then
2. avctx->coder_type; then
3. s->cabac.
Change the default option to -1 and allow the default cabac to be
determined by profile.
Add FF_API_OPENH264_CABAC macr
On Wed, 6 May 2020, Linjie Fu wrote:
And determine the profile with following priority:
1. s->profile; then
2. avctx->profile; then
3. s->cabac; then
4. a default profile.
This seems more natural in case user somehow sets both avctx->profile and
s->profile.
Signed-off-by: Linjie Fu
---
libavc
On Wed, 6 May 2020, Linjie Fu wrote:
Support the profiles "constrained_baseline" and "high" for libopenh264
version >= 1.8, support "constrained_baseline" and "main" for earlier
version.
If option not supported with current version, convert to constrained
baseline with a warning for users.
Sig
Use this in vf_spp.c, where the get_pixels operation is done on
unaligned source addresses.
This fixes fate-filter-spp on armv7.
---
People more familiar with the other assembly implementations of
get_pixels (in particular, x86) can hook them up to
get_pixels_unaligned if unaligned use explicitly
On Mon, 11 May 2020, Andriy Gelman wrote:
On Fri, 01. May 17:54, Marton Balint wrote:
On Thu, 30 Apr 2020, Andriy Gelman wrote:
> From: Andriy Gelman
>
> A temporary heap array currently stores pids from all streams. It is
> used to make sure there are no duplicated pids. However, this
Quoting Andreas Rheinhardt (2020-05-11 23:58:47)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2020-05-10 21:35:54)
> >> Anton Khirnov:
> >>> Quoting Marton Balint (2020-05-10 19:45:04)
>
>
> On Sun, 10 May 2020, Anton Khirnov wrote:
>
> > Quoting Andreas Rheinhardt (2020
66 matches
Mail list logo
