Re: [FFmpeg-devel] [PATCH v4 1/4] avfilter/vf_scdet: add filter to detect scene change

2020-05-13 Thread Gyan Doshi
On 14-05-2020 06:55 am, lance.lmw...@gmail.com wrote: will rebase and apply it tomorrow if no more comments as it's reviewed long time. I need it for other filter to use. What would be helpful is to add options to detect scene change only within a specified window. Imagine surveillance

[FFmpeg-devel] [PATCH] web/documentation: Updated list of FFmpeg books

2020-05-13 Thread FFmpegQuickHacks
--- src/documentation | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/documentation b/src/documentation index 060ef06..f6d5535 100644 --- a/src/documentation +++ b/src/documentation @@ -126,10 +126,12 @@ Books about FFmpeg -

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: expose the enabled device features

2020-05-13 Thread Lynne
May 13, 2020, 17:45 by ffm...@haasn.xyz: > Hi, I guess you already know this but just as a reminder: > > On Wed, 13 May 2020 17:53:33 +0200 (CEST), Lynne wrote: > >> +vkGetPhysicalDeviceFeatures(hwctx->phys_dev, _features); >> +#define COPY_FEATURE(DST, NAME) (DST).NAME = dev_features.NAME;

Re: [FFmpeg-devel] [PATCH v4 1/4] avfilter/vf_scdet: add filter to detect scene change

2020-05-13 Thread lance . lmwang
will rebase and apply it tomorrow if no more comments as it's reviewed long time. I need it for other filter to use. On Tue, Oct 08, 2019 at 11:28:36PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Paul B Mahol > Signed-off-by: Limin Wang > --- > configure

Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]

2020-05-13 Thread lance . lmwang
On Tue, May 12, 2020 at 11:09:19PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mv30.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c > index fed9bcd..7e67133 100644

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

2020-05-13 Thread Dale Curtis
On Wed, May 13, 2020 at 3:55 PM Michael Niedermayer wrote: > On Fri, May 08, 2020 at 05:21:06PM -0700, Dale Curtis wrote: > > On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer > > > wrote: > > > > > On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote: > > > > On Mon, May 4, 2020 at

Re: [FFmpeg-devel] [PATCH v2 4/4] avfilter/vf_drawbox: support draw specific face by facedetect metadata

2020-05-13 Thread lance . lmwang
On Wed, May 13, 2020 at 07:16:47PM +0200, Marton Balint wrote: > > > On Wed, 13 May 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/filters.texi | 10 ++ > > libavfilter/vf_drawbox.c | 27 +++

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-13 Thread Thierry Foucu
On Mon, May 11, 2020 at 9:35 AM Thierry Foucu wrote: > If you have a file with multiple Metadata Keys, the second time you parse > the keys, you will re-alloc c->meta_keys without freeing the old one. > This change will avoid parsing all the consecutive Metadata keys. > --- > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

2020-05-13 Thread Michael Niedermayer
On Fri, May 08, 2020 at 05:21:06PM -0700, Dale Curtis wrote: > On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer > wrote: > > > On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote: > > > On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer > > > > > wrote: > > > > > > > On Mon, May 04,

[FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Free packed_headers

2020-05-13 Thread Michael Niedermayer
Fixes: memleak Fixes: 21784/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-565256551058636 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000dec.c | 2 ++ 1 file

[FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Check or bound indexes

2020-05-13 Thread Michael Niedermayer
This causes indexes into scale_conversion_table to wrap around, alternatively they could be clipped, the table be enlarged or we can error out. I have not found a document that specifies what is the correct way to handle this Fixes: out of array access Fixes:

[FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: expose the enabled device features

2020-05-13 Thread Lynne
With this, the puzze of making libplacebo, ffmpeg and any other Vulkan API users interoperable is complete. Users of both libraries can initialize one another's contexts without having to create a new one. Patch attached. >From 28264793295b0d7861527f40fa7c7041a3b34907 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH v2] checkasm: add hscale test

2020-05-13 Thread Martin Storsjö
On Wed, 13 May 2020, Josh de Kock wrote: This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Should address all previous comments. tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 +

Re: [FFmpeg-devel] [PATCH v2 4/4] avfilter/vf_drawbox: support draw specific face by facedetect metadata

2020-05-13 Thread Marton Balint
On Wed, 13 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 10 ++ libavfilter/vf_drawbox.c | 27 +++ 2 files changed, 37 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: expose the enabled device features

2020-05-13 Thread Niklas Haas
Hi, I guess you already know this but just as a reminder: On Wed, 13 May 2020 17:53:33 +0200 (CEST), Lynne wrote: > +vkGetPhysicalDeviceFeatures(hwctx->phys_dev, _features); > +#define COPY_FEATURE(DST, NAME) (DST).NAME = dev_features.NAME; > +COPY_FEATURE(hwctx->device_features,

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: expose the amount of queues for each queue family

2020-05-13 Thread Lynne
This, along with the next patch, are the last missing pieces to being interoperable with libplacebo. There is no danger of users running into this API break because there are none, and API was completely backwards-incompatibly changed just 2 days ago. This is needed so we won't have to break the

Re: [FFmpeg-devel] [PATCH] doc/filters: add anchor for addroi

2020-05-13 Thread lance . lmwang
On Wed, May 13, 2020 at 10:50:59PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > add anchor for have reference for the facedetect facedetect patch use it, so update v2 and put into patchset or fate will failed. > > doc/filters.texi | 1 + > 1

[FFmpeg-devel] [PATCH v2 2/4] avfilter/vf_libopencv: add opencv HaarCascade classifier simple face detection filter

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- configure | 1 + doc/filters.texi | 29 libavfilter/vf_libopencv.c | 164 - 3 files changed, 191 insertions(+), 3 deletions(-) diff --git a/configure b/configure

[FFmpeg-devel] [PATCH v2 4/4] avfilter/vf_drawbox: support draw specific face by facedetect metadata

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 10 ++ libavfilter/vf_drawbox.c | 27 +++ 2 files changed, 37 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 76e12ef..bf9043c 100644 --- a/doc/filters.texi +++

[FFmpeg-devel] [PATCH v2 1/4] doc/filters: add anchor for addroi

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/filters.texi b/doc/filters.texi index d19fd34..c128033 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -6294,6 +6294,7 @@ build. Below is a description of the

[FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_libopencv: reindent after last commit

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_libopencv.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_libopencv.c b/libavfilter/vf_libopencv.c index 141d696..5899867 100644 --- a/libavfilter/vf_libopencv.c +++

[FFmpeg-devel] [PATCH v2] checkasm: add hscale test

2020-05-13 Thread Josh de Kock
This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Should address all previous comments. tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/sw_scale.c | 114

[FFmpeg-devel] [PATCH] doc/filters: add anchor for addroi

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- add anchor for have reference for the facedetect doc/filters.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/filters.texi b/doc/filters.texi index a1a4e81..bf9043c 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -6294,6

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tls_schannel: immediately return decrypted data if available

2020-05-13 Thread Jan Ekström
On Wed, May 13, 2020 at 12:46 PM Jan Ekström wrote: > > On Wed, May 13, 2020 at 3:02 AM Hendrik Leppkes wrote: > > > > On Wed, May 13, 2020 at 12:12 AM Jan Ekström wrote: > > > > > > Until now, we would have only attempted to utilize already decrypted > > > data if it was enough to fill the

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_drawbox: support draw specific face by facedetect metadata

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 10 ++ libavfilter/vf_drawbox.c | 27 +++ 2 files changed, 37 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index e50dcf3..a1a4e81 100644 --- a/doc/filters.texi +++

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_libopencv: add opencv HaarCascade classifier simple face detection filter

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- Have tested with opencv 2.4.13 and 3.4.10 with static link configure | 1 + doc/filters.texi | 29 libavfilter/vf_libopencv.c | 164 - 3 files changed, 191

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_libopencv: reindent after last commit

2020-05-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_libopencv.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_libopencv.c b/libavfilter/vf_libopencv.c index b7a9282..c8512cc 100644 --- a/libavfilter/vf_libopencv.c +++

[FFmpeg-devel] [PATCH 1/3] checkasm: pixblockdsp: Add tests for get_pixels_unaligned and diff_pixels_unaligned

2020-05-13 Thread Martin Storsjö
--- tests/checkasm/pixblockdsp.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/checkasm/pixblockdsp.c b/tests/checkasm/pixblockdsp.c index e14b0a90de..79ab156d45 100644 --- a/tests/checkasm/pixblockdsp.c +++ b/tests/checkasm/pixblockdsp.c @@ -44,13

[FFmpeg-devel] [PATCH 3/3] libavcodec: aarch64: Add a NEON implementation of pixblockdsp

2020-05-13 Thread Martin Storsjö
Cortex A53A72A73 get_pixels_c:140.7 87.7 72.5 get_pixels_neon: 46.0 20.0 19.5 get_pixels_unaligned_c: 140.7 87.7 73.0 get_pixels_unaligned_neon:49.2 20.2 26.2 diff_pixels_c: 209.7 133.7 138.7

[FFmpeg-devel] [PATCH 2/3] libavcodec: arm: Add a NEON implementation of pixblockdsp

2020-05-13 Thread Martin Storsjö
Cortex A7 A8 A9A53 A72 get_pixels_c:144.7 146.0 143.0 137.7 69.0 get_pixels_armv6:112.0 106.7 90.2 95.0 72.5 get_pixels_neon: 69.0 29.7 68.7 40.2 19.0 get_pixels_unaligned_c: 144.7 146.2

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tls_schannel: immediately return decrypted data if available

2020-05-13 Thread Jan Ekström
On Wed, May 13, 2020 at 3:02 AM Hendrik Leppkes wrote: > > On Wed, May 13, 2020 at 12:12 AM Jan Ekström wrote: > > > > Until now, we would have only attempted to utilize already decrypted > > data if it was enough to fill the size of buffer requested, that could > > very well be up to 32

Re: [FFmpeg-devel] [PATCH v5 1/3] lavc/libopenh264enc: Rewrite profile handling

2020-05-13 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Tuesday, May 12, 2020 21:58 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 1/3] lavc/libopenh264enc: Rewrite > profile handling > > > From: ffmpeg-devel On Behalf Of > > Martin