[FFmpeg-devel] [PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-05 Thread gautamramk
From: Gautam Ramakrishnan I have attempted to write a JPEG2000 Parser. Have tested by generating a file containing 14 frames, as mentioned by Micheal. Have also tried testing with various packet sizes by setting -frame_size option. Additionally, fixed a few formatting issues as pointed out by Mic

Re: [FFmpeg-devel] [PATCH v2] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Max Dmitrichenko > Sent: Friday, June 5, 2020 3:09 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/qsvvpp: Work around a bug > in MSDK where VPP processing ha

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-06-05 Thread lance . lmwang
On Fri, Jun 05, 2020 at 05:06:53PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-25): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/Makefile| 1 - > > libavfilter/graphdump.c | 89 + > > tools/graph2dot.c | 204

Re: [FFmpeg-devel] [PATCH v7 2/3] avdevice/lavfi: support the dumpgraph with options

2020-06-05 Thread lance . lmwang
On Fri, Jun 05, 2020 at 07:10:08PM +0200, Marton Balint wrote: > > > On Fri, 5 Jun 2020, Nicolas George wrote: > > > lance.lmw...@gmail.com (12020-05-25): > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > doc/indevs.texi | 19 +-- > > > libavdev

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/mlp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-05 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 01:03:15PM -0700, Thierry Foucu wrote: > the target_dec_fuzzer is checking for the avpkt.data pointer but if the > mlp parser cannot combine the frame, the poutbuf is not set. > --- > libavcodec/mlp_parser.c | 1 + > 1 file changed, 1 insertion(+) will apply thx [...] --

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/bmp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-05 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 01:03:27PM -0700, Thierry Foucu wrote: > the target_dec_fuzzer is checking for the avpkt.data pointer but if the > bmp parser cannot combine the frame, the poutbuf is not set. > --- > libavcodec/bmp_parser.c | 1 + > 1 file changed, 1 insertion(+) will apply thx [...] --

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-05 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 01:03:00PM -0700, Thierry Foucu wrote: > the target_dec_fuzzer is checking for the avpkt.data pointer but if the > png parser cannot combine the frame, the poutbuf is not set. > --- > libavcodec/png_parser.c | 1 + > 1 file changed, 1 insertion(+) will apply thx [...] --

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

2020-06-05 Thread Michael Niedermayer
On Thu, May 14, 2020 at 03:31:53PM -0700, Dale Curtis wrote: > Fixes one issue in the function itself and one in the dependent > function av_add_stable() which wasn't checking for NaN. > > Signed-off-by: Dale Curtis > --- > libavformat/utils.c | 2 +- > libavutil/mathematics.c | 2 +- > 2 fi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvdec: Test vertical coordinate more often

2020-06-05 Thread Michael Niedermayer
On Fri, Jun 05, 2020 at 11:18:25PM +0200, Paul B Mahol wrote: > probably ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Be

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rawdec: reduce randomness in used identifiers

2020-06-05 Thread Michael Niedermayer
On Fri, Jun 05, 2020 at 10:29:23AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-06-04 01:19:18) > >Subject: avformat/rawdec: reduce randomness in used identifiers > > The patch looks ok, but the commit message is not very clear. "fix > identifier names" would be easier to

Re: [FFmpeg-devel] [PATCH 4/4] pthread_frame: use av_buffer_replace() to simplify code

2020-06-05 Thread Michael Niedermayer
On Fri, Jun 05, 2020 at 12:02:19PM +0200, Anton Khirnov wrote: > --- > libavcodec/pthread_frame.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > this changes the output from: (it has fewer frames output) ./ffmpeg -i tickets/5522/progressive_q_mediumhd.avi -f framecrc -

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvdec: Test vertical coordinate more often

2020-06-05 Thread Paul B Mahol
probably ok On 6/5/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 22892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5135996772679680.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-05 Thread Michael Niedermayer
On Fri, Jun 05, 2020 at 09:54:49PM +0530, Gautam Ramakrishnan wrote: > On Fri, Jun 5, 2020 at 8:23 AM Gautam Ramakrishnan > wrote: > > > > On Fri, Jun 5, 2020 at 3:21 AM Michael Niedermayer > > wrote: > > > > > > On Thu, Jun 04, 2020 at 01:24:42PM +0530, gautamr...@gmail.com wrote: > > > > From:

[FFmpeg-devel] [PATCH 1/2] avcodec/movtextdec: Fix shift overflows in mov_text_init()

2020-06-05 Thread Michael Niedermayer
Fixes: left shift of 243 by 24 places cannot be represented in type 'int' Fixes: 22716/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOVTEXT_fuzzer-5704263425851392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH 2/2] avcodec/huffyuvdec: Test vertical coordinate more often

2020-06-05 Thread Michael Niedermayer
Fixes: out of array access Fixes: 22892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5135996772679680.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/huffyuvdec.c | 8 +++

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-05 Thread Dale Curtis
Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> >> Signed-off-by: Dale Curtis >> --- >> libavfo

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

2020-06-05 Thread Dale Curtis
Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> Fixes one issue in the function itself and one in

Re: [FFmpeg-devel] [PATCH v7 2/3] avdevice/lavfi: support the dumpgraph with options

2020-06-05 Thread Marton Balint
On Fri, 5 Jun 2020, Nicolas George wrote: lance.lmw...@gmail.com (12020-05-25): From: Limin Wang Signed-off-by: Limin Wang --- doc/indevs.texi | 19 +-- libavdevice/lavfi.c | 8 +--- 2 files changed, 22 insertions(+), 5 deletions(-) Either we case about backward

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-05 Thread Gautam Ramakrishnan
On Fri, Jun 5, 2020 at 8:23 AM Gautam Ramakrishnan wrote: > > On Fri, Jun 5, 2020 at 3:21 AM Michael Niedermayer > wrote: > > > > On Thu, Jun 04, 2020 at 01:24:42PM +0530, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > I have attempted to write a JPEG2000 Parser. Have te

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-06-05 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel On Behalf Of Fu, Linjie > Sent: Friday, March 13, 2020 8:18 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to > disable/enable the default scale > > > From: ffmpeg-

Re: [FFmpeg-devel] [PATCH v7 2/3] avdevice/lavfi: support the dumpgraph with options

2020-06-05 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-25): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/indevs.texi | 19 +-- > libavdevice/lavfi.c | 8 +--- > 2 files changed, 22 insertions(+), 5 deletions(-) Either we case about backwards compatibility, and you cannot cha

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-06-05 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-25): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/Makefile| 1 - > libavfilter/graphdump.c | 89 + > tools/graph2dot.c | 204 > > 3 files changed, 89 inser

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: reopen new http session for http_persistent

2020-06-05 Thread Chris Ribble
> Hello Chris Ribble > > > > Looks you are working for http patch , > > Can you share a test script for it ? > There is a description of the problem in the Trac ticket along with an example of how to reproduce the issue: https://trac.ffmpeg.org/ticket/8693 Let me know what else you are interested

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: reopen new http session for http_persistent

2020-06-05 Thread Chris Ribble
On Tue, Jun 2, 2020 at 12:22 AM Siyuan Huang wrote: > Hello Chris Ribble > > > > Looks you are working for http patch , > > Can you share a test script for it ? > > Siyuan Huang, There is a description of the problem in the Trac ticket along with an example of how to reproduce the issue: https:/

Re: [FFmpeg-devel] [PATCH v2] avutil/dict: av_realloc -> av_realloc_array()

2020-06-05 Thread lance . lmwang
On Sat, May 30, 2020 at 10:10:32PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/dict.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/dict.c b/libavutil/dict.c > index 0ea7138..9d3d96c 100644 > -

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-06-05 Thread lance . lmwang
On Thu, May 28, 2020 at 04:14:27PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-28): > > will apply the patchset tomorrow if no further comments. > > Please give me time to look carefully. This is not urgent. Nicolas, do you have got free time to review the patch set and give

[FFmpeg-devel] [PATCH v4 1/3] avfilter/vf_overlay: support for 8bit and 10bit overlay with macro-based function

2020-06-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- It's old patch, so rebase and merge into one patch for review, in addition, I have added format for yuv422p10, and fate test case. libavfilter/vf_overlay.c | 417 +-- 1 file changed, 220 insertions(+),

[FFmpeg-devel] [PATCH v4 2/3] avfilter/vf_overlay: add yuv420p10 and yuv422p10 10bit format support

2020-06-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 6 libavfilter/vf_overlay.c | 79 libavfilter/vf_overlay.h | 2 ++ 3 files changed, 87 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index f76604c.

[FFmpeg-devel] [PATCH v4 3/3] fate: add yuv420p10 and yuv422p10 tests for overlay filter

2020-06-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 8 tests/filtergraphs/overlay_yuv420p10| 5 + tests/filtergraphs/overlay_yuv422p10| 5 + tests/ref/fate/filter-overlay_yuv420p10 | 8 tests/ref/fate/filter-overlay_yuv422p1

Re: [FFmpeg-devel] [PATCH v2] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-06-05 Thread Max Dmitrichenko
On Mon, May 25, 2020 at 12:40 AM Soft Works wrote: > These are: > - Dimensions are already aligned (e.g. 1920x800) > - No scaling is done > - Color format conversion (e.g. 10bit to 8bit) > > Example command: > ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv > -filter_complex "scale_q

Re: [FFmpeg-devel] [PATCH 1/4] lavu/buffer: add a convenience function for replacing buffers

2020-06-05 Thread James Almer
On 6/5/2020 7:02 AM, Anton Khirnov wrote: > A common pattern e.g. in libavcodec is replacing/updating buffer > references: unref old one, ref new one. This function allows simplifying > such code an avoiding unnecessary refs+unrefs if the references are > already equivalent. > --- > doc/APIchanges

[FFmpeg-devel] [PATCH][GSoC]audio filter - Generate algorithmic riff music

2020-06-05 Thread Ashutosh Pradhan
diff --git a/Changelog b/Changelog index 711c843b99..905b91b570 100644 --- a/Changelog +++ b/Changelog @@ -75,7 +75,7 @@ version : - PFM decoder - dblur video filter - Real War KVAG muxer - +- atone filter version 4.2: - tpad filter diff --git a/configure b/configure index 8569a60bf8..954e35

[FFmpeg-devel] [PATCH] add ability to bypass custom video pts generation and use capture filter provided pts

2020-06-05 Thread Dmitry Sinitsyn
From: Dmitry Sinitsyn Hello, This patch is about #8620 issue. I do not know why initial developer thought that "PTS from video devices is unreliable" but nowadays my experience makes me sure that we should use sample stream start time as PTS for all types of streams. But I do not want to break

Re: [FFmpeg-devel] [PATCH 2/2 v2] avutil/buffer: avutil/buffer: add a mention that some arguments from av_buffer_pool_init2() may be NULL

2020-06-05 Thread Anton Khirnov
Quoting James Almer (2020-06-01 15:35:08) > Signed-off-by: James Almer > --- > libavutil/buffer.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avutil/buffer: use the default allocator if none is provided to av_buffer_pool_init2()

2020-06-05 Thread Anton Khirnov
Quoting James Almer (2020-06-01 15:35:07) > Signed-off-by: James Almer > --- > doc/APIchanges | 3 +++ > libavutil/buffer.c | 3 +++ > libavutil/version.h | 2 +- > 3 files changed, 7 insertions(+), 1 deletion(-) > Looks ok -- Anton Khirnov __

Re: [FFmpeg-devel] [PATCH] avutil/buffer: separate public and internal flags inside AVBuffers

2020-06-05 Thread Anton Khirnov
Quoting James Almer (2020-06-01 18:04:35) > It's better to not mix user provided flags and internal flags set by > AVBufferRef helper functions. > > Signed-off-by: James Almer > --- Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH 3/4] mpegvideo: use av_buffer_replace() to simplify code

2020-06-05 Thread Anton Khirnov
--- libavcodec/mpegpicture.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index 5fce25ec6e..59097fab0c 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c @@ -320,30 +

[FFmpeg-devel] [PATCH 2/4] hevcdec: use av_buffer_replace() to simplify code

2020-06-05 Thread Anton Khirnov
--- libavcodec/hevcdec.c | 36 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 0772608a30..94fd6f6e0d 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -3420,30 +3420,21 @@ static i

[FFmpeg-devel] [PATCH 4/4] pthread_frame: use av_buffer_replace() to simplify code

2020-06-05 Thread Anton Khirnov
--- libavcodec/pthread_frame.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 601f170447..3626e745f5 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -297,16 +297,9 @@ stati

[FFmpeg-devel] [PATCH 1/4] lavu/buffer: add a convenience function for replacing buffers

2020-06-05 Thread Anton Khirnov
A common pattern e.g. in libavcodec is replacing/updating buffer references: unref old one, ref new one. This function allows simplifying such code an avoiding unnecessary refs+unrefs if the references are already equivalent. --- doc/APIchanges | 3 +++ libavutil/buffer.c | 22 +++

Re: [FFmpeg-devel] [PATCH 4/4] lavf/tls: verify TLS connections by default whenever possible

2020-06-05 Thread Anton Khirnov
Quoting Moritz Barsnick (2020-06-03 12:32:25) > On Wed, Jun 03, 2020 at 02:40:53 -0500, Ridley Combs wrote: > > > Strictly speaking, this is a change in behavior, so I would at least > > > appreciate a version bump. > > > > Reasonable; what level should it be? I'd guess a minor bump? Though > > tra

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rawdec: reduce randomness in used identifiers

2020-06-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-06-04 01:19:18) >Subject: avformat/rawdec: reduce randomness in used identifiers The patch looks ok, but the commit message is not very clear. "fix identifier names" would be easier to understand IMO. -- Anton Khirnov