Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-11 Thread Dale Curtis
Bump again. Thanks. - dale On Fri, Jun 5, 2020 at 11:48 AM Dale Curtis wrote: > Bump for this one again. Thanks in advance. > > - dale > > On Thu, May 28, 2020 at 12:37 PM Dale Curtis > wrote: > >> Bump now that the saturated math operations have landed. Thanks! >> >> - dale >> >> On Thu, Ma

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Friday, June 12, 2020 01:52 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate > encoder instance if resolution changes > > Fu, Linjie (12020-06

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Fu, Linjie
> From: Nicolas George > Sent: Friday, June 12, 2020 00:49 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and > recreate encoder instance if resolution changes > > Linjie Fu (12020-06-11): >

Re: [FFmpeg-devel] [PATCH] OS/2:Support linking against libcx

2020-06-11 Thread Dave Yeo
On 06/11/20 10:26 AM, Michael Niedermayer wrote: On Wed, Jun 10, 2020 at 09:24:51PM -0700, Dave Yeo wrote: On 06/10/20 02:09 PM, Michael Niedermayer wrote: On Tue, Jun 09, 2020 at 11:11:48PM -0700, Dave Yeo wrote: Hi, could I get this pushed to trunk and the 4.3 branch? Fixes a build break in

[FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 5d4aee4..5315f8f 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_s

[FFmpeg-devel] [PATCH] avformat/isom: enable extended language for mov

2020-06-11 Thread Yongle Lin
Allow extended language codes using ISO designation for text tracks in mov format when strictness is set to experimental --- This patch includes a support for mov format to extend language codes using ISO designation for text tracks(https://developer.apple.com/library/archive/documentation/Quick

Re: [FFmpeg-devel] [PATCH v12 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread lance . lmwang
On Thu, Jun 11, 2020 at 06:35:15PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_showinfo.c | 37 + > > 1 file changed, 37 insertions(+) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Nicolas George
Paul B Mahol (12020-06-12): > FFmpeg is not math encyclopedia. You did not type these numbers, you took them from somewhere. Include it in the source code, where it belongs. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Paul B Mahol
On 6/12/20, Nicolas George wrote: > Paul B Mahol (12020-06-12): >> This is part of basic math, > > Then add the formula in a comment. But no, it is not just basic math: > there was a program that did the computations. FFmpeg is not math encyclopedia. > >> you seems to lack basic math knowledge.

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-11 Thread Paul B Mahol
On 6/12/20, Nicolas George wrote: > Paul B Mahol (12020-06-12): >> This is needed also by showspectrumpic filter and it needs random number >> of >> samples to skip and peek. > > I looked at the code for showspectrumpic before making my comment: the > second part of your statement does not seem ac

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-11 Thread Nicolas George
Paul B Mahol (12020-06-12): > This is needed also by showspectrumpic filter and it needs random number of > samples to skip and peek. I looked at the code for showspectrumpic before making my comment: the second part of your statement does not seem accurate. -- Nicolas George signature.asc D

Re: [FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Nicolas George
Paul B Mahol (12020-06-12): > This is part of basic math, Then add the formula in a comment. But no, it is not just basic math: there was a program that did the computations. > you seems to lack basic math knowledge. Rude again. -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Paul B Mahol
On 6/11/20, Nicolas George wrote: > Paul B Mahol (12020-06-11): >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 60 ++ >> libavfilter/Makefile |1 + >> libavfilter/af_afwtdn.c | 1345 ++ >> libavfilter/allfilters.c |1 + >> 4

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-11 Thread Paul B Mahol
On 6/11/20, Nicolas George wrote: > Paul B Mahol (12020-06-11): >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/avfilter.c | 61 +- >> libavfilter/filters.h | 17 >> 2 files changed, 72 insertions(+), 6 deletions(-) > > Still no. It make

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-11 Thread Gavin Smith
On 11/06/2020 22:03, Timo Rothenpieler wrote: On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724.  The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or pixels that were semi-tranparent would appe

Re: [FFmpeg-devel] [PATCH 3/5] lavc/h264dec: loosen new-extradata check

2020-06-11 Thread Ridley Combs
> On Jun 11, 2020, at 07:53, James Almer wrote: > > On 6/11/2020 1:43 AM, rcombs wrote: >> --- >> libavcodec/h264dec.c | 13 ++--- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c >> index 6270ea80df..0d7492cfad 100644 >>

Re: [FFmpeg-devel] [PATCH 4/5] lavf/dashdec: improve memory handling

2020-06-11 Thread Ridley Combs
> On Jun 11, 2020, at 10:19, Andreas Rheinhardt > wrote: > > rcombs: >> - Fixes a couple leaks >> - Adds an av_freep equivalent for libxml buffers >> - Avoids some redundant copying >> --- >> libavformat/dashdec.c | 44 +++ >> 1 file changed, 24 insertion

[FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Fix/check for multiple integer overflows

2020-06-11 Thread Michael Niedermayer
Fixes: shift exponent 35 is too large for 32-bit type 'int' Fixes: 22857/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5202709358837760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Fix 2 integer overflows in get_amv()

2020-06-11 Thread Michael Niedermayer
Fixes: signed integer overflow: -144876608 * 16 cannot be represented in type 'int' Fixes: 22782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-6039584977977344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-11 Thread Timo Rothenpieler
On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724. The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or pixels that were semi-tranparent would appear opaque. What is the performance impact for

[FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-11 Thread Gavin Smith
This is to address trac ticket #8724. The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or pixels that were semi-tranparent would appear opaque. --- libavfilter/vf_chromakey.c | 43 ++ 1

Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel format x2rgb10

2020-06-11 Thread Lynne
Jun 2, 2020, 08:30 by fei.w.w...@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Wang, >> Fei W >> Sent: Friday, May 15, 2020 2:58 PM >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel >> for

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-11 Thread Nicolas George
Paul B Mahol (12020-06-11): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 61 +- > libavfilter/filters.h | 17 > 2 files changed, 72 insertions(+), 6 deletions(-) Still no. It makes a very important function much more complex

Re: [FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Nicolas George
Paul B Mahol (12020-06-11): > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 60 ++ > libavfilter/Makefile |1 + > libavfilter/af_afwtdn.c | 1345 ++ > libavfilter/allfilters.c |1 + > 4 files changed, 1407 insertions(+) > create

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Nicolas George
Fu, Linjie (12020-06-11): > If rawvideo here means .h264, attached the output file produced by libx264: Now, rawvideo means rawvideo. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] [PATCH] OS/2:Support linking against libcx

2020-06-11 Thread Michael Niedermayer
On Wed, Jun 10, 2020 at 09:24:51PM -0700, Dave Yeo wrote: > On 06/10/20 02:09 PM, Michael Niedermayer wrote: > > On Tue, Jun 09, 2020 at 11:11:48PM -0700, Dave Yeo wrote: > > > Hi, could I get this pushed to trunk and the 4.3 branch? Fixes a build > > > break > > > in libavformat/ip.c (implicit de

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Nicolas George
Fu, Linjie (12020-06-11): > Indeed, tested with .mp4 and .h264 for encoder libx264, the results are > playable. > (discarding global header if resolution changing is allowed, then we can keep > the > Sequence header in each Key frame and make the resolution changing noticeable) > > Please help t

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Nicolas George
Linjie Fu (12020-06-11): > Add recreate_encoder_instance() function. > > If resolution changing is allowed, discard AV_CODEC_FLAG_GLOBAL_HEADER > even if the avformat/container declares AVFMT_GLOBALHEADER flag. Place > header information in every keyframe instead of single global header. Why? How

[FFmpeg-devel] [PATCH 1/7] avfilter/af_biquads: switch to activate()

2020-06-11 Thread Paul B Mahol
Needed by following commits. Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 81cdb0c10e..ef28db741a 100644 --- a/libavfilter/a

[FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 61 +- libavfilter/filters.h | 17 2 files changed, 72 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index dd8074e462..b1db92de4b 100644 ---

[FFmpeg-devel] [PATCH 4/7] avfilter/af_biquads: add different transform types

2020-06-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 351 +-- 1 file changed, 336 insertions(+), 15 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 5e2d74f8f9..f3ef3660cc 100644 --- a/libavfilter/af_biquads.c +++ b/lib

Re: [FFmpeg-devel] [PATCH v12 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index 5d4aee4..3658234 100644 > ---

[FFmpeg-devel] [PATCH 6/7] avfilter/avf_showspectrumpic: switch to internal queue

2020-06-11 Thread Paul B Mahol
Fixes filtering audio with more than 1.5h length. Signed-off-by: Paul B Mahol --- libavfilter/avf_showspectrum.c | 119 - 1 file changed, 59 insertions(+), 60 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index e99f377f

[FFmpeg-devel] [PATCH 5/7] avfilter/af_biquads: refactor code

2020-06-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 279 ++- 1 file changed, 68 insertions(+), 211 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index f3ef3660cc..c998f3e982 100644 --- a/libavfilter/af_biquads.c +++ b/lib

[FFmpeg-devel] [PATCH 3/7] avfilter/af_biquads: add reverse filtering support

2020-06-11 Thread Paul B Mahol
Add it to all filters, except allpass as it does not make sense to use it in such case. Signed-off-by: Paul B Mahol --- doc/filters.texi | 72 +++ libavfilter/af_biquads.c | 271 +-- 2 files changed, 333 insertions(+), 10 deletions(-) diff --

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_av1: abort when the written inferred value is not the expected one

2020-06-11 Thread James Almer
If this happens, it's a sign of parsing issues earlier in the process, or misuse by the calling module. Prevents creating invalid bitstreams. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_av1.c b/libavcod

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h2645: abort when the written inferred value is not the expected one

2020-06-11 Thread James Almer
If this happens, it's a sign of parsing issues earlier in the process, or misuse by the calling module. Prevents creating invalid bitstreams. Signed-off-by: James Almer --- libavcodec/cbs_h2645.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/liba

[FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

2020-06-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 60 ++ libavfilter/Makefile |1 + libavfilter/af_afwtdn.c | 1345 ++ libavfilter/allfilters.c |1 + 4 files changed, 1407 insertions(+) create mode 100644 libavfilter/af_afwtdn.c diff -

Re: [FFmpeg-devel] [PATCH v10 1/4] avutil: add AV_FRAME_DATA_SEI_UNREGISTERED side data type

2020-06-11 Thread lance . lmwang
On Thu, Jun 11, 2020 at 12:51:44PM -0300, James Almer wrote: > On 6/11/2020 12:39 PM, Andreas Rheinhardt wrote: > > lance.lmw...@gmail.com: > >> On Wed, Jun 10, 2020 at 07:43:11AM +0800, lance.lmw...@gmail.com wrote: > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> --- > >>> reb

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/libopenjpeg: pix fmt selection change

2020-06-11 Thread Michael Bradshaw
On Thu, Jun 11, 2020 at 9:42 AM Gautam Ramakrishnan wrote: > Got it. In that case we can safely ignore the patch to fix libopenjpeg. > However, p1_03.j2k is one of the 2 files to have ppm marker. How could I > validate a patch to add ppm marker? I need something to cross validate. > Any suggestio

Re: [FFmpeg-devel] [PATCH v11 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread lance . lmwang
On Thu, Jun 11, 2020 at 05:44:45PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Wed, Jun 10, 2020 at 08:13:59PM +0200, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> --- > >>> libavfilter/vf_showinfo.

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Fu, Linjie
> From: Nicolas George > Sent: Wednesday, June 10, 2020 19:54 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate > encoder instance if resolution changes > > Linjie Fu (12020-06-09): >

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, June 10, 2020 16:31 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate > encoder instance if resolution changes > > Quoting Linjie Fu

Re: [FFmpeg-devel] [PATCH v10 1/4] avutil: add AV_FRAME_DATA_SEI_UNREGISTERED side data type

2020-06-11 Thread James Almer
On 6/11/2020 12:39 PM, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: >> On Wed, Jun 10, 2020 at 07:43:11AM +0800, lance.lmw...@gmail.com wrote: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> rebase with master only, I'll apply the patchset in two days if no >>> objectio

[FFmpeg-devel] [PATCH v2 5/5] lavc/encoder: declare caps for encoding with variable dimension

2020-06-11 Thread Linjie Fu
Signed-off-by: Linjie Fu --- Tested following encoders with container muxer(like mp4 muxer for x264, which previously use extradata to store a global header) and raw video muxer, results are good. libavcodec/libopenh264enc.c | 4 +++- libavcodec/libvpxenc.c | 4 +++- libavcodec/libx264.c

[FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

2020-06-11 Thread Linjie Fu
Add recreate_encoder_instance() function. If resolution changing is allowed, discard AV_CODEC_FLAG_GLOBAL_HEADER even if the avformat/container declares AVFMT_GLOBALHEADER flag. Place header information in every keyframe instead of single global header. Signed-off-by: Linjie Fu --- Should be squ

Re: [FFmpeg-devel] [PATCH v11 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Wed, Jun 10, 2020 at 08:13:59PM +0200, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavfilter/vf_showinfo.c | 37 + >>> 1 file changed, 37 insertions(+) >

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-11 Thread Paul B Mahol
On 6/11/20, Michael Niedermayer wrote: > On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: >> On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: >> > NAK >> > >> > please remove this code fully. >> >> Id like to apply this and backport to the releases branches because

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/libopenjpeg: pix fmt selection change

2020-06-11 Thread Gautam Ramakrishnan
On Thu, Jun 11, 2020 at 11:42 AM Michael Bradshaw wrote: > > On Wed, Jun 10, 2020 at 9:35 PM Gautam Ramakrishnan > wrote: > > > The reference file has 4 components, Whereas all the Bayer formats > > have 3 components. Are we missing any Bayer pixel format in ffmpeg? > > Also, any other ideas on w

Re: [FFmpeg-devel] [PATCH v10 1/4] avutil: add AV_FRAME_DATA_SEI_UNREGISTERED side data type

2020-06-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Wed, Jun 10, 2020 at 07:43:11AM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> rebase with master only, I'll apply the patchset in two days if no objection. >> >> doc/APIchanges | 3 +++ >> libavutil/frame.c

Re: [FFmpeg-devel] [PATCH 4/5] lavf/dashdec: improve memory handling

2020-06-11 Thread Andreas Rheinhardt
rcombs: > - Fixes a couple leaks > - Adds an av_freep equivalent for libxml buffers > - Avoids some redundant copying > --- > libavformat/dashdec.c | 44 +++ > 1 file changed, 24 insertions(+), 20 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavf

Re: [FFmpeg-devel] [PATCH v4 24/24] avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros

2020-06-11 Thread lance . lmwang
On Thu, Jun 11, 2020 at 12:53:01PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-11): > > I'll apply the patch set in next two days if no further comments still. > > Please help to > > review if you think it's necessary. > > Please do not include my name in the commit message.

[FFmpeg-devel] [PATCH V2 2/2] vf_dnn_processing.c: add dnn backend openvino

2020-06-11 Thread Guo, Yejun
We can try with the srcnn model from sr filter. 1) get srcnn.pb model file, see filter sr 2) convert srcnn.pb into openvino model with command: python mo_tf.py --input_model srcnn.pb --data_type=FP32 --input_shape [1,960,1440,1] --keep_shape_ops See the script at https://github.com/openvinotoolk

[FFmpeg-devel] [PATCH V2 1/2] dnn: add openvino as one of dnn backend

2020-06-11 Thread Guo, Yejun
OpenVINO is a Deep Learning Deployment Toolkit at https://github.com/openvinotoolkit/openvino, it supports CPU, GPU and heterogeneous plugins to accelerate deep learning inferencing. Please refer to https://github.com/openvinotoolkit/openvino/blob/master/build-instruction.md to build openvino (c

Re: [FFmpeg-devel] [PATCH 3/5] lavc/h264dec: loosen new-extradata check

2020-06-11 Thread James Almer
On 6/11/2020 1:43 AM, rcombs wrote: > --- > libavcodec/h264dec.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 6270ea80df..0d7492cfad 100644 > --- a/libavcodec/h264dec.c > +++ b/libavcodec/h264dec.c > @@

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/sonic: Fix several integer overflows

2020-06-11 Thread Michael Niedermayer
On Sun, May 10, 2020 at 09:20:16PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2129689466 + 2129689466 cannot be represented > in type 'int' > Fixes: > 20715/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5155263109922816 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/sonic: Fix several integer state overflows

2020-06-11 Thread Michael Niedermayer
On Wed, May 20, 2020 at 08:59:20PM +0200, Michael Niedermayer wrote: > On Mon, May 11, 2020 at 01:07:54AM +0200, Paul B Mahol wrote: > > NAK > > > > please remove this code fully. > > Id like to apply this and backport to the releases branches because > sonic is in the releases > are you ok with

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dem_fuzzer: Use file extensions listed in input formats

2020-06-11 Thread Michael Niedermayer
On Mon, Jun 08, 2020 at 12:14:51PM +0200, Michael Niedermayer wrote: > This should make it easier for the fuzzer to fuzz formats being detected only > by > file extension and thus increase coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dem_fuzzer.c | 27 +++

Re: [FFmpeg-devel] [PATCH 2/5] lavc: add avpriv_h264_get_profile

2020-06-11 Thread James Almer
On 6/11/2020 1:43 AM, rcombs wrote: > --- > libavcodec/h264_parse.c | 21 + > libavcodec/h264_parse.h | 2 ++ > libavcodec/version.h| 2 +- > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c > index 352f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextdec: Fix shift overflows in mov_text_init()

2020-06-11 Thread Michael Niedermayer
On Fri, Jun 05, 2020 at 10:41:58PM +0200, Michael Niedermayer wrote: > Fixes: left shift of 243 by 24 places cannot be represented in type 'int' > Fixes: > 22716/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOVTEXT_fuzzer-5704263425851392 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/snowdec: Avoid integer overflow with huge qlog

2020-06-11 Thread Michael Niedermayer
On Sat, Jun 06, 2020 at 06:03:46PM +0200, Michael Niedermayer wrote: > Fixes: integer overflow > Fixes: > 22285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-5682428762128384 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg12dec: remove outdated comments

2020-06-11 Thread Michael Niedermayer
On Sat, Jun 06, 2020 at 08:08:15PM +0200, Michael Niedermayer wrote: > Found-by: Kieran > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg12dec.c | 3 --- > 1 file changed, 3 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nat

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for lagarith

2020-06-11 Thread Michael Niedermayer
On Sun, Jun 07, 2020 at 09:35:44PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (3minute 49 sec -> 3sec) > Fixes: > 22020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-5708544679870464 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/ma

Re: [FFmpeg-devel] [PATCH v4 24/24] avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros

2020-06-11 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-11): > I'll apply the patch set in next two days if no further comments still. > Please help to > review if you think it's necessary. Please do not include my name in the commit message. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH v4 24/24] avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros

2020-06-11 Thread lance . lmwang
On Tue, Jun 02, 2020 at 11:26:58PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Nicolas George comments for the macros: > These functions have a terrible design, let us fix them before extending > them. > First design mistake: no error code. A helper function for testing > memory a

[FFmpeg-devel] [PATCH v12 4/4] avcodec/h264: create user data unregistered SEI side data for H.264

2020-06-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264_sei.c | 19 - libavcodec/h264_sei.h | 2 + libavcodec/h264_slice.c | 14 tests/ref/fate/mov-zombie | 195 ++ 4 files changed, 162 insertions(+), 68 deletions(-) dif

[FFmpeg-devel] [PATCH v12 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 37 + 1 file changed, 37 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 5d4aee4..3658234 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilt

[FFmpeg-devel] [PATCH v12 2/4] avcodec/hevc_sei: add support for user data unregistered SEI message

2020-06-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 33 + libavcodec/hevc_sei.h | 6 ++ libavcodec/hevcdec.c| 14 ++ tests/ref/fate/hevc-monochrome-crop | 3 +++ 4 files changed, 56

[FFmpeg-devel] [PATCH 2/5] lavc: add avpriv_h264_get_profile

2020-06-11 Thread rcombs
--- libavcodec/h264_parse.c | 21 + libavcodec/h264_parse.h | 2 ++ libavcodec/version.h| 2 +- 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index 352ffea948..3069579926 100644 --- a/libavcodec/h264_pars

[FFmpeg-devel] [PATCH 5/5] lavf/dashdec: don't require opening all playlists during read_header

2020-06-11 Thread rcombs
This improves startup performance massively when the consumer doesn't make a call to avformat_find_stream_info(). Also makes the requirement that each rendition only have 1 stream more clear (this is required by DASH), and generally improves error handling. --- libavformat/dashdec.c | 283

[FFmpeg-devel] [PATCH 4/5] lavf/dashdec: improve memory handling

2020-06-11 Thread rcombs
- Fixes a couple leaks - Adds an av_freep equivalent for libxml buffers - Avoids some redundant copying --- libavformat/dashdec.c | 44 +++ 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index c9

[FFmpeg-devel] [PATCH 1/5] lavf/dashdec: fix 'adaption' typo

2020-06-11 Thread rcombs
--- libavformat/dashdec.c | 96 +-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 1bd070c7cb..c94ce2caca 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -148,7 +148,7 @@

[FFmpeg-devel] [PATCH 3/5] lavc/h264dec: loosen new-extradata check

2020-06-11 Thread rcombs
--- libavcodec/h264dec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 6270ea80df..0d7492cfad 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -988,6 +988,8 @@ static int h264_decode_frame(AVCodecC