Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-12 Thread Michael Niedermayer
On Thu, May 14, 2020 at 03:31:51PM -0700, Dale Curtis wrote: > Signed-off-by: Dale Curtis > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequ

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpl2dec: Fix integer overflow with duration

2020-06-12 Thread Michael Niedermayer
On Mon, Jun 08, 2020 at 12:14:49PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be > represented in type 'long' > Fixes: > 23167/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6425051741290496 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/4] avformat/thp: Check fps

2020-06-12 Thread Michael Niedermayer
On Mon, Jun 08, 2020 at 12:14:48PM +0200, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: > 23162/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4856420817436672 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/loco: Fix signed integer overflow in loco_get_rice()

2020-06-12 Thread Michael Niedermayer
On Tue, Jun 09, 2020 at 10:55:05PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 22975/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5658160970072064 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-12 Thread Gavin Smith
On 12/06/2020 16:58, Gavin Smith wrote: On 12/06/2020 12:59, Timo Rothenpieler wrote: On 12.06.2020 00:31, Gavin Smith wrote: On 11/06/2020 22:03, Timo Rothenpieler wrote: On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724. The filter did not preserve alpha transpa

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check block_align maximum

2020-06-12 Thread Michael Niedermayer
On Tue, Jun 09, 2020 at 10:55:04PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 22737/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-595839681920 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: use av_fast_realloc() in cbs_insert_unit()

2020-06-12 Thread Michael Niedermayer
On Sat, May 02, 2020 at 01:45:43PM -0300, James Almer wrote: > On 5/2/2020 1:39 PM, Michael Niedermayer wrote: > > On Sat, Apr 11, 2020 at 11:01:41AM -0300, James Almer wrote: > >> Fixes: Timeout > >> Fixes: > >> 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-56595377199513

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread James Almer
On 6/12/2020 7:05 AM, Anton Khirnov wrote: > Quoting James Almer (2020-06-10 14:46:21) >> On 6/10/2020 6:19 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-06-09 14:45:33) On 6/9/2020 6:06 AM, Anton Khirnov wrote: > I don't think this needs to be visible externally, since it's only

[FFmpeg-devel] [PATCH] avformat/sccdec: split line with multiple subs

2020-06-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/sccdec.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c index b9042b39ac..bf0e6c2688 100644 --- a/libavformat/sccdec.c +++ b/libavformat/sccdec.c @@ -8

Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel format x2rgb10

2020-06-12 Thread Lynne
Jun 11, 2020, 17:26 by d...@lynne.ee: > Jun 2, 2020, 08:30 by fei.w.w...@intel.com: > >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of Wang, >>> Fei W >>> Sent: Friday, May 15, 2020 2:58 PM >>> To: FFmpeg development discussions and patches >>> Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-12 Thread Gavin Smith
On 12/06/2020 12:59, Timo Rothenpieler wrote: On 12.06.2020 00:31, Gavin Smith wrote: On 11/06/2020 22:03, Timo Rothenpieler wrote: On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724. The filter did not preserve alpha transparency. Items that were transparent in the

Re: [FFmpeg-devel] [PATCH v3] lavdevice: Add AudioToolbox output device.

2020-06-12 Thread Thilo Borgmann
Am 08.06.20 um 21:45 schrieb Thilo Borgmann: > $subject, v3. If there are no more comments I'll push this next week. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit lin

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/libopenjpeg: pix fmt selection change

2020-06-12 Thread Gautam Ramakrishnan
On Thu, Jun 11, 2020 at 9:41 PM Michael Bradshaw wrote: > > On Thu, Jun 11, 2020 at 9:42 AM Gautam Ramakrishnan > wrote: > > > Got it. In that case we can safely ignore the patch to fix libopenjpeg. > > However, p1_03.j2k is one of the 2 files to have ppm marker. How could I > > validate a patch

[FFmpeg-devel] [PATCH 2/2] avfilter: add D2TS, TS2D, TS2T as a common macro in internal.h

2020-06-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/aeval.c | 2 -- libavfilter/af_volume.c | 4 libavfilter/f_select.c| 3 --- libavfilter/f_sendcmd.c | 3 --- libavfilter/internal.h| 4 libavfilter/setpts.c | 4 libavfilter/vf_delogo.c | 1 - lib

[FFmpeg-devel] [PATCH 1/2] avformat/dvenc: return error code of dv_assemble_frame()

2020-06-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dvenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index c71e532..b04d604 100644 --- a/libavformat/dvenc.c +++ b/libavformat/dvenc.c @@ -406,9 +406,10 @@ static int

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-06-12 Thread Paul B Mahol
On 6/12/20, Paul B Mahol wrote: > On 6/12/20, Nicolas George wrote: >> Paul B Mahol (12020-06-12): >>> This is needed also by showspectrumpic filter and it needs random number >>> of >>> samples to skip and peek. >> >> I looked at the code for showspectrumpic before making my comment: the >> seco

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: The chromakey filter preserves non-opaque alpha transparency.

2020-06-12 Thread Timo Rothenpieler
On 12.06.2020 00:31, Gavin Smith wrote: On 11/06/2020 22:03, Timo Rothenpieler wrote: On 11.06.2020 22:27, Gavin Smith wrote: This is to address trac ticket #8724.  The filter did not preserve alpha transparency. Items that were transparent in the input would appear black on the output or pix

[FFmpeg-devel] [PATCH v3 7/7] avcodec/adpcmenc: cleanup trellis checks

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index d2d90b9176..38cd8add3e 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmen

[FFmpeg-devel] [PATCH v3 6/7] fate: add adpcm_ima_apm encoding test

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-ima_apm | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-ima_apm diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index bb6bfe5ada..197b6ed7c0 100644 --

[FFmpeg-devel] [PATCH v3 5/7] avformat: add apm muxer

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apm.c| 110 ++- libavformat/version.h| 2 +- 5 files changed, 112 insertions(+), 3 deletions(-) d

[FFmpeg-devel] [PATCH v3 1/7] avformat/apm: check codec tag in probe and add constant

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/apm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/apm.c b/libavformat/apm.c index 9d2a856cc4..dc59c16562 100644 --- a/libavformat/apm.c +++ b/libavformat/apm.c @@ -29,6 +29,7 @@ #define APM_VS12_CHUNK_SIZE

[FFmpeg-devel] [PATCH v3 2/7] avcodec/adpcm_ima_apm: support new extradata format

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 79c5d625d1..4de4a23289 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -162,11 +162,18 @@ static a

[FFmpeg-devel] [PATCH v3 4/7] avformat/apm: use new extradata format

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/Makefile | 2 +- libavformat/apm.c| 130 +++ 2 files changed, 70 insertions(+), 62 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 0658fa3710..bb09dc6563 100644 --- a/libavfor

[FFmpeg-devel] [PATCH v3 3/7] avcodec: add adpcm_ima_apm encoder

2020-06-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 34 -- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 6 files changed, 37 insertions(+), 4 dele

[FFmpeg-devel] [PATCH v3 0/7] adpcm_ima_apm encoder + apm muxer

2020-06-12 Thread Zane van Iperen
Add support for encoding adpcm_ima_apm and muxing to apm. If possible, I would like to get this functionality into the 4.3 release. v3: [4][5][6] * Support both extradata formats - fixes FATE failure + preserves compatibility * EINVAL->ERANGE v2: [1][2][3] * fix mixed declarations and code * r

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread Kieran Kunhya
> > It still seems to me that this is a solution in search of a problem. If > I understand you correctly, the case you have in mind is a codec where > there is an internal implementation that only supports intra frames > and an external implementation that also supports inter frames. > But that see

Re: [FFmpeg-devel] [PATCH 1/3] lavc/avcodec: Add caps for the support of variable dimension encoding

2020-06-12 Thread Anton Khirnov
Quoting Nicolas George (2020-06-09 11:48:19) > Anton Khirnov (12020-06-08): > > During the last iteration, I asked how is this preferable to just making > > a new encoder instance. Don't think I got a sufficient reply. > > How do we know that we can just put the packets of the new instance > after

Re: [FFmpeg-devel] [PATCH] codec_desc: mark CFHD as intra-only

2020-06-12 Thread Anton Khirnov
Quoting James Almer (2020-06-10 14:46:21) > On 6/10/2020 6:19 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-06-09 14:45:33) > >> On 6/9/2020 6:06 AM, Anton Khirnov wrote: > >>> I don't think this needs to be visible externally, since it's only > >>> meaningful for internal use. I'm wonderi