Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread hydra3333
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Wednesday, July 1, 2020 1:34 PM > To: Roman Arzumanyan ; FFmpeg development discussions > and patches > Cc: Yogender Gupta > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 > features suppor

Re: [FFmpeg-devel] [PATCH v2] avdevice/xcbgrab: Add select_region option.

2020-06-30 Thread Andriy Gelman
Hi Omar, Thanks for your patch. nit: please remove "." at the end of the commit title On Sun, 28. Jun 13:26, Omar Emara wrote: > This patch adds a select_region option to the xcbgrab input device. > If set to 1, the user will be prompted to select the grabbing area > graphically by clicking and

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Soft Works
> From: Roman Arzumanyan > Sent: Tuesday, June 30, 2020 10:23 PM > To: Soft Works ; FFmpeg development discussions and > patches > Cc: Yogender Gupta > Subject: RE: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 > features support > > Hello, nice to meet you. > > >Wouldn't it make

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread hydra3333
> Hello, > > This patch adds Video Codec SDK 10 features support: > > * Presets and tuning info > * Multipass encode modes > * Low Delay Key Frame Scale Hello and thank you for this patch. Possibly this post belongs in ffmepg-user. Per the above archive post above ( http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Allow unknown format private AVOptions

2020-06-30 Thread Marton Balint
On Sun, 28 Jun 2020, Derek Buitenhuis wrote: This useful, because by ffprobe's very nature, you use it to probe a file and find out what it is. Requiring every format private option to be known to the demuxer forces one to run ffprobe twice, if one wants to use ffprobe in a generic way. For e

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2020-06-30 Thread Michael Niedermayer
On Tue, Jun 30, 2020 at 12:06:10PM +, Chip Kerchner wrote: > yuv2rgb_altivec.c | 10 ++ > 1 file changed, 10 insertions(+) > 42288c448d2dadce913a969945ee36afc510d200 ffmpeg_altivec_yuv2rgb_novsx.patch > diff --git a/libswscale/ppc/yuv2rgb_altivec.c > b/libswscale/ppc/yuv2rgb_altive

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-30 Thread Michael Niedermayer
On Tue, Jun 30, 2020 at 08:31:39AM +0530, Gautam Ramakrishnan wrote: > On Tue, Jun 30, 2020 at 5:49 AM Michael Niedermayer > wrote: [...] > > > > > > > +if (temp > INT_MAX) > > > +return -1; > > > +ret = temp; > > > +} > > > + > > > +if (ret >= 0) > > > +

[FFmpeg-devel] [PATCH 4/4] avcodec/mpc: Fix multiple numerical overflows in ff_mpc_dequantize_and_synth()

2020-06-30 Thread Michael Niedermayer
Fixes: -2.4187e+09 is outside the range of representable values of type 'int' Fixes: signed integer overflow: -14512205 + -2147483648 cannot be represented in type 'int' Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPC7_fuzzer-5747263166480384 Fixes: 23528/clusterfuzz-testcase-

[FFmpeg-devel] [PATCH 3/4] avcodec/apedec: Fix undefined integer overflow with 24bit

2020-06-30 Thread Michael Niedermayer
Fixes: signed integer overflow: 8683744 * 256 cannot be represented in type 'int' Fixes: 23527/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5679885932822528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/4] avcodec/hcadec: Check total_band_count against imdct_in size

2020-06-30 Thread Michael Niedermayer
Fixes: index 128 out of bounds for type 'float [128]' Fixes: 23465/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-5089866596745216 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec

[FFmpeg-devel] [PATCH 1/4] avcodec/loco: Fix integer overflow with large values from loco_get_rice()

2020-06-30 Thread Michael Niedermayer
Fixes: signed integer overflow: 155 + 2147483647 cannot be represented in type 'int' Fixes: 23421/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5652849097965568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Roman Arzumanyan
Hello, nice to meet you. >Wouldn't it make sense to transition from compile time version checks to >runtime checking? Video Codec SDK headers are not included into ffmpeg 'as is' but using the nvcodec-headers project instead. This is community-driven project which aims to work around the licensi

[FFmpeg-devel] [PATCH v3] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

2020-06-30 Thread Wang Cao
From: Wang Cao Signed-off-by: Wang Cao --- doc/encoders.texi | 36 + libavcodec/libaomenc.c | 46 ++ libavcodec/version.h | 2 +- 3 files changed, 83 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/do

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-30 Thread Kyle Swanson
On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos wrote: > No objections. Thanks. I will merge in 24 hours or so, when the next libvmaf minor release is cut. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 09/12] avformat/hevc: Defer initializations in ff_isom_write_hvcc()

2020-06-30 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Saves initialization of an HEVCDecoderConfigurationRecord when > the data is already in ISOBMFF-format or if it is plainly invalid. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hevc.c | 18 -- > 1 file changed, 8 insertions(+), 10 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Timo Rothenpieler
On 30.06.2020 16:08, Roman Arzumanyan wrote: Hello, This patch adds Video Codec SDK 10 features support: * Presets and tuning info * Multipass encode modes * Low Delay Key Frame Scale How does one get the new multipass option to work? With the new preset, I get: InitializeEn

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

2020-06-30 Thread Yatendra Singh
> > > +s->difford = 1; > > Why are you forcing this value? > The algorithm only uses first order differentials for the calculation of the specular variant and it does not seem to be an option to use other orders as far as I have understood from the paper and the official code. > > If you are s

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/isom: add comment to mov_mdhd_language_map

2020-06-30 Thread Zhao Zhili
Ping for review, thanks! > On Jun 27, 2020, at 10:26 PM, Zhao Zhili wrote: > > --- > The following code is used to do the reformat: > https://gist.github.com/quink-black/8643d8fab8b3f49ff6ace6916111d2c4 > > libavformat/isom.c | 158 +++-- > 1 file changed,

Re: [FFmpeg-devel] [PATCH v5 2/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

2020-06-30 Thread lance . lmwang
On Tue, Jun 30, 2020 at 05:39:12PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/APIchanges| 3 +++ > > libavcodec/avpacket.c | 1 + > > libavcodec/decode.c | 1 + > > libavcodec/packet.h | 8 +++

Re: [FFmpeg-devel] [PATCH v5 2/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

2020-06-30 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/APIchanges| 3 +++ > libavcodec/avpacket.c | 1 + > libavcodec/decode.c | 1 + > libavcodec/packet.h | 8 > libavcodec/version.h | 2 +- > libavformat/dump.c| 21 +

[FFmpeg-devel] [PATCH v5 2/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

2020-06-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/APIchanges| 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 8 libavcodec/version.h | 2 +- libavformat/dump.c| 21 + 6 files changed, 35 insertions(+), 1 d

[FFmpeg-devel] [PATCH v5 1/2] avutil/timecode: add description for SMPTE binary format

2020-06-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/frame.h| 4 ++-- libavutil/timecode.h | 12 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 3fb8c56..c694b12 100644 --- a/libavutil/frame.h +++ b/libavutil/fram

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Allow unknown format private AVOptions

2020-06-30 Thread Derek Buitenhuis
On 28/06/2020 21:58, Derek Buitenhuis wrote: > This useful, because by ffprobe's very nature, you use it to probe > a file and find out what it is. Requiring every format private option > to be known to the demuxer forces one to run ffprobe twice, if one > wants to use ffprobe in a generic way. >

Re: [FFmpeg-devel] [PATCH]libavfilter/asrc_atone.c : generate algorithmic music

2020-06-30 Thread Ashutosh Pradhan
On Tue, Jun 30, 2020 at 8:40 PM Thilo Borgmann wrote: > Am 30.06.20 um 16:09 schrieb Ashutosh Pradhan: > > On Mon, Jun 29, 2020 at 6:53 PM Moritz Barsnick > wrote: > > > >> On Thu, Jun 25, 2020 at 21:15:06 +0530, Ashutosh Pradhan wrote: > >>> Generate algorithmic riff music. Changed to activate

Re: [FFmpeg-devel] [PATCH]libavfilter/asrc_atone.c : generate algorithmic music

2020-06-30 Thread Thilo Borgmann
Am 30.06.20 um 16:09 schrieb Ashutosh Pradhan: > On Mon, Jun 29, 2020 at 6:53 PM Moritz Barsnick wrote: > >> On Thu, Jun 25, 2020 at 21:15:06 +0530, Ashutosh Pradhan wrote: >>> Generate algorithmic riff music. Changed to activate api. >> >> This commit doesn't change to activate API, as it introd

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dump: Use intermediate pointer for access to programs array

2020-06-30 Thread lance . lmwang
On Tue, Jun 30, 2020 at 03:09:09PM +0200, Andreas Rheinhardt wrote: > Improves readability. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/dump.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 3

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dump: Use const where appropriate

2020-06-30 Thread lance . lmwang
On Tue, Jun 30, 2020 at 03:09:08PM +0200, Andreas Rheinhardt wrote: > Also switch to using a pointer to access stream side data instead of > copying the stream's AVPacketSideData. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/dump.c | 91 --

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Roman Arzumanyan > Sent: Tuesday, June 30, 2020 4:08 PM > To: ffmpeg-devel@ffmpeg.org; timo > Cc: Yogender Gupta > Subject: [FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 > features support > > Hello, > > This patch ad

Re: [FFmpeg-devel] [PATCH v4 2/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

2020-06-30 Thread lance . lmwang
On Tue, Jun 30, 2020 at 04:10:41PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/APIchanges| 3 +++ > > libavcodec/avpacket.c | 1 + > > libavcodec/decode.c | 1 + > > libavcodec/packet.h | 8 +++

Re: [FFmpeg-devel] [PATCH]libavfilter/asrc_atone.c : generate algorithmic music

2020-06-30 Thread Nicolas George
Ashutosh Pradhan (12020-06-30): > Yes. > Windows doesn't have the recommended Fluid_R3 General Midi SoundFont file. > So one has to enter the path every time. Neither doses Linux. It may be installed on the system, but not necessarily at this path. A better solution needs to be found. The library

[FFmpeg-devel] [PATCH v6 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-30 Thread gautamramk
From: Gautam Ramakrishnan This patch adds a pgx decoder. --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/pgxdec.c | 199 ++

Re: [FFmpeg-devel] [PATCH]libavfilter/asrc_atone.c : generate algorithmic music

2020-06-30 Thread Ashutosh Pradhan
On Mon, Jun 29, 2020 at 6:53 PM Moritz Barsnick wrote: > On Thu, Jun 25, 2020 at 21:15:06 +0530, Ashutosh Pradhan wrote: > > Generate algorithmic riff music. Changed to activate api. > > This commit doesn't change to activate API, as it introduces this > filter. So that sentence doesn't belong he

Re: [FFmpeg-devel] [PATCH v4 2/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

2020-06-30 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/APIchanges| 3 +++ > libavcodec/avpacket.c | 1 + > libavcodec/decode.c | 1 + > libavcodec/packet.h | 8 > libavcodec/version.h | 2 +- > libavformat/dump.c| 21 +

[FFmpeg-devel] [PATCH] avcodec/nvenc: Video Codec SDK 10 features support

2020-06-30 Thread Roman Arzumanyan
Hello, This patch adds Video Codec SDK 10 features support: * Presets and tuning info * Multipass encode modes * Low Delay Key Frame Scale 0001-Adding-SDK10-features-support.patch Description: 0001-Adding-SDK10-features-support.patch ___ f

Re: [FFmpeg-devel] [PATCH v4 1/2] avutil/timecode: add description for SMPTE binary format

2020-06-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-30): > Below is my update by your suggestion, please help to review. Fine by me. But it was only about form. I do not know timecodes at all, so the semantic of the doc is beyond my skills. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v4 1/2] avutil/timecode: add description for SMPTE binary format

2020-06-30 Thread lance . lmwang
On Tue, Jun 30, 2020 at 12:28:34PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-30): > > From: Limin Wang > > > > AV_FRAME_DATA_S12M_TIMECODE is public API, so user need to know its format > > by the API header instead of reading the code. > > > > Signed-off-by: Limin Wang >

[FFmpeg-devel] [PATCH v6 2/2] libavformat/img2dec: Added pgx demuxer

2020-06-30 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support to demux pgx file format. --- libavformat/allformats.c | 1 + libavformat/img2dec.c| 9 + libavformat/version.h| 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformat

[FFmpeg-devel] [PATCH 1/2] avformat/dump: Use const where appropriate

2020-06-30 Thread Andreas Rheinhardt
Also switch to using a pointer to access stream side data instead of copying the stream's AVPacketSideData. Signed-off-by: Andreas Rheinhardt --- libavformat/dump.c | 91 -- 1 file changed, 48 insertions(+), 43 deletions(-) diff --git a/libavformat/du

[FFmpeg-devel] [PATCH 2/2] avformat/dump: Use intermediate pointer for access to programs array

2020-06-30 Thread Andreas Rheinhardt
Improves readability. Signed-off-by: Andreas Rheinhardt --- libavformat/dump.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 3c76edfee4..1083d7db37 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -679

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000.c: Precinct size check removed

2020-06-30 Thread Michael Niedermayer
On Mon, Jun 29, 2020 at 11:29:06PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch removes a check which throws an error if > the log2 precinct width/height is 0. The standard allows > the first component to have 0 as the log2 width/height. > However, to ensure prope

[FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2020-06-30 Thread Chip Kerchner
ffmpeg_altivec_yuv2rgb_novsx.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmalosslessdec: fix overflow with pred in revert_cdlms

2020-06-30 Thread Michael Niedermayer
On Sun, Jun 28, 2020 at 01:46:52AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2048 + 2147483646 cannot be represented in > type 'int' > Fixes: > 23538/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5227567073460224 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 2/2] avutil/common: Fix integer overflow in av_ceil_log2_c()

2020-06-30 Thread Michael Niedermayer
On Sun, Jun 28, 2020 at 01:46:53AM +0200, Michael Niedermayer wrote: > Fixes: left shift of 1913647649 by 1 places cannot be represented in type > 'int' > Fixes: > 23572/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5082619795734528 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH v4 1/2] avutil/timecode: add description for SMPTE binary format

2020-06-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-30): > From: Limin Wang > > AV_FRAME_DATA_S12M_TIMECODE is public API, so user need to know its format > by the API header instead of reading the code. > > Signed-off-by: Limin Wang > --- > libavutil/frame.h| 4 ++-- > libavutil/timecode.h | 16 +++

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-30 Thread Steinar H. Gunderson
On Tue, Jun 30, 2020 at 12:00:24PM +0200, Paul B Mahol wrote: > So we should suffer instead by applying this patch? The thousands of projects that include FFmpeg from C++, directly or indirectly, suggests that the amount of suffering on FFmpeg's part by supporting inclusion from C++ is not going t

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-30 Thread Paul B Mahol
On 6/30/20, Tomas Härdin wrote: > lör 2020-06-27 klockan 11:51 +0200 skrev Carl Eugen Hoyos: >> Am Sa., 27. Juni 2020 um 11:47 Uhr schrieb Tomas Härdin >> : >> > fre 2020-06-26 klockan 11:36 +0200 skrev Hendrik Leppkes: >> > > On Fri, Jun 26, 2020 at 11:31 AM Tomas Härdin >> > > wrote: >> > > > o

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-30 Thread Tomas Härdin
lör 2020-06-27 klockan 11:51 +0200 skrev Carl Eugen Hoyos: > Am Sa., 27. Juni 2020 um 11:47 Uhr schrieb Tomas Härdin : > > fre 2020-06-26 klockan 11:36 +0200 skrev Hendrik Leppkes: > > > On Fri, Jun 26, 2020 at 11:31 AM Tomas Härdin wrote: > > > > ons 2020-06-24 klockan 21:22 +0200 skrev Carl Euge

Re: [FFmpeg-devel] [PATCH v1 1/9] lavu/pix_fmt: add P012 pixel format

2020-06-30 Thread Xiang, Haihao
Agree with Mark. P012 and P016 have different significant bits, we should use different pixfmts, otherwise an extra field in AVFrame is needed for bit depth. BTW there are the YUV420P variants for 10 / 12 / 14 / 16 bit in FFmpeg, it would be better to follow FFmpeg's style to introduce P012 form