Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread lance . lmwang
On Sat, Jul 18, 2020 at 08:38:16PM +0200, Marton Balint wrote: > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: > > > > > > > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Fri, Jul 17, 2020

[FFmpeg-devel] [PATCH] avformat/hlsenc: increase initial program date time precision

2020-07-18 Thread Marton Balint
Also query time only once, not for every variant stream, otherwise variant streams might get a slightly different initial program date time. And we can set this unconditionally because HLS_PROGRAM_DATE_TIME flag is checked elsewhere. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 8

[FFmpeg-devel] [PATCH 1/2] avcodec/diracdsp: Fix integer anomaly in dequant_subband_*

2020-07-18 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself Fixes: 23760/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-604209011412172 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Adjust VQA threshold

2020-07-18 Thread Michael Niedermayer
Fixes: Timeout (169sec -> 9sec) Fixes: 23745/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQA_fuzzer-5638172179693568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH] fftools/ffmpeg: make specifying thread_queue_size turn on threaded input

2020-07-18 Thread Marton Balint
Threaded input can increase smoothness of e.g. x11grab significantly. Before this patch, in order to activate threaded input the user had to specify a "dummy" additional input, with this change it is no longer required. Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 5 +++--

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/libopenjpeg: pix fmt selection change

2020-07-18 Thread Carl Eugen Hoyos
Am Di., 9. Juni 2020 um 20:25 Uhr schrieb Carl Eugen Hoyos : > > Am Di., 9. Juni 2020 um 19:12 Uhr schrieb Gautam Ramakrishnan > : > > > > On Tue, Jun 9, 2020 at 10:24 PM Carl Eugen Hoyos wrote: > > > > > > Am Di., 9. Juni 2020 um 14:07 Uhr schrieb : > > > > > > > > From: Gautam Ramakrishnan > >

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread Marton Balint
On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: > > > > > > On Fri, 17 Jul 2020, lance.lmw...@gmail.com

Re: [FFmpeg-devel] [PATCH] avformat/hls: add supporting EXT-X-DISCONTINUITY tag

2020-07-18 Thread Aleksey Skripka
Greetings! unconditional AVFMT_TS_DISCONT also helps to survive when pts rollover in mpegts occurs. seems like this patch will break again reading long-lasting hls. -- Aleksey Skripka > On 17 Jul 2020, at 04:09, Dongwon Kim wrote: > > I modified setting AVFMT_TS_DISCONT flag on HLS input

[FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 46 libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_rblur.c | 560 +++ 4 files changed, 610 insertions(+) create mode 100644 libavfilter/vf_rblur.c diff

[FFmpeg-devel] [PATCH v6 2/6] libavutils: Add parse_r helper for MIPS

2020-07-18 Thread Jiaxun Yang
That helper grab from kernel code can allow us to inline newer instructions (not implemented by the assembler) in a elegant manner. Signed-off-by: Jiaxun Yang --- libavutil/mips/asmdefs.h | 42 1 file changed, 42 insertions(+) diff --git

[FFmpeg-devel] [PATCH v6 5/6] libavcodec: MIPS: MMI: Fix type mismatches

2020-07-18 Thread Jiaxun Yang
GCC complains about them. Signed-off-by: Jiaxun Yang --- libavcodec/mips/h264dsp_mips.h | 18 +- libavcodec/mips/h264dsp_mmi.c | 18 +- libavcodec/mips/xvid_idct_mmi.c | 4 ++-- libavcodec/mips/xvididct_mips.h | 4 ++-- 4 files changed, 22 insertions(+), 22

[FFmpeg-devel] [PATCH v6 6/6] libavcodec: MIPS: MMI: Move sp out of the clobber list

2020-07-18 Thread Jiaxun Yang
GCC complains: warning: listing the stack pointer register ‘$29’ in a clobber list is deprecated [-Wdeprecated] Actually stack pointer was restored at the end of the inline assembly so there is no reason to add it to the clobber list. Also use $sp insted of $29 to make our intention much more

[FFmpeg-devel] [PATCH v6 3/6] libavutil: Detect MMI and MSA flags for MIPS

2020-07-18 Thread Jiaxun Yang
Add MMI & MSA runtime detection for MIPS. Basically there are two code pathes. For systems that natively support CPUCFG instruction or kernel emulated that instruction, we'll sense this feature from HWCAP and report the flags according to values grab from CPUCFG. For systems that have no CPUCFG

[FFmpeg-devel] [PATCH v6 0/6] MIPS MSA & MMI Runtime detection support

2020-07-18 Thread Jiaxun Yang
This series adds MIPS MSA & MMI runtime detection support Please review. Thanks! v2: - Add CPUCFG support. - Add "-mloongson-ext" to MMIFLAGS for Loongson-3 as well. (Loongson2F don't need this flag) v3: - Address reveiew suggestions from Shiyou Yin and Weixi Gu. v4: - Disable DSP

[FFmpeg-devel] [PATCH v6 1/6] ffbuild: Refine MIPS handling

2020-07-18 Thread Jiaxun Yang
To enable runtime detection for MIPS, we need to refine ffbuild part to support buildding these feature together. Firstly, we fixed configure, let it probe native ability of toolchain to decide wether a feature can to be enabled, also clearly marked the conflictions between loongson2 & loongson3

Re: [FFmpeg-devel] [PATCH 1/3] doc/http: Update HTTP protocol options

2020-07-18 Thread Gyan Doshi
On 18-07-2020 05:26 pm, Jun Zhao wrote: From: Jun Zhao remove the timeout option docs part for HTTP protocol and add auth_type option part. Signed-off-by: Jun Zhao --- doc/protocols.texi | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 04:59:21PM +0200, Paul B Mahol wrote: >>> Is it good that it's slow? Or do you mean that the algorithm isn't >>> actually >>> slow? >> It is pretty fast here. > > Could you quantify what you mean by “pretty fast”? (Is it fast also

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 04:59:21PM +0200, Paul B Mahol wrote: >> Is it good that it's slow? Or do you mean that the algorithm isn't actually >> slow? > It is pretty fast here. Could you quantify what you mean by “pretty fast”? (Is it fast also measured in CPU time, or only if you have a bunch of

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 01:31:49PM +0200, Paul B Mahol wrote: >>> In short, this patch has: >>> >>> - An unusually slow algorithm (sin, cos, atan, division; all per-pixel). >> This is actually good. > > Is it good that it's slow? Or do you mean that the

[FFmpeg-devel] [PATCH v3 2/2] avcodec/put_bits: Make bit buffers 64-bit

2020-07-18 Thread Steinar H. Gunderson
Change BitBuf into uint64_t on 64-bit x86. This means we need to flush the buffer less often, which is a significant speed win. All other platforms, including all 32-bit ones, are unchanged. Output bitstream is the same. All API constraints are kept in place, e.g., you still cannot put_bits()

[FFmpeg-devel] [PATCH v3 1/2] avcodec/put_bits: Parametrize bit buffer type

2020-07-18 Thread Steinar H. Gunderson
Preparatory patch for making the bit buffer different size on different platforms; make a typedef and make all the hardcoded sizes into expressions deriving from this size. No functional change; generated assembler is near-identical. --- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/put_bits.h

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/put_bits: Parametrize bit buffer type

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 01:34:55PM +0200, Michael Niedermayer wrote: > this from libavcodec/mpegvideo_enc.c > set_put_bits_buffer_size(>pb, > FFMIN(s->thread_context[i]->pb.buf_end - s->pb.buf, INT_MAX/8-32)); > needs to be updated too OK. Including in v3, sending shortly. /*

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/put_bits: Make bit buffers 64-bit

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 01:53:36PM +0200, Carl Eugen Hoyos wrote: >> +#if ARCH_AARCH64 || ARCH_IA64 || ARCH_MIPS64 || ARCH_SPARC64 || ARCH_X86_64 > I suggest to only do this for the platforms that you actually tested. OK. If so, that's x86-64 only. /* Steinar */ -- Homepage:

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 01:31:49PM +0200, Paul B Mahol wrote: >> In short, this patch has: >> >> - An unusually slow algorithm (sin, cos, atan, division; all per-pixel). > This is actually good. Is it good that it's slow? Or do you mean that the algorithm isn't actually slow? > Performance is

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread lance . lmwang
On Sat, Jul 18, 2020 at 09:44:03AM +0200, Marton Balint wrote: > > > On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: > > > > > > > > > On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang >

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-07-18 Thread myp...@gmail.com
On Thu, Jul 16, 2020 at 9:35 AM myp...@gmail.com wrote: > > On Tue, Jul 14, 2020 at 9:47 PM Moritz Barsnick wrote: > > > > On Sun, Jul 12, 2020 at 22:44:46 +0800, myp...@gmail.com wrote: > > > Maybe I give an inaccurate description in the commit message, in fact, > > > libsrt 1.4.1 remove the

[FFmpeg-devel] [PATCH v2 3/3] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-18 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for PPM marker for JPEG2000 decoder. It allows the samples p1_03.j2k and p1_05.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 111 +++ 1 file changed, 101 insertions(+), 10 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 1/3] libavcodec/jpeg2000dec: Fix codeblock decode check

2020-07-18 Thread gautamramk
From: Gautam Ramakrishnan The codeblock decoder checks whether the mqc decoder has decoded the right number of bytes. However, this check does not account for the fact that the mqc encoder's flush routine adds 2 bytes of data which does not have to be read by the decoder. The check is modified

[FFmpeg-devel] [PATCH v2 2/3] libavcodec/jpeg2000dec: Support for Parameterless Markers

2020-07-18 Thread gautamramk
From: Gautam Ramakrishnan The JPEG2000 standard reserves marker values 0xFF30 to 0xFF3F to be used as parameterless markers. This patch adds support to decode codestream with such markers. This allows decoding of p0_02.j2k. --- libavcodec/jpeg2000dec.c | 3 ++- 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH 3/3] lavf/dashdec: enable custom interrup callback in sub-demuxer

2020-07-18 Thread Jun Zhao
From: Jun Zhao Enable the custom callback in sub-demuxer Signed-off-by: Jun Zhao --- libavformat/dashdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 694782c..c5a5ff6 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@

[FFmpeg-devel] [PATCH 1/2] libavcodec/jpeg2000dec: Fix codeblock decode check

2020-07-18 Thread gautamramk
From: Gautam Ramakrishnan The codeblock decoder checks whether the mqc decoder has decoded the right number of bytes. However, this check does not account for the fact that the mqc encoder's flush routine adds 2 bytes of data which does not have to be read by the decoder. The check is modified

[FFmpeg-devel] [PATCH 1/3] doc/http: Update HTTP protocol options

2020-07-18 Thread Jun Zhao
From: Jun Zhao remove the timeout option docs part for HTTP protocol and add auth_type option part. Signed-off-by: Jun Zhao --- doc/protocols.texi | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index

[FFmpeg-devel] [PATCH 2/3] lavf/hls: enable custom interrup callback in sub-demuxer

2020-07-18 Thread Jun Zhao
From: Jun Zhao Enable the custom callback in sub-demuxer Signed-off-by: Jun Zhao --- libavformat/hls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index ba17c4e..cf0b71d 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1984,6 +1984,7 @@

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/put_bits: Make bit buffers 64-bit

2020-07-18 Thread Carl Eugen Hoyos
Am Fr., 17. Juli 2020 um 21:41 Uhr schrieb Steinar H. Gunderson : > +#if ARCH_AARCH64 || ARCH_IA64 || ARCH_MIPS64 || ARCH_SPARC64 || ARCH_X86_64 I suggest to only do this for the platforms that you actually tested. > +typedef uint64_t BitBuf; > +#define AV_WBBUF AV_WB64 > +#define AV_WLBUF

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/put_bits: Parametrize bit buffer type

2020-07-18 Thread Michael Niedermayer
On Fri, Jul 17, 2020 at 09:41:19PM +0200, Steinar H. Gunderson wrote: > Preparatory patch for making the bit buffer different size on different > platforms; make a typedef and make all the hardcoded sizes into expressions > deriving from this size. > > No functional change; generated assembler is

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 12:53:18PM +0200, Paul B Mahol wrote: >> Nope, algorithm is just fine. You are interpreting results wrongly. > > If you are not willing to tell me what is wrong with my interpretation > (outside “you are using the wrong parameters,

[FFmpeg-devel] [PATCH 2/2] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-18 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for PPM marker for JPEG2000 decoder. It allows the samples p1_03.j2k and p1_05.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 111 +++ 1 file changed, 101 insertions(+), 10 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/put_bits: Make bit buffers 64-bit

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 11:53:44AM +0200, Michael Niedermayer wrote: >> +#if ARCH_AARCH64 || ARCH_IA64 || ARCH_MIPS64 || ARCH_SPARC64 || ARCH_X86_64 > this needs a #include "config.h" or something equivalent Sounds right, will fix. /* Steinar */ -- Homepage: https://www.sesse.net/

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 12:53:18PM +0200, Paul B Mahol wrote: > Nope, algorithm is just fine. You are interpreting results wrongly. If you are not willing to tell me what is wrong with my interpretation (outside “you are using the wrong parameters, and I won't tell you what the right parameters

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 11:06:17AM +0200, Paul B Mahol wrote: > The above picture pretty clearly shows otherwise...? Could you tell me > where my confusion would lie? The filter option amount/angle set is very small. >>> It's the default

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 11:06:17AM +0200, Paul B Mahol wrote: The above picture pretty clearly shows otherwise...? Could you tell me where my confusion would lie? >>> The filter option amount/angle set is very small. >> It's the default value. Could you recommend a command line? > Unless

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/put_bits: Make bit buffers 64-bit

2020-07-18 Thread Michael Niedermayer
On Fri, Jul 17, 2020 at 09:41:20PM +0200, Steinar H. Gunderson wrote: > Change BitBuf into uint64_t on all supported 64-bit platforms. > This means we need to flush the buffer less often, which is a > significant speed win. 32-bit platforms are unchanged. > Output bitstream is the same. > > All

Re: [FFmpeg-devel] [PATCH v6 0/7] Add support for encoding adpcm_ima_apm and muxing to apm.

2020-07-18 Thread Zane van Iperen
On Wed, 08 Jul 2020 12:54:46 + "Zane van Iperen" wrote: > > v6: [8] > * split out header and extradata fixes > * add more-descriptive commit messages > * fix bit_rate overflow > Will rebase and push in the next few days if no objections. ___

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 10:28:21AM +0200, Paul B Mahol wrote: >>> The above picture pretty clearly shows otherwise...? Could you tell me >>> where >>> my confusion would lie? >> The filter option amount/angle set is very small. > > It's the default value.

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 10:28:21AM +0200, Paul B Mahol wrote: >> The above picture pretty clearly shows otherwise...? Could you tell me where >> my confusion would lie? > The filter option amount/angle set is very small. It's the default value. Could you recommend a command line? /* Steinar */

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/18/20, Steinar H. Gunderson wrote: > On Sat, Jul 18, 2020 at 10:17:27AM +0200, Paul B Mahol wrote: >>> https://storage.sesse.net/ffmpeg-radialblur.png >> You are deeply confused, filters are working just fine. > > The above picture pretty clearly shows otherwise...? Could you tell me where

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Steinar H. Gunderson
On Sat, Jul 18, 2020 at 10:17:27AM +0200, Paul B Mahol wrote: >> https://storage.sesse.net/ffmpeg-radialblur.png > You are deeply confused, filters are working just fine. The above picture pretty clearly shows otherwise...? Could you tell me where my confusion would lie? /* Steinar */ --

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

2020-07-18 Thread Paul B Mahol
On 7/17/20, Steinar H. Gunderson wrote: > On Sun, Jul 12, 2020 at 01:01:07PM +0200, Paul B Mahol wrote: >> +@section rblur >> +Apply Radial blur filter. > > I tried this; it looks very aliased and absolutely not like what I'd expect > from a > radial blur at all. > > $ wget >

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: mark the field flag if framerate > 30FPS

2020-07-18 Thread Marton Balint
On Sat, 18 Jul 2020, lance.lmw...@gmail.com wrote: On Fri, Jul 17, 2020 at 07:13:28PM +0200, Marton Balint wrote: On Fri, 17 Jul 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > In SMPTE ST 12-1: 2014 Sec 12.2, we need to mark the frame flag if the frame rate > 30FPS to >

[FFmpeg-devel] [PATCH] avcodec/mips: fix type mismatch in h264dsp_msa.c

2020-07-18 Thread Shiyou Yin
gcc warning: assignment from incompatible pointer type. --- libavcodec/mips/h264dsp_mips.h | 24 +-- libavcodec/mips/h264dsp_msa.c | 94 ++ 2 files changed, 62 insertions(+), 56 deletions(-) diff --git a/libavcodec/mips/h264dsp_mips.h

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-18 Thread Michael Niedermayer
On Fri, Jul 17, 2020 at 02:25:24PM -0700, Yongle Lin wrote: > On Wed, Jul 15, 2020 at 4:13 PM Mark Thompson wrote: > > > On 15/07/2020 18:43, Yongle Lin wrote: > > > add block type field to AVVideoBlockParams so we could either export or > > visualize it later. > > > --- > > >

Re: [FFmpeg-devel] [aarch64] improve hscale by 50% with multi-threading

2020-07-18 Thread Michael Niedermayer
On Fri, Jul 17, 2020 at 11:08:02PM -0500, Sebastian Pop wrote: > hscale is bound by the number of multiply-adds available on a given core. > The attached patch doubles the number of multiply-adds by distributing half > the load to a helper thread. > > The performance improves up to 50% on