Re: [FFmpeg-devel] [PATCH] avformat/3dostr: Return directly after having read packet

2020-07-26 Thread Paul B Mahol
Make sure this does not break demuxing/decoding. On 7/27/20, Andreas Rheinhardt wrote: > Avoids an avio_skip(s->pb, 0). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/3dostr.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/libavformat/3dostr.c

[FFmpeg-devel] [PATCH] lavc/libxavs2.c: mark key-frame packets

2020-07-26 Thread hwrenx
From: hwren Signed-off-by: hwren --- libavcodec/libxavs2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 76b57e731e..8519f6925a 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -223,6 +223,12 @@ static int xavs2_en

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Move reslevelno check before use in case JPEG2000_PGOD_RPCL

2020-07-26 Thread Gautam Ramakrishnan
On Mon, Jul 27, 2020 at 3:16 AM Michael Niedermayer wrote: > > Fixes: division by zero > Fixes: > 24201/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5665813827420160 > Fixes: > 24245/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6285831682392064 > > Found

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Move reslevelno check before use in case JPEG2000_PGOD_RPCL

2020-07-26 Thread Gautam Ramakrishnan
On Mon, Jul 27, 2020 at 9:48 AM Gautam Ramakrishnan wrote: > > On Mon, Jul 27, 2020 at 3:16 AM Michael Niedermayer > wrote: > > > > Fixes: division by zero > > Fixes: > > 24201/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5665813827420160 > > Fixes: > > 24245/clusterfuzz-te

[FFmpeg-devel] [PATCH] avformat/internal: Remove wrong documentation

2020-07-26 Thread Andreas Rheinhardt
Has apparently been copied from ff_choose_timebase() in commit a45cf639e6fb8c86aff91a00970060cd0be401c9. Signed-off-by: Andreas Rheinhardt --- Btw: There is exactly one user of this, namely the MXF muxer. Should this be moved to mxfenc.c? The same issue exists for ff_choose_timebase(), which is o

[FFmpeg-devel] [PATCH] avformat/3dostr: Return directly after having read packet

2020-07-26 Thread Andreas Rheinhardt
Avoids an avio_skip(s->pb, 0). Signed-off-by: Andreas Rheinhardt --- libavformat/3dostr.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavformat/3dostr.c b/libavformat/3dostr.c index 6c49f7589c..3ec3c4393e 100644 --- a/libavformat/3dostr.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/smacker: Support seeking to first frame

2020-07-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > From: Timotej Lazar > > Add .read_seek function to the smacker demuxer for the special case of > seeking to ts=0. This is useful because smacker – like bink, with a > similar implementation – was mostly used to encode clips in video > games, where random seeks are rare but l

[FFmpeg-devel] Specifying crop parameters while encoding using vaapi

2020-07-26 Thread Satyajit Sahu
Hi, I am facing issue with cropping parameters while transcoding. The cropping parameters are ignored if both the way vaapi hw acceleration is used (for decoding and encoding). But if sw decoding is used the cropping parameters are working fine. For below command cropping parameters are ignor

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Move reslevelno check before use in case JPEG2000_PGOD_RPCL

2020-07-26 Thread Michael Niedermayer
Fixes: division by zero Fixes: 24201/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5665813827420160 Fixes: 24245/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6285831682392064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/ma

Re: [FFmpeg-devel] working with file descriptors on Android

2020-07-26 Thread Alex Cohn
On Sun, Jul 26, 2020 at 10:21 PM Martin Storsjö wrote: > > Hi, > > Without having too much opinion on the JNI stuff (direct access to > content:// urls might be convenient, but on the other hand, it's not > really something you'd end up with if using the command line tool on its > own - if you hav

Re: [FFmpeg-devel] [PATCH]lavfi/hflip: Support Bayer pixel formats

2020-07-26 Thread Carl Eugen Hoyos
Am So., 26. Juli 2020 um 21:28 Uhr schrieb Paul B Mahol : > > On 7/26/20, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes a part of ticket #8819. > > > > Please comment, Carl Eugen > > > > Looks good, but variable name is unfortunate. New patch attached. Carl Eugen From 43ece0f9b13f

Re: [FFmpeg-devel] [PATCH]lavfi/hflip: Support Bayer pixel formats

2020-07-26 Thread Paul B Mahol
On 7/26/20, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a part of ticket #8819. > > Please comment, Carl Eugen > Looks good, but variable name is unfortunate. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] working with file descriptors on Android

2020-07-26 Thread Martin Storsjö
Hi, Without having too much opinion on the JNI stuff (direct access to content:// urls might be convenient, but on the other hand, it's not really something you'd end up with if using the command line tool on its own - if you have one of those you most probably have some java code for getting

[FFmpeg-devel] [PATCH]lavfi/hflip: Support Bayer pixel formats

2020-07-26 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a part of ticket #8819. Please comment, Carl Eugen From 21aff2c2b8f3c5760589a99768d483b4be216bcd Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 26 Jul 2020 21:15:48 +0200 Subject: [PATCH] lavfi/hflip: Support Bayer pixel formats. Fixes part of ticket #8819.

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: don't fill data pointers for missing planes

2020-07-26 Thread James Almer
On 7/24/2020 3:08 PM, James Almer wrote: > The size for a previous plane doesn't signal the presence of another after it. > If the plane is present, av_image_fill_plane_sizes() will have returned a size > for it. > > Fixes a regression since 3a8e927176. > > Reported-by: Imad R. Faiad > Signed-of

[FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

2020-07-26 Thread Takio Yamaoka
An initial value of `AVCodecContext::chromaoffset` is zero, then it causes to block `-chromaoffset` setting as result. In addition, even though a negative number of `chromaoffset` is meaningful, `X264Context::chroma_offset` is initialized with `-1` as no setting and ignored if it is negative number

[FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 71c9c8f..9032547 100644 --- a/libavcodec/libkvazaar.c

[FFmpeg-devel] [PATCH 5/5] lavc/vaapi_encode: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode.c | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 6766641..2352fdd 100644 --- a/libavcodec/vaapi_encode.c +++ b

[FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 71c9c8f..9032547 100644 --- a/libavcodec/libkvazaar.c

[FFmpeg-devel] [PATCH 1/5] lavc/libkvazaar: fix framerate setting

2020-07-26 Thread Jun Zhao
From: Jun Zhao fix framerate setting. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 02bcae3..71c9c8f 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/lib

[FFmpeg-devel] [PATCH 2/5] lavc/libopenh264enc: use framerate if available

2020-07-26 Thread Jun Zhao
From: Jun Zhao Respecting the framerate in the libopenh264enc codec context. Both the libx264 and libx264 encoders already contain similar logic to first check the framerate before falling back to the timebase. Signed-off-by: Jun Zhao --- libavcodec/libopenh264enc.c | 11 ++- 1 file c

[FFmpeg-devel] [PATCH 4/5] lavc/openh264enc: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type and qp. NOTE: now libopenh264enc always export the the average QP with zero. And I have opened a issue for libopenh264 in https://github.com/cisco/openh264/issues/3317 Signed-off-by: Jun Zhao --- libavcodec/libopenh264enc.c | 31

[FFmpeg-devel] [PATCH 5/5] lavf/vaapi_encode: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode.c | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 6766641..2352fdd 100644 --- a/libavcodec/vaapi_encode.c +++ b

[FFmpeg-devel] [PATCH 2/5] lavc/libopenh264enc: use framerate if available

2020-07-26 Thread Jun Zhao
From: Jun Zhao Respecting the framerate in the libopenh264enc codec context. Both the libx264 and libx264 encoders already contain similar logic to first check the framerate before falling back to the timebase. Signed-off-by: Jun Zhao --- libavcodec/libopenh264enc.c | 11 ++- 1 file c

[FFmpeg-devel] [PATCH 4/5] lavc/openh264enc: export encoded frame stats

2020-07-26 Thread Jun Zhao
From: Jun Zhao Export choosen pict_type and qp. NOTE: now libopenh264enc always export the the average QP with zero. And I have opened a issue for libopenh264 in https://github.com/cisco/openh264/issues/3317 Signed-off-by: Jun Zhao --- libavcodec/libopenh264enc.c | 31

[FFmpeg-devel] [PATCH 1/5] lavc/libkvazaar: fix framerate setting

2020-07-26 Thread Jun Zhao
From: Jun Zhao fix framerate setting. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 02bcae3..71c9c8f 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/lib

Re: [FFmpeg-devel] working with file descriptors on Android

2020-07-26 Thread Alex Cohn
On Sat, Jul 25, 2020 at 9:37 PM Matthieu Bouron wrote: > > On Wed, Jul 22, 2020 at 2:38 PM Alex Cohn wrote: > > > Usually, we employ the `pipe:` protocol to deal with the numerical > > file descriptors, and this answers all our needs. On Android, there is > > a different use case in which numeric