Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/tests/url: add test cases for handling of double dot

Steven Liu (12020-07-28): > Will apply after 24 hours if no objections. Please give me time to look at it carefully. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

Jean-Baptiste Kempf (12020-07-28): > How is that different from open_memstream, which is done for this exact > purpose? I am not sure what you are referring to, I do not find a function by that name in FFmpeg. Are you referring to avio_open_dyn_buf()? If so, there are three differences: - avio

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

On Tue, 28 Jul 2020 06:10:57 +0200 "Josef Zlomek" wrote: > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: Typo: ny should be by, I'm assuming? ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

You are right, it is a typo. On Tue, Jul 28, 2020 at 12:02 PM Zane van Iperen wrote: > On Tue, 28 Jul 2020 06:10:57 +0200 > "Josef Zlomek" wrote: > > > > > Now, the function trim_double_dot_url splits the path by "/" into > > components, and processes the components one ny one: > > Typo: ny sho

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

Josef Zlomek 于2020年7月28日周二 下午12:11写道： > > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the co

[FFmpeg-devel] [PATCH 1/2] dnn_backend_native_layer_mathunary: add ceil support

It can be tested with the model generated with below python script: import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'ceil' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)):

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

see version 3 On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote: > Josef Zlomek 于2020年7月28日周二 下午12:11写道： > > > > Fixes: 8814 > > > > The logic for removing ".." path components and their corresponding > > upper directories was reworked. > > > > Now, the function trim_double_dot_url splits the p

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

Zlomek, Josef 于2020年7月28日周二 下午6:58写道： > > see version 3 Isn't this version? or maybe your mean is version 4? > > On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote: > > > Josef Zlomek 于2020年7月28日周二 下午12:11写道： > > > > > > Fixes: 8814 > > > > > > The logic for removing ".." path components and thei

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

I have removed tmp_path from function trim_double_dot_url I did not change the function ff_make_absolute_url much, as I wanted to just fix handling of "..". Josef On Tue, Jul 28, 2020 at 12:59 PM Steven Liu wrote: > Zlomek, Josef 于2020年7月28日周二 下午6:58写道： > > > > see version 3 > Isn't this vers

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

> On Jul 28, 2020, at 4:05 PM, Nicolas George wrote: > > Jean-Baptiste Kempf (12020-07-28): >> How is that different from open_memstream, which is done for this exact >> purpose? > > I am not sure what you are referring to, I do not find a function by > that name in FFmpeg. I think jb is ref

[FFmpeg-devel] [PATCH 1/2] dnn_backend_native_layer_mathunary: add ceil support

It can be tested with the model generated with below python script: import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'ceil' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)):

[FFmpeg-devel] [PATCH 2/2] dnn_backend_native_layer_mathunary: add floor support

It can be tested with the model generated with below python script: import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'floor' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)):

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

zhilizhao (12020-07-28): > I think jb is referring to > > FILE *open_memstream(char **bufp, size_t *sizep); > https://linux.die.net/man/3/open_memstream > > > VLC has a wrapper for it: > > https://code.videolan.org/videolan/vlc/-/blob/master/inc

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

On 7/24/20, Paul B Mahol wrote: > On 7/23/20, Michael Niedermayer wrote: >> On Sun, Jul 19, 2020 at 09:45:44PM +0200, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/filters.texi | 46 >>> libavfilter/Makefile | 2 + >>> libavfilter/allfilters.c | 2 + >

[FFmpeg-devel] [PATCH] dnn_backend_native_layer_mathunary: add ceil support It can be tested with the model generated with below python script:

import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'ceil' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)): os.mkdir(pb_file_path+'/{}_savemodel/'.format(name)) with tf.Sessi

[FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

An initial value of `AVCodecContext::chromaoffset` is zero, then it causes to block `-chromaoffset` setting as result. In addition, even though a negative number of `chromaoffset` is meaningful, `X264Context::chroma_offset` is initialized with `-1` as no setting and ignored if it is negative number

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

> On Jul 28, 2020, at 8:02 PM, Nicolas George wrote: > > zhilizhao (12020-07-28): >> I think jb is referring to >> >> FILE *open_memstream(char **bufp, size_t *sizep); >> https://linux.die.net/man/3/open_memstream >> >> >> VLC has a wrapper fo

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

I forgot to sign-off to patch, so I've resent the same patch. This patch is bug fix to handle chromaoffset parameter for libx264. Best Regards, Takio 2020年7月28日(火) 21:22 Takio Yamaoka : > > An initial value of `AVCodecContext::chromaoffset` is zero, > then it causes to block `-chromaoffset` setti

[FFmpeg-devel] [PATCH] dnn_backend_native_layer_mathunary: add ceil support

It can be tested with the model generated with below python script: import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'ceil' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)):

[FFmpeg-devel] [PATCH 1/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

From: Limin Wang Signed-off-by: Limin Wang --- doc/APIchanges| 3 +++ libavcodec/avpacket.c | 1 + libavcodec/packet.h | 7 +++ libavcodec/version.h | 2 +- 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 72a4833..2c76fdc 10064

[FFmpeg-devel] [PATCH 5/5] avformat/mpegtsenc: support 0x6a descriptor for AC-3 by side data if have

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 718ddab..ff0da62 100644 --- a/libavformat/mpegtsenc.c +++ b/libavforma

[FFmpeg-devel] [PATCH 4/5] avformat/mpegts: parse and export descriptor 6a side data

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c| 49 + tests/ref/fate/ts-demux | 2 +- 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index c6fd3e1..b5ea5a1 1006

Re: [FFmpeg-devel] [PATCH 1/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/APIchanges| 3 +++ > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 7 +++ > libavcodec/version.h | 2 +- > 4 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 6d29d85..b2e9721 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -28,6 +28,7 @@ #include "libavuti

[FFmpeg-devel] [PATCH 2/5] avutil/mpegts_audio_desc_metadata: add helper function for AC3 descriptor 0x6a

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/Makefile | 2 ++ libavutil/mpegts_audio_desc_metadata.c | 33 libavutil/mpegts_audio_desc_metadata.h | 57 ++ 3 files changed, 92 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH 1/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

On 28/07/2020 16:03, lance.lmw...@gmail.com wrote: > +case AV_PKT_DATA_MPEGTS_DESC_6A: return "ETSI 300 468 > descriptor 0x6A(AC-3)"; Is there not anything more... descriptive it could be called, rather than simply the hex literal it uses... ? - Derek

Re: [FFmpeg-devel] [PATCH 1/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

On Tue, 28 Jul 2020 at 16:04, wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/APIchanges| 3 +++ > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 7 +++ > libavcodec/version.h | 2 +- > 4 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/d

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mpegts: parse and export descriptor 6a side data

lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mpegts.c| 49 > + > tests/ref/fate/ts-demux | 2 +- > 2 files changed, 46 insertions(+), 5 deletions(-) > > diff --git a/libavformat/mpegts.c b/lib

[FFmpeg-devel] [PATCH 2/2] avformat/utils: reindent after remove if()

--- libavformat/utils.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index af1cca0c7d..88b69c6036 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2583,14 +2583,14 @@ int avformat_seek_file(AVFormatCont

[FFmpeg-devel] [PATCH 1/2] avformat/utils: remove always true if()

--- libavformat/utils.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 807d9f10cb..af1cca0c7d 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2543,6 +2543,8 @@ int av_seek_frame(AVFormatContext *s, int

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

Paul B Mahol (12020-07-28): > >> Please add an example that produces high quality output. > >> Iam asking so the filter can be tested in relation to the concerns that > >> have been raised in previous reviews > Ping. Did I miss the new patch with a high quality output example? -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH v3 4/5] avcodec/cavsdec, h264*, hevc_parser: Use get_ue_golomb_31 where possible

On Mon, Jul 27, 2020 at 11:08:09AM +0200, Andreas Rheinhardt wrote: > instead of get_ue_golomb(). The difference between the two is that the > latter also has to take into account the case in which the read code is > more than 9 bits (four preceding zeroes + at most five value bits) long, > leading

Re: [FFmpeg-devel] [PATCH v3 3/5] avcodec/golomb: Document return value of get_ue_golomb_31 on error

On Mon, Jul 27, 2020 at 11:08:08AM +0200, Andreas Rheinhardt wrote: > get_ue_golomb_31() reads nine bits and an array with 512 entries to > parse golomb codes. The longest golomb codes that fit into 9 bits use > four leading zeroes and five value bits and can encode numbers in the > 0..30 range. 31

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/golomb: Prevent shift by negative number

On Mon, Jul 27, 2020 at 11:08:07AM +0200, Andreas Rheinhardt wrote: > This happened in get_ue_golomb() if the cached bitstream reader was in > use, because there was no check to handle the case of the read value > not being in the supported range. > For consistency with the uncached bitstream reade

Re: [FFmpeg-devel] [PATCH] lavc/libxavs2.c: mark key-frame packets

On Mon, Jul 27, 2020 at 04:57:29PM +0800, Steven Liu wrote: > hwren 于2020年7月27日周一 下午3:59写道： > > > > > > > > > 在 2020-07-27 15:26:24，"Steven Liu" 写道： > > > 于2020年7月27日周一 下午2:22写道： > > >> > > >> From: hwren > > >> > > >> Signed-off-by: hwren > > >> --- > > >> libavcodec/libxavs2.c | 6 ++ >

Re: [FFmpeg-devel] [PATCH v5] libavcodec/jpeg2000dec: Support for PPM marker

On Sat, Jul 25, 2020 at 07:46:34PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds support for PPM marker for JPEG2000 > decoder. It allows the samples p1_03.j2k and p1_05.j2k > to be decoded. > --- > libavcodec/jpeg2000dec.c | 106 +

[FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options

The tile_rows/cols options currently do a confusingly different thing to the options of the same name on other encoders like libvpx and libaom. There is no backward-compatibility reason to implement the log2 behaviour as there was for libaom, so just get rid of them entirely. --- doc/encoders.texi

[FFmpeg-devel] [PATCH 2/6] vaapi_encode_h265: Fix ordering of tile dimensions

Dimensions are normally specified as width x height. Remove the indirection through the private context at the same time. --- doc/encoders.texi | 2 +- libavcodec/vaapi_encode.h | 2 +- libavcodec/vaapi_encode_h265.c | 13 +++-- 3 files changed, 5 insertions(+), 12 del

[FFmpeg-devel] [PATCH 6/6] vaapi_encode_h265: Set tiles_fixed_structure_flag

We only make one PPS, so the tile structure necessarily fixed. --- libavcodec/vaapi_encode_h265.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index b0c6d63ea2..b454d560c7 100644 --- a/libavcodec/vaapi_encode_h265.c +++ b/libav

[FFmpeg-devel] [PATCH 4/6] vaapi_encode: Delete unused field

--- libavcodec/vaapi_encode.c | 12 libavcodec/vaapi_encode.h | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 4544090bcc..b3a02459f1 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.

[FFmpeg-devel] [PATCH 3/6] vaapi_encode_h265: Don't require uniform_spacing_flag

Though still use it if the tile arrangement matches. Also try to keep the fields in the same order as the standard. --- libavcodec/vaapi_encode_h265.c | 39 -- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcod

[FFmpeg-devel] [PATCH 5/6] vaapi_encode: Rewrite slice/tile support

This precalculates all of the information we will need to define slice and tile positions at init time rather than rebuilding some of it with every slice. The control of tiles is generalised to match slices, so that arbitrary tile and slice layouts are possible within the constraint that slices ca

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mpegts: parse and export descriptor 6a side data

On Tue, Jul 28, 2020 at 06:55:14PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mpegts.c| 49 > > + > > tests/ref/fate/ts-demux | 2 +- > > 2 files

Re: [FFmpeg-devel] [PATCH 1/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

On Tue, Jul 28, 2020 at 05:09:33PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/APIchanges| 3 +++ > > libavcodec/avpacket.c | 1 + > > libavcodec/packet.h | 7 +++ > > libavcodec/version.h | 2 +

Re: [FFmpeg-devel] [PATCH 3/6] vaapi_encode_h265: Don't require uniform_spacing_flag

On Tue, 2020-07-28 at 23:50 +0100, Mark Thompson wrote: > Though still use it if the tile arrangement matches. Also try to keep the > fields in the same order as the standard. > --- > libavcodec/vaapi_encode_h265.c | 39 -- > 1 file changed, 28 insertions(+), 11 de

Re: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options

> From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Wednesday, July 29, 2020 06:50 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove > confusing and redundant tile options > > The tile_rows/cols options currently do a confusingly different thing t

[FFmpeg-devel] Custom Video Encoding and Decoding

Dear members of ffmpeg-devel, I am currently working on a research project and from looking over the examples and documentation in the ffmpeg repository, I believe I need to implement a custom encoder / decoder to perform my task. To first explain the project idea, currently I am working mainly w

Re: [FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

On 7/28/20, Nicolas George wrote: > Paul B Mahol (12020-07-28): >> >> Please add an example that produces high quality output. >> >> Iam asking so the filter can be tested in relation to the concerns that >> >> have been raised in previous reviews > >> Ping. > > Did I miss the new patch with a hig

Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode: add EQUAL_MULTI_ROWS support for slice structure

> From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Tuesday, July 28, 2020 05:52 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode: add > EQUAL_MULTI_ROWS support for slice structure > > On 19/07/2020 08:00, Li

Re: [FFmpeg-devel] Custom Video Encoding and Decoding

On 7/29/20, Jaeho Bang wrote: > Dear members of ffmpeg-devel, > > I am currently working on a research project and from looking over the > examples and documentation in the ffmpeg repository, I believe I need to > implement a custom encoder / decoder to perform my task. > > To first explain the pr