[FFmpeg-devel] [PATCH 3/3] avcodec/mips: Optimize function ff_h264_loop_filter_strength_msa.

2020-09-04 Thread Shiyou Yin
From: gxw Speed of decoding H264: 5.45x ==> 5.53x Signed-off-by: Shiyou Yin --- libavcodec/mips/Makefile| 3 +- libavcodec/mips/h264_deblock_msa.c | 153 libavcodec/mips/h264dsp_init_mips.c | 2 + libavcodec/mips/h264dsp_mips.h | 4 +

[FFmpeg-devel] [loongson] Optimize H264 decoding.

2020-09-04 Thread Shiyou Yin
H264 decoding speed: 154fps ==> 165fps, 5.14x ==> 5.53x (tested on 3A4000) [PATCH 1/3] avcodec/mips: Restore the initialization sequence of MSA. [PATCH 2/3] avcodec/mips: Refine get_cabac_inline_mips. [PATCH 3/3] avcodec/mips: Optimize function ff_h264_loop_filter_strength_msa. _

[FFmpeg-devel] [PATCH 1/3] avcodec/mips: Restore the initialization sequence of MSA and MMI in ff_h264chroma_init_mips.

2020-09-04 Thread Shiyou Yin
Speed of decoding H264: 5.14x ==> 5.23x (tested on 3A4000). --- libavcodec/mips/h264chroma_init_mips.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavcodec/mips/h264chroma_init_mips.c b/libavcodec/mips/h264chroma_init_mips.c index 6bb19d3..755cc04 10

[FFmpeg-devel] [PATCH 2/3] avcodec/mips: Refine get_cabac_inline_mips.

2020-09-04 Thread Shiyou Yin
1. Refined function get_cabac_inline_mips. 2. Optimize function get_cabac_bypass and get_cabac_bypass_sign. Speed of decoding h264: 5.23x ==> 5.45x(tested on 3A4000). --- libavcodec/mips/cabac.h | 131 +--- 1 file changed, 102 insertions(+), 29 deletion

Re: [FFmpeg-devel] qsv: question on CONFIG macros

2020-09-04 Thread js
> On Sep 4, 2020, at 23:58, Rogozhkin, Dmitry V > wrote: > > Hi, > > Can someone, please, help to clarify: > 1. Where CONFIG_QSV and CONFIG_LIBMFX gets defined (I don't see that in > the grep output - attached below)? Defined at config.h during “./configuration xxx” step. > 2. What's relati

Re: [FFmpeg-devel] [PATCH 3/5] avdevice/lavfi: Use av_packet_pack_dictionary() to pack dictionary

2020-09-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > av_packet_pack_dictionary() returns NULL in case the dictionary's count > is zero; but given that the dict API does not return such dicts at all, > I have not added any check for this. > > libavdevice/lavfi.c | 25 --

[FFmpeg-devel] [PATCH 8/8] avcodec/jpegls: Remove unused structure

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/jpegls.h | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/jpegls.h b/libavcodec/jpegls.h index 6b89b2afa3..16372bd39d 100644 --- a/libavcodec/jpegls.h +++ b/libavcodec/jpegls.h @@ -34,10 +34,6 @@ #undef near /* This file uses st

[FFmpeg-devel] [PATCH 7/8] avcodec/jpeglsenc: Allocate buffers together

2020-09-04 Thread Andreas Rheinhardt
Having only one allocation that is not automatically freed in particular means that one does not need to free the already allocated buffers when allocating another one fails. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsenc.c | 25 +++-- 1 file changed, 7 insertions

[FFmpeg-devel] [PATCH 6/8] avcodec/jpeglsenc: Avoid allocation of JLSState

2020-09-04 Thread Andreas Rheinhardt
This state is currently allocated and freed for every packet; but it can just be moved to the stack instead. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsenc.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/libavcodec/jpeglsenc.c b/liba

[FFmpeg-devel] [PATCH 3/8] avcodec/jpeglsenc: Move check out of loop

2020-09-04 Thread Andreas Rheinhardt
ls_encode_line() encodes a line of input, going from left to right. In order to calculate a predicted value it uses the left and upper-left value of the output picture (that is, it uses how a decoder would see the already encoded part of the picture), unless this is the very first pixel of this lin

[FFmpeg-devel] [PATCH 2/8] avcodec/jpeglsenc: Don't modify frame we don't own

2020-09-04 Thread Andreas Rheinhardt
The jpegls encoder uses three buffers (as well as its state) to perform its function: A copy of the last encoded line as a decoder would decode it, the part of the current line that has been encoded (again, as a decoder would decode it) and the part of the current line that is not yet encoded. The

[FFmpeg-devel] [PATCH 5/8] avcodec/jpeglsenc: Remove redundant av_packet_unref()

2020-09-04 Thread Andreas Rheinhardt
If encoding fails, the AVPacket that ought to contain the encoded packet is already unreferenced generically. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/jpeglsenc.c b/libavcodec/jpeglsenc.c index d05fe4564b..b1e54431

[FFmpeg-devel] [PATCH 4/8] avcodec/jpeglsenc: Only use one line at a time as spare buffer

2020-09-04 Thread Andreas Rheinhardt
ls_encode_line() encodes one line of input from left to right and to do so it uses the values of the left, upper left, upper and upper right pixels for prediction (i.e. the values that a decoder gets when it decodes the already encoded part of the picture). So a simple algorithm would use a buffer

[FFmpeg-devel] [PATCH 1/8] avcodec/jpeglsenc: Don't use put bits API for byte-aligned writes

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Is it actually guaranteed that the allocated packet size is sufficient? If it is, one could use unchecked writes throughout; if it isn't, should I add a check to properly error out in case the buffer is too small? (And what would the return value be in this ca

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: only limit DASH manifest size according to AVBprint limits

2020-09-04 Thread Steven Liu
Jan Ekström 于2020年9月4日周五 上午2:33写道: > > Currently the API is internally limited to unsigned integers, so if we > limit the file size as well as the amount to read to UINT_MAX - 1, we > do not require additional limiting to be performed on the values. > > This change is based on the fact that initia

Re: [FFmpeg-devel] [PATCH v4 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-04 Thread Steven Liu
于2020年9月4日周五 下午11:09写道: > > From: Xu Jun > > Use pthread to multithread dnn_execute_layer_conv2d. > Can be tested with command "./ffmpeg_g -i input.png -vf \ > format=yuvj420p,dnn_processing=dnn_backend=native:model= \ > espcn.model:input=x:output=y:options=conv2d_threads=23 \ > -y sr_native.jpg

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2020 at 10:03:26PM +0200, Paul B Mahol wrote: > On 9/4/20, Michael Niedermayer wrote: > > On Fri, Sep 04, 2020 at 12:17:04PM +0200, Paul B Mahol wrote: > >> get_unary() takes at minimum only 1 bit. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/dxtory.c | 10 +

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/videotoolbox: h264 decoder on iOS is unable to decode interlaced video

2020-09-04 Thread Aman Gupta
On Tue, Sep 26, 2017 at 4:20 AM Carl Eugen Hoyos wrote: > 2017-09-26 2:36 GMT+02:00 Aman Gupta : > > > > > + case kCMVideoCodecType_H264 : { > > > + H264Context *h = avctx->priv_data; > > > + if (TARGET_OS_IPHONE && h->ps.sps->frame_mbs_only_flag == 0) { > > > > I believe that for DVB

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: only limit DASH manifest size according to AVBprint limits

2020-09-04 Thread Jan Ekström
On Thu, Sep 3, 2020 at 8:29 PM Jan Ekström wrote: > > Currently the API is internally limited to unsigned integers, so if we > limit the file size as well as the amount to read to UINT_MAX - 1, we > do not require additional limiting to be performed on the values. > > This change is based on the f

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, Michael Niedermayer wrote: > On Fri, Sep 04, 2020 at 12:17:04PM +0200, Paul B Mahol wrote: >> get_unary() takes at minimum only 1 bit. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/dxtory.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) > > should be ok

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/photocd: Remove set-but-unused variables

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/photocd.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > ok > diff --git a/libavcodec/photocd.c b/libavcodec/photocd.c > index 6f8426b5d2..057c9d33d4 100644 > --- a/libavcodec/photocd.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mobiclip: Fix mixed declarations and code

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mobiclip.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > ok > diff --git a/libavcodec/mobiclip.c b/libavcodec/mobiclip.c > index e2bda76978..d147eddbae 100644 > --- a/libavcodec/mobicl

[FFmpeg-devel] [PATCH 2/2] avcodec/photocd: Remove set-but-unused variables

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/photocd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/photocd.c b/libavcodec/photocd.c index 6f8426b5d2..057c9d33d4 100644 --- a/libavcodec/photocd.c +++ b/libavcodec/photocd.c @@ -227,9 +227,9 @@ static av_

[FFmpeg-devel] [PATCH 1/2] avcodec/mobiclip: Fix mixed declarations and code

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mobiclip.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mobiclip.c b/libavcodec/mobiclip.c index e2bda76978..d147eddbae 100644 --- a/libavcodec/mobiclip.c +++ b/libavcodec/mobiclip.c @@ -1333,13 +1333,15 @@ s

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2020 at 12:17:04PM +0200, Paul B Mahol wrote: > get_unary() takes at minimum only 1 bit. > > Signed-off-by: Paul B Mahol > --- > libavcodec/dxtory.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) should be ok thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] fate: add wav chapters test

2020-09-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- tests/fate/lavf-audio.mak | 5 + tests/ref/fate/wav-chapters | 45 + 2 files changed, 50 insertions(+) create mode 100644 tests/ref/fate/wav-chapters diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak ind

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/bink: Combine allocations of arrays into one

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Saves allocations, checks for the allocations as well as frees. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bink.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > LGTM > diff --git a/libavcodec/bink.c b/libavcodec/bi

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/bink: Only keep what is used from HpelDSPContext

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bink.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > LGTM > diff --git a/libavcodec/bink.c b/libavcodec/bink.c > index 9fdfa37395..ec164d0165 100644 > --- a/libavcodec/bink.

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: allow qsv decoders to use initialized device

2020-09-04 Thread Rogozhkin, Dmitry V
On Thu, 2020-09-03 at 01:02 +, Rogozhkin, Dmitry V wrote: > > > > (If you do implement it then you can delete all of the ad-hoc > > treatment in ffmpeg, like has been done for the other hardware > > codecs.) > > I like deleting code:). Ok, this sounds good. Let's try to understand > what migh

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/binkaudio: Avoid allocation for array

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > The array in question can not be too large (only 26 elements), so it can > simply be put on the context. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/binkaudio.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > LGTM > diff --git

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/binkaudio: Remove unused array from context

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Unused since 7bfd1766d1c18f07b0a2dd042418a874d49ea60d. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/binkaudio.c | 1 - > 1 file changed, 1 deletion(-) > LGTM > diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c > index f17164da91..f7

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/binkaudio: Don't use static storage for context-dependent data

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Move it to the context instead. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/binkaudio.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > Wow, nice catch, LGTM. > diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c > i

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/bink: Fix memleak upon init failure

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > The init function first allocates an AVFrame and then some buffers; if > one of the buffers couldn't be allocated, the AVFrame leaks. Solve this > by setting the FF_CODEC_CAP_INIT_CLEANUP flag. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bink.c

[FFmpeg-devel] [PATCH 5/6] avcodec/binkaudio: Remove unused array from context

2020-09-04 Thread Andreas Rheinhardt
Unused since 7bfd1766d1c18f07b0a2dd042418a874d49ea60d. Signed-off-by: Andreas Rheinhardt --- libavcodec/binkaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index f17164da91..f7e9a37a1b 100644 --- a/libavcodec/binkaudio.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 6/6] avcodec/binkaudio: Avoid allocation for array

2020-09-04 Thread Andreas Rheinhardt
The array in question can not be too large (only 26 elements), so it can simply be put on the context. Signed-off-by: Andreas Rheinhardt --- libavcodec/binkaudio.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index f7e9

[FFmpeg-devel] [PATCH 3/6] avcodec/bink: Only keep what is used from HpelDSPContext

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bink.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index 9fdfa37395..ec164d0165 100644 --- a/libavcodec/bink.c +++ b/libavcodec/bink.c @@ -114,7 +114,7 @@ typedef struct

[FFmpeg-devel] [PATCH 4/6] avcodec/binkaudio: Don't use static storage for context-dependent data

2020-09-04 Thread Andreas Rheinhardt
Move it to the context instead. Signed-off-by: Andreas Rheinhardt --- libavcodec/binkaudio.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index 012190a955..f17164da91 100644 --- a/libavcodec/binkaudio.c +++ b/libavcode

[FFmpeg-devel] [PATCH 2/6] avcodec/bink: Combine allocations of arrays into one

2020-09-04 Thread Andreas Rheinhardt
Saves allocations, checks for the allocations as well as frees. Signed-off-by: Andreas Rheinhardt --- libavcodec/bink.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index c7ef333bd4..9fdfa37395 100644 --- a/libavcodec/b

[FFmpeg-devel] [PATCH 1/6] avcodec/bink: Fix memleak upon init failure

2020-09-04 Thread Andreas Rheinhardt
The init function first allocates an AVFrame and then some buffers; if one of the buffers couldn't be allocated, the AVFrame leaks. Solve this by setting the FF_CODEC_CAP_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavcodec/bink.c | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2020 at 12:13:53PM +0200, Paul B Mahol wrote: > On 9/4/20, Michael Niedermayer wrote: > > On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: > >> On 9/3/20, Michael Niedermayer wrote: > >> > On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: > >> >> get_unary

Re: [FFmpeg-devel] MLP Multichannel for DVD-Audio

2020-09-04 Thread Paul B Mahol
On 9/4/20, fabrice nicol wrote: > I've recently been integrating the ffmpeg encoder into the DVD-Audio > creating software dvda-author (https://dvd-audio.sourceforge.io), > command-line options --encode and --mlp-files > > 1. The good news is that multichannel ffmpeg-encoded MLP audio overall > pl

Re: [FFmpeg-devel] [PATCH] lavfi/vsrc_testsrc: switch to activate.

2020-09-04 Thread Paul B Mahol
On 7/7/20, Paul B Mahol wrote: > Why this was never applied? > Ping. > On 6/26/20, Nicolas George wrote: >> Allow to set the EOF timestamp. >> >> Also: doc/filters/testsrc*: specify the rounding of the duration option. >> >> The changes in the ref files are right. >> >> For filter-fps-down, the

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2020 at 05:28:06PM +0200, Paul B Mahol wrote: > On 9/4/20, James Almer wrote: > > On 9/4/2020 11:53 AM, Paul B Mahol wrote: > >> On 9/4/20, James Almer wrote: > >>> On 9/4/2020 11:44 AM, Paul B Mahol wrote: > On 9/4/20, James Almer wrote: > > On 9/4/2020 6:29 AM, Paul B

[FFmpeg-devel] MLP Multichannel for DVD-Audio

2020-09-04 Thread fabrice nicol
I've recently been integrating the ffmpeg encoder into the DVD-Audio creating software dvda-author (https://dvd-audio.sourceforge.io), command-line options --encode and --mlp-files 1. The good news is that multichannel ffmpeg-encoded MLP audio overall plays back fine on a DVD-Audio player (usi

[FFmpeg-devel] qsv: question on CONFIG macros

2020-09-04 Thread Rogozhkin, Dmitry V
Hi, Can someone, please, help to clarify: 1. Where CONFIG_QSV and CONFIG_LIBMFX gets defined (I don't see that in the grep output - attached below)? 2. What's relationship between these 2? Which one should actually be used? /from the first glance they are about the same.../ $ fgrep -rsn CONFIG_QS

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, James Almer wrote: > On 9/4/2020 11:53 AM, Paul B Mahol wrote: >> On 9/4/20, James Almer wrote: >>> On 9/4/2020 11:44 AM, Paul B Mahol wrote: On 9/4/20, James Almer wrote: > On 9/4/2020 6:29 AM, Paul B Mahol wrote: >> On 9/4/20, Michael Niedermayer wrote: >>> On Fri,

[FFmpeg-devel] [PATCH v4 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-04 Thread xujunzz
From: Xu Jun Use pthread to multithread dnn_execute_layer_conv2d. Can be tested with command "./ffmpeg_g -i input.png -vf \ format=yuvj420p,dnn_processing=dnn_backend=native:model= \ espcn.model:input=x:output=y:options=conv2d_threads=23 \ -y sr_native.jpg -benchmark" before patch: utime=11.238

[FFmpeg-devel] [PATCH v4 1/2] dnn_backend_native.c: parse options in native backend

2020-09-04 Thread xujunzz
From: Xu Jun Signed-off-by: Xu Jun --- v2: use av_opt_set_from_string instead of function dnn_parse_option(). v3: make all the options supported, not just conv2d_threads v4: move dnn_native_options and dnn_native_class to from .h to .c. libavfilter/dnn/dnn_backend_native.c | 22 +++

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread James Almer
On 9/4/2020 11:53 AM, Paul B Mahol wrote: > On 9/4/20, James Almer wrote: >> On 9/4/2020 11:44 AM, Paul B Mahol wrote: >>> On 9/4/20, James Almer wrote: On 9/4/2020 6:29 AM, Paul B Mahol wrote: > On 9/4/20, Michael Niedermayer wrote: >> On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, James Almer wrote: > On 9/4/2020 11:44 AM, Paul B Mahol wrote: >> On 9/4/20, James Almer wrote: >>> On 9/4/2020 6:29 AM, Paul B Mahol wrote: On 9/4/20, Michael Niedermayer wrote: > On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: >> On 9/3/20, Michael Niederm

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread James Almer
On 9/4/2020 11:44 AM, Paul B Mahol wrote: > On 9/4/20, James Almer wrote: >> On 9/4/2020 6:29 AM, Paul B Mahol wrote: >>> On 9/4/20, Michael Niedermayer wrote: On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: > On 9/3/20, Michael Niedermayer wrote: >> On Thu, Sep 03, 20

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, James Almer wrote: > On 9/4/2020 6:29 AM, Paul B Mahol wrote: >> On 9/4/20, Michael Niedermayer wrote: >>> On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: On 9/3/20, Michael Niedermayer wrote: > On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread James Almer
On 9/4/2020 6:29 AM, Paul B Mahol wrote: > On 9/4/20, Michael Niedermayer wrote: >> On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: >>> On 9/3/20, Michael Niedermayer wrote: On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: > get_unary() takes at minimum only 1

[FFmpeg-devel] [PATCH v3 1/2] dnn_backend_native.c: parse options in native backend

2020-09-04 Thread xujunzz
From: Xu Jun Signed-off-by: Xu Jun --- v2: use av_opt_set_from_string instead of function dnn_parse_option(). v3: make all the options supported, not just conv2d_threads libavfilter/dnn/dnn_backend_native.c | 19 ++- libavfilter/dnn/dnn_backend_native.h | 21 +++

Re: [FFmpeg-devel] [PATCH v5]libavfilter/asrc_fluidsynthmusic.c : generate algorithmic music

2020-09-04 Thread Ashutosh Pradhan
On Fri, Sep 4, 2020 at 6:08 PM Paul B Mahol wrote: > On 8/25/20, Ashutosh Pradhan wrote: > > Generate algorithmic music using riffs, lindenmayer systems, cellular > > automaton and rhythm algorithms. > > > > Changelog |1 + > > configure |

Re: [FFmpeg-devel] [PATCH v2 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > xuju...@sjtu.edu.cn > Sent: 2020年9月4日 20:46 > To: ffmpeg-devel@ffmpeg.org > Cc: xuju...@sjtu.edu.cn > Subject: [FFmpeg-devel] [PATCH v2 2/2] > dnn_backend_native_layer_conv2d.c:Add mutithread function > > From: Xu Jun > > v2: ad

Re: [FFmpeg-devel] [PATCH v2 1/2] dnn_backend_native.c: parse options in native backend

2020-09-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > xuju...@sjtu.edu.cn > Sent: 2020年9月4日 20:46 > To: ffmpeg-devel@ffmpeg.org > Cc: xuju...@sjtu.edu.cn > Subject: [FFmpeg-devel] [PATCH v2 1/2] dnn_backend_native.c: parse options in > native backend > > From: Xu Jun > > v2: use av

Re: [FFmpeg-devel] [PATCH] avcodec: add PhotoCD decoder

2020-09-04 Thread Paul B Mahol
On 8/30/20, Paul B Mahol wrote: > On 8/30/20, Andreas Rheinhardt wrote: > [...] >>> +static int read_hufftable(AVCodecContext *avctx, VLC *vlc) >>> +{ >>> +PhotoCDContext *s = avctx->priv_data; >>> +GetByteContext *gb = &s->gb; >>> +int start = s->streampos; >>> +int count, ret; >

[FFmpeg-devel] [PATCH v2 1/2] dnn_backend_native.c: parse options in native backend

2020-09-04 Thread xujunzz
From: Xu Jun v2: use av_opt_set_from_string instead of function dnn_parse_option(). Signed-off-by: Xu Jun --- libavfilter/dnn/dnn_backend_native.c | 19 ++- libavfilter/dnn/dnn_backend_native.h | 21 + 2 files changed, 31 insertions(+), 9 deletions(-) diff

[FFmpeg-devel] [PATCH v2 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-04 Thread xujunzz
From: Xu Jun v2: add check for HAVE_PTHREAD_CANCEL and modify FATE test dnn-layer-conv2d-test.c Use pthread to multithread dnn_execute_layer_conv2d. Can be tested with command "./ffmpeg_g -i input.png -vf \ format=yuvj420p,dnn_processing=dnn_backend=native:model= \ espcn.model:input=x:output=y:o

Re: [FFmpeg-devel] [PATCH v5]libavfilter/asrc_fluidsynthmusic.c : generate algorithmic music

2020-09-04 Thread Paul B Mahol
On 8/25/20, Ashutosh Pradhan wrote: > Generate algorithmic music using riffs, lindenmayer systems, cellular > automaton and rhythm algorithms. > > Changelog |1 + > configure |4 + > doc/filters.texi | 146 > libavf

Re: [FFmpeg-devel] [PATCH 2/2] avformat/yuv4mpegenc: Add const where appropriate

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/yuv4mpegenc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > lgtm > diff --git a/libavformat/yuv4mpegenc.c b/libavformat/yuv4mpegenc.c > index fdd020e13b..6b53780ba0 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH 1/2] avformat/yuv4mpegenc: Simplify writing global and packet headers

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > YUV4MPEG writes a string as header for both the file itself as well as > for every frame; these strings contain magic strings and these were up > until now included in the string to write via %s. Yet they are compile > time constants, so one can use the compi

[FFmpeg-devel] [PATCH 2/2] avformat/yuv4mpegenc: Add const where appropriate

2020-09-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/yuv4mpegenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/yuv4mpegenc.c b/libavformat/yuv4mpegenc.c index fdd020e13b..6b53780ba0 100644 --- a/libavformat/yuv4mpegenc.c +++ b/libavformat/yuv4mpegenc.c @@ -1

[FFmpeg-devel] [PATCH 1/2] avformat/yuv4mpegenc: Simplify writing global and packet headers

2020-09-04 Thread Andreas Rheinhardt
YUV4MPEG writes a string as header for both the file itself as well as for every frame; these strings contain magic strings and these were up until now included in the string to write via %s. Yet they are compile time constants, so one can use the compile-time string concatentation instead of inser

[FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
get_unary() takes at minimum only 1 bit. Signed-off-by: Paul B Mahol --- libavcodec/dxtory.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/dxtory.c b/libavcodec/dxtory.c index bc19f27951..3cd95afe80 100644 --- a/libavcodec/dxtory.c +++ b/libavcodec/dxt

[FFmpeg-devel] [PATCH 2/3] avcodec/dxtory: support subsample formats with non-aligned dimensions

2020-09-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dxtory.c | 191 1 file changed, 175 insertions(+), 16 deletions(-) diff --git a/libavcodec/dxtory.c b/libavcodec/dxtory.c index 3cd95afe80..123833741b 100644 --- a/libavcodec/dxtory.c +++ b/libavcodec/dxtory.

[FFmpeg-devel] [PATCH 3/3] avcodec/dxtory: add missed rgb555/rgb565 formats for vflip case

2020-09-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/dxtory.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/dxtory.c b/libavcodec/dxtory.c index 123833741b..e239abe233 100644 --- a/libavcodec/dxtory.c +++ b/libavcodec/dxtory.c @@ -62,6 +62,8 @@ static void do_vflip(AVCodecContext *avctx,

Re: [FFmpeg-devel] request to upload sample

2020-09-04 Thread Paul B Mahol
On 9/4/20, Andreas Rheinhardt wrote: > Paul B Mahol: >> Hi. >> >> Please upload this file to FATE servers. >> >> http://trac.ffmpeg.org/raw-attachment/ticket/8872/200828-005.wav >> >> Will add chapter/cue test later. > > Can't the file be made smaller? No because cue stuff is at end of file. Are

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, Michael Niedermayer wrote: > On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: >> On 9/3/20, Michael Niedermayer wrote: >> > On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: >> >> get_unary() takes at minimum only 1 bit. >> >> >> >> Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] request to upload sample

2020-09-04 Thread Andreas Rheinhardt
Paul B Mahol: > Hi. > > Please upload this file to FATE servers. > > http://trac.ffmpeg.org/raw-attachment/ticket/8872/200828-005.wav > > Will add chapter/cue test later. Can't the file be made smaller? - Andreas ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Paul B Mahol
On 9/4/20, Michael Niedermayer wrote: > On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: >> On 9/3/20, Michael Niedermayer wrote: >> > On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: >> >> get_unary() takes at minimum only 1 bit. >> >> >> >> Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-09-04 Thread Tomas Härdin
tis 2020-09-01 klockan 11:06 +0100 skrev Rémi Achard: > > If you want the IS_KLV_KEY() check to be more lenient then you should > > make mxf_jp2k_rsiz[] shorter, not replace the end of it with NULs > > This UL come straight from SMPTE ST 422M, not sure what you mean but I > didn't replace it with

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: unbreak decoding after 6e1a167c556

2020-09-04 Thread Michael Niedermayer
On Fri, Sep 04, 2020 at 12:27:11AM +0200, Paul B Mahol wrote: > On 9/3/20, Michael Niedermayer wrote: > > On Thu, Sep 03, 2020 at 07:03:23PM +0200, Paul B Mahol wrote: > >> get_unary() takes at minimum only 1 bit. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> > >> As this is important fix,