[FFmpeg-devel] [PATCH] tiff: remove tiff type check for ICC profiles

2020-09-05 Thread Lynne
Although the ICC specifications say to check for this, libtiff doesn't and neither does any other TIFF implementation, and the TIFF specs say that Photoshop has a different way to encapsulate ICC profiles, and are asking for advice on how to deal with it. So basically, photoshop puts a different

Re: [FFmpeg-devel] [PATCH]lavc/tiff: Do not fail for an ICC profile with invalid type

2020-09-05 Thread Lynne
Sep 5, 2020, 18:24 by ceffm...@gmail.com: > Hi! > > Attached patch fixes ticket 8884. > > Please comment, Carl Eugen > Just posted a patch which fixes the problem and allows parsing of such files instead. Tested and works on #8884's samples. ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: support remaping negative values in the prelut

2020-09-05 Thread Mark Reid
On Sat, Sep 5, 2020 at 2:13 PM wrote: > From: Mark Reid > > --- > libavfilter/vf_lut3d.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c > index 6730a424ce..988f6c8b55 100644 > --- a/libavfilter/vf_lut3d.c > +++

[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: support remaping negative values in the prelut

2020-09-05 Thread mindmark
From: Mark Reid --- libavfilter/vf_lut3d.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index 6730a424ce..988f6c8b55 100644 --- a/libavfilter/vf_lut3d.c +++ b/libavfilter/vf_lut3d.c @@ -878,18 +878,16 @@ static int

[FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2020-09-05 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8819. Please comment, Carl Eugen From 61f4e419cbeae3d0adb726578bc1c8d87fb0c50b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 5 Sep 2020 21:14:01 +0200 Subject: [PATCH] lavfi/vflip: Support Bayer vertical flip. Fixes ticket #8819. ---

[FFmpeg-devel] [PATCH 6/8] avcodec: use av_timecode_make_smpte_tc_string2 in hevc and h264 decoder

2020-09-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/h264_slice.c | 2 +- libavcodec/hevcdec.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c7b2764270..cfc29e186c 100644 --- a/libavcodec/h264_slice.c +++

[FFmpeg-devel] [PATCH 8/8] avformat: use av_timecode_make_smpte_tc_string2

2020-09-05 Thread Marton Balint
WSD format has no frames stored for playback time. Signed-off-by: Marton Balint --- libavformat/dump.c | 6 +++--- libavformat/dv.c | 2 +- libavformat/wsddec.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index

[FFmpeg-devel] [PATCH 7/8] avfilter/vf_showinfo: use av_timecode_make_smpte_tc_string2

2020-09-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_showinfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 1be939614d..c63e6f075f 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -114,7

[FFmpeg-devel] [PATCH 5/8] fftools/ffprobe: use av_timecode_make_smpte_tc_string2

2020-09-05 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index d4e494f11f..86bd23d36d 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2225,7 +2225,7 @@ static void

[FFmpeg-devel] [PATCH 2/8] avutil/timecode: cosmetics on av_timecode_get_smpte

2020-09-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/timecode.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index cb916970ef..c0956adadb 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -71,31 +71,28 @@ uint32_t

[FFmpeg-devel] [PATCH 4/8] avutil/timecode: add av_timecode_make_smpte_tc_string2

2020-09-05 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/timecode.c | 19 ++- libavutil/timecode.h | 17 + libavutil/version.h | 2 +- 4 files changed, 39 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH 3/8] avutil/timecode: do not trash bits on invalid av_timecode_get_smpte arguments

2020-09-05 Thread Marton Balint
The function has no way to return error, so let's clip or calculate modulo. Signed-off-by: Marton Balint --- libavutil/timecode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index c0956adadb..806638ddfc 100644 --- a/libavutil/timecode.c

[FFmpeg-devel] [PATCH 1/8] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-09-05 Thread Marton Balint
SMPTE 12M timecode can only count frames up to 39, because the tens-of-frames value is stored in 2 bit. In order to resolve this 50/60 fps SMPTE timecode is using the field bit (which is the same bit as the phase correction bit) to signal the least significant bit of a 50/60 fps timecode. See

[FFmpeg-devel] [PATCH]lavc/tiff: Do not fail for an ICC profile with invalid type

2020-09-05 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket 8884. Please comment, Carl Eugen From 0f7a5c6d2c739119ceb50fd8efd570807b8c7eb5 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 5 Sep 2020 19:22:54 +0200 Subject: [PATCH] lavc/tiff: Do not fail for an ICC profile with invalid type. Fixes ticket #8884.

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/jpeglsenc: Allocate buffers together

2020-09-05 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 01:17:15AM +0200, Andreas Rheinhardt wrote: > Having only one allocation that is not automatically freed in particular > means that one does not need to free the already allocated buffers > when allocating another one fails. > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/tdsc: Only reallocate deflatebuffer if its size changed

2020-09-05 Thread Michael Niedermayer
On Thu, Jun 18, 2020 at 02:20:26PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (47sec -> 35msec) > Fixes: > 23375/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TDSC_fuzzer-5633949497032704 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avidec: Fix io_fsize overflow

2020-09-05 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:36:18AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 7958120835074169528 * 9 cannot be represented > in type 'long long' > Fixes: > 23382/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6230683226996736 > > Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH] avformat/argo_asf: fix handling of v1.1 files

2020-09-05 Thread Zane van Iperen
Version 1.1 (FX Fighter) files all have a sample rate of 44100 in the header, but only play back correctly at 22050. Force the sample rate to 22050 when reading, and restrict it when muxing. Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 19 +-- 1 file changed, 17

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: only limit DASH manifest size according to AVBprint limits

2020-09-05 Thread Jan Ekström
On Sat, Sep 5, 2020 at 1:12 AM Steven Liu wrote: > > Jan Ekström 于2020年9月4日周五 上午2:33写道: > > > > Currently the API is internally limited to unsigned integers, so if we > > limit the file size as well as the amount to read to UINT_MAX - 1, we > > do not require additional limiting to be performed

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Autodetect Photo CD images

2020-09-05 Thread Carl Eugen Hoyos
Am Do., 20. Dez. 2018 um 01:00 Uhr schrieb Carl Eugen Hoyos : > Attached patch depends on Paul's PhotoCD decoder. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/jpeglsenc: Remove redundant av_packet_unref()

2020-09-05 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 01:17:13AM +0200, Andreas Rheinhardt wrote: > If encoding fails, the AVPacket that ought to contain the encoded packet > is already unreferenced generically. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeglsenc.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [FFmpeg-devel] [FFmpeg-user] ffplay.exe leaves fullscreen mode and iconifies when losing focus

2020-09-05 Thread Norbert Marouschek
Dear all, I could identify the reason for the behaviour. In FFmpeg-master\libavdevice\gdigrab.c, gdigrab_region_wnd_init() *WS_POPUP *is used for CreateWindowEx(), Why? WS_POPUP is not expected for main windows. Is it possible to fix this? Best regards,     Norbert /**  * Initialize the

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/jpeglsenc: Avoid allocation of JLSState

2020-09-05 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 01:17:14AM +0200, Andreas Rheinhardt wrote: > This state is currently allocated and freed for every packet; but it can > just be moved to the stack instead. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeglsenc.c | 26 ++ > 1 file