Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On Wed, Sep 9, 2020 at 6:36 AM James Almer wrote: > This helper removes a side data entry from the packet, maintaining the > integrity and order of the remaining entries, if any. > > Signed-off-by: James Almer > --- > Missing APIChanges entry and version bump. > > Couldn't find a place in the tr

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: add option to set inband FEC

Pushed as 1e5b3f77d9f6f6827b5755763ef041d360969d0c On 08-09-2020 10:32 am, Gyan Doshi wrote: Plan to push in a day. On 06-09-2020 12:27 pm, Gyan Doshi wrote: ---   doc/encoders.texi   | 5 +   libavcodec/libopusenc.c | 9 +   2 files changed, 14 insertions(+) diff --git a/doc/en

Re: [FFmpeg-devel] [PATCH] examples/decode_video: flush parser to fix missing frame

On Tue, Aug 18, 2020 at 8:05 PM wrote: > From: Zhao Zhili > > To reproduce, run decode_video with a single frame sample. No frame > was decoded before the patch. > --- > doc/examples/decode_video.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/example

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevcdec: fix stat_coeff save/load for persistent_rice_adaptation_enabled_flag

Hi Mickaël & all, any suggestions? On Sat, Aug 29, 2020 at 1:52 PM Xu Guangxin wrote: > It's required by 9.3.1. following clips have this feature: > > WPP_HIGH_TP_444_8BIT_RExt_Apple_2.bit > Bitdepth_A_RExt_Sony_1.bin > Bitdepth_B_RExt_Sony_1.bin > EXTPREC_HIGHTHROUGHPUT_444_16_INTRA_10BIT_RExt_

[FFmpeg-devel] [PATCH V3 1/2] avcodec: add av1 hardware acceleration decoder

This av1 decoder is now only used for av1 hardware acceleration decoder. Consider it can be extend to a local decoder like hevc or vp9 in the future, so define its name as "av1" and put it into external libraries codec list. Signed-off-by: Fei Wang --- update: 1. reuse buffer for tile_group_info.

[FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder

Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- Changelog | 1 + configure | 3 + libavcodec/Makefile |

[FFmpeg-devel] [PATCH 1/2] dnn/openvino: support run inference via GPU

for enabling OpenVINO GPU please: 1. install required OpenCL drivers, see: https://github.com/intel/compute-runtime/releases/tag/19.41.14441 2. build OpenVINO c lib with GPU enabled: use cmake config with: -DENABLE_CLDNN=ON 3. then make, and include the OpenVINO c lib in environment variables det

[FFmpeg-devel] [PATCH 2/2] dnn/openvino: add input/output name info

show all input/output names when the input or output name not correct Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_ope

Re: [FFmpeg-devel] [PATCH 25/25] avfilter/af_headphone: Don't check for clipping in separate loop

On Tue, Sep 08, 2020 at 11:18:56PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > More patches will be coming later. > > libavfilter/af_headphone.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > Actually on second look, it does not hurt at al

Re: [FFmpeg-devel] [PATCH 24/25] avfilter/af_headphone: Remove pointless additions

On Tue, Sep 08, 2020 at 11:18:55PM +0200, Andreas Rheinhardt wrote: > buffer_length is a power-of-two and modulo is buffer_length - 1, so that > buffer_length & modulo is zero. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [FFmpeg-devel] [PATCH 23/25] avfilter/af_headphone: Use more appropriate variable name

On Tue, Sep 08, 2020 at 11:18:54PM +0200, Andreas Rheinhardt wrote: > Also unify incrementing the variable containing the pointer > to the currently used HRIR data. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletio

Re: [FFmpeg-devel] [PATCH 22/25] avfilter/af_headphone: Avoid indirection for function pointer

On Tue, Sep 08, 2020 at 11:18:53PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > probably useful ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH 20/25] avfilter/af_headphone: Don't allocate unused element in array

On Tue, Sep 08, 2020 at 11:18:51PM +0200, Andreas Rheinhardt wrote: > The headphone filter uses an array with as many elements as the > filter has inputs to store some per-input information; yet actually it > only stores information for all inputs except the very first one (which > is special for t

Re: [FFmpeg-devel] [PATCH 19/25] avfilter/af_headphone: Only keep one AVFrame at a time

On Tue, Sep 08, 2020 at 11:18:50PM +0200, Andreas Rheinhardt wrote: > Despite the headphone filter only using one AVFrame at a time, it kept > an array each of whose entries contained a pointer to an AVFrame at all > times; the pointers were mostly NULL. This commit instead replaces them > by using

Re: [FFmpeg-devel] [PATCH 18/25] avfilter/af_headphone: Avoid intermediate buffer III

On Tue, Sep 08, 2020 at 11:18:49PM +0200, Andreas Rheinhardt wrote: > The headphone filter allocates a pair of buffers to be used as > intermediate buffers lateron: Before every use they are zeroed, then > some elements of the buffer are set and lateron the complete buffers are > copied into anothe

Re: [FFmpeg-devel] [PATCH 17/25] avfilter/af_headphone: Simplify finding channel index

On Tue, Sep 08, 2020 at 11:18:48PM +0200, Andreas Rheinhardt wrote: > Before this commit, the headphone filter called > av_channel_layout_extract_channel() in a loop in order to find out > the index of a channel (given via its AV_CH_* value) in a channel layout. > This commit changes this to av_get

Re: [FFmpeg-devel] [PATCH 16/25] avfilter/af_headphone: Fix channel assignment

On Tue, Sep 08, 2020 at 11:18:47PM +0200, Andreas Rheinhardt wrote: > The documentation of the map argument of the headphone filter states: > > "Set mapping of input streams for convolution. The argument is a > ’|’-separated list of channel names in order as they are given as > additional stream i

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/extract_extradata: Consolidate zeroing extradata padding

On 9/7/2020 10:17 AM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/extract_extradata_bsf.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/libavcodec/extract_extradata_bsf.c > b/libavcodec/extract_extradata_bsf.c > index 1fead74b

Re: [FFmpeg-devel] [PATCH 15/25] avfilter/af_headphone: Avoid intermediate buffers II

On Tue, Sep 08, 2020 at 11:18:46PM +0200, Andreas Rheinhardt wrote: > When the headphone filter is configured to perform its processing in the > frequency domain, it allocates (among other things) two pairs of > buffers, all of the same size. One pair is used to store data in it > during the initia

Re: [FFmpeg-devel] [PATCH 14/25] avfilter/af_headphone: Avoid intermediate buffers I

On Tue, Sep 08, 2020 at 11:18:45PM +0200, Andreas Rheinhardt wrote: > The headphone filter has two modes; in one of them (say A), it needs > certain buffers to store data. But it allocated them in both modes. > Furthermore when in mode A it also allocated intermediate buffers of the > same size, in

Re: [FFmpeg-devel] [PATCH 12/25] avfilter/af_headphone: Remove unused arrays

On Tue, Sep 08, 2020 at 11:18:43PM +0200, Andreas Rheinhardt wrote: > The delay arrays were never properly initialized, only zero-initialized; > furthermore these arrays duplicate fields in the headphone_inputs > struct. So remove them. > (Btw: The allocations for them have not been checked.) > >

Re: [FFmpeg-devel] [PATCH 13/25] avfilter/af_headphone: Remove delay fields

On Tue, Sep 08, 2020 at 11:18:44PM +0200, Andreas Rheinhardt wrote: > They seem to exist for an option that was never implemented. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) I would prefer if this

Re: [FFmpeg-devel] [PATCH 11/25] avfilter/af_headphone: Avoid duplicating string needlessly

On Tue, Sep 08, 2020 at 11:18:42PM +0200, Andreas Rheinhardt wrote: > The string given by an AVOption that contains the channel assignment > is used only once; ergo it doesn't matter that parsing the string via > av_strtok() is destructive. There is no need to make a copy. > > Signed-off-by: Andre

Re: [FFmpeg-devel] [PATCH 10/25] avfilter/af_headphone: Simplify parsing channel mapping string

On Tue, Sep 08, 2020 at 11:18:41PM +0200, Andreas Rheinhardt wrote: > When parsing the channel mapping string (a string containing '|' > delimited tokens each of which is supposed to contain a channel name > like "FR"), the old code would at each step read up to seven uppercase > characters from th

Re: [FFmpeg-devel] [PATCH 09/25] avfilter/af_headphone: Use uint64_t for channel mapping

On Tue, Sep 08, 2020 at 11:18:40PM +0200, Andreas Rheinhardt wrote: > The headphone filter has an option for the user to specify an assignment > of inputs to channels (or from pairs of channels of the second input to > channels). Up until now, these channels were stored in an int containing > the l

Re: [FFmpeg-devel] [PATCH 01/25] avfilter/af_headphone: Don't use uninitialized buffer in log message

On Tue, Sep 08, 2020 at 11:18:32PM +0200, Andreas Rheinhardt wrote: > This buffer was supposed to be initialized by sscanf(input, "%7[A-Z]%n", > buf, &len), yet if the first input character is not in the A-Z range, > buf is not touched (in particular it needn't be zero-terminated if the > failure h

Re: [FFmpeg-devel] [PATCH 21/25] avfilter/af_headphone: Avoid allocating array

On Tue, Sep 08, 2020 at 11:18:52PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > ok ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] [PATCH 25/25] avfilter/af_headphone: Don't check for clipping in separate loop

On Tue, Sep 08, 2020 at 11:18:56PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > More patches will be coming later. > > libavfilter/af_headphone.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/libavfilter/af_headphone.c b/liba

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fastaudio: Remove redundant % 32

On Tue, Sep 08, 2020 at 11:29:20PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/fastaudio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels

On Tue, Sep 08, 2020 at 11:29:19PM +0200, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256 > Fixes: > 25433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-6215671900536832 >

Re: [FFmpeg-devel] [PATCH 06/25] avfilter/af_headphone: Fix stack buffer overflow

On Tue, Sep 08, 2020 at 11:18:37PM +0200, Andreas Rheinhardt wrote: > The number of channels can be up to 64, not only 16. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_headphone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > LGTM ___

Re: [FFmpeg-devel] [PATCH 05/25] avfilter/af_headphone: Don't overrun array

On Tue, Sep 08, 2020 at 11:18:36PM +0200, Andreas Rheinhardt wrote: > The headphone filter stores the channel position of the ith HRIR stream > in the ith element of an array of 64 elements; but because there is no > check for duplicate channels, it is easy to write beyond the end of the > array by

Re: [FFmpeg-devel] [PATCH 04/25] avfilter/af_headphone: Fix segfault when using very short streams

On Tue, Sep 08, 2020 at 11:18:35PM +0200, Andreas Rheinhardt wrote: > When the headphone filter does its processing in the time domain, > the lengths of the buffers involved are determined by three parameters, > only two of which are relevant here: ir_len and air_len. The former is > the length (in

[FFmpeg-devel] [PATCH v2 2/4] avformat/argo_asf: split functionality into a header

For future use by the argo_brp demuxer. Adds: - void ff_argo_asf_parse_file_header(ArgoASFFileHeader *hdr, const uint8_t *buf); - int ff_argo_asf_validate_file_header(AVFormatContext *s, const ArgoASFFileHeader *hdr); - void ff_argo_asf_parse_chunk_header(ArgoASFChunkHeader *hdr, const ui

[FFmpeg-devel] [PATCH v2 4/4] avformat: add Argonaut Games BRP demuxer

Used in FMVs for FX Fighter and Croc. Supports BVID and BASF streams, requests samples for anything else. Due to the way BASF streams are contained in the file, only one is supported. I have yet to see a BRP file with multiple. Signed-off-by: Zane van Iperen --- Changelog| 1 +

[FFmpeg-devel] [PATCH v2 3/4] avformat/argo_asf: add ASF_MIN_BUFFER_SIZE #define

For future use by the argo_brp demuxer Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 2 +- libavformat/argo_asf.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index ee8c85f735..c131207aa1 100644 --- a/libavfor

[FFmpeg-devel] [PATCH v2 1/4] avformat/argo_asf: bail if invalid tag

Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index bf9b5d0c0a..208280b4d9 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -144,6 +144,9 @@ static int argo_asf_re

[FFmpeg-devel] [PATCH v2 0/4] Add demuxer for Argonaut Games BRP files

Adds support for demuxing BRP files from Argonaut Games' games. Used to store the FMVs. v2: [1] - Don't add AV_CODEC_ID_ARGO descriptor, use AV_CODEC_ID_NONE instead. [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-September/269332.html Zane van Iperen (4): avformat/argo_asf: bail if inval

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On 9/8/2020 7:42 PM, Andreas Rheinhardt wrote: > James Almer: >> This helper removes a side data entry from the packet, maintaining the >> integrity and order of the remaining entries, if any. >> >> Signed-off-by: James Almer >> --- >> Missing APIChanges entry and version bump. >> >> Couldn't find

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

James Almer: > This helper removes a side data entry from the packet, maintaining the > integrity and order of the remaining entries, if any. > > Signed-off-by: James Almer > --- > Missing APIChanges entry and version bump. > > Couldn't find a place in the tree where it could be used right now,

[FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

This helper removes a side data entry from the packet, maintaining the integrity and order of the remaining entries, if any. Signed-off-by: James Almer --- Missing APIChanges entry and version bump. Couldn't find a place in the tree where it could be used right now, but it makes the API be more

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/fastaudio: Bugfixes

here are some mobiclib files for you to shake a stick at. mobiclip_files ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

[FFmpeg-devel] [PATCH 0/3] avcodec/fastaudio: Bugfixes

These patches fix a few bugs found by the fuzzer or while fixing such bugs. The changes are not tested against any fastaudio data as i failed to find any looking at the fate samples, sample archive and patches adding fastaudi support If you have samples, please provide links so i can test this t

[FFmpeg-devel] [PATCH 3/3] avcodec/fastaudio: Fix invalid shift exponent

Fixes: shift exponent 32 is too large for 32-bit type 'unsigned int' Fixes: 25434/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-6252363168612352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

[FFmpeg-devel] [PATCH 2/3] avcodec/fastaudio: Remove redundant % 32

Signed-off-by: Michael Niedermayer --- libavcodec/fastaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fastaudio.c b/libavcodec/fastaudio.c index 34857d1b88..16f44790f5 100644 --- a/libavcodec/fastaudio.c +++ b/libavcodec/fastaudio.c @@ -95,7 +95,7 @@ static

[FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels

Fixes: division by 0 Fixes: 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256 Fixes: 25433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-6215671900536832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/mas

[FFmpeg-devel] [PATCH 23/25] avfilter/af_headphone: Use more appropriate variable name

Also unify incrementing the variable containing the pointer to the currently used HRIR data. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index

[FFmpeg-devel] [PATCH 24/25] avfilter/af_headphone: Remove pointless additions

buffer_length is a power-of-two and modulo is buffer_length - 1, so that buffer_length & modulo is zero. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c in

[FFmpeg-devel] [PATCH 25/25] avfilter/af_headphone: Don't check for clipping in separate loop

Signed-off-by: Andreas Rheinhardt --- More patches will be coming later. libavfilter/af_headphone.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index 03ef88c4a4..edf8e773d7 100644 --- a/libavfilter/af_head

[FFmpeg-devel] [PATCH 20/25] avfilter/af_headphone: Don't allocate unused element in array

The headphone filter uses an array with as many elements as the filter has inputs to store some per-input information; yet actually it only stores information for all inputs except the very first one (which is special for this filter). Therefore this commit modifies the code to remove this unused e

[FFmpeg-devel] [PATCH 22/25] avfilter/af_headphone: Avoid indirection for function pointer

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index 2d2b57d819..8b0a431c45 100644 --- a/libavfilter/af_headphone.c +++ b/libavfilter/af_he

[FFmpeg-devel] [PATCH 21/25] avfilter/af_headphone: Avoid allocating array

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index bbbe32a475..2d2b57d819 100644 --- a/libavfilter/af_headphone.c +++ b/libavfilter/af_headphone.c

[FFmpeg-devel] [PATCH 19/25] avfilter/af_headphone: Only keep one AVFrame at a time

Despite the headphone filter only using one AVFrame at a time, it kept an array each of whose entries contained a pointer to an AVFrame at all times; the pointers were mostly NULL. This commit instead replaces them by using a single pointer to an AVFrame on the stack of the only function that actua

[FFmpeg-devel] [PATCH 15/25] avfilter/af_headphone: Avoid intermediate buffers II

When the headphone filter is configured to perform its processing in the frequency domain, it allocates (among other things) two pairs of buffers, all of the same size. One pair is used to store data in it during the initialization of the filter; the other pair is only allocated lateron. It is zero

[FFmpeg-devel] [PATCH 14/25] avfilter/af_headphone: Avoid intermediate buffers I

The headphone filter has two modes; in one of them (say A), it needs certain buffers to store data. But it allocated them in both modes. Furthermore when in mode A it also allocated intermediate buffers of the same size, initialized them, copied their contents into the permanent buffers and freed t

[FFmpeg-devel] [PATCH 17/25] avfilter/af_headphone: Simplify finding channel index

Before this commit, the headphone filter called av_channel_layout_extract_channel() in a loop in order to find out the index of a channel (given via its AV_CH_* value) in a channel layout. This commit changes this to av_get_channel_layout_channel_index() instead. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 16/25] avfilter/af_headphone: Fix channel assignment

The documentation of the map argument of the headphone filter states: "Set mapping of input streams for convolution. The argument is a ’|’-separated list of channel names in order as they are given as additional stream inputs for filter." Yet this has not been honoured at all. Instead for the kth

[FFmpeg-devel] [PATCH 13/25] avfilter/af_headphone: Remove delay fields

They seem to exist for an option that was never implemented. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index f9799d8548..f862181cbb 1006

[FFmpeg-devel] [PATCH 18/25] avfilter/af_headphone: Avoid intermediate buffer III

The headphone filter allocates a pair of buffers to be used as intermediate buffers lateron: Before every use they are zeroed, then some elements of the buffer are set and lateron the complete buffers are copied into another, bigger buffer. These intermediate buffers are unnecessary as the data can

[FFmpeg-devel] [PATCH 11/25] avfilter/af_headphone: Avoid duplicating string needlessly

The string given by an AVOption that contains the channel assignment is used only once; ergo it doesn't matter that parsing the string via av_strtok() is destructive. There is no need to make a copy. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 9 ++--- 1 file changed,

[FFmpeg-devel] [PATCH 12/25] avfilter/af_headphone: Remove unused arrays

The delay arrays were never properly initialized, only zero-initialized; furthermore these arrays duplicate fields in the headphone_inputs struct. So remove them. (Btw: The allocations for them have not been checked.) Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 11 ++--

[FFmpeg-devel] [PATCH 10/25] avfilter/af_headphone: Simplify parsing channel mapping string

When parsing the channel mapping string (a string containing '|' delimited tokens each of which is supposed to contain a channel name like "FR"), the old code would at each step read up to seven uppercase characters from the input string and give this to av_get_channel_layout() to parse. The return

[FFmpeg-devel] [PATCH 09/25] avfilter/af_headphone: Use uint64_t for channel mapping

The headphone filter has an option for the user to specify an assignment of inputs to channels (or from pairs of channels of the second input to channels). Up until now, these channels were stored in an int containing the logarithm of the channel layout. Yet it is not the logarithm that is used lat

[FFmpeg-devel] [PATCH 04/25] avfilter/af_headphone: Fix segfault when using very short streams

When the headphone filter does its processing in the time domain, the lengths of the buffers involved are determined by three parameters, only two of which are relevant here: ir_len and air_len. The former is the length (in samples) of the longest HRIR input stream and the latter is the smallest po

[FFmpeg-devel] [PATCH 06/25] avfilter/af_headphone: Fix stack buffer overflow

The number of channels can be up to 64, not only 16. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index 99bdefbcff..42adc82df8 100644 --- a/libavfilter/

[FFmpeg-devel] [PATCH 08/25] avfilter/af_headphone: Only attempt once to init coeffs

The headphone filter does most of its initialization after its init function, because it can perform certain tasks only after all but its first input streams have reached eof. When this happens, it allocates certain buffers and errors out if an allocation fails. Yet the filter didn't check whether

[FFmpeg-devel] [PATCH 02/25] avfilter/af_headphone: Remove always true check

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index e590d02eff..1024ff57b1 100644 --- a/libavfilter/af_headphone.c +++ b/libavfilter/af_headphone.c @@ -631,10 +631,8 @@

[FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Not providing any samples makes no sense at all. And if no samples were provided for one of the HRIR streams, one would either run into an av_assert1 in ff_inlink_consume_samples() or into a segfault in take_samples() in avfilter.c. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.

[FFmpeg-devel] [PATCH 01/25] avfilter/af_headphone: Don't use uninitialized buffer in log message

This buffer was supposed to be initialized by sscanf(input, "%7[A-Z]%n", buf, &len), yet if the first input character is not in the A-Z range, buf is not touched (in particular it needn't be zero-terminated if the failure happened when parsing the first channel and it still contains the last channe

[FFmpeg-devel] [PATCH 07/25] avfilter/af_headphone: Combine several loops when checking for EOF

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_headphone.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index 42adc82df8..c71f43c5c8 100644 --- a/libavfilter/af_headphone.c +++ b/libavfi

[FFmpeg-devel] [PATCH 05/25] avfilter/af_headphone: Don't overrun array

The headphone filter stores the channel position of the ith HRIR stream in the ith element of an array of 64 elements; but because there is no check for duplicate channels, it is easy to write beyond the end of the array by simply repeating channels. This commit adds a check for duplicate channels

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

On 9/8/2020 3:36 PM, Nicolas George wrote: > James Almer (12020-09-08): >> You should use the stdint.h UINT64_C macro then, instead of casting. > > I probably *could*. But I find casting more readable. What benefit do > you see to them compared to casting? It's a macro designed for this specific

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

James Almer (12020-09-08): > You should use the stdint.h UINT64_C macro then, instead of casting. I probably *could*. But I find casting more readable. What benefit do you see to them compared to casting? Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

On 9/8/2020 3:19 PM, Nicolas George wrote: > Andreas Rheinhardt (12020-09-08): >> Using ULL would be shorter. > > But it would be wrong, it could be more than 64 bits. For modern C, > using longs and shorts directly is a mistake (or the consequence of > dealing with an obsolescent library), these

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

Andreas Rheinhardt (12020-09-08): > Using ULL would be shorter. But it would be wrong, it could be more than 64 bits. For modern C, using longs and shorts directly is a mistake (or the consequence of dealing with an obsolescent library), these types are used internally to implement the sane types

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

Nicolas George: > Fix CID 146. > > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c > index 9338969bf1..58848941d4 100644 > --- a/libavfilter/buffer

[FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

Fix CID 146. Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 9338969bf1..58848941d4 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.

Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

On Mon, 7 Sep 2020, Zhao Zhili wrote: On Aug 27, 2020, at 4:20 PM, Marton Balint wrote: On Thu, 27 Aug 2020, Zhao Zhili wrote: --- Goto fail will make ffplay exit immediately. I'm not sure it is the expected behavior. How about just remove the check on pb->error so decoders can drain

Re: [FFmpeg-devel] [PATCH 7/8] avfilter/vf_showinfo: use av_timecode_make_smpte_tc_string2

On Sun, 6 Sep 2020, lance.lmw...@gmail.com wrote: On Sat, Sep 05, 2020 at 08:22:16PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/vf_showinfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_sh

[FFmpeg-devel] [PATCH 4/4] avdevice/decklink_dec: add support for querying RP188 High Frame Rate timecode

Signed-off-by: Marton Balint --- doc/indevs.texi | 4 ++-- libavdevice/decklink_common.h | 5 + libavdevice/decklink_common_c.h | 2 ++ libavdevice/decklink_dec_c.c| 5 - 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.tex

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink_commoh.h: remove unsupported decklink version ifdef

Signed-off-by: Marton Balint --- libavdevice/decklink_common.h | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/decklink_common.h b/libavdevice/decklink_common.h index bd68c7ba77..9f69054e64 100644 --- a/libavdevice/decklink_common.h +++ b/libavdevice/decklink_common.h @@ -156,1

[FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: add support for rgb/yuv pixel format autodetection

Signed-off-by: Marton Balint --- doc/indevs.texi | 15 +++ libavdevice/decklink_dec.cpp | 8 +++- libavdevice/decklink_dec_c.c | 3 ++- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 4d2312e201..7748232b26 100

[FFmpeg-devel] [PATCH 2/4] avdevice/decklink_dec: use decklink_ctx->raw_format as bmdPixelFormat

Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 6 +++--- libavdevice/decklink_dec.cpp| 9 ++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index 53b57ffe4e..8b58ede1ef 100644 --- a/li

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: allow qsv decoders to use initialized device

On Sun, 2020-09-06 at 15:25 +0100, Mark Thompson wrote: > On 04/09/2020 19:24, Rogozhkin, Dmitry V wrote: > > On Thu, 2020-09-03 at 01:02 +, Rogozhkin, Dmitry V wrote: > > > > > > > > (If you do implement it then you can delete all of the ad-hoc > > > > treatment in ffmpeg, like has been done

[FFmpeg-devel] [PATCH] tools/make_chlayout_test: use newer pan syntax.

The syntax with : was deprecated and no longer works. Signed-off-by: Nicolas George --- tools/make_chlayout_test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/make_chlayout_test b/tools/make_chlayout_test index fcdbda3b73..c310def850 100755 --- a/tools/make_chlayout_t

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

I will add the test by the end of this week. Thanks, Mohammad On Mon, Sep 7, 2020 at 2:56 AM Jan Ekström wrote: > On Sat, Jul 25, 2020 at 12:09 AM Mohammad Izadi > wrote: > > > > On Fri, Jul 24, 2020 at 9:30 AM Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > > > Mohammad Iz

Re: [FFmpeg-devel] Request for immediate take of action

Jean-Baptiste Kempf (12020-09-08): > I think the explanation is quite aggressive and has absolutely nothing > to do inside a git log, to be honest. > > The fact that you disagree on the commit is fine, but being passive > aggressive on a commit log is not OK, in my humble opinion. Especially > whe

Re: [FFmpeg-devel] Request for immediate take of action

On Tue, 8 Sep 2020, at 15:17, Nicolas George wrote: > Paul B Mahol (12020-09-08): > > Nicolas George reverted one of my reviewed commits without proper > > explanation why it is faulty. > > The explanation is in the commit message, and your patch was not > reviewed and you should never have pushed

Re: [FFmpeg-devel] [PATCH] examples/decode_video: flush parser to fix missing frame

Please help review the patch, thanks. > On Aug 18, 2020, at 7:59 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > To reproduce, run decode_video with a single frame sample. No frame > was decoded before the patch. > --- > doc/examples/decode_video.c | 12 +++- > 1 file changed,

[FFmpeg-devel] [PATCH v2 2/2] avformat/rtsp: fix parse_rtsp_message

1. Remove the assumption that the message method is TEARDOWN. 2. Don't ignore the error code of ff_rtsp_parse_streaming_commands. --- libavformat/rtsp.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 597413803f..3e69ab7287 100

[FFmpeg-devel] [PATCH v2 1/2] avformat/rtsp: fix infinite loop with udp transport

sender: ./ffmpeg -i test.mp4 -c copy -f rtsp -rtsp_transport udp rtsp://localhost:12345/live.sdp receiver: ./ffmpeg_g -y -rtsp_flags listen -timeout 100 -i rtsp://localhost:12345/live.sdp -c copy test.mp4 --- libavformat/rtsp.c| 2 ++ libavformat/rtsp.h| 1 + libavformat/rtspdec.c | 2

Re: [FFmpeg-devel] [PATCH v3 3/4] lavfi: check the validity of formats lists.

Nicolas George: > Moritz Barsnick (12020-08-28): >> "case" indentation is too large. > > Thanks. > > Fixed, rebased and series pushed. > > Regards, > > Seems like this patchset broke compilation with some old versions of GCC. See http://fate.ffmpeg.org/history.cgi?slot=x86_64-openbsd5.6-gcc4.2

Re: [FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

> On 8 Sep 2020, at 14:29, Gyan Doshi wrote: > > On 08-09-2020 06:23 pm, Harry Mallon wrote: >> >> >>> On 8 Sep 2020, at 13:08, Gyan Doshi wrote: >>> >>> Hi Harry, >>> >>> On 06-09-2020 04:24 pm, Gyan Doshi wrote: On 06-09-2020 02:59 pm, Harry Mallon wrote: > Is there anythi

Re: [FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

On 08-09-2020 06:23 pm, Harry Mallon wrote: On 8 Sep 2020, at 13:08, Gyan Doshi wrote: Hi Harry, On 06-09-2020 04:24 pm, Gyan Doshi wrote: On 06-09-2020 02:59 pm, Harry Mallon wrote: Is there anything I need to do to move this forwards? I think it is relatively uncontroversial? Agree

Re: [FFmpeg-devel] Request for immediate take of action

Paul B Mahol (12020-09-08): > It was reviewed on IRC. Nobody complained about it. Show the relevant excerpt of log. Non-trivial reviews should happen on the mailing-list anyway. > The explanation in commit log is very cryptic. I do not owe you my time. All the information is there. Ask specific

Re: [FFmpeg-devel] Request for immediate take of action

On Tue, Sep 08, 2020 at 03:17:15PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-08): > > Nicolas George reverted one of my reviewed commits without proper > > explanation why it is faulty. > > The explanation is in the commit message, and your patch was not > reviewed and you should never

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

On Fri, Sep 04, 2020 at 00:59:46 +0200, Lynne wrote: > > Fixes: 4907 > > > > Adds support for decoding of animated WebP. > Sorry it took me so long to get to this. > Took a look and the patch looks fine to me. > Will apply in a few days unless someone else has comments or I find something > I > m

Re: [FFmpeg-devel] Request for immediate take of action

Paul B Mahol (12020-09-08): > Nicolas George reverted one of my reviewed commits without proper > explanation why it is faulty. The explanation is in the commit message, and your patch was not reviewed and you should never have pushed it in the first place. -- Nicolas George signature.asc De

[FFmpeg-devel] Request for immediate take of action

Hi, Nicolas George reverted one of my reviewed commits without proper explanation why it is faulty. I kindly ask Nicolas George to review this patch and explain what is wrong with it. If not, I will be forced to either revert this revert or take more actions to Technical Committee. Regards. __

Re: [FFmpeg-devel] [PATCH] lavfi/vsrc_testsrc: switch to activate.

Paul B Mahol (12020-07-07): > Why this was never applied? I don't know. Did you bother to review it? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinf

  1   2   >