Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-09-20 Thread myp...@gmail.com
On Mon, Sep 21, 2020 at 1:27 AM Gyan Doshi wrote: > > > > On 17-09-2020 01:07 pm, Gyan Doshi wrote: > > > > > > On 15-09-2020 12:47 pm, myp...@gmail.com wrote: > >> On Tue, Sep 15, 2020 at 2:23 PM Gyan Doshi wrote: > >>> This should be backported to 4.3 and other releases whose builds fail. >

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-09-20 Thread myp...@gmail.com
On Mon, Sep 21, 2020 at 1:27 AM Gyan Doshi wrote: > > > > On 17-09-2020 01:07 pm, Gyan Doshi wrote: > > > > > > On 15-09-2020 12:47 pm, myp...@gmail.com wrote: > >> On Tue, Sep 15, 2020 at 2:23 PM Gyan Doshi wrote: > >>> This should be backported to 4.3 and other releases whose builds fail. >

Re: [FFmpeg-devel] [PATCH 21/21] avformat/dashdec: Avoid duplicating string

2020-09-20 Thread Steven Liu
> 2020年9月20日 上午12:36,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > There is still stuff left to fix in this demuxer after this patchset: > 1. resolve_content_path() is in bad shape; i.e. it can try to read > str[-1]. > 2. One can get a crash in get_current_fragment()

Re: [FFmpeg-devel] [PATCH] configure: Add atsc_a53 dependencies for H.264 and HEVC parser

2020-09-20 Thread James Almer
On 9/19/2020 3:18 PM, Andreas Rheinhardt wrote: > They need it because they make use of SEI parsing code. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 5d68695192..70740a7bc7

Re: [FFmpeg-devel] [PATCH] configure: Add atsc_a53 dependencies for H.264 and HEVC parser

2020-09-20 Thread Carl Eugen Hoyos
Am Sa., 19. Sept. 2020 um 20:18 Uhr schrieb Andreas Rheinhardt : > > They need it because they make use of SEI parsing code. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH 1/4] avformat/wvdec: Check rate for overflow

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:26:05PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 6000 * -2147483648 cannot be represented in > type 'int' > Fixes: > 25700/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6578316302352384 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check for EOF in first loop in track_header()

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:26:06PM +0200, Michael Niedermayer wrote: > Fixes: timeout (243sec -> a few ms) > Fixes: > 25716/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5764093666131968 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/moflex: Check pop_int() for overflow

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:26:07PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2 * 2132811776 cannot be represented in type > 'int' > Fixes: > 25722/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6221704077246464 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/photocd: Use ff_set_dimensions()

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:26:08PM +0200, Michael Niedermayer wrote: > Fixes: out of memory > Fixes: > 25588/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PHOTOCD_fuzzer-6612945080156160 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/4 v2] ffmpeg: move A/V non-streamcopy initialization to a later point

2020-09-20 Thread Jan Ekström
On Wed, Sep 16, 2020 at 1:20 PM Jan Ekström wrote: > > On Wed, Sep 16, 2020 at 12:24 AM Michael Niedermayer > wrote: > > > > On Mon, Sep 14, 2020 at 12:33:14AM +0300, Jan Ekström wrote: > > > - For video, this means a single initialization point in do_video_out. > > > - For audio we

[FFmpeg-devel] [PATCH 1/4] avformat/wvdec: Check rate for overflow

2020-09-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 6000 * -2147483648 cannot be represented in type 'int' Fixes: 25700/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6578316302352384 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check for EOF in first loop in track_header()

2020-09-20 Thread Michael Niedermayer
Fixes: timeout (243sec -> a few ms) Fixes: 25716/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5764093666131968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 2 ++ 1

[FFmpeg-devel] [PATCH 3/4] avformat/moflex: Check pop_int() for overflow

2020-09-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 2 * 2132811776 cannot be represented in type 'int' Fixes: 25722/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6221704077246464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 4/4] avcodec/photocd: Use ff_set_dimensions()

2020-09-20 Thread Michael Niedermayer
Fixes: out of memory Fixes: 25588/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PHOTOCD_fuzzer-6612945080156160 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/photocd.c | 5 +++-- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-20 Thread Jan Ekström
On Thu, Sep 10, 2020 at 3:00 AM James Almer wrote: > > On 9/9/2020 7:54 PM, Michael Niedermayer wrote: > > On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: > >> Actually write it in yuv4_write_header() instead of with the first > >> packet. > >> > >> Signed-off-by: James Almer > >>

Re: [FFmpeg-devel] [PATCH v3] avutil/pixfmt: improve definition of AVColorRange

2020-09-20 Thread Jan Ekström
On Sun, Sep 20, 2020 at 9:34 PM Vittorio Giovara wrote: > > On Sun, Sep 20, 2020 at 7:12 PM Jan Ekström wrote: > > > As it was brought up that the current documentation leaves things > > as specific to YCbCr only, ICtCp and RGB are now mentioned. > > Additionally, the specifications on which

Re: [FFmpeg-devel] [PATCH v3] avutil/pixfmt: improve definition of AVColorRange

2020-09-20 Thread Vittorio Giovara
On Sun, Sep 20, 2020 at 7:12 PM Jan Ekström wrote: > As it was brought up that the current documentation leaves things > as specific to YCbCr only, ICtCp and RGB are now mentioned. > Additionally, the specifications on which these definitions of > narrow and full range are defined are mentioned.

Re: [FFmpeg-devel] Request for immediate take of action

2020-09-20 Thread Paul B Mahol
On Tue, Sep 08, 2020 at 03:28:06PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-08): > > It was reviewed on IRC. Nobody complained about it. > > Show the relevant excerpt of log. Non-trivial reviews should happen on > the mailing-list anyway. > > > The explanation in commit log is very

Re: [FFmpeg-devel] [PATCH] avformat/aaxdec: Fix potential integer overflow

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 06:16:57PM +0200, Andreas Rheinhardt wrote: > The AAX demuxer reads a 32bit number containing the amount of entries > of an array and stores it in an uint32_t. Yet when iterating over this > array, a loop counter of type int is used. This leads to undefined > behaviour if

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-09-20 Thread Gyan Doshi
On 17-09-2020 01:07 pm, Gyan Doshi wrote: On 15-09-2020 12:47 pm, myp...@gmail.com wrote: On Tue, Sep 15, 2020 at 2:23 PM Gyan Doshi wrote: This should be backported to 4.3 and other releases whose builds fail. Gyan Will backporting, thx Ping. 4.3.1 build with libsrt remains broken.

[FFmpeg-devel] [PATCH 3/4] avcodec/cbs_av1: add an option to select an operating point

2020-09-20 Thread James Almer
This implements the function drop_obu() as defined in Setion 6.2.1 from the spec. In a reading only scenario, units that belong to an operating point the caller doesn't want should not be parsed. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 18 +-

[FFmpeg-devel] [PATCH 4/4] avcodec/av1dec: add an option to select an operating point

2020-09-20 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 36 libavcodec/av1dec.h | 7 +++ 2 files changed, 43 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 0bb04a3e44..178fbdc2f0 100644 --- a/libavcodec/av1dec.c +++

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs: add an AVClass to CodedBitstreamType for option handling

2020-09-20 Thread James Almer
So unit parsing may be configured with caller set options. Signed-off-by: James Almer --- libavcodec/cbs.c | 9 + libavcodec/cbs_internal.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index 7c1aa005c2..e73e18f398 100644 ---

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs: allow cbs_read_fragment_content() to discard units

2020-09-20 Thread James Almer
The caller may not need all units in a fragment in reading only scenarios. They could in fact alter global state stored in the private CodedBitstreamType fields in an undesirable way. And unlike preventing decomposition of units, discarding can be done based on parsed values within the unit.

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase default read buffer size to 2*max_buffer_size for streamed data

2020-09-20 Thread Marton Balint
On Sun, 20 Sep 2020, Michael Niedermayer wrote: On Sun, Sep 20, 2020 at 10:52:53AM +0200, Marton Balint wrote: This should increase the effectiveness of ffio_ensure_seekback. Note: increasing buffer size to non-streamed or write buffer should also work, but they both cause fate failures...

[FFmpeg-devel] [PATCH v3] avutil/pixfmt: improve definition of AVColorRange

2020-09-20 Thread Jan Ekström
As it was brought up that the current documentation leaves things as specific to YCbCr only, ICtCp and RGB are now mentioned. Additionally, the specifications on which these definitions of narrow and full range are defined are mentioned. This way, the documentation of AVColorRange should now

[FFmpeg-devel] [PATCH 4/5] avformat/movenc: use more fall-back values for average bit rate fields

2020-09-20 Thread Jan Ekström
If the average bit rate cannot be calculated, such as in the case of streamed fragmented mp4, utilize various available parameters in priority order. Tests are updated where the esds or btrt or ISML manifest boxes' output changes. --- libavformat/movenc.c | 17 +

[FFmpeg-devel] [PATCH 5/5] avformat/movenc: simplify ISML manifest bit rate setting

2020-09-20 Thread Jan Ekström
The newly calculated average bit rate value is pretty much what is being done here. --- libavformat/movenc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 0f14e255e9..35d028e6de 100644 ---

[FFmpeg-devel] [PATCH 2/5] avformat/movenc: utilize the maximum bit rate in ISML writing

2020-09-20 Thread Jan Ekström
This way we have a single location in movenc which utilizes the CPB properties. --- libavformat/movenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 1962f2..31e1ac1589 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 3/5] avformat/movenc: implement writing of the btrt box

2020-09-20 Thread Jan Ekström
This is utilized by various media ingests to figure out the bit rate of the content you are pushing towards it, so write it by default for video, audio and subtitle tracks. It is only mentioned for timed metadata sample descriptions in QTFF, so limit it only to ISOBMFF (MODE_MP4). Updates the

[FFmpeg-devel] [PATCH 1/5] avformat/movenc: split MPEG-4 bit rate value calculation

2020-09-20 Thread Jan Ekström
This can now be re-utilized in other places. --- libavformat/movenc.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 12471c7d68..1962f2 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 0/5] avformat/movenc: btrt box support

2020-09-20 Thread Jan Ekström
Various media ingest servers read the incoming stream's advertised bit rate from this box. As it is only defined for timed metadata tracks in QTFF, limit it to just MODE_MP4 (ISOBMFF) for now. Unifies the MPEG-4 bit rate value calculation, and attempts to utilize it everywhere matching. Jan

[FFmpeg-devel] [PATCH] avformat/aaxdec: Fix potential integer overflow

2020-09-20 Thread Andreas Rheinhardt
The AAX demuxer reads a 32bit number containing the amount of entries of an array and stores it in an uint32_t. Yet when iterating over this array, a loop counter of type int is used. This leads to undefined behaviour if the amount of entries is not in the range of int; to avoid this, it is

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: fix typo in comments

2020-09-20 Thread Michael Niedermayer
On Fri, Sep 18, 2020 at 10:33:37PM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 8c1243b48d..9fc0db24d5 100644 > --- a/libavformat/mov.c > +++

Re: [FFmpeg-devel] [PATCH 2/6] avformat/wc3movie: Cleanup on wc3_read_header() failure

2020-09-20 Thread Michael Niedermayer
On Sat, Sep 19, 2020 at 10:34:46AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sun, Jul 19, 2020 at 07:55:24PM +0200, Andreas Rheinhardt wrote: > >> James Almer: > >>> On 7/19/2020 2:42 PM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/ansi: Check nb_args for overflow

2020-09-20 Thread Michael Niedermayer
On Sat, Sep 19, 2020 at 09:47:45PM +0200, Paul B Mahol wrote: > On Sat, Sep 19, 2020 at 09:31:08PM +0200, Michael Niedermayer wrote: > > Fixes: Integer overflow (no testcase) > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ansi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_scale: translate and verify swscale internal range flag

2020-09-20 Thread Jan Ekström
On Sun, Sep 20, 2020 at 6:03 PM Michael Niedermayer wrote: > > On Sun, Sep 20, 2020 at 01:36:56PM +0300, Jan Ekström wrote: > > This value - while it looks like the actual range of the content - > > is nothing but the internal value of swscale. > > > > Thus, if we have RGB content, translate the

Re: [FFmpeg-devel] [PATCH 3/3] avformat/swf: Separate mux and demux contexts

2020-09-20 Thread Michael Niedermayer
On Sun, Sep 20, 2020 at 01:53:41PM +0200, Andreas Rheinhardt wrote: > There was almost no overlap between them: The only field used by both > was an int named samples_per_frame. Therefore this commit separates > them. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/swf.h| 33

Re: [FFmpeg-devel] [PATCH 2/3] avdevice/lavfi: unref the frame on failure

2020-09-20 Thread Nicolas George
lance.lmw...@gmail.com (12020-09-18): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavdevice/lavfi.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) LGTM, thanks. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 3/3] avdevice/lavfi: av_malloc -> av_malloc_array

2020-09-20 Thread Nicolas George
lance.lmw...@gmail.com (12020-09-18): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavdevice/lavfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/lavfi: fix FIXME and check a/v type by codec_type

2020-09-20 Thread Nicolas George
lance.lmw...@gmail.com (12020-09-18): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavdevice/lavfi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) LGTM, thanks. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase default read buffer size to 2*max_buffer_size for streamed data

2020-09-20 Thread Michael Niedermayer
On Sun, Sep 20, 2020 at 10:52:53AM +0200, Marton Balint wrote: > This should increase the effectiveness of ffio_ensure_seekback. > > Note: increasing buffer size to non-streamed or write buffer should also > work, but they both cause fate failures... The reason for that should be > checked. > >

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_scale: translate and verify swscale internal range flag

2020-09-20 Thread Michael Niedermayer
On Sun, Sep 20, 2020 at 01:36:56PM +0300, Jan Ekström wrote: > This value - while it looks like the actual range of the content - > is nothing but the internal value of swscale. > > Thus, if we have RGB content, translate the value to 1 which is what > at least this filter expects for RGB.

Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Nicolas George
Andreas Rheinhardt (12020-09-20): > parse_string() checks for this (for the content, not the labels, where > the check is unnecessary). Oh, even better. Then ok without reservation. -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2] avutil/pixfmt: improve definition of AVColorRange

2020-09-20 Thread Jan Ekström
On Sun, Sep 20, 2020 at 5:50 PM Michael Niedermayer wrote: > > On Sat, Sep 19, 2020 at 02:42:01PM +0300, Jan Ekström wrote: > > As it was brought up that the current documentation leaves things > > as specific to YCbCr only, ICtCp and RGB are now mentioned. > > Additionally, the specifications on

Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-09-20): >> The tedcaptions demuxer uses an AVBPrint whose string is not restricted >> to its internal buffer; it therefore needs to be cleaned up, yet this is >> not done on error, as parse_file() returned simply returned directly. >> This is fixed by

[FFmpeg-devel] [PATCH] tests/fate-run: Always overwrite output files for md5 tests

2020-09-20 Thread Andreas Rheinhardt
Otherwise the result of such tests will not accurately reflect the current state. Signed-off-by: Andreas Rheinhardt --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 1b283e9c35..58d5fdbb60 100755 ---

Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Nicolas George
Andreas Rheinhardt (12020-09-20): > The tedcaptions demuxer uses an AVBPrint whose string is not restricted > to its internal buffer; it therefore needs to be cleaned up, yet this is > not done on error, as parse_file() returned simply returned directly. > This is fixed by going to fail first in

Re: [FFmpeg-devel] [PATCH v2] avutil/pixfmt: improve definition of AVColorRange

2020-09-20 Thread Michael Niedermayer
On Sat, Sep 19, 2020 at 02:42:01PM +0300, Jan Ekström wrote: > As it was brought up that the current documentation leaves things > as specific to YCbCr only, ICtCp and RGB are now mentioned. > Additionally, the specifications on which these definitions of > narrow and full range are defined are

[FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Andreas Rheinhardt
The tedcaptions demuxer uses an AVBPrint whose string is not restricted to its internal buffer; it therefore needs to be cleaned up, yet this is not done on error, as parse_file() returned simply returned directly. This is fixed by going to fail first in such cases. Furthermore, there is also a

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Timo Rothenpieler
Consider just not using libwavpack at all. The ffmpeg native wavpack code has more features. There even is a patch on this list for its removal. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread James Almer
On 9/20/2020 8:52 AM, Bernd Kuhls wrote: > Fixes static builds with toolchains needing "-lm" for math functions. > > Signed-off-by: Bernd Kuhls > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 5d68695192..4e6c6edd30 100755

Re: [FFmpeg-devel] [PATCH 2/3] avformat/aviobuf: fix checks in ffio_ensure_seekback

2020-09-20 Thread Marton Balint
On Sun, 20 Sep 2020, Paul B Mahol wrote: On Sun, Sep 20, 2020 at 03:16:15PM +0200, Marton Balint wrote: On Sun, 20 Sep 2020, Paul B Mahol wrote: > On Sun, Sep 20, 2020 at 10:52:52AM +0200, Marton Balint wrote: > > Signed-off-by: Marton Balint > > --- > > libavformat/aviobuf.c | 7

Re: [FFmpeg-devel] [PATCH 2/3] avformat/aviobuf: fix checks in ffio_ensure_seekback

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 03:16:15PM +0200, Marton Balint wrote: > > > On Sun, 20 Sep 2020, Paul B Mahol wrote: > > > On Sun, Sep 20, 2020 at 10:52:52AM +0200, Marton Balint wrote: > > > Signed-off-by: Marton Balint > > > --- > > > libavformat/aviobuf.c | 7 +-- > > > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH 2/3] avformat/aviobuf: fix checks in ffio_ensure_seekback

2020-09-20 Thread Marton Balint
On Sun, 20 Sep 2020, Paul B Mahol wrote: On Sun, Sep 20, 2020 at 10:52:52AM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Jan Ekström
On Sun, Sep 20, 2020 at 3:34 PM Carl Eugen Hoyos wrote: > > > > > > > Am 20.09.2020 um 13:52 schrieb Bernd Kuhls : > > > > Fixes static builds with toolchains needing "-lm" for math functions. > > Please don’t. > Please reword this in another way if your meaning is to note that you'd like the

Re: [FFmpeg-devel] [PATCH 2/3] avformat/aviobuf: fix checks in ffio_ensure_seekback

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:52:52AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c > index 9675425349..aa1d6c0830 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Carl Eugen Hoyos
> Am 20.09.2020 um 13:52 schrieb Bernd Kuhls : > > Fixes static builds with toolchains needing "-lm" for math functions. Please don’t. Why is this necessary? Doesn’t every FFmpeg link command contain -lm? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 00/10] argo_brp cleanups and fixes

2020-09-20 Thread Zane van Iperen
On Sun, 20 Sep 2020 08:06:09 + "Zane van Iperen" wrote: > > Fixes handling of embedded ASF streams and BVID timestamps. Also adds > AV_CODEC_ID_ARGO to libavcodec in preparation for Paul's decoder. I'll push this shortly without parts 9 & 10 and with the missing ',' readded.

[FFmpeg-devel] [PATCH 2/3] avformat/swfdec: Reorder allocations/initializations

2020-09-20 Thread Andreas Rheinhardt
The earlier code would first attempt to allocate two buffers, then attempt to allocate an AVIOContext, using one of the new buffers I/O buffer, then check the allocations. On success, a z_stream that is used in the AVIOContext's read_packet callback is initialized afterwards. There are two

[FFmpeg-devel] [PATCH 3/3] avformat/swf: Separate mux and demux contexts

2020-09-20 Thread Andreas Rheinhardt
There was almost no overlap between them: The only field used by both was an int named samples_per_frame. Therefore this commit separates them. Signed-off-by: Andreas Rheinhardt --- libavformat/swf.h| 33 - libavformat/swfdec.c | 22 +-

[FFmpeg-devel] [PATCH 1/3] avformat/swfdec: Fix memleaks on error

2020-09-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/swfdec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/swfdec.c b/libavformat/swfdec.c index e427998744..7a74fa3ac7 100644 --- a/libavformat/swfdec.c +++ b/libavformat/swfdec.c @@ -146,13 +146,18 @@ static

[FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Bernd Kuhls
Fixes static builds with toolchains needing "-lm" for math functions. Signed-off-by: Bernd Kuhls --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 5d68695192..4e6c6edd30 100755 --- a/configure +++ b/configure @@ -6438,7 +6438,7 @@

Re: [FFmpeg-devel] [PATCH 1/3] avformat/aviobuf: read till the very end of the IO buffer

2020-09-20 Thread Marton Balint
On Sun, 20 Sep 2020, Paul B Mahol wrote: On Sun, Sep 20, 2020 at 10:52:51AM +0200, Marton Balint wrote: There was an off-by-one error when checking if the IO buffer still has enough space till the end. How to reproduce such error(s)? It is not something you will notice, only the buffer

[FFmpeg-devel] [PATCH v2] avfilter/vf_scale: translate and verify swscale internal range flag

2020-09-20 Thread Jan Ekström
This value - while it looks like the actual range of the content - is nothing but the internal value of swscale. Thus, if we have RGB content, translate the value to 1 which is what at least this filter expects for RGB. Swscale will ignore this value when set. Additionally, after calling

Re: [FFmpeg-devel] [PATCH 1/3] avformat/aviobuf: read till the very end of the IO buffer

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 10:52:51AM +0200, Marton Balint wrote: > There was an off-by-one error when checking if the IO buffer still has enough > space till the end. How to reproduce such error(s)? > > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 01/10] avformat/argo_asf: fix enforcement of chunk count

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 08:06:18AM +, Zane van Iperen wrote: > Enforcing num_chunks == 1 only makes sense when demuxing from an ASF > file. When embedded in a BRP file, an ASF stream can have multiple chunks. > > Signed-off-by: Zane van Iperen > --- > libavformat/argo_asf.c | 17

Re: [FFmpeg-devel] [PATCH 01/10] avformat/argo_asf: fix enforcement of chunk count

2020-09-20 Thread Zane van Iperen
On Sun, 20 Sep 2020 10:54:44 +0200 "Paul B Mahol" wrote: > > On Sun, Sep 20, 2020 at 08:06:18AM +, Zane van Iperen wrote: > > Enforcing num_chunks == 1 only makes sense when demuxing from an ASF > > file. When embedded in a BRP file, an ASF stream can have multiple chunks. > > > >

Re: [FFmpeg-devel] [PATCH 03/10] avformat/argo_brp: remove an allocation

2020-09-20 Thread Zane van Iperen
On Sun, 20 Sep 2020 10:13:48 +0200 "Andreas Rheinhardt" wrote: > > @@ -444,6 +429,5 @@ AVInputFormat ff_argo_brp_demuxer = { > > .priv_data_size = sizeof(ArgoBRPDemuxContext), > > .read_probe = argo_brp_probe, > > .read_header= argo_brp_read_header, > > -.read_packet

Re: [FFmpeg-devel] [PATCH 1/2] avformat/swfenc: Fix memleak upon write_header error

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 09:43:45AM +0200, Andreas Rheinhardt wrote: > The SWF muxer accepts at most one mp3 audio and at most one VP6F, FLV1 > or MJPEG stream. Upon encountering an mp3 stream, a fifo is allocated > that leaks if one of the subsequent streams is incompliant with the > restrictions

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Avoid unnecessary skip

2020-09-20 Thread Paul B Mahol
On Sun, Sep 20, 2020 at 09:43:46AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/swfdec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > lgtm ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase default read buffer size to 2*max_buffer_size for streamed data

2020-09-20 Thread Marton Balint
This should increase the effectiveness of ffio_ensure_seekback. Note: increasing buffer size to non-streamed or write buffer should also work, but they both cause fate failures... The reason for that should be checked. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 5 + 1 file

[FFmpeg-devel] [PATCH 1/3] avformat/aviobuf: read till the very end of the IO buffer

2020-09-20 Thread Marton Balint
There was an off-by-one error when checking if the IO buffer still has enough space till the end. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index a77517d712..9675425349

[FFmpeg-devel] [PATCH 2/3] avformat/aviobuf: fix checks in ffio_ensure_seekback

2020-09-20 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 9675425349..aa1d6c0830 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -999,9 +999,12 @@ int

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: fix broken logic in ffio_ensure_seekback()

2020-09-20 Thread Marton Balint
On Sun, 20 Sep 2020, Paul B Mahol wrote: On Sat, Sep 19, 2020 at 11:46:50PM +0200, Marton Balint wrote: On Sat, 19 Sep 2020, Paul B Mahol wrote: > On Thu, Sep 17, 2020 at 12:31:06PM +0200, Paul B Mahol wrote: > > This removes big CPU overhead for demuxing chained ogg streams. > > > >

Re: [FFmpeg-devel] [PATCH 03/10] avformat/argo_brp: remove an allocation

2020-09-20 Thread Andreas Rheinhardt
Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > libavformat/argo_brp.c | 20 ++-- > 1 file changed, 2 insertions(+), 18 deletions(-) > > diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c > index 27029d07b1..e57c20eb96 100644 > --- a/libavformat/argo_brp.c >

[FFmpeg-devel] [PATCH 09/10] avcodec: add "Argonaut Games Video" descriptor

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/version.h| 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9e73dcba27..713a45ddc9 100644 ---

[FFmpeg-devel] [PATCH 10/10] avformat/argo_brp: use AV_CODEC_ID_ARGO

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 75587b24c0..5c8d6b0851 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -196,9 +196,7 @@

[FFmpeg-devel] [PATCH 08/10] avformat/argo_brp: don't pass AVStream into avpriv_request_sample()

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index ad54420283..75587b24c0 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -275,7 +275,7 @@ static

[FFmpeg-devel] [PATCH 04/10] avformat/argo_brp: cleanup 'goto fail's

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 63 +++--- 1 file changed, 23 insertions(+), 40 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index e57c20eb96..6c6e126b17 100644 --- a/libavformat/argo_brp.c +++

[FFmpeg-devel] [PATCH 06/10] avformat/argo_brp: handle multiple BASF blocks

2020-09-20 Thread Zane van Iperen
Turns out that there are files with multiple (reasonably-sized) BASF blocks. Some of the files just have particularly large frames (~10s). Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 142 ++--- 1 file changed, 49 insertions(+), 93 deletions(-)

[FFmpeg-devel] [PATCH 07/10] avformat/argo_brp: set BVID packet duration

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index fb5c2b7245..ad54420283 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -306,6 +306,7 @@ static int

[FFmpeg-devel] [PATCH 05/10] avformat/argo_brp: make sure stream ids match

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 6c6e126b17..312eb23771 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -184,6 +184,10 @@ static int

[FFmpeg-devel] [PATCH 01/10] avformat/argo_asf: fix enforcement of chunk count

2020-09-20 Thread Zane van Iperen
Enforcing num_chunks == 1 only makes sense when demuxing from an ASF file. When embedded in a BRP file, an ASF stream can have multiple chunks. Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[FFmpeg-devel] [PATCH 03/10] avformat/argo_brp: remove an allocation

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 27029d07b1..e57c20eb96 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@

[FFmpeg-devel] [PATCH 00/10] argo_brp cleanups and fixes

2020-09-20 Thread Zane van Iperen
Fixes handling of embedded ASF streams and BVID timestamps. Also adds AV_CODEC_ID_ARGO to libavcodec in preparation for Paul's decoder. Zane van Iperen (10): avformat/argo_asf: fix enforcement of chunk count avformat/argo_asf: cosmetics avformat/argo_brp: remove an allocation

[FFmpeg-devel] [PATCH 02/10] avformat/argo_asf: cosmetics

2020-09-20 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index eb0c18601d..6f7d9e93c9 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -348,7 +348,7 @@ static

[FFmpeg-devel] [PATCH 1/2] avformat/swfenc: Fix memleak upon write_header error

2020-09-20 Thread Andreas Rheinhardt
The SWF muxer accepts at most one mp3 audio and at most one VP6F, FLV1 or MJPEG stream. Upon encountering an mp3 stream, a fifo is allocated that leaks if one of the subsequent streams is incompliant with the restrictions mentioned above or if the framerate or samplerate are invalid. This is fixed

[FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Avoid unnecessary skip

2020-09-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/swfdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/swfdec.c b/libavformat/swfdec.c index 9a0b27bd8c..e427998744 100644 --- a/libavformat/swfdec.c +++ b/libavformat/swfdec.c @@ -78,10 +78,9 @@ static int