[FFmpeg-devel] [PATCH 5/6] avformat/argo_brp: allow v1.1 ASF streams to have a non-22050 sample rate in certain circumstances

2020-09-25 Thread Zane van Iperen
It seems that in files where the BASF block isn't first, v1.1 ASF streams are allowed to be non-22050. Either this format is really inconsistent, or FX Fighter and Croc just ignored the sample rate field, requiring the v1.1 restriction in the first place. This bumps the version to 1.2 in these

[FFmpeg-devel] [PATCH 6/6] avformat/argo_brp: use header frame counts

2020-09-25 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index af64a0d6dc..76b4da2e66 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -237,6 +237,8 @@ static int

[FFmpeg-devel] [PATCH 3/6] avformat/argo_brp: handle the case where the BASF block isn't the first

2020-09-25 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 613f04aef2..d3aab92af0 100644 --- a/libavformat/argo_brp.c +++

[FFmpeg-devel] [PATCH 4/6] avformat/argo_brp: cosmetics

2020-09-25 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index d3aab92af0..4041183011 100644 --- a/libavformat/argo_brp.c +++ b/libavformat/argo_brp.c @@ -36,8

[FFmpeg-devel] [PATCH 1/6] avformat/argo_{asf, brp}: fix potential segfault in ff_argo_asf_fill_stream()

2020-09-25 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 10 +- libavformat/argo_asf.h | 2 +- libavformat/argo_brp.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index de941caeac..8e2bf21c71 100644 ---

[FFmpeg-devel] [PATCH 2/6] avformat/argo_brp: support MASK streams

2020-09-25 Thread Zane van Iperen
We can't actually use them though. Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index a60de59f64..613f04aef2 100644 ---

[FFmpeg-devel] [PATCH 4/6] tools/target_dec_fuzzer: Correct maxsamples_per_frame if maxsamples has been changed

2020-09-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 7bea736fcf..db1c6d35a6 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -185,6 +185,7 @@ int

[FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: assume that discarded audio packets produced max samples

2020-09-25 Thread Michael Niedermayer
We do not know how many samples these produce as its not exported. Alternatively we could export that but as long as its not we better assume its more than 0 as otherwise the thresholds would not work Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 5 + 1 file changed, 5

[FFmpeg-devel] [PATCH 2/6] avcodec/dxtory: Fix negative shift in dxtory_decode_v1_410()

2020-09-25 Thread Michael Niedermayer
Fixes: left shift of negative value -256 Fixes: 25460/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXTORY_fuzzer-5073252341514240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dxtory.c

[FFmpeg-devel] [PATCH 6/6] avcodec/decode: Consider discarded samples in max_samples

2020-09-25 Thread Michael Niedermayer
Fixes: Timeout (several minutes -> 3 sec) Fixes: 25246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5943400661254144 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/decode.c |

[FFmpeg-devel] [PATCH 1/6] avcodec/dxtory: Fix get_raw_size() for YUV

2020-09-25 Thread Michael Niedermayer
Fixes: out of array read Fixes: 25455/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXTORY_fuzzer-6327985731534848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dxtory.c | 4 ++-- 1

[FFmpeg-devel] [PATCH 3/8] avcodec/cbs_h2645: implement CodedBitstreamType.flush() callbacks

2020-09-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index b9233f4df7..b6d77dd17f 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@

[FFmpeg-devel] [PATCH 7/8] avcodec/av1dec: call ff_cbs_flush() on decoder flush

2020-09-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index a30a496b4c..07026b7aeb 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -854,6 +854,8 @@ static void

[FFmpeg-devel] [PATCH 4/8] avcodec/cbs_vp9: implement a CodedBitstreamType.flush() callback

2020-09-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_vp9.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/cbs_vp9.c b/libavcodec/cbs_vp9.c index 6a480b4ce3..e0b8c02ac2 100644 --- a/libavcodec/cbs_vp9.c +++ b/libavcodec/cbs_vp9.c @@ -634,6 +634,13 @@ static int

[FFmpeg-devel] [PATCH 5/8] avcodec/av1dec: parse dimensions from the sequence header in extradata

2020-09-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 0bb04a3e44..f6b9fbbac3 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -405,6 +405,9 @@ static av_cold int

[FFmpeg-devel] [PATCH 6/8] avcodec/av1dec: fix check for active sequence header

2020-09-25 Thread James Almer
We clear the AV1RawSequenceHeader pointer on flush, not the relevant AVBufferRef. Signed-off-by: James Almer --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index f6b9fbbac3..a30a496b4c 100644 ---

[FFmpeg-devel] [PATCH 1/8] avcodec/cbs: add a flush callback to CodedBitstreamType

2020-09-25 Thread James Almer
Used to reset the codec's private internal state. Signed-off-by: James Almer --- libavcodec/cbs.c | 6 ++ libavcodec/cbs.h | 5 + libavcodec/cbs_internal.h | 3 +++ 3 files changed, 14 insertions(+) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index

[FFmpeg-devel] [PATCH 8/8] avcodec/av1dec: clean state on frame decoding errors

2020-09-25 Thread James Almer
Fixes: member access within null pointer of type 'TileGroupInfo' (aka 'struct TileGroupInfo') Fixes: 25725/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5166692706287616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: Check tile_group_info size before use

2020-09-25 Thread James Almer
On 9/25/2020 5:05 AM, Michael Niedermayer wrote: > On Thu, Sep 24, 2020 at 05:51:43PM -0300, James Almer wrote: >> On 9/24/2020 5:20 PM, Michael Niedermayer wrote: >>> Fixes: member access within null pointer of type 'TileGroupInfo' (aka >>> 'struct TileGroupInfo') >>> Fixes: >>>

[FFmpeg-devel] [PATCH 2/2] lavf/hls: add AC-3/EAC-3 to allowed extensions file list

2020-09-25 Thread Jun Zhao
From: Jun Zhao Add AC-3/EAC-3 to allowed extensions file list. From HTTP Live Streaming 2nd Edition draft-pantos-hls-rfc8216bis-07 section 3.1.3.Packed Audio, HLS demuxer need to support MP3/AC-3/EAC-3. Signed-off-by: Jun Zhao --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 1/2] examples/muxing: misc style fixes

2020-09-25 Thread Jun Zhao
From: Jun Zhao misc style fixes. Signed-off-by: Jun Zhao --- doc/examples/muxing.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/doc/examples/muxing.c b/doc/examples/muxing.c index bd16486..42f704c 100644 ---

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: Add QSV AV1 decoder

2020-09-25 Thread Zhong Li
Haihao Xiang 于2020年9月16日周三 下午3:08写道: > > AV1 decoder is supported on Tiger Lake+ platforms since libmfx 1.34 > > Signed-off-by: Haihao Xiang LGTM. Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [GASPP PATCH 2/2] Use cl for preprocessing when using armasm

2020-09-25 Thread Martin Storsjö
On Wed, 23 Sep 2020, Martin Storsjö wrote: When invoking gas-preprocessor to preprocess only to get the dependency list, we still need to use cpp, as cl doesn't support the -M options. This allows using gas-preprocessor in an environment with only MSVC available, no GCC/Clang providing a

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: Check tile_group_info size before use

2020-09-25 Thread Michael Niedermayer
On Thu, Sep 24, 2020 at 05:51:43PM -0300, James Almer wrote: > On 9/24/2020 5:20 PM, Michael Niedermayer wrote: > > Fixes: member access within null pointer of type 'TileGroupInfo' (aka > > 'struct TileGroupInfo') > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/sonic: Check channels before deallocating

2020-09-25 Thread Michael Niedermayer
On Thu, Sep 24, 2020 at 10:58:22PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: heap-buffer-overflow > > Fixes: > > 25744/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5172961169113088 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mobiclip: Move quantizer check into setup_qtables()

2020-09-25 Thread Michael Niedermayer
On Thu, Sep 24, 2020 at 01:47:29PM +0200, Paul B Mahol wrote: > On Thu, Sep 24, 2020 at 11:03:43AM +0200, Michael Niedermayer wrote: > > Fixes: shift exponent -2 is negative > > Fixes: > > 25683/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-6434808492982272 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: check avctx->hwaccel when hwaccel pix_fmt selected

2020-09-25 Thread Xiang, Haihao
On Fri, 2020-09-25 at 06:10 +, Wang, Fei W wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Wang, > > Fei W > > Sent: Tuesday, September 22, 2020 11:22 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: check

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: check avctx->hwaccel when hwaccel pix_fmt selected

2020-09-25 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of Wang, > Fei W > Sent: Tuesday, September 22, 2020 11:22 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: check avctx->hwaccel > when hwaccel pix_fmt selected > > > > >