[FFmpeg-devel] [PATCH v4 6/9] avformat/wavdec.c: Reindent after last commit

2020-10-02 Thread Nicolas Gaullier
--- libavformat/wavdec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index b755ab5514..5b287680e2 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -768,14 +768,14 @@ smv_out: size = FFMIN(S

[FFmpeg-devel] [PATCH v4 7/9] avformat/wavdec: fix s337m/spdif probing beyond data_end

2020-10-02 Thread Nicolas Gaullier
--- libavformat/wavdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 5b287680e2..9f48ff067b 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -80,7 +80,7 @@ static void set_spdif_s337m(AVFormatContext *s, WAVD

[FFmpeg-devel] [PATCH v4 8/9] avformat/wavdec: Test s337m

2020-10-02 Thread Nicolas Gaullier
Test s337m probing in wav container. Test dolby_e demuxing for 20 bits with program config '5.1+2'. --- tests/Makefile | 1 + tests/fate/audio.mak | 3 +++ tests/ref/fate/s337m-wav | 11 +++ 3 files changed, 15 insertions(+) create mode 100644 tests/ref/fate/s337m-wav dif

[FFmpeg-devel] [PATCH v4 9/9] avformat: Add probe_stream option

2020-10-02 Thread Nicolas Gaullier
Allows user to disable codec auto-detection. Probe requests are ignored, including spdif/s337m submux detection in wavdec. Note: this option is required to pass-through dolby_e data from a wav file. --- doc/formats.texi| 3 +++ libavformat/avformat.h | 9 - libavformat/op

[FFmpeg-devel] [PATCH v4 5/9] avformat/wavdec: s337m support

2020-10-02 Thread Nicolas Gaullier
Add s337m probing/reading similarly to spdif. --- libavformat/wavdec.c | 37 - 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index d6ab0dde35..b755ab5514 100644 --- a/libavformat/wavdec.c +++ b/libavfo

[FFmpeg-devel] [PATCH v4 2/9] avformat/s337m: Split read_packet/get_packet

2020-10-02 Thread Nicolas Gaullier
Prepare use of s337m_get_packet from outside. --- libavformat/s337m.c | 26 -- libavformat/s337m.h | 37 + 2 files changed, 57 insertions(+), 6 deletions(-) create mode 100644 libavformat/s337m.h diff --git a/libavformat/s337m.c b/libav

[FFmpeg-devel] [PATCH v4 4/9] avformat/s337m: New ff_s337m_probe()

2020-10-02 Thread Nicolas Gaullier
Similar to ff_spdif_probe() with just an additional checking of the bit resolution of the container as it may be 16 or 24 for s337m. --- libavformat/s337m.c | 32 libavformat/s337m.h | 16 2 files changed, 48 insertions(+) diff --git a/libavformat

[FFmpeg-devel] [PATCH v4 3/9] avformat/s337m: Consider container bit resolution

2020-10-02 Thread Nicolas Gaullier
Prepare the support of s337m in muxers other than raw (ex: wav). For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav file. --- libavformat/s337m.c | 17 +++-- libavformat/s337m.h | 3 ++- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH v4 1/9] avcodec/dolby_e: set constant frame_size

2020-10-02 Thread Nicolas Gaullier
Fixes pts generation. --- libavcodec/dolby_e.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dolby_e.c b/libavcodec/dolby_e.c index 429612ec08..b0e6d6aee3 100644 --- a/libavcodec/dolby_e.c +++ b/libavcodec/dolby_e.c @@ -577,6 +577,7 @@ static int filter_frame(DBEContext *s, AVFram

[FFmpeg-devel] [PATCH v4 0/9] avformat: wav-s337m support + new probe_stream option

2020-10-02 Thread Nicolas Gaullier
Because of the dependencies, I had to group all the patchs in a serie, but they are 3 functionnal parts : * patch 1 is necessary to fix dolby_e pts that will be part of the test in patch 8 * patch 2,3,4,5,6,7,8 : s337m support in wav this is a rework of a precedent serie (https://patchwork.f

Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: set constant frame_size

2020-10-02 Thread Nicolas Gaullier
>Wouldn't it make more sense to set it in decoder init? >Anton Khirnov Yes, you're right, in the actual code, this would seem the best place. But, I have in mind to add support for s337m in wav (I am just getting back on this work I started some months ago). Take a 48k wav with dolby_e in it whic

[FFmpeg-devel] [PATCH] avcodec/mobiclip: Check that Motion vectors are within the input frame

2020-10-02 Thread Michael Niedermayer
The MV checks did not consider the width and height of the block, also they had some off by 1 errors. This resulted in undefined behavior and crashes. This commit instead errors out on these Fixes: out of array read Fixes: 26080/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-57

[FFmpeg-devel] [PATCH 4/4 v2] avcodec/av1dec: add an option to select an operating point

2020-10-02 Thread James Almer
Signed-off-by: James Almer --- doc/decoders.texi | 13 + libavcodec/av1dec.c | 34 ++ libavcodec/av1dec.h | 7 +++ 3 files changed, 54 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index 8649f83e28..667941652c 100644 --- a/doc

[FFmpeg-devel] [PATCH 3/4 v2] avcodec/cbs_av1: add an option to select an operating point

2020-10-02 Thread James Almer
This implements the function drop_obu() as defined in Setion 6.2.1 from the spec. In a reading only scenario, units that belong to an operating point the caller doesn't want should not be parsed. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 30 +- libavcodec/

[FFmpeg-devel] [PATCH 6/7] lavfi/vf_fspp: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
--- libavfilter/Makefile | 2 +- libavfilter/vf_fspp.c | 59 +-- libavfilter/vf_fspp.h | 2 +- 3 files changed, 25 insertions(+), 38 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index dcbb867265..be2c3e3156 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH 4/7] lavfi/vf_spp: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
--- libavfilter/Makefile| 2 +- libavfilter/vf_spp.c| 57 - libavfilter/vf_spp.h| 3 +- tests/fate/filter-video.mak | 4 +-- 4 files changed, 29 insertions(+), 37 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile i

[FFmpeg-devel] [PATCH 3/7] lavfi/vf_pp: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
--- libavfilter/Makefile| 2 +- libavfilter/qp_table.c | 66 + libavfilter/qp_table.h | 32 ++ libavfilter/vf_pp.c | 19 --- tests/fate/filter-video.mak | 6 ++-- 5 files changed, 117 insertions(+), 8 deletions

[FFmpeg-devel] [PATCH 7/7] lavfi/vf_codecview: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
--- libavfilter/Makefile | 2 +- libavfilter/vf_codecview.c | 14 +++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index be2c3e3156..119a9c513b 100644 --- a/libavfilter/Makefile +++ b/libavfilter/Makefile @@ -185,7 +1

[FFmpeg-devel] [PATCH 2/7] lavfi/vf_qp: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
Temporarily disable fate-filter-qp until vf_pp is converted. --- libavfilter/vf_qp.c | 65 - tests/fate/filter-video.mak | 8 ++--- 2 files changed, 47 insertions(+), 26 deletions(-) diff --git a/libavfilter/vf_qp.c b/libavfilter/vf_qp.c index 33d39493

[FFmpeg-devel] [PATCH 5/7] lavfi/vf_pp7: convert to the video_enc_params API

2020-10-02 Thread Anton Khirnov
--- libavfilter/Makefile| 2 +- libavfilter/vf_pp7.c| 14 +++--- libavfilter/vf_pp7.h| 1 - tests/fate/filter-video.mak | 4 ++-- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index 2669d7b84b..dcbb867

[FFmpeg-devel] [PATCH 1/7] mpegvideo: use the AVVideoEncParams API for exporting QP tables

2020-10-02 Thread Anton Khirnov
Do it only when requested with the AV_CODEC_EXPORT_DATA_VIDEO_ENC_PARAMS flag. Drop previous code using the long-deprecated AV_FRAME_DATA_QP_TABLE* API. Temporarily disable fate-filter-pp, fate-filter-pp7, fate-filter-spp. They will be reenabled once these filters are converted in following commit

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-10-02 Thread Guangxin Xu
On Tue, Sep 29, 2020 at 10:03 PM Mark Thompson wrote: > On 10/09/2020 07:42, Haihao Xiang wrote: > > Resend Linjie's patchset with the updates. > > > > As a part of the support for VA-API HEVC SCC decoding (gen12, Tiger > > Lake+). > > > > The full support could be accessed in: > > https://github

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: handle tracks w/o AVStreams in calculate_mpeg4_bit_rates

2020-10-02 Thread Jan Ekström
On Fri, Oct 2, 2020 at 12:33 PM Martin Storsjö wrote: > > On Mon, 28 Sep 2020, Jan Ekström wrote: > > > The generated text streams for chapters lack an AVStream since they > > are but an internal concept within movenc. > > > > Fixes #8190 > > --- > > libavformat/movenc.c | 5 +++-- > > 1 file chang

Re: [FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder

2020-10-02 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Wednesday, September 30, 2020 1:10 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder > > On 9/9/2020 12:39 AM, Fei Wang wrote: > > +static int vaapi_av1_

Re: [FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder

2020-10-02 Thread Wang, Fei W
> -Original Message- > From: Wang, Fei W > Sent: Wednesday, September 30, 2020 1:58 PM > To: FFmpeg development discussions and patches > Subject: RE: [FFmpeg-devel] [PATCH V3 2/2] avcodec: add av1 VAAPI decoder > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Mark

[FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder

2020-10-02 Thread Fei Wang
Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- Changelog | 1 + configure | 3 + libavcodec/Makefile |

Re: [FFmpeg-devel] [PATCH 3/3] avformat/moflex: Check m->size before seeking

2020-10-02 Thread Paul B Mahol
On Fri, Oct 02, 2020 at 02:59:15PM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 26016/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6195663833137152 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: Fix negative stride shift in dx2_decode_slice_420()

2020-10-02 Thread Paul B Mahol
On Fri, Oct 02, 2020 at 02:59:13PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -640 > Fixes: > 26044/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXTORY_fuzzer-5631057602543616 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mas

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3_parser: add avpriv function to parse EC3SpecificBox (dec3)

2020-10-02 Thread James Almer
On 10/2/2020 10:10 AM, Nachiket Tarate wrote: > This will be used by HLS demuxer for SAMPLE-AES decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/ac3_parser.c | 47 > libavcodec/ac3_parser_internal.h | 4 +++ > 2 files changed, 51 insert

[FFmpeg-devel] [PATCH 2/2] libavcodec/ac3_parser: add avpriv function to parse EC3SpecificBox (dec3)

2020-10-02 Thread Nachiket Tarate
This will be used by HLS demuxer for SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/ac3_parser.c | 47 libavcodec/ac3_parser_internal.h | 4 +++ 2 files changed, 51 insertions(+) diff --git a/libavcodec/ac3_parser.c b/libavcodec/a

[FFmpeg-devel] [PATCH 1/2] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2020-10-02 Thread Nachiket Tarate
These will be used by HLS demuxer for SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 18 ++ libavcodec/adts_header.h | 4 2 files changed, 22 insertions(+) diff --git a/libavcodec/adts_header.c b/libavcodec/adts_header.c index 0889820f

[FFmpeg-devel] [PATCH 2/3] avcodec/smacker: Check remaining bits in SMK_BLK_FULL

2020-10-02 Thread Michael Niedermayer
Fixes: out of array access Fixes: 26047/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5083031667474432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/smacker.c | 2 ++ 1 fi

[FFmpeg-devel] [PATCH 3/3] avformat/moflex: Check m->size before seeking

2020-10-02 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 26016/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6195663833137152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/moflex.c | 5 - 1 file changed,

Re: [FFmpeg-devel] [PATCH v2 1/2] libswscale/tests: add floatimg_cmp test

2020-10-02 Thread Michael Niedermayer
On Mon, Sep 28, 2020 at 08:44:33PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > changes since v1: > - made into fate test > - fixed c90 warnings > - tests more intermediate formats > - tested on BE mips too > > --- > libswscale/Makefile | 1 + > libswscale/tests/.gitign

[FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: Fix negative stride shift in dx2_decode_slice_420()

2020-10-02 Thread Michael Niedermayer
Fixes: left shift of negative value -640 Fixes: 26044/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXTORY_fuzzer-5631057602543616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dxtory.c

[FFmpeg-devel] [PATCH] avcodec/tiff: do not abort decoding if strips are available

2020-10-02 Thread Paul B Mahol
Even if such files are invalid, they can be decoded just fine. Also stored tiles may have bigger dimensions than displayed ones, so do not abort decoding in such cases. Signed-off-by: Paul B Mahol --- libavcodec/tiff.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/li

Re: [FFmpeg-devel] [WIP] Organisation process

2020-10-02 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2020-10-02 00:41:34) > Hello folks, > > I've documented what has been decided/discussed about the voting process and > the committees. > > I'd like to know where should I commit this .md. In doc/? In a subfolder? > somewhere else? doc/ is getting pretty crowded, so a

[FFmpeg-devel] [PATCH] avcodec: add Cintel RAW decoder

2020-10-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/cri.c| 328 libavformat/img2.c | 1 + 6 files changed, 339 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: set constant frame_size

2020-10-02 Thread Anton Khirnov
Quoting Nicolas Gaullier (2020-10-01 15:22:37) > Fixes pts generation. > --- > libavcodec/dolby_e.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/dolby_e.c b/libavcodec/dolby_e.c > index 429612ec08..b0e6d6aee3 100644 > --- a/libavcodec/dolby_e.c > +++ b/libavcodec/dolby_e.c

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: handle tracks w/o AVStreams in calculate_mpeg4_bit_rates

2020-10-02 Thread Martin Storsjö
On Mon, 28 Sep 2020, Jan Ekström wrote: The generated text streams for chapters lack an AVStream since they are but an internal concept within movenc. Fixes #8190 --- libavformat/movenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/

Re: [FFmpeg-devel] [PATCH] avformat: add tri-ACE demuxer

2020-10-02 Thread Paul B Mahol
On Thu, Sep 24, 2020 at 07:34:52PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/acedec.c | 114 +++ > libavformat/allformats.c | 1 + > 3 files changed, 116 insertions(+) > create mode 1

Re: [FFmpeg-devel] [PATCH] rtsp: Fix infinite loop in listen mode with UDP transport

2020-10-02 Thread Zhao Zhili
On 10/2/20 4:48 AM, Martin Storsjö wrote: On Thu, 1 Oct 2020, Andriy Gelman wrote: On Thu, 01. Oct 22:00, Zhao Zhili wrote: On 10/1/20 4:15 AM, Martin Storsjö wrote: > On Wed, 30 Sep 2020, Zhao Zhili wrote: > > > Hi Martin, > > > > On 9/30/20 5:41 PM, Martin Storsjö wrote: > > > In listen mo

Re: [FFmpeg-devel] [PATCH 1/1] avformat: mca: relax a condition check to be able to play certain files

2020-10-02 Thread Paul B Mahol
On Thu, Oct 01, 2020 at 11:53:36PM -0600, liush...@aosc.io wrote: > From: liushuyu > > In certain mca files, the coefficient table is in the data section > instead of the header section. In this case, the coefficient offset > relative to the header ending marker is a negative value thus failing >