Re: [FFmpeg-devel] [WIP] Organisation process

2020-10-04 Thread Moritz Barsnick
Hi Jean-Baptiste, On Fri, Oct 02, 2020 at 00:41:34 +0200, Jean-Baptiste Kempf wrote: > Hello folks, Nit: > The TC is resolving technical conflicts but is not a technical steering > committee. If it's not only happening right now, but happens in general, you write: The TC resolves technical

[FFmpeg-devel] [PATCH] Allow using only the mfra info for seeking using the fragment index

2020-10-04 Thread Derek Buitenhuis
From: Justin Ruggles The mfra has enough information to enable seeking, and reading it is behind an AVOption flag, so we shouldn't require that sidx information also be present in order to seek using the fragment index. Signed-off-by: Derek Buitenhuis --- This is especially important want I/O i

[FFmpeg-devel] [PATCH] avformat/mpegts: ensure seekback for small probesize

2020-10-04 Thread Andriy Gelman
From: Andriy Gelman get_packet_size() may read upto PROBE_PACKET_MAX_BUF bytes, which may be larger than probesize. Signed-off-by: Andriy Gelman --- An alternative could be to make sure we don't read more than s->probesize bytes in get_packet_size(), but because this function is also called du

[FFmpeg-devel] [PATCH 3/3] avcodec/mv30: Fix multiple integer overflows

2020-10-04 Thread Michael Niedermayer
Fixes: signed integer overflow: -895002 * 2400 cannot be represented in type 'int' Fixes: 26052/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5431812577558528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread Nachiket Tarate
This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/ac3_parser.c | 6 +++--- libavcodec/ac3enc.c | 2 +- libavcodec/ac3enc_fixed.c | 2 +- libavcodec/ac3enc_float.c | 2 +- libavcodec/ac3tab.c

[FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: Limit initial skipped_bytes_pos_size to nal size / 16

2020-10-04 Thread Michael Niedermayer
Fixes: OOM Fixes: 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-6300869057576960 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h2645_parse.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for opus

2020-10-04 Thread Michael Niedermayer
Fixes: Timeout (12sec -> 3sec) Fixes: 24549/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBOPUS_fuzzer-6211170349088768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: Limit initial skipped_bytes_pos_size to nal size / 16

2020-10-04 Thread James Almer
On 10/4/2020 4:41 PM, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-6300869057576960 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for opus

2020-10-04 Thread James Almer
On 10/4/2020 4:41 PM, Michael Niedermayer wrote: > Fixes: Timeout (12sec -> 3sec) > Fixes: > 24549/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBOPUS_fuzzer-6211170349088768 codec id, or decoder? And if the latter, why is an external library based decoder being fuzzed? > > Found-by: cont

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread James Almer
On 10/4/2020 11:35 AM, Nachiket Tarate wrote: > This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during > SAMPLE-AES decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/ac3_parser.c | 6 +++--- > libavcodec/ac3enc.c | 2 +- > libavcodec/ac3enc_fixed.c | 2 +-

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: Limit initial skipped_bytes_pos_size to nal size / 16

2020-10-04 Thread Michael Niedermayer
On Sun, Oct 04, 2020 at 05:04:05PM -0300, James Almer wrote: > On 10/4/2020 4:41 PM, Michael Niedermayer wrote: > > Fixes: OOM > > Fixes: > > 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-6300869057576960 > > > > Found-by: continuous fuzzing process > > https://github.com/

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: Limit initial skipped_bytes_pos_size to nal size / 16

2020-10-04 Thread James Almer
On 10/4/2020 5:57 PM, Michael Niedermayer wrote: > On Sun, Oct 04, 2020 at 05:04:05PM -0300, James Almer wrote: >> On 10/4/2020 4:41 PM, Michael Niedermayer wrote: >>> Fixes: OOM >>> Fixes: >>> 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-6300869057576960 >>> >>> Found-by:

[FFmpeg-devel] [PATCH 2/2] libavcodec/ac3tab: rename ff_ac3_sample_rate_tab to avpriv_ac3_sample_rate_tab so that it can be used in libavformat

2020-10-04 Thread Nachiket Tarate
This will be used by HLS demuxer to parse EC3SpecificBox (dec3) during SAMPLE-AES decryption. Signed-off-by: Nachiket Tarate --- libavcodec/ac3_parser.c | 6 +++--- libavcodec/ac3enc.c | 2 +- libavcodec/ac3enc_fixed.c | 2 +- libavcodec/ac3enc_float.c | 2 +- libavcodec/ac3tab.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/smacker: Check remaining bits in SMK_BLK_FULL

2020-10-04 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: out of array access > Fixes: > 26047/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5083031667474432 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > -

Re: [FFmpeg-devel] [PATCH 2/9] avformat/aviobuf: check if requested seekback buffer is already read

2020-10-04 Thread Andriy Gelman
Hi Marton, On Tue, 29. Sep 23:10, Marton Balint wrote: > Existing code did not check if the requested seekback buffer is > already read entirely. In this case, nothing has to be done to guarantee > seekback. > > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 3 +++ > 1 file change

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h2645_parse: Limit initial skipped_bytes_pos_size to nal size / 16

2020-10-04 Thread James Almer
On 10/4/2020 6:02 PM, James Almer wrote: > On 10/4/2020 5:57 PM, Michael Niedermayer wrote: >> On Sun, Oct 04, 2020 at 05:04:05PM -0300, James Almer wrote: >>> On 10/4/2020 4:41 PM, Michael Niedermayer wrote: Fixes: OOM Fixes: 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_MET