Re: [FFmpeg-devel] [PATCH] dnn_backend_tf.c: add option sess_config for tf backend

2020-10-13 Thread Guo, Yejun
> From: Chris Miceli > Sent: 2020年10月14日 6:15 > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH] dnn_backend_tf.c: add option sess_config > for tf backend > > Hi! > > With proto files they can be serialised to many different formats, is the

Re: [FFmpeg-devel] [PATCH] libavformat/hls: check new_init_section for null

2020-10-13 Thread Steven Liu
Chris Miceli 于2020年10月13日周二 下午1:59写道: > > new_init_section will return NULL under circumstances where the init > failed and this code needed to check for that. ret and goto fail are how > this is handled throughout the code. > --- > libavformat/hls.c | 4 > 1 file changed, 4 insertions(+) >

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend{openvino, tf}: check memory alloc non-NULL

2020-10-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chris > Miceli > Sent: 2020年10月14日 9:00 > To: ffmpeg-devel@ffmpeg.org > Cc: Chris Miceli > Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend{openvino, tf}: > check memory alloc non-NULL > > These previously would not chec

[FFmpeg-devel] [PATCH] lavc/qsvenc: fix poor video quality with "-force_key_frames"

2020-10-13 Thread Alex Pokotilo
From 64abde49dffd7ef80f77210f2b943388e4682be6 Mon Sep 17 00:00:00 2001 From: Alex Pokotilo Date: Wed, 14 Oct 2020 02:19:25 + Subject: [PATCH] lavc/qsvenc: fix poor video quality with "-force_key_frames" if run ffmpeg with "-force_key_frames" flag without this fix, all new frames will have "M

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chris > Miceli > Sent: 2020年10月14日 8:20 > To: ffmpeg-devel@ffmpeg.org > Cc: Chris Miceli > Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem > allocation > > check that frame allocations return non-null. > -

[FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend{openvino, tf}: check memory alloc non-NULL

2020-10-13 Thread Chris Miceli
These previously would not check that the return value was non-null meaning it was susceptible to a sigsegv. This checks those values. --- libavfilter/dnn/dnn_backend_openvino.c | 14 +- libavfilter/dnn/dnn_backend_tf.c | 16 +++- 2 files changed, 28 insertions(+), 2

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-13 Thread Chris Miceli
check that frame allocations return non-null. --- libavfilter/dnn/dnn_backend_native.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index d45e211f0c..4fc3ba2044 100644 --- a/libavf

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-13 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. The fate test file can be found here: https://drive.google.com/file/d/1Hadzc

Re: [FFmpeg-devel] [PATCH] dnn_backend_tf.c: add option sess_config for tf backend

2020-10-13 Thread Chris Miceli
Hi! With proto files they can be serialised to many different formats, is there a reason for it to use hex? The reason I ask is that it's not trivially readable for those debugging the command line. Perhaps something like json is better? Even if not using json, maybe a file is a little easier? In

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 20:11 +0200, Andreas Rheinhardt wrote: > > Joakim Tjernlund: > > On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: > > > > > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > > > beyond

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Andreas Rheinhardt
Joakim Tjernlund: > On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: >> >> On 13/10/2020 15:19, Joakim Tjernlund wrote: >>> For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is >>> beyond this patch. >> >> As Ronald mentioned, if you're going to fix the ABI/API, you sho

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 14:03 -0300, James Almer wrote: > > > On 10/13/2020 11:24 AM, Derek Buitenhuis wrote: > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > > beyond this patch. > > > > As Ronald mentioned, if you'

[FFmpeg-devel] [PATCH v2] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 This seems to be caused by the custom handling of "av_max_alloc(0)" in Chromium's ffmpeg fork to mean unlimited (added in [1]). Upstream ffmpeg doesn't treat 0 as a special value; versions before 4.3 s

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread James Almer
On 10/13/2020 11:24 AM, Derek Buitenhuis wrote: > On 13/10/2020 15:19, Joakim Tjernlund wrote: >> For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is >> beyond this patch. > > As Ronald mentioned, if you're going to fix the ABI/API, you should actually > fix every use of that A

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > beyond this patch. > > As Ronald mentioned, if you're going to fix the ABI/API, you should actually > fix eve

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Derek Buitenhuis
On 13/10/2020 15:19, Joakim Tjernlund wrote: > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is beyond > this patch. As Ronald mentioned, if you're going to fix the ABI/API, you should actually fix every use of that ABI/API, not just the one you care about (0). So max value

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif_cuda: CUDA implementation of bwdif

2020-10-13 Thread Thomas Mundt
Am Mo., 12. Okt. 2020 um 21:42 Uhr schrieb Philip Langdale < phil...@overt.org>: > On Sun, 11 Oct 2020 18:36:42 +0200 > Thomas Mundt wrote: > > > Hi Philip, > > > > Am Fr., 9. Okt. 2020 um 18:33 Uhr schrieb Philip Langdale > > > >: > > > > > I've been sitting on this for a couple of years now, a

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 09:41 -0400, Ronald S. Bultje wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > Hi, > > On Tue, Oct 13, 2020 at 6:30 AM Joakim Tjernlund >

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Ronald S. Bultje
Hi, On Tue, Oct 13, 2020 at 6:30 AM Joakim Tjernlund < joakim.tjernl...@infinera.com> wrote: > From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 > > This seems to be caused by the custom handling of "av_max_alloc(0)" in > Chromium's ffmpeg fork to mea

Re: [FFmpeg-devel] [PATCH v9] avfilter/avf_aphasemeter: Add out of phase and mono detection

2020-10-13 Thread Romane Lafon
On Mon, Oct 12, 2020 at 8:43 PM Paul B Mahol wrote: > On Mon, Oct 12, 2020 at 07:01:17PM +0200, Romane Lafon wrote: > > This patch extends aphasemeter to detect out of phase or mono sequences > in > > stereo streams. Same patch as v8, but doc updated with the latest master > > branch. > > > > pro

[FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 This seems to be caused by the custom handling of "av_max_alloc(0)" in Chromium's ffmpeg fork to mean unlimited (added in [1]). Upstream ffmpeg doesn't treat 0 as a special value; versions before 4.3 s

[FFmpeg-devel] [PATCH v2] avformat/webvttdec, enc: correctly process files containing STYLE, REGION blocks

2020-10-13 Thread Dave Evans
This patch fixes the total failure to parse cues when style and region definition blocks are contained in the input file, and ensures those blocks are written to the output when copying. The sample attached needs to be added to samples at the path shown in the patch in order to validate that the o

[FFmpeg-devel] [PATCH 7/9] avfilter/af_mcompand: Remove redundant calls to AVFilter.uninit

2020-10-13 Thread Andreas Rheinhardt
uninit is already called automatically (even when configuring the filter failed). Signed-off-by: Andreas Rheinhardt --- libavfilter/af_mcompand.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index f

[FFmpeg-devel] [PATCH 8/9] avcodec/v3/408enc: Remove empty close functions

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/v308enc.c | 6 -- libavcodec/v408enc.c | 7 --- 2 files changed, 13 deletions(-) diff --git a/libavcodec/v308enc.c b/libavcodec/v308enc.c index 29b7f8bedd..0891251dea 100644 --- a/libavcodec/v308enc.c +++ b/libavcodec/v308enc.c @@ -68,11 +

[FFmpeg-devel] [PATCH 6/9] avcodec/asvenc: Avoid reversing output data twice

2020-10-13 Thread Andreas Rheinhardt
The ASUS V2 format is designed for a little-endian bitstream reader, yet our encoder used an ordinary big-endian bitstream writer to write it; the bits of every byte were swapped at the end and some data (namely the numbers not in static tables) had to be bitreversed before writing it at all, so th

[FFmpeg-devel] [PATCH 9/9] avcodec/ylc: Inline constants

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ylc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ylc.c b/libavcodec/ylc.c index 2afe3fc9d5..ecfecc0292 100644 --- a/libavcodec/ylc.c +++ b/libavcodec/ylc.c @@ -371,7 +371,7 @@ static int decode_frame(A

[FFmpeg-devel] [PATCH 5/9] avcodec/asvenc: Simplify flushing and padding packet

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/asvenc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c index 054ec8ee65..49df3ffbe1 100644 --- a/libavcodec/asvenc.c +++ b/libavcodec/asvenc.c @@ -291,12 +291,9 @@ static int en

[FFmpeg-devel] [PATCH 3/9] avcodecc/asvdec: Avoid reversing input data twice

2020-10-13 Thread Andreas Rheinhardt
Up until now the ASV2 decoder used an ordinary big-endian bitreader to read data actually destined for a little-endian bitreader; this is done by reversing the whole input packet bitwise, using the big-endian bigreader and reversing (and shifting) the result again. This commit stops this and instea

[FFmpeg-devel] [PATCH 4/9] avcodec/asvenc: Inline constants

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/asvenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c index 28f7a94071..054ec8ee65 100644 --- a/libavcodec/asvenc.c +++ b/libavcodec/asvenc.c @@ -47,7 +47,7 @@ static inline v

[FFmpeg-devel] [PATCH 1/9] avcodec/asvdec: Reduce the size of some VLCs

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/asvdec.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/asvdec.c b/libavcodec/asvdec.c index 9a11446f52..a21e4277b3 100644 --- a/libavcodec/asvdec.c +++ b/libavcodec/asvdec.c @@ -34,7 +3

[FFmpeg-devel] [PATCH 2/9] avcodec/asvdec: Use init_get_bits8()

2020-10-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/asvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/asvdec.c b/libavcodec/asvdec.c index a21e4277b3..6198188fc5 100644 --- a/libavcodec/asvdec.c +++ b/libavcodec/asvdec.c @@ -235,7 +235,9 @@ static int decode_

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec, enc: correctly process files containing STYLE, REGION blocks

2020-10-13 Thread Dave Evans
On Mon, Oct 12, 2020 at 11:20 PM Jan Ekström wrote: > > On Tue, Oct 13, 2020 at 12:07 AM Dave Evans wrote: > > > > This patch fixes the total failure to parse cues when style and region > > definition blocks are contained in the input file, and ensures those blocks > > are written to the output w

[FFmpeg-devel] [PATCH] dnn_backend_tf.c: add option sess_config for tf backend

2020-10-13 Thread Guo, Yejun
TensorFlow C library accepts config for session options to set different parameters for the inference. This patch exports this interface. The config is a serialized tensorflow.ConfigProto proto, so we need two steps to use it: 1. generate the serialized proto with python (see script example below)

[FFmpeg-devel] [PATCH] Preventing Buffer Overflow for RTSP Links Increasing the buffer size of control uri, used when storing the input argument RTSP link. Following the Web URI standards, lengths of

2020-10-13 Thread Yigit Uyan
--- libavformat/rtsp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h index 54a9a30c16..2b37f5b49f 100644 --- a/libavformat/rtsp.h +++ b/libavformat/rtsp.h @@ -315,7 +315,7 @@ typedef struct RTSPState { /** some MS RTSP streams cont

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-13 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chris > Miceli > Sent: 2020年10月13日 13:16 > To: ffmpeg-devel@ffmpeg.org > Cc: Chris Miceli > Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem > allocation > > check that frame allocations return non-null. >

[FFmpeg-devel] [PATCH] avformat/hlsenc: support CODECS Attribute in hevc EXT-X-STREAM-INF

2020-10-13 Thread Steven Liu
fix ticket: 8904 parse the SPS from extradata and get profile_tier_level write the profile_tier_level info into CODECS Attribute HLS CODECS Attribute reference to :https://developer.apple.com/documentation/http_live_streaming/hls_authoring_specification_for_apple_devices/hls_authoring_specificati