Re: [FFmpeg-devel] [PATCH 1/3] avcodec/on2avcdata: Deduplicate symbol tables

2020-10-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Saves about 10KB. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/on2avcdata.c | 921 ++-- > 1 file changed, 36 insertions(+), 885 deletions(-) > Will apply this patchset (with the exception of 4/5) later today unless there

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/on2avc: Avoid indirection when calling float dsp function

2020-10-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Anton Khirnov: >> Quoting Andreas Rheinhardt (2020-10-19 13:07:05) >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavcodec/on2avc.c | 35 ++- >>> 1 file changed, 18 insertions(+), 17 deletions(-) >>> >> >> I don't quite see the point of

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/on2avc: Avoid indirection when calling float dsp function

2020-10-20 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-10-19 13:07:05) >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/on2avc.c | 35 ++- >> 1 file changed, 18 insertions(+), 17 deletions(-) >> > > I don't quite see the point of this. I cannot imagine it is

Re: [FFmpeg-devel] [PATCH 06/11] avutil/eval: Unconditionally check argument of e_div

2020-10-20 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: division by zero > Fixes: > 26451/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVO_fuzzer-4756955832516608 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Unify initializing and freeing VLC tables

2020-10-20 Thread Andreas Rheinhardt
Peter Ross: > On Tue, Oct 20, 2020 at 09:53:54AM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/vp3.c | 163 --- >> libavcodec/vp3data.h | 22 ++ >> libavcodec/vp4data.h | 22 ++ >> 3 files changed,

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp3: Check allocations of VLCs

2020-10-20 Thread Andreas Rheinhardt
Peter Ross: > On Tue, Oct 20, 2020 at 09:53:53AM +0200, Andreas Rheinhardt wrote: >> It would lead to crashs lateron if they failed. > > did you find these automatically? > > have previously used this tool tool to find such errors: > https://github.com/ralight/mallocfail > No, I just look at

Re: [FFmpeg-devel] [PATCH 05/11] avformat/ffmetadec: finalize AVBPrint on errors

2020-10-20 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: memleak > Fixes: > 26450/clusterfuzz-testcase-minimized-ffmpeg_dem_FFMETADATA_fuzzer-6249850443923456 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] tests/audiomatch: removes a warning when compiling tests/audiomatch

2020-10-20 Thread Steven Liu
> 2020年10月20日 下午5:45,Steven Liu 写道: > > liuqi05 于2020年10月19日周一 下午2:10写道: >> >> the warning message: >> warning: using floating point absolute value function >> 'fabs' when argument is of integer type >> use FFABS to set the absolute value. >> >> Signed-off-by: liuqi05 >> --- >>

[FFmpeg-devel] [PATCH 3/3] avcodec/av1dec: don't derive loop filter delta parameters

2020-10-20 Thread James Almer
This is now handled by CBS. Signed-off-by: James Almer --- Alternative approach to "avcodec/av1dec: always update frame loop filter deltas using bitstream values" where CBS takes care of everything so this work doesn't have to be duplicated on all the modules that require it.

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: infer loop filter delta parameters from reference frames

2020-10-20 Thread James Almer
Partially implements of setup_past_independence() and load_previous(). These ensures they are always set, even if the values were not coded in the input bitstream and will not be coded in the output bitstream. Signed-off-by: James Almer --- libavcodec/cbs_av1.h | 3 +++

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_av1: infer segmentation parameters from reference frames

2020-10-20 Thread James Almer
Partially implements of setup_past_independence() and load_previous(). These ensures they are always set, even if the values were not coded in the input bitstream and will not be coded in the output bitstream. Signed-off-by: James Almer --- libavcodec/cbs_av1.h | 2 ++

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Unify initializing and freeing VLC tables

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:54AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp3.c | 163 --- > libavcodec/vp3data.h | 22 ++ > libavcodec/vp4data.h | 22 ++ > 3 files changed, 55 insertions(+),

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp3: Check allocations of VLCs

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:53AM +0200, Andreas Rheinhardt wrote: > It would lead to crashs lateron if they failed. did you find these automatically? have previously used this tool tool to find such errors: https://github.com/ralight/mallocfail > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Fix memleak upon init failure

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:52AM +0200, Andreas Rheinhardt wrote: > Up until now, there was no cleanup in case initializing the Theora VLC > tables failed, leading to memleaks. This commit gets rid of them by > setting the FF_CODEC_CAP_INIT_CLEANUP flag for all decoders in vp3.c; > this also

[FFmpeg-devel] [PATCH 09/11] avformat/pcm: Check block_align

2020-10-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 321 * 8746632 cannot be represented in type 'int' Fixes: 26461/clusterfuzz-testcase-minimized-ffmpeg_dem_PVF_fuzzer-6326427831762944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 07/11] avformat/rmdec: Make expected_len 64bit

2020-10-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 1347551268 * 14 cannot be represented in type 'int' Fixes: 26458/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-5655364324032512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 04/11] avformat/utils: Move +1 to avoid overflow

2020-10-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long' Fixes: Timeout Fixes: 26434/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5752845451919360 Fixes: 26444/clusterfuzz-testcase-minimized-ffmpeg_dem_BINK_fuzzer-4697773380993024 Found-by: continuous

[FFmpeg-devel] [PATCH 11/11] avutil/mathematics: Use av_sat_add64() for the last addition in av_add_stable()

2020-10-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854770375 + 5450 cannot be represented in type 'long' Fixes: 26471/clusterfuzz-testcase-minimized-ffmpeg_dem_MXG_fuzzer-6229617557635072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 06/11] avutil/eval: Unconditionally check argument of e_div

2020-10-20 Thread Michael Niedermayer
Fixes: division by zero Fixes: 26451/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVO_fuzzer-4756955832516608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavutil/eval.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 10/11] avformat/lrcdec: Clip timestamps

2020-10-20 Thread Michael Niedermayer
Fixes: signed integer overflow: 7531010 - -7335632962598013506 cannot be represented in type 'long' Fixes: 26463/clusterfuzz-testcase-minimized-ffmpeg_dem_LRC_fuzzer-6015558333759488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 01/11] avcodec/notchlc: Check uncompressed size against input for LZ4

2020-10-20 Thread Michael Niedermayer
Fixes: OOM Fixes: 26168/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-6019839015256064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/notchlc.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 02/11] tools/target_dec_fuzzer: adjust threshold for wmalossless

2020-10-20 Thread Michael Niedermayer
Fixes: Timeout (>30sec -> 0.5sec) Fixes: 26351/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5191487740182528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 05/11] avformat/ffmetadec: finalize AVBPrint on errors

2020-10-20 Thread Michael Niedermayer
Fixes: memleak Fixes: 26450/clusterfuzz-testcase-minimized-ffmpeg_dem_FFMETADATA_fuzzer-6249850443923456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/ffmetadec.c | 8 ++-- 1 file

[FFmpeg-devel] [PATCH 03/11] avformat/mxfdec: Check type before setting sub_descriptors_refs

2020-10-20 Thread Michael Niedermayer
Fixes: memleak Fixes: 26352/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5201158714687488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 08/11] avformat/mpegts: Check pcr_incr before setting bitrate

2020-10-20 Thread Michael Niedermayer
Fixes: division by zero Fixes: 26459/clusterfuzz-testcase-minimized-ffmpeg_dem_MPEGTSRAW_fuzzer-5666350112178176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mpegts.c | 6 -- 1 file

Re: [FFmpeg-devel] [PATCH v9] avfilter/avf_aphasemeter: Add out of phase and mono detection

2020-10-20 Thread Romane Lafon
On Tue, Oct 13, 2020 at 2:48 PM Romane Lafon wrote: > > On Mon, Oct 12, 2020 at 8:43 PM Paul B Mahol wrote: > >> On Mon, Oct 12, 2020 at 07:01:17PM +0200, Romane Lafon wrote: >> > This patch extends aphasemeter to detect out of phase or mono sequences >> in >> > stereo streams. Same patch as

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-10-20 Thread FRÉDÉRIC RECOULES
Dear developers, We sent you on April a list of several compliance issues in FFMPEG inline assembly chunks, and we submitted a bunch of patches to fix them. They pass the fate test and can be found at https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=996. Since the changes only concern

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/notchlc: Check uncompressed size against input for LZ4

2020-10-20 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 04:57:47PM +0200, Paul B Mahol wrote: > This broke decoding of every single file. > > Please revert ASAP! reverted, i have to say though that this was the bound that you posted. I think you mixed upper and lower bounds and I didnt notice The patch i originally posted

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/notchlc: Check uncompressed size against input for LZ4

2020-10-20 Thread Paul B Mahol
This broke decoding of every single file. Please revert ASAP! On Tue, Oct 20, 2020 at 3:43 PM Michael Niedermayer wrote: > On Thu, Oct 15, 2020 at 10:32:28PM +0200, Michael Niedermayer wrote: > > Fixes: OOM > > Fixes: >

Re: [FFmpeg-devel] [PATCH] avfilter: add frequency and phase shift filters

2020-10-20 Thread Paul B Mahol
Will apply very soon! On Sun, Oct 18, 2020 at 6:53 PM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Now with better output quality. > --- > doc/filters.texi| 30 +++ > libavfilter/Makefile| 2 + > libavfilter/af_afreqshift.c | 379

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/h264idct_template: Fix integer overflow in ff_h264_chroma422_dc_dequant_idct()

2020-10-20 Thread Michael Niedermayer
On Thu, Oct 15, 2020 at 10:32:29PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 241173056 + 1953511200 cannot be represented > in type 'int' > Fixes: > 26086/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5068366420901888 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 3/5] avformat/asfdec_f: Check name_len for overflow

2020-10-20 Thread Michael Niedermayer
On Thu, Oct 15, 2020 at 10:32:30PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1172299744 * 2 cannot be represented in type > 'int' > Fixes: > 26258/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5672758488596480 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/notchlc: Check uncompressed size against input for LZ4

2020-10-20 Thread Michael Niedermayer
On Thu, Oct 15, 2020 at 10:32:28PM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 26168/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-6019839015256064 > > Equation is based on LZ4_COMPRESSBOUND from lz4.h > Suggested-by: Paul > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-20 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 12:46:12PM +0200, Michael Niedermayer wrote: > Fixes: stack buffer overflow (read) > Fixes: > 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mobiclip: Avoid signed integer overflows in idct()

2020-10-20 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 07:35:26PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 536870912 + 1610612736 cannot be represented > in type 'int' > Fixes: > 26288/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-6194364759670784 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/adpcm: Check channels before use for ADPCM_PSX

2020-10-20 Thread Michael Niedermayer
On Thu, Oct 15, 2020 at 10:32:31PM +0200, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: > 26293/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_PSX_fuzzer-5176665237618688 > Fixes: > 26331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_PSX_fuzzer-5632330364092416

Re: [FFmpeg-devel] [PATCH] libavformat/utils: Fix misleading indent

2020-10-20 Thread Michael Niedermayer
On Tue, Oct 13, 2020 at 03:59:06PM +1100, Chris Miceli wrote: > 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994 introduced this and it was part > of a very large merging of refactoring. Current behaviour is what is > reflected by this indenting change, however my understanding of timing > is such that

Re: [FFmpeg-devel] [PATCH] avcodec/cri: Check for end of image in unpack_10bit()

2020-10-20 Thread Michael Niedermayer
On Thu, Oct 15, 2020 at 05:52:48PM +0200, Michael Niedermayer wrote: > Fixes: out of array write > Fixes: > 26242/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5161495882891264 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode/ff_get_buffer: Check for overflow in FFALIGN()

2020-10-20 Thread Michael Niedermayer
On Wed, Oct 14, 2020 at 05:53:08PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 64 cannot be represented in type > 'int' > Fixes: > 26218/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5734075396259840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-20 Thread Nachiket Tarate
From: ffmpeg-devel on behalf of Steven Liu Sent: Tuesday, October 20, 2020 7:55 AM To: FFmpeg development discussions and patches Cc: Steven Liu Subject: Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

Re: [FFmpeg-devel] [PATCH 2/4] avformat/hlsenc: Don't use uninitialized buffer in av_stristr()

2020-10-20 Thread Steven Liu
Andreas Rheinhardt 于2020年10月20日周二 下午7:04写道: > > Introduced in a2b1dd0ce301450a47c972745a6b33c4c273aa5d. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/hlsenc: Fix mixed declaration and code

2020-10-20 Thread Steven Liu
Andreas Rheinhardt 于2020年10月20日周二 下午7:04写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 22077073bd..4967247bca 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsenc: Fix extradata length check

2020-10-20 Thread Steven Liu
Andreas Rheinhardt 于2020年10月20日周二 下午7:03写道: > > Commit a2b1dd0ce301450a47c972745a6b33c4c273aa5d added support for > parsing annex B HEVC extradata to extract profile and level information. > Yet it only checks for there to be enough data left for the startcode > and the first byte of the NAL unit

Re: [FFmpeg-devel] [PATCH 4/4] avformat/hlsenc: Fix check for SPS

2020-10-20 Thread Steven Liu
Andreas Rheinhardt 于2020年10月20日周二 下午7:04写道: > > Check all the six bits, not only the two bits that are set for SPS. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH 3/4] avformat/hlsenc: Fix mixed declaration and code

2020-10-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 22077073bd..4967247bca 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -352,13 +352,14 @@ static void

[FFmpeg-devel] [PATCH 4/4] avformat/hlsenc: Fix check for SPS

2020-10-20 Thread Andreas Rheinhardt
Check all the six bits, not only the two bits that are set for SPS. Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 4967247bca..cbfd8f7c0d 100644 ---

[FFmpeg-devel] [PATCH 2/4] avformat/hlsenc: Don't use uninitialized buffer in av_stristr()

2020-10-20 Thread Andreas Rheinhardt
Introduced in a2b1dd0ce301450a47c972745a6b33c4c273aa5d. Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 49c4ab5966..22077073bd 100644 --- a/libavformat/hlsenc.c +++

[FFmpeg-devel] [PATCH 1/4] avformat/hlsenc: Fix extradata length check

2020-10-20 Thread Andreas Rheinhardt
Commit a2b1dd0ce301450a47c972745a6b33c4c273aa5d added support for parsing annex B HEVC extradata to extract profile and level information. Yet it only checks for there to be enough data left for the startcode and the first byte of the NAL unit header and not for the full NAL unit header; it simply

Re: [FFmpeg-devel] [PATCH] tests/audiomatch: removes a warning when compiling tests/audiomatch

2020-10-20 Thread Steven Liu
liuqi05 于2020年10月19日周一 下午2:10写道: > > the warning message: > warning: using floating point absolute value function > 'fabs' when argument is of integer type > use FFABS to set the absolute value. > > Signed-off-by: liuqi05 > --- > tests/audiomatch.c | 7 --- > 1 file changed, 4

Re: [FFmpeg-devel] [PATCH] doc/general_contents.texi: add uavs3d section

2020-10-20 Thread Gyan Doshi
On 20-10-2020 02:07 pm, hwren wrote: Will apply if no more suggestions. LGTM. Thanks, Huiwen Ren At 2020-10-06 15:08:21, hwr...@126.com wrote: From: hwren Signed-off-by: hwren --- doc/general_contents.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] doc/general_contents.texi: add uavs3d section

2020-10-20 Thread hwren
Will apply if no more suggestions. Thanks, Huiwen Ren At 2020-10-06 15:08:21, hwr...@126.com wrote: >From: hwren > >Signed-off-by: hwren >--- > doc/general_contents.texi | 10 ++ > 1 file changed, 10 insertions(+) > >diff --git a/doc/general_contents.texi b/doc/general_contents.texi

Re: [FFmpeg-devel] [PATCH 4/7] avformat/sbgdec: Check for timestamp overflow in parse_time_sequence()

2020-10-20 Thread Michael Niedermayer
On Mon, Oct 19, 2020 at 04:32:56PM +0200, Nicolas George wrote: > Michael Niedermayer (12020-10-19): > > Fixes: signed integer overflow: 345801500790256 + 642568637304000 > > cannot be represented in type 'long' > > Fixes: > >

[FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Fix memleak upon init failure

2020-10-20 Thread Andreas Rheinhardt
Up until now, there was no cleanup in case initializing the Theora VLC tables failed, leading to memleaks. This commit gets rid of them by setting the FF_CODEC_CAP_INIT_CLEANUP flag for all decoders in vp3.c; this also allows to remove some (now redundant) cleanup code. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Unify initializing and freeing VLC tables

2020-10-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 163 --- libavcodec/vp3data.h | 22 ++ libavcodec/vp4data.h | 22 ++ 3 files changed, 55 insertions(+), 152 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index

[FFmpeg-devel] [PATCH 4/4] avcodec/vp3: Make parsing Theora Huffman tables more spec-compliant

2020-10-20 Thread Andreas Rheinhardt
Theora allows to use custom Huffman tables which are coded in the bitstream as a tree: Whether the next node is a leaf or not is coded in a bit; each node itself contains a five bit token. Each tree can contain at most 32 leafs; typically they contain exactly 32 with the 32 symbols forming a

[FFmpeg-devel] [PATCH 2/4] avcodec/vp3: Check allocations of VLCs

2020-10-20 Thread Andreas Rheinhardt
It would lead to crashs lateron if they failed. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 112 +++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 0d8d1ff80f..7ee65c8062 100644