Re: [FFmpeg-devel] [PATCH] avformat/dhav: also support ZLAV packets

2020-10-25 Thread zhilizhao(赵志立)
> > On Oct 25, 2020, at 7:58 AM, Michael Keeley wrote: > > Hi Zhao, > >>> Some DVRs (e.g. D7008FH made by Zhuhai Ltd) output the same format >> .dav file, >>> but use ZLAV/zlav tags to delimit the packets instead of DHAV/dhav. >> >> Zhuhai Ltd doesn't look like the real company name. I didn't

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-25 Thread lance . lmwang
On Sun, Oct 25, 2020 at 06:47:27PM +0100, Marton Balint wrote: > > > On Sun, 25 Oct 2020, lance.lmw...@gmail.com wrote: > > > On Sun, Oct 25, 2020 at 01:04:11PM +0100, Marton Balint wrote: > > > > > > > > > On Thu, 22 Oct 2020, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang > >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-25 Thread Jan Ekström
On Wed, Oct 14, 2020 at 2:54 AM Mohammad Izadi wrote: > > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > > The fate

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: Check for unset obu instead of crashing

2020-10-25 Thread James Almer
On 10/25/2020 8:00 PM, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: > 26550/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5417762807349248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

[FFmpeg-devel] [PATCH 4/4] avformat/argo_brp: Check num_frames before using it to compute the duration

2020-10-25 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: 26572/clusterfuzz-testcase-minimized-ffmpeg_dem_ARGO_BRP_fuzzer-5166735591997440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/argo_brp.c | 3 ++- 1 file cha

[FFmpeg-devel] [PATCH 3/4] avcodec/utils: Check bitrate for overflow in get_bit_rate()

2020-10-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 617890810133996544 * 16 cannot be represented in type 'long' Fixes: 26565/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5092054700654592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: Check for unset obu instead of crashing

2020-10-25 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 26550/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5417762807349248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/av1dec.c | 7 ++-

[FFmpeg-devel] [PATCH 2/4] avformat/mov: Check if hoov is at the end

2020-10-25 Thread Michael Niedermayer
Fixes: Timeout, probably infinite loop Fixes: 26559/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5391165484171264 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vp3: Make parsing Theora Huffman tables more spec-compliant

2020-10-25 Thread Peter Ross
On Sun, Oct 25, 2020 at 09:02:25AM +0100, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Theora allows to use custom Huffman tables which are coded in the > > bitstream as a tree: Whether the next node is a leaf or not is coded > > in a bit; each node itself contains a five bit token. Each tre

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-25 Thread Marton Balint
On Sun, 25 Oct 2020, lance.lmw...@gmail.com wrote: On Sun, Oct 25, 2020 at 01:04:11PM +0100, Marton Balint wrote: On Thu, 22 Oct 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > now first_pts assume dts will start from zero, if it's not true(copyts is enable), > too many null

[FFmpeg-devel] [PATCH 5/5] ffmpeg.c: stop accessing private AVStream.codec_info_nb_frames

2020-10-25 Thread Anton Khirnov
Use AVSTREAM_EVENT_FLAG_NEW_PACKETS instead, which should provide the same information in this case. --- fftools/ffmpeg_opt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index a0d1b06f2d..d58462b6ae 100644 --- a/fftools/ffmpeg_o

[FFmpeg-devel] [PATCH 4/5] avformat: add a stream event flag for new packets

2020-10-25 Thread Anton Khirnov
--- libavformat/avformat.h | 6 ++ libavformat/utils.c| 2 ++ 2 files changed, 8 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 3ad92a06e7..6aa7c310f7 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -995,6 +995,12 @@ typedef struct AVS

[FFmpeg-devel] [PATCH 2/5] avformat: extend documentation of event_flags

2020-10-25 Thread Anton Khirnov
Document how it is to be used for muxing (currently supported by flvenc). --- libavformat/avformat.h | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 2c54177591..3ad92a06e7 100644 ---

[FFmpeg-devel] [PATCH 3/5] ffmpeg.c: rename 'area' to 'score'

2020-10-25 Thread Anton Khirnov
Other factors besides area are used to pick the best video stream, so the name 'area' is misleading. --- fftools/ffmpeg_opt.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 19f719e3ff..a0d1b06f2d 100644 --- a/fftoo

[FFmpeg-devel] [PATCH 1/5] avformat: fix typo in doxy

2020-10-25 Thread Anton Khirnov
av_read_frame() reads new packets, av_read_packet() does not exist. --- libavformat/avformat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index acfe25239d..2c54177591 100644 --- a/libavformat/avformat.h +++ b/libavformat/avfo

[FFmpeg-devel] [RFC] replacing AVStream.codec_info_nb_frames in fmpeg.c

2020-10-25 Thread Anton Khirnov
Hi, this patch set implements the idea from 160363238545.32279.13634998196741008...@lain.red.khirnov.net by exporting "there were new packets for this AVStream" as an event flag. It should allow us to stop accessing private AVstream.codec_info_nb_frames in ffmpeg.c, but keep the same results for pi

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg.c: refine picking default video stream

2020-10-25 Thread James Almer
On 10/25/2020 10:26 AM, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-10-25 14:17:06) >> Anton Khirnov: >>> Quoting Michael Niedermayer (2020-10-21 13:17:46) are we talking about the same thing ? ./ffmpeg -i ~/tickets/4496/08_lect_01.rm file.avi produces a outpu

[FFmpeg-devel] [PATCH] http: support retry on connection error

2020-10-25 Thread Eran Kornblau
Hi, This patch adds 2 options to http: - reconnect_on_status - a list of http status codes that should be retried. the list can contain explicit status codes or the strings 4xx/5xx. - reconnect_on_err - reconnects on arbitrary errors during connect, e.g. ECONNRESET/ETIMEDOUT. The retry employs

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg.c: refine picking default video stream

2020-10-25 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-10-25 14:17:06) > Anton Khirnov: > > Quoting Michael Niedermayer (2020-10-21 13:17:46) > >> > >> are we talking about the same thing ? > >> ./ffmpeg -i ~/tickets/4496/08_lect_01.rm file.avi > >> > >> produces a output over 1 hour long before the patch, theres no s

Re: [FFmpeg-devel] [PATCH] tests/fate/hevc: Add test for 3fbf8737923ac49754946a2505367630544b87f1

2020-10-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-10-25 10:01:20) > On Thu, Oct 22, 2020 at 11:38:36AM +0200, Michael Niedermayer wrote: > > Tested-on: x86-32/64/ARM/MIPS Linux, Mingw/WINE 32/64 > > Signed-off-by: Michael Niedermayer > > --- > > tests/fate/hevc.mak| 3 +++ > > tests/ref/fate/hevc

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-25 Thread lance . lmwang
On Sun, Oct 25, 2020 at 01:04:11PM +0100, Marton Balint wrote: > > > On Thu, 22 Oct 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > now first_pts assume dts will start from zero, if it's not true(copyts is > > enable), > > too many null packet will be inserted for cbr outpu

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg.c: refine picking default video stream

2020-10-25 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Michael Niedermayer (2020-10-21 13:17:46) >> >> are we talking about the same thing ? >> ./ffmpeg -i ~/tickets/4496/08_lect_01.rm file.avi >> >> produces a output over 1 hour long before the patch, theres no seek to >> before EOF >> >> ./ffmpeg -i ~/tickets/4496/08_lect

Re: [FFmpeg-devel] [PATCH 2/3] ffmpeg.c: refine picking default video stream

2020-10-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-10-21 13:17:46) > > are we talking about the same thing ? > ./ffmpeg -i ~/tickets/4496/08_lect_01.rm file.avi > > produces a output over 1 hour long before the patch, theres no seek to before > EOF > > ./ffmpeg -i ~/tickets/4496/08_lect_01.rm file-new.avi >

Re: [FFmpeg-devel] [PATCHv2] Document community process

2020-10-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-10-19 23:57:31) > On Mon, Oct 19, 2020 at 07:22:48PM +0200, Jean-Baptiste Kempf wrote: > > Yo, > > > > On Mon, 19 Oct 2020, at 19:02, Michael Niedermayer wrote: > > > > +## Voting > > > > + > > > > > > > +Voting is done using a ranked voting system, currently run

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm[...]

2020-10-25 Thread Anton Khirnov
Quoting Alan Kelly (2020-10-23 15:34:18) > Fixed. The wrong step size was used causing a write passed the end of > the buffer. yuv2yuvX_mmxext is now called if there are any remaining > pixels. > > There is currently no checkasm for these functions. Is this required for > submission? Not stric

Re: [FFmpeg-devel] Request for Technical committee action

2020-10-25 Thread Paul B Mahol
Ping. On Tue, Jul 21, 2020 at 11:56 PM Paul B Mahol wrote: > On 7/21/20, Kieran Kunhya wrote: > >> > >> This is not about peer review code or better quality code overall. > >> If it was about that, mentioned parties would show their pseudo code > >> to improve current proposed code already. > >

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2020-10-25 Thread Paul B Mahol
On Thu, Apr 25, 2019 at 9:14 PM Nicolas George wrote: > Paul B Mahol (12019-04-25): > > Not really, it works with 2x/3x/4x/5x.. sample rate or 1/2 / 1/3 / 1/4 / > 1/5 > > o sample rate in other direction. > > I do not think so: the algorithm can work for absolutely any ratio. The > effect on the

Re: [FFmpeg-devel] [PATCH v3 0/6] ffmpeg: late A/V encoder init, AVFrame metadata usage

2020-10-25 Thread Jan Ekström
On Wed, Oct 21, 2020 at 10:14 AM Jan Ekström wrote: > > On Fri, Oct 16, 2020, 16:16 Jan Ekström wrote: >> >> This patch set started with a very simple wish to not have to set color >> related values manually each time when utilizing ffmpeg.c. >> >> As of the third iteration, the following changes

Re: [FFmpeg-devel] [PATCH v3] lavf/url: fix rel path’s query string contains :/

2020-10-25 Thread Marton Balint
On Fri, 23 Oct 2020, 蔡昊凝 wrote: 于2020年10月17日周六 下午11:17写道: From: "ruiquan.crq" Signed-off-by: ruiquan.crq --- libavformat/tests/url.c | 2 ++ libavformat/url.c | 2 +- tests/ref/fate/url | 8 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavformat/t

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: use total_size instead of avio_tell()

2020-10-25 Thread Marton Balint
On Thu, 22 Oct 2020, lance.lmw...@gmail.com wrote: From: Limin Wang avio_tell() fails to get the amount of data written so far when the underlying IO context is flushed to segments. Please test with below command: $ ./ffmpeg -f lavfi -i testsrc=duration=100:size=vga -c:v libx264 -x264opts

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-25 Thread Marton Balint
On Thu, 22 Oct 2020, lance.lmw...@gmail.com wrote: From: Limin Wang now first_pts assume dts will start from zero, if it's not true(copyts is enable), too many null packet will be inserted for cbr output. Please test with below command, you'll get huge test.ts without the patch: ./ffmpeg -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rv34: Don't needlessly copy VLC length and symbol arrays

2020-10-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Most of the VLCs used by RealVideo 3 and 4 obey three simple rules: > Shorter codes are on the left of the tree, for each length, the symbols > are ascending from left to right and the symbols either form a > permutation of 1..size or 0..(size - 1). For the latter case, one ju

Re: [FFmpeg-devel] [PATCH 1/8] tools/target_dem_fuzzer: Limit max blocks

2020-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2020 at 12:23:05AM +0200, Michael Niedermayer wrote: > With a IO block size of 1 byte potentially megabytes are quite slow to read, > thus > limit the number > > Fixes: > 26511/clusterfuzz-testcase-minimized-ffmpeg_dem_NUV_fuzzer-5679249073373184 > Fixes: > 26517/clusterfuzz-tes

Re: [FFmpeg-devel] [PATCH] tests/fate/hevc: Add test for 3fbf8737923ac49754946a2505367630544b87f1

2020-10-25 Thread Michael Niedermayer
On Thu, Oct 22, 2020 at 11:38:36AM +0200, Michael Niedermayer wrote: > Tested-on: x86-32/64/ARM/MIPS Linux, Mingw/WINE 32/64 > Signed-off-by: Michael Niedermayer > --- > tests/fate/hevc.mak| 3 +++ > tests/ref/fate/hevc-small422chroma | 6 ++ > 2 files changed, 9 insertions(+)

Re: [FFmpeg-devel] [PATCH 11/11] avutil/mathematics: Use av_sat_add64() for the last addition in av_add_stable()

2020-10-25 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:19PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854770375 + 5450 cannot be > represented in type 'long' > Fixes: > 26471/clusterfuzz-testcase-minimized-ffmpeg_dem_MXG_fuzzer-6229617557635072 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 10/11] avformat/lrcdec: Clip timestamps

2020-10-25 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:18PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 7531010 - -7335632962598013506 > cannot be represented in type 'long' > Fixes: > 26463/clusterfuzz-testcase-minimized-ffmpeg_dem_LRC_fuzzer-6015558333759488 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 09/11] avformat/pcm: Check block_align

2020-10-25 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:17PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 321 * 8746632 cannot be represented in type > 'int' > Fixes: > 26461/clusterfuzz-testcase-minimized-ffmpeg_dem_PVF_fuzzer-6326427831762944 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH 07/11] avformat/rmdec: Make expected_len 64bit

2020-10-25 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:15PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1347551268 * 14 cannot be represented in type > 'int' > Fixes: > 26458/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-5655364324032512 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH 02/11] tools/target_dec_fuzzer: adjust threshold for wmalossless

2020-10-25 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:10PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (>30sec -> 0.5sec) > Fixes: > 26351/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5191487740182528 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/maste

Re: [FFmpeg-devel] [PATCH 2/8] avformat/electronicarts: Check for EOF in each iteration of the loop in ea_read_packet()

2020-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2020 at 12:34:25PM +1100, Peter Ross wrote: > On Sun, Oct 25, 2020 at 12:23:06AM +0200, Michael Niedermayer wrote: > > Fixes: timeout(>20sec -> 1ms) > > Fixes: > > 26526/clusterfuzz-testcase-minimized-ffmpeg_dem_EA_fuzzer-567232806912 > > > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/pgxdec: Check depth more completely

2020-10-25 Thread Michael Niedermayer
On Sat, Oct 24, 2020 at 05:23:47PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Fri, Oct 09, 2020 at 06:52:18PM +0200, Michael Niedermayer wrote: > >> On Thu, Oct 08, 2020 at 09:48:41PM +0200, Andreas Rheinhardt wrote: > >>> Michael Niedermayer: > Fixes: shift exponent -1 is

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vp3: Make parsing Theora Huffman tables more spec-compliant

2020-10-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Theora allows to use custom Huffman tables which are coded in the > bitstream as a tree: Whether the next node is a leaf or not is coded > in a bit; each node itself contains a five bit token. Each tree can > contain at most 32 leafs; typically they contain exactly 32 with the