Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-29 Thread Linjie Fu
On Fri, Oct 30, 2020 at 9:18 AM wrote: > On Thu, Oct 29, 2020 at 09:09:00PM +0800, Linjie Fu wrote: > > On Thu, Oct 29, 2020 at 7:16 PM wrote: > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavfilter/unsharp.h| 3 + > > > libavfilter/vf_unsharp.c | 16

[FFmpeg-devel] [PATCH v2 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 3 ++ tests/ref/fate/filter-unsharp-yuv420p10 | 55 + 2 files changed, 58 insertions(+) create mode 100644 tests/ref/fate/filter-unsharp-yuv420p10 diff --git a/tests/fate/

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-29 Thread lance . lmwang
On Thu, Oct 29, 2020 at 09:09:00PM +0800, Linjie Fu wrote: > On Thu, Oct 29, 2020 at 7:16 PM wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/unsharp.h| 3 + > > libavfilter/vf_unsharp.c | 162 > > +-- > >

Re: [FFmpeg-devel] [PATCH] avformat/jacosubdec: Fix unintended fallthrough

2020-10-29 Thread Michael Niedermayer
On Thu, Oct 29, 2020 at 01:39:35PM +0100, Andreas Rheinhardt wrote: > Regression since 715ff75e5dbbbefff7337351db596a9b7a5d4379. > > Fixes Coverity issues #1468654 and #1468656. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/jacosubdec.c | 12 +--- > 1 file changed, 9 inserti

[FFmpeg-devel] [PATCH] avformat/dv: allow returning damaged audio

2020-10-29 Thread Michael Niedermayer
These potentially damaged packets are marked as corrupt. The packet length is predicted based on packet length history, allowing prediction of the common pattern used in NTSC. Fixes: Ticket8762 Tested-by: Dave Rice Signed-off-by: Michael Niedermayer --- libavformat/dv.c | 60 +++

Re: [FFmpeg-devel] [PATCH] tls: Hook up the url_get_short_seek function in the TLS backends

2020-10-29 Thread Martin Storsjö
On Thu, 29 Oct 2020, Andreas Rheinhardt wrote: Martin Storsjö: This makes sure that small seeks forward on https don't end up doing new requests. --- libavformat/tls_gnutls.c | 7 +++ libavformat/tls_libtls.c | 7 +++ libavformat/tls_mbedtls.c | 7 +++ lib

Re: [FFmpeg-devel] [PATCH] tls: Hook up the url_get_short_seek function in the TLS backends

2020-10-29 Thread Andreas Rheinhardt
Martin Storsjö: > This makes sure that small seeks forward on https don't end up > doing new requests. > --- > libavformat/tls_gnutls.c | 7 +++ > libavformat/tls_libtls.c | 7 +++ > libavformat/tls_mbedtls.c | 7 +++ > libavformat/tls_openssl.c | 7 ++

[FFmpeg-devel] [PATCH] tls: Hook up the url_get_short_seek function in the TLS backends

2020-10-29 Thread Martin Storsjö
This makes sure that small seeks forward on https don't end up doing new requests. --- libavformat/tls_gnutls.c | 7 +++ libavformat/tls_libtls.c | 7 +++ libavformat/tls_mbedtls.c | 7 +++ libavformat/tls_openssl.c | 7 +++ libavformat/tls_schanne

Re: [FFmpeg-devel] [PATCH] avcodec/rkmpp : reset end of stream flag on flush

2020-10-29 Thread David Sowa
This is my first code submission to this project which I did a few days back and received no feedback, probably because I've done something wrong. So I will provide more details on the issue and the solution in hopes of moving the process forward. The code I have that uses libavcodec allows the us

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/utils: Check sample rate before use for AV_CODEC_ID_BINKAUDIO_DCT in get_audio_frame_duration()

2020-10-29 Thread Michael Niedermayer
On Wed, Oct 28, 2020 at 12:17:47PM +1100, Peter Ross wrote: > On Tue, Oct 27, 2020 at 05:21:19PM +0100, Michael Niedermayer wrote: > > Fixes: shift exponent 95 is too large for 32-bit type 'int' > > Fixes: > > 26590/clusterfuzz-testcase-minimized-ffmpeg_dem_SMACKER_fuzzer-5120609937522688 > > > >

Re: [FFmpeg-devel] [PATCH v4 4/5] ffmpeg: pass decoded or filtered AVFrame to output stream initialization

2020-10-29 Thread Michael Niedermayer
On Tue, Oct 27, 2020 at 08:30:55PM +0200, Jan Ekström wrote: > Additionally, reap the first rewards by being able to set the > color related encoding values based on the passed AVFrame. > > The only tests that seem to have changed their results with this > change seem to be the MXF tests. There, t

Re: [FFmpeg-devel] [PATCH v4 0/5] ffmpeg: late A/V encoder init, AVFrame metadata usage

2020-10-29 Thread Jan Ekström
On Wed, Oct 28, 2020 at 4:58 PM Jan Ekström wrote: > > On Tue, Oct 27, 2020 at 8:30 PM Jan Ekström wrote: > > > > This patch set started with a very simple wish to not have to set color > > related values manually each time when utilizing ffmpeg.c. > > > > As of the fourth iteration, the followin

Re: [FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Check filename length before use

2020-10-29 Thread Andreas Rheinhardt
Nicolas George: > Michael Niedermayer (12020-10-28): >> Fixes: out array read >> Fixes: >> 26610/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5631838049271808 >> >> Found-by: continuous fuzzing process >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Check filename length before use

2020-10-29 Thread Nicolas George
Michael Niedermayer (12020-10-28): > Fixes: out array read > Fixes: > 26610/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5631838049271808 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > -

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-10-29 Thread Christophe Gisquet
Forgot to add this: Le jeu. 29 oct. 2020 à 14:51, Christophe Gisquet a écrit : > > [1] https://github.com/oddstone/FFmpeg/commits/rext1 > > This has additional fixes (which looks good, haven't really delved > into it) that unfortunately doesn't fix: And I suspect you need these entropy state fix

[FFmpeg-devel] [PATCH 2/2] avcodec/mimic: Inline constants

2020-10-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mimic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mimic.c b/libavcodec/mimic.c index 2563a49d53..0f8103ef85 100644 --- a/libavcodec/mimic.c +++ b/libavcodec/mimic.c @@ -34,6 +34,7 @@ #include "thread.h"

[FFmpeg-devel] [PATCH 1/2] avcodec/tscc2: Don't check for errors for complete VLCs

2020-10-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/tscc2.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/tscc2.c b/libavcodec/tscc2.c index 6aadb51ad4..9fa28fe9fc 100644 --- a/libavcodec/tscc2.c +++ b/libavcodec/tscc2.c @@ -151,8 +151,6 @@ static int tscc2_decode_mb(TSCC2Conte

[FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

2020-10-29 Thread Anton Khirnov
They add considerable complexity to frame-threading implementation, which includes an unavoidably leaking error path, while the advantages of this option to the users are highly dubious. It should be always possible and desirable for the callers to make their get_buffer2() implementation thread-sa

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-10-29 Thread Christophe Gisquet
Hi, Le mar. 29 sept. 2020 à 17:55, Linjie Fu a écrit : > I didn’t see such plans for now, hence adding sufficient error message > seems to be a proper way. Hi, as you are the only one active on this decoder, this shouldn't matter, but: down the line, the ffmpeg project has no way of testing if s

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-10-29 Thread Christophe Gisquet
Hi, Le ven. 2 oct. 2020 à 18:12, Guangxin Xu a écrit : > Most of scc conformance clip has tiles. > But currently, the hevc software decoder has many issues for tile cabac > saving and loading. > We'd better fix them before starting implement scc tool. > > I have queue up some patches to address t

Re: [FFmpeg-devel] [PATCH 2/2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2020-10-29 Thread Christophe Gisquet
Le sam. 29 août 2020 à 07:52, Xu Guangxin a écrit : > you can download it from: > https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.bit Just for the record, this is now https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_ex

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-10-29 Thread Joakim Tjernlund
Ping .. On Tue, 2020-10-27 at 08:48 +, Joakim Tjernlund wrote: > > Yet a ping ... > > This is a simple technical patch, it just needs a policy decision. > Can I have one ? > >    Jocke > > On Thu, 2020-10-22 at 14:17 +0200, Joakim Tjernlund wrote: > > Ping ? > > > >  Jocke > > > > On Fri

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

2020-10-29 Thread Anton Khirnov
Quoting Moritz Barsnick (2020-08-10 23:14:59) > On Tue, Aug 04, 2020 at 13:59:42 +0200, Anton Khirnov wrote: > > --- a/fftools/ffmpeg.c > > +++ b/fftools/ffmpeg.c > > @@ -2883,7 +2883,9 @@ static int init_input_stream(int ist_index, char > > *error, int error_len) > > ist->dec_ctx->opaque

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-29 Thread Linjie Fu
On Thu, Oct 29, 2020 at 7:16 PM wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/unsharp.h| 3 + > libavfilter/vf_unsharp.c | 162 > +-- > 2 files changed, 90 insertions(+), 75 deletions(-) > > diff --git a/libavfilte

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevcdec: fix stat_coeff save/load for persistent_rice_adaptation_enabled_flag

2020-10-29 Thread Christophe Gisquet
Le mer. 9 sept. 2020 à 07:51, Guangxin Xu a écrit : > Hi Mickaël & all, > any suggestions? The patch is almost good, though I would have hoped to link at a relevant part of the specs and TableStatCoeff* beyong just "9.3". Though as I suspected, there is probably something missing. Maybe around s

Re: [FFmpeg-devel] [PATCH 1/4] avformat/apngdec: Check for incomplete reads in append_extradata()

2020-10-29 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: OOM > Fixes: > 26608/clusterfuzz-testcase-minimized-ffmpeg_dem_APNG_fuzzer-4839491644424192 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/apngdec.c

[FFmpeg-devel] [PATCH] avformat/jacosubdec: Fix unintended fallthrough

2020-10-29 Thread Andreas Rheinhardt
Regression since 715ff75e5dbbbefff7337351db596a9b7a5d4379. Fixes Coverity issues #1468654 and #1468656. Signed-off-by: Andreas Rheinhardt --- libavformat/jacosubdec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubd

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/unsharp.h| 3 + libavfilter/vf_unsharp.c | 162 +-- 2 files changed, 90 insertions(+), 75 deletions(-) diff --git a/libavfilter/unsharp.h b/libavfilter/unsharp.h index a60b30f..253e32d

[FFmpeg-devel] [PATCH 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index 639f957..f295df4 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -410,6

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_unsharp: add more pixel format support

2020-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_unsharp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c index 416bf1c..e9b6c90 100644 --- a/libavfilter/vf_unsharp.c +++ b/libavfilter/vf_unsharp.c @@ -201,6 +201,10 @@ st

[FFmpeg-devel] [PATCH v2 2/2] avformat/mpegtsenc: first timestamp check needed

2020-10-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 383181d..9e105b7 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -232,

Re: [FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder

2020-10-29 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Thursday, October 29, 2020 5:18 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder > > On 02/10/2020 15:28, Fei Wang wrote: > > Example cmdline: > > ffmpeg

[FFmpeg-devel] [PATCH v5] avcodec: add av1 VAAPI decoder

2020-10-29 Thread Fei Wang
Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- change: 1.rebase v4 to master. Changelog | 1 + configure | 3