Re: [FFmpeg-devel] [PATCH v4 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 11:40:27AM -0400, Andriy Gelman wrote: > Hi Limin, > > On Fri, 30. Oct 23:11, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak | 3 +++ > > tests/ref/fate/filter-unsharp-yuv420p10

Re: [FFmpeg-devel] [PATCH 1/4] avformat/apngdec: Check for incomplete reads in append_extradata()

2020-10-30 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Oct 29, 2020 at 02:25:49PM +0100, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: OOM >>> Fixes: >>> 26608/clusterfuzz-testcase-minimized-ffmpeg_dem_APNG_fuzzer-4839491644424192 >>> >>> Found-by: continuous fuzzing process >>>

Re: [FFmpeg-devel] [PATCH 1/4] avformat/apngdec: Check for incomplete reads in append_extradata()

2020-10-30 Thread Michael Niedermayer
On Thu, Oct 29, 2020 at 02:25:49PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: OOM > > Fixes: > > 26608/clusterfuzz-testcase-minimized-ffmpeg_dem_APNG_fuzzer-4839491644424192 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH 3/5] avformat/mpc8: correct integer overflow in mpc8_parse_seektable()

2020-10-30 Thread Michael Niedermayer
Fixes: signed integer overflow: -4683718486770919638 * 2 cannot be represented in type 'long' Fixes: 26704/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-6327056939614208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/5] avformat/mov: Fix memleak in dref reading

2020-10-30 Thread Michael Niedermayer
Fixes: leak in mov_read_dref() Fixes: 26698/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5638785444085760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 5 + 1 file

[FFmpeg-devel] [PATCH 4/5] avformat/mpc8: Check remaining space in mpc8_parse_seektable()

2020-10-30 Thread Michael Niedermayer
Fixes: Fixes infinite loop Fixes: 26704/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-6327056939614208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mpc8.c | 4 1 file

[FFmpeg-devel] [PATCH 1/5] avformat/argo_brp: Check block align before use

2020-10-30 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 26667/clusterfuzz-testcase-minimized-ffmpeg_dem_ARGO_BRP_fuzzer-5645146928185344.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/argo_brp.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 5/5] avformat/rmdec: Check remaining space in debug av_log() loop

2020-10-30 Thread Michael Niedermayer
Fixes: Timeout (long -> 2 ms) Fixes: 26709/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5665833403285504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/rmdec.c | 5 - 1 file

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-30 Thread Bohan Li
Gentle ping :) Bohan On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > Hi Jan, > > Thanks for the suggestion! I believe that is a good idea. I am not super > familiar with this part, though, so will probably need to propose this to > the Aomedia issue tracker. > Meanwhile I think it is also

Re: [FFmpeg-devel] [PATCH 04/11] avformat/utils: Move +1 to avoid overflow

2020-10-30 Thread Michael Niedermayer
On Wed, Oct 21, 2020 at 08:47:22AM +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Michael Niedermayer: > >> Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > >> represented in type 'long' > >> Fixes: Timeout > >> Fixes: > >>

[FFmpeg-devel] [PATCH] avcodec/mpc8: Unobfuscate sign-extension

2020-10-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpc8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpc8.c b/libavcodec/mpc8.c index 03838a9351..631bac2753 100644 --- a/libavcodec/mpc8.c +++ b/libavcodec/mpc8.c @@ -384,7 +384,7 @@ static int

Re: [FFmpeg-devel] [PATCH v4 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread Andriy Gelman
Hi Limin, On Fri, 30. Oct 23:11, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 3 +++ > tests/ref/fate/filter-unsharp-yuv420p10 | 25 + > 2 files changed, 28 insertions(+) > create

[FFmpeg-devel] [PATCH v4 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/unsharp.h| 3 + libavfilter/vf_unsharp.c | 162 +-- 2 files changed, 90 insertions(+), 75 deletions(-) diff --git a/libavfilter/unsharp.h b/libavfilter/unsharp.h index a60b30f..253e32d

[FFmpeg-devel] [PATCH v4 2/3] avfilter/vf_unsharp: add more pixel format support

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_unsharp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c index 416bf1c..e9b6c90 100644 --- a/libavfilter/vf_unsharp.c +++ b/libavfilter/vf_unsharp.c @@ -201,6 +201,10 @@

[FFmpeg-devel] [PATCH v4 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-unsharp-yuv420p10 | 25 + 2 files changed, 28 insertions(+) create mode 100644 tests/ref/fate/filter-unsharp-yuv420p10 diff --git

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 03:15:08PM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-10-30): > > Sorry, I ignore it for I haven't realized it's a question in fact. > > Please do not ignore things people write to you. If they (I) took time > writing it, there must be a reason. > > >

Re: [FFmpeg-devel] [PATCH 1/9] avformat/segafilm: Check that there is a stream

2020-10-30 Thread Michael Niedermayer
On Thu, Oct 22, 2020 at 12:37:25AM +0200, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 26472/clusterfuzz-testcase-minimized-ffmpeg_dem_SEGAFILM_fuzzer-5759751591559168 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-10-30): > Sorry, I ignore it for I haven't realized it's a question in fact. Please do not ignore things people write to you. If they (I) took time writing it, there must be a reason. > Without the first scale, it'll report error, but without the final scale, > no

[FFmpeg-devel] [PATCH v2] fate: Add test for Musepack SV8 decoding

2020-10-30 Thread Andreas Rheinhardt
While the FATE suite contains a sample file for Musepack 8, it did not use it to test the decoder; it is only used in the mpc8-demux test that tests the demuxer via streamcopy. Therefore this commit adds an actual encoder test. The test uses the framecrc output, because Musepack SV8 is an encoder

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 02:46:50PM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-10-30): > > Sorry, in the previous email I did not understand the meaning of this > > sentence. > > Then maybe ask for clarification instead of just ignoring it? Sorry, I ignore it for I haven't

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-10-30): > Sorry, in the previous email I did not understand the meaning of this > sentence. Then maybe ask for clarification instead of just ignoring it? > Now I think it's necessary to add a final scale like below, correct? >

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 12:12:26PM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-10-30): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak | 3 ++ > > tests/ref/fate/filter-unsharp-yuv420p10 | 55 > >

Re: [FFmpeg-devel] [PATCH] fate: Add test for Musepack SV8 decoding

2020-10-30 Thread Nicolas George
Andreas Rheinhardt (12020-10-30): > While the FATE suite contains a sample file for Musepack 8, it did not > use it to test the decoder; it is only used in the mpc8-demux test that > tests the demuxer via streamcopy. Therefore this commit adds an actual > encoder test. > > The test uses the

[FFmpeg-devel] [PATCH] fate: Add test for Musepack SV8 decoding

2020-10-30 Thread Andreas Rheinhardt
While the FATE suite contains a sample file for Musepack 8, it did not use it to test the decoder; it is only used in the mpc8-demux test that tests the demuxer via streamcopy. Therefore this commit adds an actual encoder test. The test uses the framecrc output, because Musepack SV8 is an encoder

Re: [FFmpeg-devel] [PATCH 3/3] aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB

2020-10-30 Thread Martin Storsjö
On Fri, 30 Oct 2020, Martin Storsjö wrote: The previous threshold, 4 KB, maybe was reasonable when it was set (in 2010), but in today's settings and with typical network speeds and data sizes, it's pretty small. 32 KB probably is a more reasonable default now, regardless of input. ---

[FFmpeg-devel] scale2ref throw segmentation fault if reference frame is HW (cuda)

2020-10-30 Thread Alex
scale2ref video filter failed with message "segmentation fault". Command to reproduce:  I just want to scale watermark depending of size of the main video. ffmpeg -init_hw_device cuda=cuda hwaccel cuda -hwaccel_output_format cuda -filter_hw_device cuda -i 720p.mp4 -ss 10 -t 10 -filter_complex

Re: [FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-10-30): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 3 ++ > tests/ref/fate/filter-unsharp-yuv420p10 | 55 > + > 2 files changed, 58 insertions(+) > create mode 100644

[FFmpeg-devel] [PATCH v3 2/3] avfilter/vf_unsharp: add more pixel format support

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_unsharp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c index 416bf1c..e9b6c90 100644 --- a/libavfilter/vf_unsharp.c +++ b/libavfilter/vf_unsharp.c @@ -201,6 +201,10 @@

[FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_unsharp: add 10bit support

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/unsharp.h| 3 + libavfilter/vf_unsharp.c | 162 +-- 2 files changed, 90 insertions(+), 75 deletions(-) diff --git a/libavfilter/unsharp.h b/libavfilter/unsharp.h index a60b30f..253e32d

[FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 3 ++ tests/ref/fate/filter-unsharp-yuv420p10 | 55 + 2 files changed, 58 insertions(+) create mode 100644 tests/ref/fate/filter-unsharp-yuv420p10 diff --git

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mpegtsenc: first timestamp check needed

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 10:18:29AM +0100, Marton Balint wrote: > > On Thu, 29 Oct 2020, lance.lmw...@gmail.com wrote: > > A better commit message would be: > avformat/mpegtsenc: check that not only first pts but also first dts is valid fix it locally. > > > From: Limin Wang > > > >

[FFmpeg-devel] [PATCH 3/3] aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB

2020-10-30 Thread Martin Storsjö
The previous threshold, 4 KB, maybe was reasonable when it was set (in 2010), but in today's settings and with typical network speeds and data sizes, it's pretty small. 32 KB probably is a more reasonable default now, regardless of input. --- libavformat/aviobuf.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH v2 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread lance . lmwang
On Fri, Oct 30, 2020 at 11:18:28AM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-10-30): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak | 3 ++ > > tests/ref/fate/filter-unsharp-yuv420p10 | 55 > >

[FFmpeg-devel] [PATCH 2/3] tls: Hook up the url_get_short_seek function in the TLS backends

2020-10-30 Thread Martin Storsjö
This makes sure that small seeks forward on https don't end up doing new requests. --- libavformat/tls.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/tls.h b/libavformat/tls.h index 4f3315427d..d33af80454 100644 --- a/libavformat/tls.h +++ b/libavformat/tls.h @@ -56,10

[FFmpeg-devel] [PATCH 1/3] tls: Share code for common protocol functions and fields

2020-10-30 Thread Martin Storsjö
--- libavformat/tls.h | 13 + libavformat/tls_gnutls.c | 11 ++- libavformat/tls_libtls.c | 11 ++- libavformat/tls_mbedtls.c | 11 ++- libavformat/tls_openssl.c | 11 ++- libavformat/tls_schannel.c

Re: [FFmpeg-devel] [PATCH v2 3/3] fate/filter-video: add 10bit test for unsharp filter

2020-10-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-10-30): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 3 ++ > tests/ref/fate/filter-unsharp-yuv420p10 | 55 > + > 2 files changed, 58 insertions(+) > create mode 100644

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mpegtsenc: first timestamp check needed

2020-10-30 Thread Marton Balint
On Thu, 29 Oct 2020, lance.lmw...@gmail.com wrote: A better commit message would be: avformat/mpegtsenc: check that not only first pts but also first dts is valid From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 8 1 file changed, 4 insertions(+), 4