Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/rtsp: don't forget to call ff_network_close() on error

2020-11-20 Thread Andriy Gelman
Hi Martin, Thank you for reviewing the set. On Fri, 20. Nov 10:33, Martin Storsjö wrote: > On Mon, 12 Oct 2020, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > In sdp_read_header() some ff_network_close() calls were missed. > > > > Also in rtp_read_header() update comment to explain w

Re: [FFmpeg-devel] [PATCH 0/3] add vvc raw demuxer

2020-11-20 Thread James Almer
On 11/20/2020 10:55 PM, Nuo Mi wrote: Hi Mark, James and all, There are two ways to implement the parser. 1. use cbs like av1 parser. 2. follow h264/h265 parser method. Which is your preferred? thanks A CBS module for VVC is needed regardless of how the parser is ultimately implemented (There

[FFmpeg-devel] [PATCH 1/3] avcodec/vvc: add shared header for vvc

2020-11-20 Thread Nuo Mi
--- libavcodec/vvc.h | 69 1 file changed, 69 insertions(+) create mode 100644 libavcodec/vvc.h diff --git a/libavcodec/vvc.h b/libavcodec/vvc.h new file mode 100644 index 00..02d532730f --- /dev/null +++ b/libavcodec/vvc.h @@ -0,0 +1,69 @

[FFmpeg-devel] [PATCH 2/3] avcodec: add vvc codec id and profiles

2020-11-20 Thread Nuo Mi
--- libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 8 libavcodec/codec_id.h | 1 + libavcodec/profiles.c | 5 + libavcodec/profiles.h | 1 + 5 files changed, 17 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 20af3ef00d..c120295add 100644

[FFmpeg-devel] [PATCH 4/4] avdevice/decklink_dec: fix warning for unused variable

2020-11-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 049e133..2e41b58 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink

[FFmpeg-devel] [PATCH 3/4] avutil/opt: add AV_OPT_FLAG_DEPRECATED option

2020-11-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/opt.c| 1 + tests/ref/fate/opt | 54 +++--- 2 files changed, 28 insertions(+), 27 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index c8413fa..590146b 100644 --- a/libavu

[FFmpeg-devel] [PATCH 2/4] avdevice/decklink: add AV_OPT_FLAG_DEPRECATED flag for list_devices

2020-11-20 Thread lance . lmwang
From: Limin Wang and claim the option deprecated in the description. Signed-off-by: Limin Wang --- libavdevice/decklink_dec_c.c | 3 ++- libavdevice/decklink_enc_c.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_dec_c.c b/libavdevice/decklink_dec_

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink: use boolean for list_devices option

2020-11-20 Thread lance . lmwang
From: Limin Wang For the document(indevs.texi and outdevs.texi) used it as boolean. Signed-off-by: Limin Wang --- libavdevice/decklink_dec_c.c | 2 +- libavdevice/decklink_enc_c.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_dec_c.c b/libavdevice/

Re: [FFmpeg-devel] [PATCH 0/3] add vvc raw demuxer

2020-11-20 Thread Nuo Mi
Hi Mark, James and all, There are two ways to implement the parser. 1. use cbs like av1 parser. 2. follow h264/h265 parser method. Which is your preferred? thanks On Sat, Nov 21, 2020 at 9:45 AM Nuo Mi wrote: > test command: ffprobe vvc.bit > > Nuo Mi (3): > avcodec/vvc: add shared header for

[FFmpeg-devel] [PATCH] hwcontext_drm: issue DMA_BUF_IOCTL_SYNC when mapping FDs

2020-11-20 Thread Lynne
This improves performance and helps a little when given FDs without any synchronization fences. Patch attached. >From b4b0b8038bef08cf3dae9daa78eca3a675b67f89 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 20 Nov 2020 18:23:42 +0100 Subject: [PATCH] hwcontext_drm: issue DMA_BUF_IOCTL_SYNC when

Re: [FFmpeg-devel] [PATCH] avformat/movenc: allow Apple Lossless inside mp4

2020-11-20 Thread Jan Ekström
On Fri, Nov 20, 2020 at 7:02 PM Leo Izen wrote: > > MP4 already supports Apple Lossless, and it can be put inside by using > muxer=ipod, but it's not tagged as supported in mp4. The mp4ra lists > alac as a valid fourcc inside mp4, so it should be supported by spec. > > See: https://mp4ra.org/#/cod

Re: [FFmpeg-devel] [RFC][PATCH 18/18] avcodec/avpacket: make the AVPacketList API thread safe

2020-11-20 Thread Marton Balint
On Wed, 18 Nov 2020, James Almer wrote: On 11/18/2020 5:08 PM, Marton Balint wrote: On Wed, 18 Nov 2020, James Almer wrote: Signed-off-by: James Almer --- I don't know if this is necessary, so i'm sending it as an RFC. I don't think this API should provide locking by default, maybe as

[FFmpeg-devel] [PATCH] avformat/flacenc: Fix memleak when writing attached pictures fails

2020-11-20 Thread Andreas Rheinhardt
The FLAC muxer currently stores an attached picture corresponding to an AVStream in AVStream.priv_data. The AVPacket contained therein is unreferenced after it has been written. The AVPacket structure itself is then freed generically as AVStream.priv_data. And this can lead to memleaks if an attac

Re: [FFmpeg-devel] [PATCH v2 1/3] libavutil: introduce AVFilmGrainParams side data

2020-11-20 Thread Lynne
Nov 12, 2020, 18:42 by d...@lynne.ee: > This patch introduces a new frame side data type AVFilmGrainParams for use > with video codecs which are able to use it. > > It is generalized rather than being AV1 specific as AV2 is expected to carry > the same data, as well as the fact there already exis

Re: [FFmpeg-devel] [PATCH v4] avdevice/decklink_dec: map the raw_format instead of hardcode

2020-11-20 Thread Marton Balint
On Fri, 20 Nov 2020, lance.lmw...@gmail.com wrote: From: Limin Wang The patch will change the numerical values for the string constants so bump micro version. Signed-off-by: Limin Wang --- libavdevice/decklink_common.h | 9 + libavdevice/decklink_dec.cpp | 3 ++- libavdevice/deckl

Re: [FFmpeg-devel] [PATCH v2 086/162] avcodec/mpeg4video: Make tables used to initialize VLCs smaller

2020-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 08:19:59AM +0100, Andreas Rheinhardt wrote: > Switching from ff_init_vlc_sparse() to ff_init_vlc_from_lengths() > allows to replace codes which are so long that they need to be stored > in an uint16_t by symbols which fit into an uint8_t; and even these can > be avoided in c

Re: [FFmpeg-devel] [PATCH v2 087/162] avcodec/mpeg4videodec: Make studio VLCs static

2020-11-20 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Nov 20, 2020 at 08:20:00AM +0100, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mpeg4video.h| 4 -- >> libavcodec/mpeg4videodec.c | 88 -- >> 2 files changed, 36 insertions(+), 56 deletio

Re: [FFmpeg-devel] [PATCH v2 087/162] avcodec/mpeg4videodec: Make studio VLCs static

2020-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 08:20:00AM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4video.h| 4 -- > libavcodec/mpeg4videodec.c | 88 -- > 2 files changed, 36 insertions(+), 56 deletions(-) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH v2 143/162] avcodec/aac*: Make initializing ff_aac_pow*sf_tab thread-safe

2020-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 08:33:08AM +0100, Andreas Rheinhardt wrote: > This table is currently initialized up to three times: Once by the > encoder and twice by the decoders (once by the fixed and once by the > floating-point decoder); each of these initializations is guarded by an > AVOnce, yet the

Re: [FFmpeg-devel] [PATCH v2 154/162] avcodec/mpegaudiodec: Reduce the size of tables used to initialize VLCs

2020-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 08:33:19AM +0100, Andreas Rheinhardt wrote: > By switching from ff_init_vlc_sparse() to ff_init_vlc_from_lengths() one > can replace tables of codes of type uint16_t by tables of symbols of > type uint8_t; this saves about 1.3KB for both the fixed and floating > point decode

Re: [FFmpeg-devel] [PATCH v2 161/162] avcodec/mpegaudiodec: Hardcode tables to save space

2020-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 08:33:26AM +0100, Andreas Rheinhardt wrote: > The csa_tables (which always consist of 32 entries of four byte each, > but the type depends upon whether the decoder is fixed or > floating-point) are currently initialized once during decoder > initialization; yet it turns out

[FFmpeg-devel] [PATCH] avformat/movenc: allow Apple Lossless inside mp4

2020-11-20 Thread Leo Izen
MP4 already supports Apple Lossless, and it can be put inside by using muxer=ipod, but it's not tagged as supported in mp4. The mp4ra lists alac as a valid fourcc inside mp4, so it should be supported by spec. See: https://mp4ra.org/#/codecs --- libavformat/movenc.c | 1 + 1 file changed, 1 inser

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Call avcodec_flush_buffers() in a fuzzer choosen pattern

2020-11-20 Thread James Almer
On 11/20/2020 7:44 AM, Michael Niedermayer wrote: On Thu, Nov 19, 2020 at 10:51:36AM -0300, James Almer wrote: On 11/14/2020 10:29 PM, James Almer wrote: From: Michael Niedermayer This should increase coverage Signed-off-by: Michael Niedermayer Signed-off-by: James Almer Ping for set.

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-20 Thread Anton Khirnov
Quoting Mohammad Izadi (2020-11-20 04:57:11) > From: Mohammad Izadi > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be > decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side > data packet to be used or passed through. > --- > The fate test f

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Call avcodec_flush_buffers() in a fuzzer choosen pattern

2020-11-20 Thread Michael Niedermayer
On Thu, Nov 19, 2020 at 10:51:36AM -0300, James Almer wrote: > On 11/14/2020 10:29 PM, James Almer wrote: > > From: Michael Niedermayer > > > > This should increase coverage > > > > Signed-off-by: Michael Niedermayer > > Signed-off-by: James Almer > > Ping for set. probably ok thx [...] --

Re: [FFmpeg-devel] [PATCH 10/18] lavf: move AVStream.*index_entries* to AVStreamInternal

2020-11-20 Thread Michael Niedermayer
On Wed, Nov 18, 2020 at 06:49:10PM -0300, James Almer wrote: > On 11/18/2020 6:41 PM, Michael Niedermayer wrote: > > On Mon, Nov 16, 2020 at 09:46:01PM -0300, James Almer wrote: > > > On 11/16/2020 12:25 PM, Hendrik Leppkes wrote: > > > > On Mon, Nov 16, 2020 at 4:20 PM James Almer wrote: > > > >

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/rtsp: don't forget to call ff_network_close() on error

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman In sdp_read_header() some ff_network_close() calls were missed. Also in rtp_read_header() update comment to explain why a single call to ff_network_close() is enough to cover all cases even if sdp_read_header() returns an error. S

Re: [FFmpeg-devel] [PATCH v3 5/6] avformat/rtsp: set return variable in error path

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman In this error path ret still stores the number of bytes read in ffurl_read(). Signed-off-by: Andriy Gelman --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index e9f

Re: [FFmpeg-devel] [PATCH v3 4/6] avformat/rtspdec: cosmetics

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman Make error check style consistent with rest of function. --- libavformat/rtspdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 7c617837ca..b9fbc45190 100

Re: [FFmpeg-devel] [PATCH v3 3/6] avformat/rtspdec: fix mem leaks in connect mode if init fails

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman Fixes #6334 Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 5a383b5a19..7c617837ca 100644

Re: [FFmpeg-devel] [PATCH v3 2/6] avformat/rtspdec: fix mem leaks in listen mode if init fails

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 1ff84cdd56..5a383b5a19 100644 --- a/libavformat/rtspdec

Re: [FFmpeg-devel] [PATCH v3 1/6] avformat/rtspdec: add network init to listen mode

2020-11-20 Thread Martin Storsjö
On Mon, 12 Oct 2020, Andriy Gelman wrote: From: Andriy Gelman As per the docs network initialization is required before ff_url_join(). Furthermore, because the ff_network_init() was skipped, this makes one additional call to ff_network_close() if the stream exits without errors. The was forgo

Re: [FFmpeg-devel] [PATCH] http: Return AVERROR_EOF instead of 0 in some EOF conditions

2020-11-20 Thread Martin Storsjö
On Fri, 20 Nov 2020, Jan Ekström wrote: On Fri, Nov 13, 2020 at 12:32 AM Martin Storsjö wrote: IO functions are expected to return AVERROR_EOF instead of 0 nowadays. This is also expected by other higher level layers within the http protocol itself (e.g. the reconnect mechanism). --- libavfo

Re: [FFmpeg-devel] [PATCHv2 2/2] avformat/mspdec: Microsoft Paint (MSP) demuxer

2020-11-20 Thread Peter Ross
On Fri, Oct 23, 2020 at 11:53:03AM +1100, Peter Ross wrote: > Signed-off-by: Peter Ross > --- > Changelog | 1 + > doc/general_contents.texi | 2 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/mspdec.c | 117 +

Re: [FFmpeg-devel] [PATCH] http: Check for AVERROR_EOF in the check for premature end

2020-11-20 Thread Martin Storsjö
On Fri, 20 Nov 2020, Jan Ekström wrote: On Fri, Nov 13, 2020 at 12:17 AM Martin Storsjö wrote: When the check was added (in 3668701f9600, in 2015), some IO functions returned 0 on EOF (in particular, the TCP protocol did, but the TLS protocol returned AVERROR_EOF). Since 0e1f771d2200d in 2017