Re: [FFmpeg-devel] [PATCH 61/72] avcodec/pcm-dvd: Mark decoder as init-threadsafe

2020-11-28 Thread Paul B Mahol
lgtm On Fri, Nov 27, 2020 at 6:50 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pcm-dvd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pcm-dvd.c b/libavcodec/pcm-dvd.c > index 725c2f5b

Re: [FFmpeg-devel] [PATCH v2 161/162] avcodec/mpegaudiodec: Hardcode tables to save space

2020-11-28 Thread Michael Niedermayer
On Fri, Nov 27, 2020 at 08:56:46PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Fri, Nov 20, 2020 at 08:33:26AM +0100, Andreas Rheinhardt wrote: > >> The csa_tables (which always consist of 32 entries of four byte each, > >> but the type depends upon whether the decoder is fixed o

[FFmpeg-devel] [PATCH] avcodec/hevcdec: slice decoder, fix crash for thread_number > 16

2020-11-28 Thread Nuo Mi
following comandline will crash the ffmpeg ffmpeg -threads 17 -thread_type slice -i WPP_A_ericsson_MAIN_2.bit out.yuv -y the HEVCContext->sList size is MAX_NB_THREADS(16), any > 16 thread number will crash the application --- libavcodec/hevcdec.c | 7 ++- 1 file changed, 6 insertions(+), 1 d

Re: [FFmpeg-devel] [PATCH v2] avformat/rtspdec: fix potential mem leak in listen mode

2020-11-28 Thread Andriy Gelman
On Fri, 27. Nov 09:25, Martin Storsjö wrote: > On Thu, 26 Nov 2020, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > Currently a repeating setup request (with the same stream id) will > > simply overwrite rtp_handle/transport_priv without freeing the > > resources first. This is fixed by c

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: slice decoder, fix crash for thread_number > 16

2020-11-28 Thread Marton Balint
On Sat, 28 Nov 2020, Nuo Mi wrote: following comandline will crash the ffmpeg ffmpeg -threads 17 -thread_type slice -i WPP_A_ericsson_MAIN_2.bit out.yuv -y the HEVCContext->sList size is MAX_NB_THREADS(16), any > 16 thread number will crash the application --- libavcodec/hevcdec.c | 7 ++

[FFmpeg-devel] [PATCH v2 1/6] avutil/timecode: allow drop frame timecodes for multiples of 30000/1001 fps

2020-11-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/timecode.c | 17 +++-- libavutil/timecode.h | 4 ++-- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index f2db21c52c..7caa6c64f5 100644 --- a/libavutil/timecode.c +++ b/libavutil/

[FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2020-11-28 Thread Andriy Gelman
From: Andriy Gelman As per signal() help (man 2 signal) the semantics of using signal may vary across platforms. It is suggested to use sigaction() instead. On my system, the capture signal is reset to the default handler after the first call thus failing to properly handle multiple SIGINTs. Si

[FFmpeg-devel] [PATCH 2/2] RFC ffmpeg: exit demuxers earlier after signal received

2020-11-28 Thread Andriy Gelman
From: Andriy Gelman We currently use the same interrupt_callback function for both muxers and demuxers to break out of potential infinite loops. The function decode_interrupt_cb() checks for how many SIGINT/SIGTERM interrupts have been received, and (usually) two interrupts are needed to break o

Re: [FFmpeg-devel] [PATCH 04/11] avformat/utils: Move +1 to avoid overflow

2020-11-28 Thread Michael Niedermayer
On Fri, Oct 30, 2020 at 09:24:15PM +0100, Michael Niedermayer wrote: > On Wed, Oct 21, 2020 at 08:47:22AM +0200, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > > Michael Niedermayer: > > >> Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > > >> represented in type 'long' >

[FFmpeg-devel] [PATCH] avcodec/pthread_slice: Don't use static variable, fix race

2020-11-28 Thread Andreas Rheinhardt
ff_slice_thread_init() uses a static variable to hold a function pointer, although the value of said pointer needn't be saved between different runs of this function at all; The reason for this being so is probably that said pointer points to a static function (if used); but storage class specifie

[FFmpeg-devel] [PATCH 2/5] avutil/timecode: Avoid undefined behavior with large framenum

2020-11-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147462079 + 2149596 cannot be represented in type 'int' Fixes: 27565/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5091972813160448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/5] avformat/mov: Check a.size before computing next_root_atom

2020-11-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 64 + 9223372036854775799 cannot be represented in type 'long' Fixes: 27563/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6244650163372032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 5/5] avformat/id3v2: Check against max compression ratio before allocation

2020-11-28 Thread Michael Niedermayer
Fixes: Timeout (>10sec -> 12ms) Fixes: 27612/clusterfuzz-testcase-minimized-ffmpeg_dem_PCM_S24BE_fuzzer-6605893000757248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/id3v2.c | 2 ++ 1 file

[FFmpeg-devel] [PATCH 3/5] avformat/avidec: Use av_sat_sub64() in check_stream_max_drift()

2020-11-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 8833900919969684211 - -9223372036854775808 cannot be represented in type 'long' Fixes: 26726/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-5669377724383232 Fixes: 27587/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-6294562263531520 Found-by: continu

[FFmpeg-devel] [PATCH 4/5] avformat/id3v2: Sanity check tlen before alloc and uncompress

2020-11-28 Thread Michael Niedermayer
Fixes: Timeout (>20sec -> 65ms) Fixes: 26896/clusterfuzz-testcase-minimized-ffmpeg_dem_DAUD_fuzzer-5691024049176576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/id3v2.c | 3 +++ 1 file cha

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: slice decoder, fix crash for thread_number > 16

2020-11-28 Thread Nuo Mi
On Sun, Nov 29, 2020 at 1:54 AM Marton Balint wrote: > > > On Sat, 28 Nov 2020, Nuo Mi wrote: > > > following comandline will crash the ffmpeg > > ffmpeg -threads 17 -thread_type slice -i WPP_A_ericsson_MAIN_2.bit > out.yuv -y > > > > the HEVCContext->sList size is MAX_NB_THREADS(16), any > 16 th

[FFmpeg-devel] [PATCH] avcodec/hevcdec: slice decoder, fix crash for thread_number > 16

2020-11-28 Thread Nuo Mi
following comandline will crash the ffmpeg ffmpeg -threads 17 -thread_type slice -i WPP_A_ericsson_MAIN_2.bit out.yuv -y the HEVCContext->sList size is MAX_NB_THREADS(16), any > 16 thread number will crash the application --- libavcodec/hevcdec.c | 6 +- 1 file changed, 5 insertions(+), 1 de

[FFmpeg-devel] [PATCH] avdevice/decklink: remove the duplicated warning message

2020-11-28 Thread lance . lmwang
From: Limin Wang ./ffmpeg -list_devices true -f decklink -i dummy [Blackmagic DeckLink indev @ 0x2f96d00] The "list_devices" option is deprecated: list available devices [decklink @ 0x2f96400] The -list_devices option is deprecated and will be removed. Please use ffmpeg -sources decklink inste

[FFmpeg-devel] [PATCH v2] avcodec/hevcdec: slice decoder, fix crash for thread_number > 16

2020-11-28 Thread Nuo Mi
following comandline will crash the ffmpeg ffmpeg -threads 17 -thread_type slice -i WPP_A_ericsson_MAIN_2.bit out.yuv -y the HEVCContext->sList size is MAX_NB_THREADS(16), any > 16 thread number will crash the application --- libavcodec/hevcdec.c | 6 +- 1 file changed, 5 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH 2/4] avdevice/decklink: add AV_OPT_FLAG_DEPRECATED flag for list_devices

2020-11-28 Thread lance . lmwang
On Sat, Nov 21, 2020 at 12:21:10PM +0100, Marton Balint wrote: > > > On Sat, 21 Nov 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > and claim the option deprecated in the description. > > No, the description should stay as is. Adding the flag is enough, the > deprecation wi

[FFmpeg-devel] [PATCH 1/1] avformat/mov: fix timecode with counter mode flag set

2020-11-28 Thread mindmark
From: Mark Reid The current behaviour ends up squaring the avg_frame_rate if the conter mode flag is set. This messes up the timecode calculation, and looks to me as a regression that seems to have been introduced 428b4aac. The new behaviour is use the "Number of frames" field for avg_frame_ra