Re: [FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: add low latency P-pyramid support for qsv

2020-12-24 Thread myp...@gmail.com
On Fri, Dec 25, 2020 at 12:55 PM wrote: > > From: Wenbinc-Bin > > Add low latency P-pyramid support for qsv, and it relates to a new > command line parameter "-p_strategy". To enable this flag, user also > need to set "-bf" to -1 or 0. > > Signed-off-by Wenbin Chen > --- > libavcodec/qsvenc.c |

[FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: add low latency P-pyramid support for qsv

2020-12-24 Thread wenbin . chen
From: Wenbinc-Bin Add low latency P-pyramid support for qsv, and it relates to a new command line parameter "-p_strategy". To enable this flag, user also need to set "-bf" to -1 or 0. Signed-off-by Wenbin Chen --- libavcodec/qsvenc.c | 23 +++ libavcodec/qsvenc.h | 2 ++ 2

[FFmpeg-devel] [PATCH 3/4] avcodec/siren: Factorize category 5 and 6 noise computation

2020-12-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/siren.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavcodec/siren.c b/libavcodec/siren.c index 0713ef25e7..1f37305bd1 100644 --- a/libavcodec/siren.c +++ b/libavcodec/siren.c @@ -624,7 +624,7 @@ static i

[FFmpeg-devel] [PATCH 2/4] avcodec/siren: remove constant region_size

2020-12-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/siren.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/siren.c b/libavcodec/siren.c index b1b4944562..0713ef25e7 100644 --- a/libavcodec/siren.c +++ b/libavcodec/siren.c @@ -352,6 +352,7 @@ static cons

[FFmpeg-devel] [PATCH 4/4] avcodec/siren: Increase noise category 5 and 6

2020-12-24 Thread Michael Niedermayer
The entry read is not used in subsequent computation, thus its value is not important. Fixes: out of array read Fixes: 28578/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SIREN_fuzzer-6332019122503680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projec

[FFmpeg-devel] [PATCH 1/4] avformat/mpc8: Check size before implicitly converting to int

2020-12-24 Thread Michael Niedermayer
Fixes: Timeout Fixes: 28551/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-6229183210586112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mpc8.c | 2 +- 1 file changed, 1 insertion(+

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Marton Balint
On Thu, 24 Dec 2020, Nicolas George wrote: +static int librist_read(URLContext *h, uint8_t *buf, int size) +{ +RISTContext *s = h->priv_data; +const struct rist_data_block *data_block; +int ret; + +ret = rist_receiver_data_read(s->rist_ctx, &data_block, 5); Already mention

Re: [FFmpeg-devel] [PATCH] libswscale: avoid UB nullptr-with-offset.

2020-12-24 Thread Michael Niedermayer
On Thu, Dec 24, 2020 at 04:27:19AM +, Jeremy Leconte wrote: > Great news that the patch is accepted. > Just updated the author is this version. > Thanks! > --- > libswscale/slice.c| 12 > libswscale/swscale_unscaled.c | 4 +--- > 2 files changed, 5 insertions(+), 11 d

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: clip sample rate

2020-12-24 Thread Michael Niedermayer
On Wed, Nov 18, 2020 at 10:08:16PM +0100, Michael Niedermayer wrote: > Fixes: 1.21126e+111 is outside the range of representable values of type 'int' > Fixes: > 27398/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5412960339755008 > > Found-by: continuous fuzzing process > https://github.c

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust maxpixels for G2M

2020-12-24 Thread Michael Niedermayer
On Tue, Nov 17, 2020 at 07:15:47PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (50sec -> 3sec) > Fixes: > 27383/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5196953666977792 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Paul B Mahol
Look guys I will apply this patch soon. Your reviews are very bad! Why your reviews are extremely bad? You really have no skills or experience to say anything useful in this patch. Simple proof is that I posted one variant where you objected about allocation and than your are not happy how I re

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread James Almer
On 12/24/2020 8:08 AM, Paul B Mahol wrote: +typedef struct RISTContext { +const AVClass *class; + +int profile; +int buffer_size; +int packet_size; +int log_level; +int encryption; +char *secret; + +struct rist_logging_settings logging_settings; +struct rist_pe

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Nicolas George
Paul B Mahol (12020-12-24): > I have zero respect about your disrespectful and extremely rude reviews. > > Why such flag should be handled? It does not make sense. > timeout is correct. > payload is never silently discarded, it is make sure that it is never > bigger than max packet size, its just

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Paul B Mahol
On Thu, Dec 24, 2020 at 12:32 PM Nicolas George wrote: > Paul B Mahol (12020-12-24): > > This work is sponsored by Open Broadcast Systems. > > > > Signed-off-by: Paul B Mahol > > --- > > configure | 5 + > > doc/protocols.texi | 32 ++ > > libavformat/Makefile| 1

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Nicolas George
Paul B Mahol (12020-12-24): > This work is sponsored by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > configure | 5 + > doc/protocols.texi | 32 ++ > libavformat/Makefile| 1 + > libavformat/librist.c | 242

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-24 Thread Carl Eugen Hoyos
Am Mo., 21. Dez. 2020 um 01:18 Uhr schrieb Marton Balint : > >>> Attached patch fixes ticket #9005. > >> > >> Why are the codec_tags set at all? Can't we simply remove setting of all > >> the codec tags in decklink? They hold no additional information to > >> codec id and pixel format. This should

[FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Paul B Mahol
This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 ++ libavformat/Makefile| 1 + libavformat/librist.c | 242 libavformat/protocols.c | 1 + 5 fil

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: only increase s->level if transform is known

2020-12-24 Thread Paul B Mahol
On Wed, Dec 23, 2020 at 4:04 PM Michael Niedermayer wrote: > On Wed, Dec 23, 2020 at 12:35:38PM +0100, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/cfhd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/cfhd.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2020-12-24 Thread Nicolas George
Paul B Mahol (12020-12-24): > This work is sponsored by Open Broadcast Systems. > > Signed-off-by: Paul B Mahol > --- > configure | 5 + > doc/protocols.texi | 32 ++ > libavformat/Makefile| 1 + > libavformat/librist.c | 233