Re: [FFmpeg-devel] [RFC] Event loop

2021-01-03 Thread Peter Ross
On Thu, Dec 31, 2020 at 02:37:21PM +0100, Nicolas George wrote: > This mail is about a project I have to make FFmpeg's API and > infrastructure more convenient. For a common introduction, see this thread: > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-December/274167.html > > The API to access

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Andreas Rheinhardt
Jonathan Baudanza: > On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote: >> Lynne: >>> >>> Apart from that LGTM. >> >> +1 if the case of more than two channels has been properly tested. >> > > I tested this by creating an (invalid) SDP file with channels set to 3. In > this case, the rtp

Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and also refine naming with correct prefix

2021-01-03 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: 2021年1月4日 1:31 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and > also refine naming with correct prefix > > Quoting Guo, Yejun

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Jonathan Baudanza
On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote: > Lynne: > > > > Apart from that LGTM. > > +1 if the case of more than two channels has been properly tested. > I tested this by creating an (invalid) SDP file with channels set to 3. In this case, the rtp demuxer fails with the

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Andreas Rheinhardt
Lynne: > Jan 3, 2021, 23:48 by j...@jonb.org: > >> >> >> On Sun, Jan 3, 2021, at 2:25 PM, Lynne wrote: >> +/* Input sample rate (0 = unspecified) */> +bytestream_put_le32 (, 0); >>> Put in 48000 here. Stream copy will preserve extradata, and we don't want to >>> generate weird

[FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vsrc_testsrc.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index cf9fa4b2b2..7001f9ba16 100644 --- a/libavfilter/vsrc_testsrc.c +++

[FFmpeg-devel] [PATCH 15/16] avfilter/af_biquads: Don't redundantly set AVClass

2021-01-03 Thread Andreas Rheinhardt
It is already set generically in ff_filter_alloc(). Signed-off-by: Andreas Rheinhardt --- libavfilter/af_biquads.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 4774dfc5b6..4a09f8204a 100644 --- a/libavfilter/af_biquads.c +++

[FFmpeg-devel] [PATCH 14/16] avfilter/af_biquads: Deduplicate options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_biquads.c | 106 --- 1 file changed, 20 insertions(+), 86 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 92e711bc4f..4774dfc5b6 100644 --- a/libavfilter/af_biquads.c +++

[FFmpeg-devel] [PATCH 13/16] avfilter/vf_blend: Deduplicate options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_blend.c | 109 +++-- 1 file changed, 51 insertions(+), 58 deletions(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index d59bed823f..ffcc0e9997 100644 --- a/libavfilter/vf_blend.c +++

[FFmpeg-devel] [PATCH 12/16] avfilter/af_asupercut: Deduplicate options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_asupercut.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_asupercut.c b/libavfilter/af_asupercut.c index 89f4cf0ed0..d5c9a75d5d 100644 --- a/libavfilter/af_asupercut.c +++

[FFmpeg-devel] [PATCH 11/16] avfilter/vf_neighbor: Deduplicate options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_neighbor.c | 42 --- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/libavfilter/vf_neighbor.c b/libavfilter/vf_neighbor.c index 17a9b88265..9cd9001320 100644 --- a/libavfilter/vf_neighbor.c

[FFmpeg-devel] [PATCH 10/16] avfilter/vf_convolution: Deduplicate filter options

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- I wonder whether one should add an AVFILTER_DEFINE_CLASS2 macro that allows a custom options name. libavfilter/vf_convolution.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_convolution.c

[FFmpeg-devel] [PATCH 03/16] avcodec/metasound: Deduplicate data

2021-01-03 Thread Andreas Rheinhardt
Saves about 13KB; also reduces the amount of relocations. Signed-off-by: Andreas Rheinhardt --- libavcodec/metasound.c | 12 +- libavcodec/metasound_data.c | 448 +--- libavcodec/metasound_data.h | 3 - 3 files changed, 9 insertions(+), 454 deletions(-)

[FFmpeg-devel] [PATCH 09/16] avformat/hashenc: Deduplicate (stream)hash options

2021-01-03 Thread Andreas Rheinhardt
Also saves relocations. Signed-off-by: Andreas Rheinhardt --- libavformat/hashenc.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c index 5523dfd1cd..1e9faf372a 100644 --- a/libavformat/hashenc.c +++

[FFmpeg-devel] [PATCH 08/16] avcodec/wavpack: Deduplicate exp and log tables

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 4 +-- libavcodec/wavpack.h | 45 -- libavcodec/wavpackdata.c | 60 libavcodec/wavpackenc.c | 4 +-- 4 files changed, 69 insertions(+), 44 deletions(-)

[FFmpeg-devel] [PATCH 02/16] avcodec/g723_1: Move tables to their only user

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/g723_1.h| 120 - libavcodec/g723_1dec.c | 72 + libavcodec/g723_1enc.c | 48 + 3 files changed, 120 insertions(+), 120 deletions(-) diff --git

[FFmpeg-devel] [PATCH 07/16] avformat/mxf: Deduplicate random_index_pack_key

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- There is also another key that is duplicated: header_open_partition_key and mxf_jp2k_rsiz. But they seem to mean something different which makes me wonder if one of these keys is incorrect; I have therefore refrained from deduplicating them.

[FFmpeg-devel] [PATCH 04/16] avcodec/twinvq, metasound_data: Deduplicate lsp tables

2021-01-03 Thread Andreas Rheinhardt
Saves about 24KB. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 2 +- libavcodec/metasound_data.c | 41 +- libavcodec/metasound_data.h | 6 + libavcodec/twinvq_data.h| 790 libavcodec/twinvqdec.c | 17 +- 5 files changed,

[FFmpeg-devel] [PATCH 06/16] avfilter/vf_qp: Deduplicate variable names arrays

2021-01-03 Thread Andreas Rheinhardt
This also avoids relocations. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_qp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_qp.c b/libavfilter/vf_qp.c index af46fe0ece..e2d60fdbb5 100644 --- a/libavfilter/vf_qp.c +++ b/libavfilter/vf_qp.c @@

[FFmpeg-devel] [PATCH 05/16] avcodec/vp3data: Deduplicate coeff_tables

2021-01-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3data.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp3data.h b/libavcodec/vp3data.h index 1fbeac731b..272af4e3a0 100644 --- a/libavcodec/vp3data.h +++ b/libavcodec/vp3data.h @@ -179,8 +179,7 @@ static

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Jonathan Baudanza
On Sun, Jan 3, 2021, at 3:33 PM, James Almer wrote: > > Made those changes and pushed it. Thanks for your help everyone! Looking forward to deploying this! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread James Almer
On 1/3/2021 8:05 PM, Lynne wrote: Jan 3, 2021, 23:48 by j...@jonb.org: On Sun, Jan 3, 2021, at 2:25 PM, Lynne wrote: +/* Input sample rate (0 = unspecified) */> +bytestream_put_le32 (, 0); Put in 48000 here. Stream copy will preserve extradata, and we don't want to generate

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Lynne
Jan 3, 2021, 23:48 by j...@jonb.org: > > > On Sun, Jan 3, 2021, at 2:25 PM, Lynne wrote: > >> > +/* Input sample rate (0 = unspecified) */> +bytestream_put_le32 >> > (, 0); >> Put in 48000 here. Stream copy will preserve extradata, and we don't want to >> generate weird streams, even if

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-03 Thread Steinar Apalnes
> > > > I used the devel list because I considered, and still consider this as > > a bug, and not a user "how-to" question. > > > > My general rule of thumb I use whenever someone asks if they should post in > #ffmpeg or #ffmpeg-devel (irc) etc is to only ask on devel if you are > specifically

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Jonathan Baudanza
On Sun, Jan 3, 2021, at 2:25 PM, Lynne wrote: > > +/* Input sample rate (0 = unspecified) */> +bytestream_put_le32 > > (, 0); > Put in 48000 here. Stream copy will preserve extradata, and we don't want to > generate weird streams, even if our decoder ignores this. > > > +/*

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Lynne
Jan 3, 2021, 23:06 by j...@jonb.org: > On Sun, Jan 3, 2021, at 12:50 PM, Andreas Rheinhardt wrote: > >> >> It would be better if you used ff_alloc_extradata(): It also already >> frees the extradata that might be present. And it does only set the >> extradata_size after the allocation succeeded.

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Jonathan Baudanza
On Sun, Jan 3, 2021, at 12:50 PM, Andreas Rheinhardt wrote: > > It would be better if you used ff_alloc_extradata(): It also already > frees the extradata that might be present. And it does only set the > extradata_size after the allocation succeeded. But it is of course even > better if you

Re: [FFmpeg-devel] [PATCH 1/6] avformat/utils: do not overwrite already existing program with defaults in av_new_program

2021-01-03 Thread Marton Balint
On Mon, 28 Dec 2020, Marton Balint wrote: av_new_program returns the existing program if that already exists, in that case it makes no sense to overwrite existing attributes. Signed-off-by: Marton Balint --- libavformat/utils.c | 12 +--- 1 file changed, 5 insertions(+), 7

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Andreas Rheinhardt
Jonathan Baudanza: > On Wed, Dec 30, 2020, at 10:34 AM, James Almer wrote: > >> Nothing should have done it at that point. The demuxer allocates the >> AVStream after all. But to be sure you can do >> av_freep(>codecpar->extradata) to ensure it's NULL before anything >> else is done. > >

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-03 Thread Josh Dekker
On 2021/01/03 20:18, Michael Niedermayer wrote: On Sun, Jan 03, 2021 at 06:32:11PM +0100, Kieran Kunhya wrote: Hello, As it's 2021 I would like to propose FFmpeg purchase one or more (e.g FATE + development) Apple M1 Mac Minis and provide access to developers. This is something I have done a

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

2021-01-03 Thread Jonathan Baudanza
On Wed, Dec 30, 2020, at 10:34 AM, James Almer wrote: > Nothing should have done it at that point. The demuxer allocates the > AVStream after all. But to be sure you can do > av_freep(>codecpar->extradata) to ensure it's NULL before anything > else is done. Thanks James. I've updated the

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-03 Thread Christopher Degawa
> > I used the devel list because I considered, and still consider this as > a bug, and not a user "how-to" question. > My general rule of thumb I use whenever someone asks if they should post in #ffmpeg or #ffmpeg-devel (irc) etc is to only ask on devel if you are specifically hacking on ffmpeg

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-03 Thread Michael Niedermayer
On Sun, Jan 03, 2021 at 06:32:11PM +0100, Kieran Kunhya wrote: > Hello, > > As it's 2021 I would like to propose FFmpeg purchase one or more (e.g > FATE + development) Apple M1 Mac Minis and provide access to developers. > This is something I have done a few years ago when AVX2 was a new >

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-03 Thread Kieran Kunhya
> > I can host these in the UK 24/7 and provide access and label them as > belonging to the project and not me. > To clarify these will be hosted in a proper datacentre, with proper connectivity, cooling etc. Kieran ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/7] api-band-test: use non-obsolete decoding API

2021-01-03 Thread James Almer
On 12/12/2020 12:45 PM, Anton Khirnov wrote: --- tests/api/api-band-test.c | 90 +++ 1 file changed, 53 insertions(+), 37 deletions(-) diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c index 257e741694..34bed1d6be 100644 ---

[FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-03 Thread Kieran Kunhya
Hello, As it's 2021 I would like to propose FFmpeg purchase one or more (e.g FATE + development) Apple M1 Mac Minis and provide access to developers. This is something I have done a few years ago when AVX2 was a new instruction set. I can host these in the UK 24/7 and provide access and label

Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and also refine naming with correct prefix

2021-01-03 Thread Anton Khirnov
Quoting Guo, Yejun (2020-12-30 16:35:06) > The prefix for symbols not exported from the library and not > local to one translation unit is ff_ (or FF for types). > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn/dnn_backend_openvino.c | 32 ++--- > libavfilter/dnn/queue.c

[FFmpeg-devel] [PATCH] avfilter: add xdif video filter

2021-01-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 54 +++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vf_xdif.c | 261 libavfilter/xdif.h | 47 ++ libavfilter/xdif_template.c | 289