Re: [FFmpeg-devel] [PATCH v3 07/11] avcodec: add cbs for h266/vvc

2021-01-13 Thread James Almer
On 1/11/2021 1:33 PM, Nuo Mi wrote: @@ -1218,6 +1464,20 @@ static int cbs_h2645_unit_requires_zero_byte(enum AVCodecID codec_id, return type == H264_NAL_SPS || type == H264_NAL_PPS; if (codec_id == AV_CODEC_ID_HEVC) return type == HEVC_NAL_VPS || type == HEVC_NAL_SPS ||

Re: [FFmpeg-devel] [PATCH] avutil/tx: use ENOSYS instead of ENOTSUP

2021-01-13 Thread Lynne
Jan 14, 2021, 03:04 by jamr...@gmail.com: > It's the standard error code used across the codebase to signal unimplemented > or unsupported features. > > Signed-off-by: James Almer > --- > libavutil/tx_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/t

[FFmpeg-devel] [PATCH] avutil/tx: use ENOSYS instead of ENOTSUP

2021-01-13 Thread James Almer
It's the standard error code used across the codebase to signal unimplemented or unsupported features. Signed-off-by: James Almer --- libavutil/tx_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c index a91b8f900c..15

Re: [FFmpeg-devel] [PATCH v2 1/5] ac3enc_fixed: convert to 32-bit sample format

2021-01-13 Thread Lynne
Jan 13, 2021, 00:55 by d...@lynne.ee: > Jan 12, 2021, 22:24 by andreas.rheinha...@gmail.com: > >> Lynne: >> >>> The AC3 encoder used to be a separate library called "Aften", which >>> got merged into libavcodec (literally, SVN commits and all). >>> The merge preserved as much features from the lib

Re: [FFmpeg-devel] [PATCH] avformat/fifo: utilize a clone packet for muxing

2021-01-13 Thread Jan Ekström
On Tue, Jan 12, 2021 at 9:59 AM Jan Ekström wrote: > > On Mon, Jan 11, 2021 at 10:53 PM Andreas Rheinhardt > wrote: > > > > Jan Ekström: > > > On Tue, Dec 8, 2020 at 2:54 PM Jan Ekström wrote: > > >> > > >> From: Jan Ekström > > >> > > >> This way the timestamp adjustments do not have to be man

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-01-13 Thread Michael Niedermayer
On Mon, Jan 11, 2021 at 05:46:31PM +0100, Alan Kelly wrote: > --- > Fixes a bug where if there is no offset and a tail which is not processed by > the > sse3/avx2 version the dither is modified > Deletes mmx/mmxext yuv2yuvX version from swscale_template and adds it > to yuv2yuvX.asm to reduce

Re: [FFmpeg-devel] [PATCH v2 1/3] kmsgrab: Use invalid modifier if modifiers weren't used.

2021-01-13 Thread Mark Thompson
On 13/01/2021 00:19, Bas Nieuwenhuizen wrote: A friendly ping on reviewing this series. Thanks! Apologies; last time I looked at this I got distracted by Intel having broken import of X-tiled surfaces from kmsgrab, which was a bit of a problem to my testing. (

Re: [FFmpeg-devel] [PATCH v2 3/3] hwcontext_vaapi: Use PRIME_2 memory type for modifiers.

2021-01-13 Thread Mark Thompson
On 13/11/2020 23:15, Bas Nieuwenhuizen wrote: This way we can pass explicit modifiers in. Sometimes the modifier matters for the number of memory planes that libva accepts, in particular when dealing with driver-compressed textures. Furthermore the driver might not actually be able to determine t

Re: [FFmpeg-devel] [PATCH v3 07/11] avcodec: add cbs for h266/vvc

2021-01-13 Thread James Almer
On 1/12/2021 11:34 PM, James Almer wrote: +    if (err < 0) +    return err; +    } +    break; + +    case VVC_TRAIL_NUT: +    case VVC_STSA_NUT: +    case VVC_RADL_NUT: +    case VVC_RASL_NUT: +    case VVC_IDR_W_RADL: +    case VVC_IDR_N_LP: +    case VVC_CRA_NUT: +

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread James Almer
On 1/13/2021 4:58 PM, Thierry Foucu wrote: HI Lynne On Wed, Jan 13, 2021 at 10:30 AM Lynne wrote: Jan 13, 2021, 18:46 by tfo...@gmail.com: By default the time code scale in a MKV file in millisecond. With this option we can set the time code scale to microsecond or nanoseconds for very high

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/udp: add memory alloc checks

2021-01-13 Thread Marton Balint
On Sat, 9 Jan 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 088e30c..a7fbb94 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -9

Re: [FFmpeg-devel] [PATCH v7] avformat/udp: return the error code instead of generic EIO

2021-01-13 Thread Marton Balint
On Wed, 13 Jan 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 58 ++- 1 file changed, 36 insertions(+), 22 deletions(-) LGTM, thanks. Marton diff --git a/libavformat/udp.c b/liba

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Lynne
Jan 13, 2021, 20:58 by tfo...@gmail.com: > HI Lynne > > On Wed, Jan 13, 2021 at 10:30 AM Lynne <> d...@lynne.ee> > wrote: > >> Jan 13, 2021, 18:46 by >> tfo...@gmail.com>> : >> >> > By default the time code scale in a MKV file in millisecond. With this >> > option we can set the time code scale to

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread James Almer
On 1/13/2021 5:50 PM, Thierry Foucu wrote: a note with this change: If we set the timecodescale to microsecond, and we encode a 30 fps video, the duration of each frame are then 3 us. In this case, (int16_t)cluster_time != cluster_time Will almost every time faile and we will need to create a

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
a note with this change: If we set the timecodescale to microsecond, and we encode a 30 fps video, the duration of each frame are then 3 us. In this case, (int16_t)cluster_time != cluster_time Will almost every time faile and we will need to create a new block per frame (it seems to me at least

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
HI Lynne On Wed, Jan 13, 2021 at 10:30 AM Lynne wrote: > Jan 13, 2021, 18:46 by tfo...@gmail.com: > > > By default the time code scale in a MKV file in millisecond. With this > > option we can set the time code scale to microsecond or nanoseconds for > > very high frame rate. > > --- > > libavf

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread James Almer
On 1/13/2021 2:46 PM, Thierry Foucu wrote: By default the time code scale in a MKV file in millisecond. With this option we can set the time code scale to microsecond or nanoseconds for very high frame rate. --- libavformat/matroskaenc.c | 11 +++ 1 file changed, 7 insertions(+), 4 del

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Lynne
Jan 13, 2021, 18:46 by tfo...@gmail.com: > By default the time code scale in a MKV file in millisecond. With this > option we can set the time code scale to microsecond or nanoseconds for > very high frame rate. > --- > libavformat/matroskaenc.c | 11 +++ > 1 file changed, 7 insertions(+)

[FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
By default the time code scale in a MKV file in millisecond. With this option we can set the time code scale to microsecond or nanoseconds for very high frame rate. --- libavformat/matroskaenc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-01-13 Thread Jan Ekström
On Wed, Jan 13, 2021 at 3:02 PM Nicolas George wrote: > > Jan Ekström (12021-01-11): > > From: Stefano Sabatini > > > > --- > > libavutil/avstring.h | 1 + > > libavutil/bprint.c | 14 ++ > > tools/ffescape.c | 1 + > > 3 files changed, 16 insertions(+) > > Please see > https

Re: [FFmpeg-devel] Development of a CUDA accelerated variant of the libav vf_tonemap

2021-01-13 Thread Felix LeClair
I've pulled the branch and built with --enable-vulkan --enable-libglslang. What else is needed? Do I need to pull the libplacebo repo as well and/or add any special enables in ./configure? On Wed, Jan 13, 2021 at 5:12 am, Lynne wrote: Jan 12, 2021, 22:13 by felix.leclair...@hotmail.com

Re: [FFmpeg-devel] [PATCH] lavu: support arbitrary-point FFT and all even (i)MDCT transforms

2021-01-13 Thread James Almer
On 1/12/2021 4:18 AM, Lynne wrote: This patch adds support for arbitrary-point FFTs and all even MDCT transforms. Odd MDCTs are not supported yet as they're based on the DCT-II and DCT-III and they're very niche. With this we can now write tests. Patch attached. [...] @@ -575,11 +651,13 @@

Re: [FFmpeg-devel] [PATCH] lavu: support arbitrary-point FFT and all even (i)MDCT transforms

2021-01-13 Thread Lynne
Jan 12, 2021, 08:18 by d...@lynne.ee: > This patch adds support for arbitrary-point FFTs and all even MDCT > transforms. > Odd MDCTs are not supported yet as they're based on the DCT-II and DCT-III > and they're very niche. > > With this we can now write tests. > > Patch attached. > Pushed. _

[FFmpeg-devel] Patch for FFmpeg

2021-01-13 Thread Robin Cooksey
I’ve attached a patch which makes avformat handle the 308 Permanent Redirect HTTP status code – which is more recently defined in https://tools.ietf.org/html/rfc7538 The change just treats 308 in the same way as the other 30x status codes. 0001-Treat-HTTP-status-code-308-in-the-same-way-

[FFmpeg-devel] [PATCH] avfilter: add estdif video filter

2021-01-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 64 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_estdif.c | 469 +++ 4 files changed, 535 insertions(+) create mode 100644 libavfilter/vf_estdif.c diff -

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-13 Thread Martin Storsjö
On Wed, 13 Jan 2021, Reimar Döffinger wrote: If building with MSVC tools, yes you're right that armasm.exe/armasm64.exe takes a different syntax. But the gas-preprocessor tool (which is picked up automatically by our configure, one just needs to make sure it's available) handles expanding all

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-13 Thread Reimar Döffinger
> If building with MSVC tools, yes you're right that armasm.exe/armasm64.exe > takes a different syntax. But the gas-preprocessor tool (which is picked up > automatically by our configure, one just needs to make sure it's available) > handles expanding all the macros and rewriting directives int

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-01-13 Thread Nicolas George
Jan Ekström (12021-01-11): > From: Stefano Sabatini > > --- > libavutil/avstring.h | 1 + > libavutil/bprint.c | 14 ++ > tools/ffescape.c | 1 + > 3 files changed, 16 insertions(+) Please see https://ffmpeg.org/pipermail/ffmpeg-devel/2020-December/273500.html Regards, --

Re: [FFmpeg-devel] [PATCH v2 01/11] avcodec/vvc: add shared header for vvc

2021-01-13 Thread Nuo Mi
On Tue, Jan 12, 2021 at 6:01 AM Mark Thompson wrote: > On 10/01/2021 08:35, Nuo Mi wrote: > > On Sun, Jan 10, 2021 at 9:39 AM Nuo Mi wrote: > >> On Sun, Jan 10, 2021 at 3:09 AM Mark Thompson wrote: > >>> On 09/01/2021 07:34, Nuo Mi wrote: > --- > libavcodec/vvc.h | 124 > ++

[FFmpeg-devel] Fix for avformat DHAV parsing issue.

2021-01-13 Thread Idan Freiberg
Hello FFmpeg developers, Iv'e noticed some DAV files containing a 0xff's padding in between DHAV chunks. This is possible when the Dahua DVR device generates a DAV file which is concatenated from 2 different DAV files kept on the device hard drive. Here

[FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-13 Thread Idan Freiberg
DAV files may contain a variable length padding in between chunks filled with 0xff bytes. The current skipping logic is incorrect as it may skip over DHAV chunks not appearing sequentially in the file. We now look for the 'DHAV' tag using a byte-by-byte search in order to handle such situations. A

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

2021-01-13 Thread Martin Storsjö
On Tue, 12 Jan 2021, Reimar Döffinger wrote: On 12 Jan 2021, at 13:24, Josh Dekker wrote: Hi, AS libavcodec/aarch64/hevcdsp_idct_neon.o libavcodec/aarch64/hevcdsp_idct_neon.S: Assembler messages: libavcodec/aarch64/hevcdsp_idct_neon.S:418: Error: operand mismatch -- `mov v29.4S,v28.4S'

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-13 Thread Martin Storsjö
Hi, On Tue, 12 Jan 2021, Reimar Döffinger wrote: I’m not sure it will discourage it more than having to write the optimizations over and over, for Armv7 NEON, for Armv8 Linux, for Armv8 Windows, then SVE/SVE2, who knows maybe Armv9 will also need a rewrite. NEON code for armv8 windows and arm