Re: [FFmpeg-devel] [PATCH v2 06/11] avcodec: add cbs for h266/vvc

2021-01-16 Thread Nuo Mi
On Tue, Jan 12, 2021 at 4:45 AM Mark Thompson wrote: > On 10/01/2021 09:10, Nuo Mi wrote: > > On Sun, Jan 10, 2021 at 5:34 AM Mark Thompson wrote: > >> On 09/01/2021 07:34, Nuo Mi wrote: > >>> --- > >>>configure |2 + > >>>libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH v3 07/11] avcodec: add cbs for h266/vvc

2021-01-16 Thread Nuo Mi
On Thu, Jan 14, 2021 at 12:22 PM James Almer wrote: > On 1/11/2021 1:33 PM, Nuo Mi wrote: > > @@ -1218,6 +1464,20 @@ static int cbs_h2645_unit_requires_zero_byte(enum > AVCodecID codec_id, > > return type == H264_NAL_SPS || type == H264_NAL_PPS; > > if (codec_id == AV_CODEC_ID_HEV

Re: [FFmpeg-devel] [PATCH v2 06/11] avcodec: add cbs for h266/vvc

2021-01-16 Thread Nuo Mi
On Tue, Jan 12, 2021 at 9:28 AM James Almer wrote: > On 1/11/2021 5:45 PM, Mark Thompson wrote: > +static int FUNC(vui_parameters)(CodedBitstreamContext *ctx, RWContext > >>> *rw, > +H266RawVUI *current) > +{ > +int err; > + > +

Re: [FFmpeg-devel] [PATCH v3 07/11] avcodec: add cbs for h266/vvc

2021-01-16 Thread Nuo Mi
On Thu, Jan 14, 2021 at 6:25 AM James Almer wrote: > On 1/12/2021 11:34 PM, James Almer wrote: > >> +if (err < 0) > >> +return err; > >> +} > >> +break; > >> + > >> +case VVC_TRAIL_NUT: > >> +case VVC_STSA_NUT: > >> +case VVC_RADL_NUT: > >>

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/qsvdec: refact, remove duplicate code for plugin loading

2021-01-16 Thread Guangxin Xu
Hi Lingjie, thanks for the comment. We can use codec id to do special things for a specific codec. Just like qsv_decode_init. thanks On Sat, Jan 16, 2021 at 3:22 PM Linjie Fu wrote: > Guangxin: > > On Tue, Jan 5, 2021 at 10:44 AM Xu Guangxin wrote: > > > > --- > > libavcodec/qsvdec.c | 29 ++

Re: [FFmpeg-devel] [PATCH] Revert "avutil/timecode: fix sscanf format string with garbage at the end"

2021-01-16 Thread Marton Balint
On Sun, 17 Jan 2021, lance.lmw...@gmail.com wrote: On Sat, Jan 16, 2021 at 09:49:42AM +0100, Marton Balint wrote: This reverts commit 6696a07ac62bfec49dd488510a719367918b9f7a. It is wrong to restrict timecodes to always contain leading zeros or for hours or frames to be 2 chars only. Sorry,

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: use AV_OPT_TYPE_DURATION

2021-01-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/muxers.texi | 15 +++ libavformat/hlsenc.c | 18 +- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 8e12aca..1f9f293 100644 --- a/doc/muxers.texi +++ b/do

[FFmpeg-devel] [PATCH v2] avformat/mov: fix timecode with counter mode flag set

2021-01-16 Thread mindmark
From: Mark Reid The current behaviour ends up squaring the avg_frame_rate if the conter mode flag is set. This messes up the timecode calculation, and looks to me as a regression that seems to have been introduced 428b4aac. Upon further testing is seems that no special case is need for having t

[FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

2021-01-16 Thread emcodem
The purpose of this is to tell ffmpeg which field order the returned clip of the avisynth .avs script decided to finally deliver, which is handy in an automated environment. Interlacing is generally a very hard topic in avisynth, the huge comment is neccessary to explain my reasons. Additionally

Re: [FFmpeg-devel] [PATCH] Revert "avutil/timecode: fix sscanf format string with garbage at the end"

2021-01-16 Thread lance . lmwang
On Sat, Jan 16, 2021 at 09:49:42AM +0100, Marton Balint wrote: > This reverts commit 6696a07ac62bfec49dd488510a719367918b9f7a. > > It is wrong to restrict timecodes to always contain leading zeros or for hours > or frames to be 2 chars only. Sorry, I think I was misunderstood by the following synt

[FFmpeg-devel] [GASPP PATCH 2/2] Match aarch64 register lists with tbl/tbx too

2021-01-16 Thread Martin Storsjö
Remove the restriction on matching on the same line as ld1/st1 and similar ones; the pattern for the register list itself should be strict enough to avoid false matches. --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocess

[FFmpeg-devel] [GASPP PATCH 1/2] Recognize aarch64 register ranges with .16b suffixes too

2021-01-16 Thread Martin Storsjö
Match e.g. "ld1 {v16.16b-v19.16b}". Previously this regex only matched lane specifiers with a single digit, e.g. "ld1 {v16.8h-v19.8h}". --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index c4b1c1d..4d78dac 1007

[FFmpeg-devel] [PATCH 1/7] avformat/mpsubdec: Use av_sat_add/sub64() in fracval handling

2021-01-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 922337203685000 + 900 cannot be represented in type 'long long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MPSUB_fuzzer-665448017480908 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-

Re: [FFmpeg-devel] [PATCH 3/4] lavc/aarch64: add HEVC sao_band NEON

2021-01-16 Thread Martin Storsjö
On Thu, 7 Jan 2021, Josh Dekker wrote: Only works for 8x8. Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_init.c | 7 +++ libavcodec/aarch64/hevcdsp_sao_neon.S | 87 +++ 3 files changed, 96 insertions(+), 1 del

[FFmpeg-devel] [PATCH 4/7] avformat/nistspheredec: Check bits_per_coded_sample and channels

2021-01-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 80 * 92233009 cannot be represented in type 'int' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_NISTSPHERE_fuzzer-6669100654919680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 3/7] avformat/mvi: Use 64bit for testing dimensions

2021-01-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 65535 * 65535 cannot be represented in type 'int' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-6649291124899840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

[FFmpeg-devel] [PATCH 7/7] avformat/sbgdec: Reduce the amount of floating point in str_to_time()

2021-01-16 Thread Michael Niedermayer
Fixes: 1e+75 is outside the range of representable values of type 'long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6626834808700928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 5/7] avformat/nutdec: Fix integer overflow in count computation

2021-01-16 Thread Michael Niedermayer
Note, the value is checked a few lines later already Fixes: signed integer overflow: -440402016 - 1879048064 cannot be represented in type 'int' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_NUT_fuzzer-6603876618469376 Found-by: continuous fuzzing process https://github.com/google/oss

[FFmpeg-devel] [PATCH 2/7] avformat/utils: Check dts in update_initial_timestamps() more

2021-01-16 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036853488158 - 9000 cannot be represented in type 'long long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_MPSUB_fuzzer-6696625298866176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

[FFmpeg-devel] [PATCH 6/7] avformat/realtextdec: Avoid undefined overflow in the end of read_ts()

2021-01-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 234080282628234040 * 100 cannot be represented in type 'long long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-6649867065753600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-o

Re: [FFmpeg-devel] [PATCH 2/4] lavc/aarch64: add HEVC idct_dc NEON

2021-01-16 Thread Martin Storsjö
On Thu, 7 Jan 2021, Josh Dekker wrote: Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile| 3 +- libavcodec/aarch64/hevcdsp_idct_neon.S | 74 ++ libavcodec/aarch64/hevcdsp_init.c | 19 +++ 3 files changed, 95 insertions(+), 1 deletion(-) create

Re: [FFmpeg-devel] [PATCH 1/4] lavc/aarch64: add HEVC add_residual NEON

2021-01-16 Thread Martin Storsjö
On Thu, 7 Jan 2021, Josh Dekker wrote: Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/hevcdsp_add_res_neon.S | 298 ++ libavcodec/aarch64/hevcdsp_init.c | 59 + libavcodec/hevcdsp.c | 2 +

[FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-16 Thread Nicolas Caramelli
This patch adds KMS/DRM output device for rendering a video stream using KMS/DRM dumb buffer. The proposed implementation is very basic, only bgr0 pixel format is currently supported (the most common format with KMS/DRM). To enable this output device you need to configure FFmpeg with --enable-libdr

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

2021-01-16 Thread Martin Storsjö
On Sat, 16 Jan 2021, Reimar Döffinger wrote: On 15 Jan 2021, at 23:55, Martin Storsjö wrote: On Tue, 12 Jan 2021, reimar.doeffin...@gmx.de wrote: create mode 100644 libavcodec/aarch64/hevcdsp_idct_neon.S create mode 100644 libavcodec/aarch64/hevcdsp_init_aarch64.c This patch fails checkasm

Re: [FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

2021-01-16 Thread Martin Storsjö
On Sat, 16 Jan 2021, Reimar Döffinger wrote: On 15 Jan 2021, at 23:25, Martin Storsjö wrote: On Fri, 15 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger It would get immediately overridden to $cc, which in case of gas-preprocessor missing would result in it trying to use

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/librav1e: Pass through timestamps as opaque user data

2021-01-16 Thread James Almer
On 1/14/2021 10:55 AM, Derek Buitenhuis wrote: avcodec has no facilities to generate timestamps properly from output frame numbers (and it would be wrong for VFR anyway), so pass through the timestamps using rav1e's opaque user data feature, which was added in v0.4.0. This bumps the minimum libr

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/librav1e: Fix indentation

2021-01-16 Thread Derek Buitenhuis
On 14/01/2021 13:55, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > Seems it got mangled at some point. > --- > libavcodec/librav1e.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) Will push both of these tomorrow if nobody objects.

[FFmpeg-devel] [PATCH 1/2] avfilter/vsrc_testsrc: add planar support to rgbtestsrc

2021-01-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vsrc_testsrc.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index 7001f9ba16..c047fe8e86 100644 --- a/libavfilter/vsrc_testsrc.c +++ b/liba

[FFmpeg-devel] [PATCH 2/2] avfilter/vsrc_testsrc: add complement mode to rgbtestsrc

2021-01-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vsrc_testsrc.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index c047fe8e86..2cf33aadc9 100644 --- a/libavfilter/vsrc_testsrc.c +++ b/lib

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: set pctx to NULL when av_bsf_alloc failed

2021-01-16 Thread Steven Liu
> 在 2021年1月16日,21:19,James Almer 写道: > > On 1/16/2021 2:24 AM, Steven Liu wrote: >> av_bsf_free will free invalid pointer when av_bsf_alloc failed. >> because av_bsf_list_parse_str called av_bsf_get_null_filter, >> av_bsf_get_null_filter called av_bsf_alloc, and av_bsf_alloc >> should set a val

[FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-01-16 Thread Mark Plomer
Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, although it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this causes ffmpeg/VLC-player to produce/play corrupted video. In other players/editors it works

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: set pctx to NULL when av_bsf_alloc failed

2021-01-16 Thread James Almer
On 1/16/2021 2:24 AM, Steven Liu wrote: av_bsf_free will free invalid pointer when av_bsf_alloc failed. because av_bsf_list_parse_str called av_bsf_get_null_filter, av_bsf_get_null_filter called av_bsf_alloc, and av_bsf_alloc should set a value to the *pctx before return success or failed, becaus

[FFmpeg-devel] [PATCH] avfilter/af_astats: fix possible crash because of undefined float to integer rounding

2021-01-16 Thread Marton Balint
Fixes ticket #9049. Signed-off-by: Marton Balint --- libavfilter/af_astats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_astats.c b/libavfilter/af_astats.c index ebaae29f44..f50cbe199c 100644 --- a/libavfilter/af_astats.c +++ b/libavfilter/af_astats.c @

[FFmpeg-devel] [PATCH] Revert "avutil/timecode: fix sscanf format string with garbage at the end"

2021-01-16 Thread Marton Balint
This reverts commit 6696a07ac62bfec49dd488510a719367918b9f7a. It is wrong to restrict timecodes to always contain leading zeros or for hours or frames to be 2 chars only. Signed-off-by: Marton Balint --- libavutil/timecode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li