Re: [FFmpeg-devel] [PATCH] avformat/fifo: utilize a clone packet for muxing

2021-01-24 Thread Jan Ekström
On Thu, Jan 14, 2021 at 2:13 AM Jan Ekström wrote: > > On Tue, Jan 12, 2021 at 9:59 AM Jan Ekström wrote: > > > > On Mon, Jan 11, 2021 at 10:53 PM Andreas Rheinhardt > > wrote: > > > > > > Jan Ekström: > > > > On Tue, Dec 8, 2020 at 2:54 PM Jan Ekström wrote: > > > >> > > > >> From: Jan

Re: [FFmpeg-devel] [PATCH v4 0/4] Initial implementation of TTML encoding/muxing

2021-01-24 Thread Jan Ekström
On Fri, Jan 22, 2021 at 1:21 PM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around previous VDD), and >

Re: [FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-01-24 Thread Linjie Fu
On Mon, Jan 25, 2021 at 12:49 AM Anton Khirnov wrote: > > Quoting Linjie Fu (2021-01-24 16:05:56) > > Regression since 87f0c8280. > > > > If the extradata of a stream could not be extracted correctly, > > codec_info_nb_frames would remain zero, while st->event_flag would still > > be marked as

Re: [FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 5. Sept. 2020 um 21:15 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #8819. Paul, I believe you had an objection but I forgot what it was... Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: deprecate AVCodecContext.debug_mv

2021-01-24 Thread James Almer
On 1/24/2021 8:30 PM, Andreas Rheinhardt wrote: James Almer: On 1/24/2021 8:14 PM, Andreas Rheinhardt wrote: James Almer: It's been unused for almost three years now. Signed-off-by: James Almer ---   doc/APIchanges |  4   libavcodec/avcodec.h   |  7 ---  

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: deprecate AVCodecContext.debug_mv

2021-01-24 Thread Andreas Rheinhardt
James Almer: > On 1/24/2021 8:14 PM, Andreas Rheinhardt wrote: >> James Almer: >>> It's been unused for almost three years now. >>> >>> Signed-off-by: James Almer >>> --- >>>   doc/APIchanges |  4 >>>   libavcodec/avcodec.h   |  7 --- >>>   libavcodec/pthread_frame.c |  4

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: deprecate AVCodecContext.debug_mv

2021-01-24 Thread James Almer
On 1/24/2021 8:14 PM, Andreas Rheinhardt wrote: James Almer: It's been unused for almost three years now. Signed-off-by: James Almer --- doc/APIchanges | 4 libavcodec/avcodec.h | 7 --- libavcodec/pthread_frame.c | 4 libavcodec/version.h | 10

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: deprecate AVCodecContext.debug_mv

2021-01-24 Thread Andreas Rheinhardt
James Almer: > It's been unused for almost three years now. > > Signed-off-by: James Almer > --- > doc/APIchanges | 4 > libavcodec/avcodec.h | 7 --- > libavcodec/pthread_frame.c | 4 > libavcodec/version.h | 10 +- > 4 files changed, 17

[FFmpeg-devel] [PATCH 2/2] avcodec: deprecate AVCodecContext.debug_mv

2021-01-24 Thread James Almer
It's been unused for almost three years now. Signed-off-by: James Almer --- doc/APIchanges | 4 libavcodec/avcodec.h | 7 --- libavcodec/pthread_frame.c | 4 libavcodec/version.h | 10 +- 4 files changed, 17 insertions(+), 8 deletions(-) diff

[FFmpeg-devel] [PATCH 1/2] avcodec: remove long dead debug_mv code

2021-01-24 Thread James Almer
FF_API_DEBUG_MV has been zero since ffmpeg 4.0 Signed-off-by: James Almer --- fftools/ffmpeg.c | 6 +- libavcodec/avcodec.h | 24 --- libavcodec/mpegpicture.c | 3 - libavcodec/mpegutils.c | 128 - libavcodec/options_table.h |

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-24 Thread Nicolas George
Andreas Rheinhardt (12021-01-24): > I know that Anton is currently working on merging them, but I thought > that this would only involve compiling lavd into libavformat.so; not > that the API would be changed or the libavdevice/ source folder merged > into libavformat. Considering Anton's open

Re: [FFmpeg-devel] [PATCH 1/3] avformat/asfdec_o: Check for EOF in asf_read_marker()

2021-01-24 Thread Michael Niedermayer
On Wed, Jan 20, 2021 at 12:32:21AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 26460/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5710884393189376 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] fate/hlsend: rework the ffprobe dependency of hls-fmp4_ac3

2021-01-24 Thread James Almer
On 1/24/2021 7:08 PM, Andreas Rheinhardt wrote: James Almer: Add it to the existing +FATE_SAMPLES_FFPROBE list of ffprobe dependant tests instead. Signed-off-by: James Almer --- tests/fate/hlsenc.mak | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] fate/hlsend: rework the ffprobe dependency of hls-fmp4_ac3

2021-01-24 Thread Andreas Rheinhardt
James Almer: > Add it to the existing +FATE_SAMPLES_FFPROBE list of ffprobe dependant tests > instead. > > Signed-off-by: James Almer > --- > tests/fate/hlsenc.mak | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265_syntax_template: Better check for num_long_term_sps

2021-01-24 Thread Michael Niedermayer
On Sat, Nov 21, 2020 at 06:49:55PM +, Mark Thompson wrote: > On 21/11/2020 17:37, Michael Niedermayer wrote: > > On Sun, Nov 15, 2020 at 09:37:45PM +, Mark Thompson wrote: > > > On 14/11/2020 10:18, Michael Niedermayer wrote: > > > > Fixes: index 26 out of bounds for type 'uint8_t [16]' >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_nnedi: Fix segfault when prescreening is disabled

2021-01-24 Thread Paul B Mahol
LGTM On Sun, Jan 24, 2021 at 10:33 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Since c737f6edcef74a64f4d0ebcefa970bd31266d512 prescreening is > nevertheless run because of a wrong check: "if (s->prescreen > 0)". > s->prescreen is an array of two function pointers that is

[FFmpeg-devel] [PATCH] fate/hlsend: rework the ffprobe dependency of hls-fmp4_ac3

2021-01-24 Thread James Almer
Add it to the existing +FATE_SAMPLES_FFPROBE list of ffprobe dependant tests instead. Signed-off-by: James Almer --- tests/fate/hlsenc.mak | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index 02f041a7c2..30b81344f1 100644

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_unsharp: Remove unnecessary ;

2021-01-24 Thread Andreas Rheinhardt
A macro that expands to a function definition might look like a declaration, but it isn't and therefore an extra ';' at the end is unnecessary and actually invalid (both GCC and Clang warn about this when using -pedantic). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_unsharp.c | 4 ++--

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_nnedi: Fix segfault when prescreening is disabled

2021-01-24 Thread Andreas Rheinhardt
Since c737f6edcef74a64f4d0ebcefa970bd31266d512 prescreening is nevertheless run because of a wrong check: "if (s->prescreen > 0)". s->prescreen is an array of two function pointers that is contained in the context and comparing it with 0 (i.e. NULL) is actually undefined behaviour, because NULL

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 10. Okt. 2020 um 02:44 Uhr schrieb Andriy Gelman : > > From: Chip Kerchner > > --- > libswscale/ppc/yuv2rgb_altivec.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libswscale/ppc/yuv2rgb_altivec.c > b/libswscale/ppc/yuv2rgb_altivec.c > index 536545293d..930ef6b98f

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-24 Thread Andreas Rheinhardt
James Almer: > On 1/24/2021 5:16 PM, Andreas Rheinhardt wrote: >> It has been added in 6db42a2b6b22e6f1928fafcf3faa67ed78201004, >> yet since then none of the necessary create/free_device_capabilities >> functions has been implemented, making this API completely useless. >> >> Because of this one

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-24 Thread James Almer
On 1/24/2021 5:16 PM, Andreas Rheinhardt wrote: It has been added in 6db42a2b6b22e6f1928fafcf3faa67ed78201004, yet since then none of the necessary create/free_device_capabilities functions has been implemented, making this API completely useless. Because of this one can already simplify

[FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-24 Thread Andreas Rheinhardt
It has been added in 6db42a2b6b22e6f1928fafcf3faa67ed78201004, yet since then none of the necessary create/free_device_capabilities functions has been implemented, making this API completely useless. Because of this one can already simplify avdevice_capabilities_free/create and can already remove

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-24 Thread Lynne
Jan 24, 2021, 17:05 by an...@khirnov.net: > Quoting Lynne (2021-01-23 20:10:46) > >> This is an RFC about the upcoming additions to the AVPacket structure >> (whose size is still part of the ABI, so we need to plan for any changes). >> >> The current RFC patch adds 3 fields: >>     - "void

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2021-01-24 Thread Andriy Gelman
On Sat, 07. Nov 16:31, Andriy Gelman wrote: > On Sat, 31. Oct 10:17, Andriy Gelman wrote: > > On Fri, 16. Oct 00:02, Andriy Gelman wrote: > > > On Fri, 09. Oct 20:17, Andriy Gelman wrote: > > > > From: Chip Kerchner > > > > > > > > --- > > > > libswscale/ppc/yuv2rgb_altivec.c | 10 ++ >

Re: [FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-01-24 Thread Anton Khirnov
Quoting Linjie Fu (2021-01-24 16:05:56) > Regression since 87f0c8280. > > If the extradata of a stream could not be extracted correctly, > codec_info_nb_frames would remain zero, while st->event_flag would still > be marked as AVSTREAM_EVENT_FLAG_NEW_PACKETS. > > The two expressions could be

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 23. Jan. 2021 um 23:21 Uhr schrieb Reimar Döffinger : > > > > > On 23 Jan 2021, at 19:35, Carl Eugen Hoyos wrote: > > > > > > New patch attached, thank you! > > > > Looks good to me. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-24 Thread Anton Khirnov
Quoting Lynne (2021-01-23 20:10:46) > This is an RFC about the upcoming additions to the AVPacket structure > (whose size is still part of the ABI, so we need to plan for any changes). > > The current RFC patch adds 3 fields: >     - "void *opaque;" for the user to use as they wish, same as

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: restore to use codec_info_nb_frames to calculate score

2021-01-24 Thread Linjie Fu
On Sun, Jan 24, 2021 at 9:38 PM James Almer wrote: > > On 1/24/2021 10:00 AM, Linjie Fu wrote: > > From: Linjie Fu > > > > Regression since 87f0c8280. > > > > If the extradata of a stream could not be extracted correctly, > > codec_info_nb_frames would remain zero, while st->event_flag would

[FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-01-24 Thread Linjie Fu
Regression since 87f0c8280. If the extradata of a stream could not be extracted correctly, codec_info_nb_frames would remain zero, while st->event_flag would still be marked as AVSTREAM_EVENT_FLAG_NEW_PACKETS. The two expressions could be different in this case, hence reset event_flags and

[FFmpeg-devel] [PATCH] avformat/utils: always preserve container dimensions for all streams

2021-01-24 Thread James Almer
If a decoder is used for probing it may change the dimensions reported by the demuxer, either by the lowres factor or because of assorted frames reporting different dimensions, and in a codec copy scenario, the last dimensions arbitrarily set by it could end up being propagated to the muxer.

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-24 Thread Anton Khirnov
Quoting James Almer (2021-01-23 19:38:57) > > If i apply the following, the output of three remuxing (codec copy) > tests change > > > diff --git a/libavformat/utils.c b/libavformat/utils.c > > index 8ac6bc04b8..0cdf3156a6 100644 > > --- a/libavformat/utils.c > > +++ b/libavformat/utils.c > >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: restore to use codec_info_nb_frames to calculate score

2021-01-24 Thread James Almer
On 1/24/2021 10:00 AM, Linjie Fu wrote: From: Linjie Fu Regression since 87f0c8280. If the extradata of a stream could not be extracted correctly, codec_info_nb_frames would remain zero, while st->event_flag would still be marked as AVSTREAM_EVENT_FLAG_NEW_PACKETS since it's a new packet

Re: [FFmpeg-devel] [PATCH 6/6] avformat/flvdec: Check for EOF in loop in flv_data_packet()

2021-01-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-23 23:10:56) > Fixes: Timeout > Fixes: > 29656/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5840098987999232 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 4/6] avformat/flvdec: Check for nesting depth in amf_parse_object()

2021-01-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-23 23:10:54) > Fixes: out of array access > Fixes: > 29202/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5112845840809984 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/apedec: Use FFABSU() in do_apply_filter()

2021-01-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-23 23:10:52) > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: > 29053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-4814432697974784 > > Found-by:

Re: [FFmpeg-devel] [PATCH 1/6] avutil/common: Add FFABSU() for a signed -> unsigned ABS

2021-01-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-23 23:10:51) > Signed-off-by: Michael Niedermayer > --- > libavutil/common.h | 8 This is a public header, so a minor bump+APIchanges entry are needed. (ideally we'd also rename those to use the AV prefix, but that is for later) -- Anton Khirnov

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: restore to use codec_info_nb_frames to calculate score

2021-01-24 Thread Linjie Fu
From: Linjie Fu Regression since 87f0c8280. If the extradata of a stream could not be extracted correctly, codec_info_nb_frames would remain zero, while st->event_flag would still be marked as AVSTREAM_EVENT_FLAG_NEW_PACKETS since it's a new packet indeed. The two expressions could be

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Check outlen before allocation

2021-01-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-23 23:34:19) > On Sat, Jan 23, 2021 at 03:29:38PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-01-22 15:09:47) > > > Fixes: Timeout (too long -> 241ms) > > > Fixes: > > >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/avfilter: Remove AVFilterLink.flags

2021-01-24 Thread Nicolas George
Andreas Rheinhardt (12021-01-24): > It is a private field that is unused since > 44f660e7e75b856eafa5f7e7cc6e633de5d01b5d. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.h | 5 - > 1 file changed, 5 deletions(-) LGTM, thanks. Regards, -- Nicolas George

[FFmpeg-devel] [PATCH 2/2] avfilter/avfilter: Remove AVFilterLink.flags

2021-01-24 Thread Andreas Rheinhardt
It is a private field that is unused since 44f660e7e75b856eafa5f7e7cc6e633de5d01b5d. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.h | 5 - 1 file changed, 5 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 100183f56c..d43b866599 100644 ---

[FFmpeg-devel] [PATCH 1/2] avformat/url: Reorder elements of URLProtocol to make it smaller

2021-01-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/url.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/url.h b/libavformat/url.h index e33edf0cb9..1ef5ca35d5 100644 --- a/libavformat/url.h +++ b/libavformat/url.h @@ -87,8 +87,8 @@ typedef struct URLProtocol {

Re: [FFmpeg-devel] seeking consultancy around FFmpeg

2021-01-24 Thread Gregor Riepl
> What we are looking for is pretty straight forward. I like to capture > the HDMI video/audio output of a Chromecast dongle and distribute it > into a LAN network via UDP multicast. Something like this: > > Chromecast -> HDMI -> HDMI-USB Capture -> RPi4/8G (with FFmpeg) -> > UDP/Multicast ->

[FFmpeg-devel] seeking consultancy around FFmpeg

2021-01-24 Thread Gisbert Haas
Hello everyone, I hope this is the right email list for asking if someone is interested in doing some consultancy work for us. What we are looking for is pretty straight forward. I like to capture the HDMI video/audio output of a Chromecast dongle and distribute it into a LAN network via

Re: [FFmpeg-devel] [PATCH] avfilter: add epx pixel art scaler

2021-01-24 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".