Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Marton Balint
On Thu, 28 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 23:50 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote: > ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: > > ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: > > > On Wed, 27 Jan 2021, Tomas Här

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Marton Balint
On Thu, 28 Jan 2021, Gyan Doshi wrote: On 28-01-2021 05:08 am, Marton Balint wrote: So only timecode, convergence_duration and the pseudopal flag should be removed, because there is no replacement for those. Will timecode still be available from ffprobe after this patchset? Only mpeg2

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Gyan Doshi
On 28-01-2021 05:08 am, Marton Balint wrote: So only timecode, convergence_duration and the pseudopal flag should be removed, because there is no replacement for those. Will timecode still be available from ffprobe after this patchset? Regards, Gyan _

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-27 Thread lance . lmwang
On Wed, Jan 27, 2021 at 08:42:40AM +0100, Tobias Rapp wrote: > On 26.01.2021 16:39, Tomas Härdin wrote: > > tis 2021-01-26 klockan 00:34 +0100 skrev Marton Balint: > > > Maybe they should post patches instead of having workarounds? And I > > > explained, libavformat MXF muxer will still be identifi

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread James Almer
On 1/27/2021 8:38 PM, Marton Balint wrote: On Wed, 27 Jan 2021, James Almer wrote: On 1/27/2021 7:42 PM, Michael Niedermayer wrote: On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: Also drop the sections guarded by #if FF_API* These macros are private and should not be used by

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-27 Thread levi
From: Levi Dooley There was an assumption in the existing code that indentation would not occur more than once on the same row. This was a bad assumption. There are examples of 608 streams which call handle_pac multiple times on the same row with different indentation. As the code was before th

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, James Almer wrote: On 1/27/2021 7:42 PM, Michael Niedermayer wrote: On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: Also drop the sections guarded by #if FF_API* These macros are private and should not be used by external callers. --- fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Tomas Härdin
ons 2021-01-27 klockan 23:50 +0100 skrev Marton Balint: > > On Wed, 27 Jan 2021, Tomas Härdin wrote: > > > ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: > > > ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: > > > > On Wed, 27 Jan 2021, Tomas Härdin wrote: > > > > > > > > > Hi >

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread James Almer
On 1/27/2021 7:42 PM, Michael Niedermayer wrote: On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: Also drop the sections guarded by #if FF_API* These macros are private and should not be used by external callers. --- fftools/ffprobe.c | 34 -- .../re

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Paul B Mahol
On Wed, Jan 27, 2021 at 11:43 PM Michael Niedermayer wrote: > On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: > > Also drop the sections guarded by #if FF_API* > > These macros are private and should not be used by external callers. > > --- > > fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add Coding Equations and Color Primaries to local tags

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 22:07 +0100 skrev Marton Balint: Fixes ticket #9079. Signed-off-by: Marton Balint --- libavformat/mxfenc.c| 2 ++ tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/mxf-d10-user-comments| 2

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote: Hi Ticket #9079 brought this about. This should prevent accidentally adding local tags that are

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-01-27 Thread Michael Niedermayer
On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: > Also drop the sections guarded by #if FF_API* > These macros are private and should not be used by external callers. > --- > fftools/ffprobe.c | 34 -- > .../ref/fate/concat-demuxer-extended-lavf-mxf |

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-27 Thread Levi Dooley
Yeah, I am looking into the test failure now. Sorry about that. I did run "make fate" prior to submitting the patch, but I missed the fact that I needed the sample files first, so it looked like it passed all the tests at the time. I have the sample files now, and I am correctly seeing the test fai

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add Coding Equations and Color Primaries to local tags

2021-01-27 Thread Tomas Härdin
ons 2021-01-27 klockan 22:07 +0100 skrev Marton Balint: > Fixes ticket #9079. > > Signed-off-by: Marton Balint > --- > libavformat/mxfenc.c| 2 ++ > tests/ref/fate/copy-trac4914| 2 +- > tests/ref/fate/mxf-d10-user-comments| 2 +- > tests/ref/fate/mxf-opatom-u

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Tomas Härdin
ons 2021-01-27 klockan 22:24 +0100 skrev Tomas Härdin: > ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: > > On Wed, 27 Jan 2021, Tomas Härdin wrote: > > > > > Hi > > > > > > Ticket #9079 brought this about. This should prevent accidentally > > > adding local tags that are not registered

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-27 Thread Mark Thompson
On 27/01/2021 14:36, Nicolas George wrote: Mark Thompson (12021-01-26): Even after such a merge, the libavdevice API is still a problem. I will re-center the discussion on this alone. And I ask, simply: what problem exactly? See for example the list of suggestions I made for improving the A

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Tomas Härdin
ons 2021-01-27 klockan 21:38 +0100 skrev Marton Balint: > > On Wed, 27 Jan 2021, Tomas Härdin wrote: > > > Hi > > > > Ticket #9079 brought this about. This should prevent accidentally > > adding local tags that are not registered in the primer. It also allows > > us to omit tags that we know won

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-27 Thread Andreas Rheinhardt
Aman Karmani: > On Mon, Jan 25, 2021 at 3:16 PM Levi Dooley > wrote: > >> There was an assumption in the existing code that indentation would not >> occur more than once on the same row. >> This was a bad assumption. There are examples of 608 streams which call >> handle_pac multiple times on the

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-27 Thread Aman Karmani
On Mon, Jan 25, 2021 at 3:16 PM Levi Dooley wrote: > There was an assumption in the existing code that indentation would not > occur more than once on the same row. > This was a bad assumption. There are examples of 608 streams which call > handle_pac multiple times on the same row with different

[FFmpeg-devel] [PATCH] avformat/mxfenc: add Coding Equations and Color Primaries to local tags

2021-01-27 Thread Marton Balint
Fixes ticket #9079. Signed-off-by: Marton Balint --- libavformat/mxfenc.c| 2 ++ tests/ref/fate/copy-trac4914| 2 +- tests/ref/fate/mxf-d10-user-comments| 2 +- tests/ref/fate/mxf-opatom-user-comments | 2 +- tests/ref/fate/mxf-reel_name| 2 +- tes

Re: [FFmpeg-devel] [PATCH] avcodec/flashsv2enc: Fix use of uninitialized value

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Andreas Rheinhardt wrote: Before 257a83b969157eb76c18158a4e503e908d8b1125, certain buffers were zero-allocated in the init function and only reallocated lateron if they turned out to be too small; now they are only allocated during init, leading to use-of-uninitialized val

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Marton Balint
On Wed, 27 Jan 2021, Tomas Härdin wrote: Hi Ticket #9079 brought this about. This should prevent accidentally adding local tags that are not registered in the primer. It also allows us to omit tags that we know won't be used, in a manner that is more elegant than the old code. The actual mea

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-27 Thread James Almer
On 1/27/2021 2:40 PM, Lynne wrote: Jan 27, 2021, 16:07 by jamr...@gmail.com: On 1/27/2021 6:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-26 20:11:16) On 1/26/2021 1:17 PM, Anton Khirnov wrote: We could start by adding a field to AVPacket that would be set to a magic value by a

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: add prism interpolation

2021-01-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 2 ++ libavfilter/vf_lut3d.c | 57 ++ 2 files changed, 59 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index a38f9b4124..52458c116d 100644 --- a/doc/filters.texi +++ b/doc/filters.

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: add pyramid interpolation

2021-01-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 2 ++ libavfilter/vf_lut3d.c | 62 ++ 2 files changed, 64 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index fb9995eddf..a38f9b4124 100644 --- a/doc/filters.texi +++ b/doc/filters.

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-27 Thread Lynne
Jan 27, 2021, 16:07 by jamr...@gmail.com: > On 1/27/2021 6:16 AM, Anton Khirnov wrote: > >> Quoting James Almer (2021-01-26 20:11:16) >> >>> On 1/26/2021 1:17 PM, Anton Khirnov wrote: >>> We could start by adding a field to AVPacket that would be set to a magic value by av_packet_alloc()

[FFmpeg-devel] [PATCH] avcodec/rl: Improve documentation of ff_rl_init/ff_rl_init_vlc

2021-01-27 Thread Andreas Rheinhardt
In particular, document that they initialize different parts of an RLTable and therefore need not be synchronized. Signed-off-by: Andreas Rheinhardt --- libavcodec/rl.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/rl.h b/libavcodec/rl.h index 26e0b32a90..5aae69

[FFmpeg-devel] [PATCH 1/3] av_dump_format: add a heading for chapters

2021-01-27 Thread Anton Khirnov
Otherwise the chapters look like a part of the metadata section. --- libavformat/dump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index fe628010d3..ca73c2810c 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -686,6 +686,8 @@ void av_du

[FFmpeg-devel] [PATCH 2/3] av_dump_format(): increase indentation for chapter metadata

2021-01-27 Thread Anton Khirnov
It should be at a deeper level than the chapter ti belongs to. --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index ca73c2810c..5c8e8bc60d 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -696,7 +696,7 @

[FFmpeg-devel] [PATCH 3/3] av_dump_format(): reduce indentation for streams

2021-01-27 Thread Anton Khirnov
Makes it easier to identify where metadata/chapters end and streams begin. --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 5c8e8bc60d..62ef5e9852 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -54

[FFmpeg-devel] [PATCH] avformat/rtpdec: Avoid allocations of small dynamic buffers

2021-01-27 Thread Andreas Rheinhardt
Besides avoiding allocations this also fixes a design defect of ff_rtp_send_punch_packets: It did not return an error in case of these allocations failed. Signed-off-by: Andreas Rheinhardt --- libavformat/rtpdec.c | 38 +- 1 file changed, 13 insertions(+), 25

Re: [FFmpeg-devel] [PATCH] avformat/utils: always preserve container dimensions for all streams

2021-01-27 Thread Hendrik Leppkes
On Wed, Jan 27, 2021 at 2:56 PM Anton Khirnov wrote: > > Quoting James Almer (2021-01-26 00:17:51) > > On 1/25/2021 7:46 PM, Michael Niedermayer wrote: > > > On Sun, Jan 24, 2021 at 11:41:13AM -0300, James Almer wrote: > > >> If a decoder is used for probing it may change the dimensions reported

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-27 Thread James Almer
On 1/27/2021 6:16 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-26 20:11:16) On 1/26/2021 1:17 PM, Anton Khirnov wrote: We could start by adding a field to AVPacket that would be set to a magic value by av_packet_alloc(). Then have e.g. AVCodecContext/AVFormatContext warn when they see

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-27 Thread Nicolas George
Jean-Baptiste Kempf (12021-01-26): > Unfortunately, that's not how it works. > We need to accept the will of majority of developers, even if you (or > someone else) is not convinced. We will accept the will of the majority of developers when the time for making a decision comes if no consensus has

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-27 Thread Nicolas George
Mark Thompson (12021-01-26): > Even after such a merge, the libavdevice API is still a problem. I will re-center the discussion on this alone. And I ask, simply: what problem exactly? You, who AFAIK, do not maintain anything in libavdevice and have never used it in a project, say there is a prob

[FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-27 Thread Tomas Härdin
Hi Ticket #9079 brought this about. This should prevent accidentally adding local tags that are not registered in the primer. It also allows us to omit tags that we know won't be used, in a manner that is more elegant than the old code. The actual meat of this patch is mxf_mark_tag_unused(), mxf_

Re: [FFmpeg-devel] [PATCH] avformat/utils: always preserve container dimensions for all streams

2021-01-27 Thread Anton Khirnov
Quoting James Almer (2021-01-26 00:17:51) > On 1/25/2021 7:46 PM, Michael Niedermayer wrote: > > On Sun, Jan 24, 2021 at 11:41:13AM -0300, James Almer wrote: > >> If a decoder is used for probing it may change the dimensions reported by > >> the > >> demuxer, either by the lowres factor or because

Re: [FFmpeg-devel] [PATCH] cbs_h2645: Implement replace-PS with a table rather than many functions

2021-01-27 Thread Nuo Mi
On Wed, Jan 27, 2021 at 7:06 AM Mark Thompson wrote: > > + > +err = ff_cbs_make_unit_refcounted(ctx, unit); > +if (err < 0) > +return err; > + > +ref_array = > + (AVBufferRef**)((uint8_t*)ctx->priv_data + > ps_type->ref_array_offset); > +ptr_array = (void**)((uint8

Re: [FFmpeg-devel] [PATCH v4 3/9] avcodec: add SEI enum for vvc

2021-01-27 Thread Nuo Mi
On Tue, Jan 26, 2021 at 11:11 PM James Almer wrote: > On 1/26/2021 12:09 PM, Nuo Mi wrote: > > On Tue, Jan 26, 2021 at 10:36 PM James Almer wrote: > > > >> On 1/25/2021 11:15 AM, Nuo Mi wrote: > >>> --- > >>>libavcodec/vvc_sei.h | 47 > > >>>1

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

2021-01-27 Thread Anton Khirnov
Quoting Xu Guangxin (2021-01-05 03:43:37) > --- > libavcodec/qsvdec_h2645.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c > index 02c41883b6..3d6e85230f 100644 > --- a/libavcodec/qsvdec_h2645.c > +++ b/libavcodec/qsvdec_h2645.c >

[FFmpeg-devel] [PATCH] avcodec/flashsv2enc: Fix use of uninitialized value

2021-01-27 Thread Andreas Rheinhardt
Before 257a83b969157eb76c18158a4e503e908d8b1125, certain buffers were zero-allocated in the init function and only reallocated lateron if they turned out to be too small; now they are only allocated during init, leading to use-of-uninitialized values lateron. The same could happen before if the dim

Re: [FFmpeg-devel] [PATCH] avfilter: add kirsch video filter

2021-01-27 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: fix code style in is_common_init_section_exist

2021-01-27 Thread Moritz Barsnick
On Fri, Jan 15, 2021 at 20:13:44 +0800, Steven Liu wrote: > > Good idea, but the indentation is incorrect. The subsequent lines are > > not arguments to av_strcasecmp(), but further clauses for if(). > > > > Also, you should make this change the first commit of your series which > Hi Moritz, > >

Re: [FFmpeg-devel] [PATCH 1/7] tools/target_dec_fuzzer: use non-obsolete decoding API

2021-01-27 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-02 02:24:42) > On Fri, Jan 01, 2021 at 02:37:21PM +0100, Anton Khirnov wrote: > > pushed patches 2-6, which nobody objected to > > > > Michael, could you please test 1/7? > > It seems still working with the patch with the 4 or so files i tried Thank you, patc

Re: [FFmpeg-devel] [PATCH 6/6] avformat/flvdec: Check for EOF in loop in flv_data_packet()

2021-01-27 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-01-26 17:42:27) > On Sun, Jan 24, 2021 at 02:17:05PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-01-23 23:10:56) > > > Fixes: Timeout > > > Fixes: > > > 29656/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5840098987999232 > > > > > >

Re: [FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

2021-01-27 Thread Anton Khirnov
Quoting James Almer (2021-01-26 20:11:16) > On 1/26/2021 1:17 PM, Anton Khirnov wrote: > > We could start by adding a field to AVPacket that would be set to a > > magic value by av_packet_alloc(). > > Then have e.g. AVCodecContext/AVFormatContext warn when they see a > > packet without this magic v

Re: [FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2021-01-27 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-01-23 19:50:11) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2021-01-21 21:20:52) > >> Anton Khirnov: > >>> Quoting Andreas Rheinhardt (2020-12-10 12:16:38) > The H.261 decoder only uses an RLTable's VLC table, yet it also > initializes its index_run,

Re: [FFmpeg-devel] [PATCH] avfilter: add colortemperature filter

2021-01-27 Thread Michael Niedermayer
On Tue, Jan 26, 2021 at 12:16:31PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 22 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_colortemperature.c | 280