Part of the build message:
src/libavformat/smoothstreamingenc.c: In function ‘ism_flush’:
src/libavformat/smoothstreamingenc.c:510:49: warning: ‘/temp’ directive output
may be truncated writing 5 bytes into a region of size between 1 and 1024
[-Wformat-truncation=]
snprintf(filename, siz
src/libavformat/protocols.c: In function ‘avio_enum_protocols’:
src/libavformat/protocols.c:116:7: warning: assignment discards ‘const’
qualifier from pointer target type [-Wdiscarded-qualifiers]
p = p ? p + 1 : url_protocols;
^
Signed-off-by: Guo, Yejun
---
libavformat/protocols.c
src/libavutil/opt.c: In function ‘av_opt_child_class_iterate’:
src/libavutil/opt.c:1738:15: warning: assignment discards ‘const’ qualifier
from pointer target type [-Wdiscarded-qualifiers]
*iter = parent->child_class_next(*iter);
^
Signed-off-by: Guo, Yejun
---
libavutil
Part of warning message:
src/libavformat/dashenc.c: In function ‘flush_init_segment’:
src/libavformat/dashenc.c:608:49: warning: ‘%s’ directive output may be
truncated writing up to 1023 bytes into a region of size between 1 and 1024
[-Wformat-truncation=]
snprintf(filename, sizeof(filen
src/libavfilter/vf_vif.c: In function ‘process_frame’:
src/libavfilter/vf_vif.c:542:20: warning: ‘main’ is usually a function [-Wmain]
AVFrame *out, *main = NULL, *ref = NULL;
^~~~
Signed-off-by: Guo, Yejun
---
libavfilter/vf_vif.c | 14 +++---
1 file changed, 7
The build warning message:
src/libavfilter/vf_ssim.c: In function ‘ssim_plane_16bit’:
src/libavfilter/vf_ssim.c:246:24: warning: ‘main’ is usually a function [-Wmain]
const uint8_t *main = td->main_data[c];
^~~~
src/libavfilter/vf_ssim.c: In function ‘ssim_plane’:
s
Here is the warning message:
src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’:
src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be truncated
writing up to 255 bytes into a region of size 251 [-Wformat-truncation=]
snprintf(device_name, sizeof(device_name), "/de
> -Original Message-
> From: ffmpeg-devel On Behalf Of Guo,
> Yejun
> Sent: 2021年2月24日 23:15
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/v4l2.c: fix build warning
>
>
>
> > -Original Message-
> > From: ffmpeg-devel O
> -Original Message-
> From: Guo, Yejun
> Sent: 2021年2月22日 15:31
> To: ffmpeg-devel@ffmpeg.org
> Cc: Guo, Yejun
> Subject: [PATCH V3 3/3] libavfilter: add filter dnn_detect for object
> detection
>
> Below are the example steps to do object detection:
>
> 1. download and install l_op
On Thu, Feb 25, 2021 at 1:32 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> James Almer:
> > On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
> >> avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
> >> public API (transform.h is not a public header), yet they a
On Wed, Feb 24, 2021 at 9:48 PM Werner Robitza
wrote:
> On Wed, Feb 24, 2021 at 9:11 PM Paul B Mahol wrote:
> >
> > Why duplicating code that would give same output as ffprobe?
>
> I was told to here:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/275510.html
>
> Could please show an e
James Almer:
> On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
>> avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
>> public API (transform.h is not a public header), yet they are currently
>> exported because of their name. This commit changes this:
>> avfilter_transform is
Not possible.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Hi people. Now it is very common videos recorded with bad rotations. With
ffmpeg it is possible to rotate without re-encoding the video using the
'rotate' instruction. But if the video has more than one rotation it is not
possible. Will it be possible to add rotation instructions with time? For
On Wed, Feb 24, 2021 at 9:51 PM Nicolas George wrote:
> I never told you to duplicate code. Code duplication is almost always a
> motive for rejection.
>
> If you are tempted to duplicate code, what you need to do is to share it
> between the various places that use it. Making it a proper API if
>
Werner Robitza (12021-02-24):
> I was told to here:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/275510.html
I never told you to duplicate code. Code duplication is almost always a
motive for rejection.
If you are tempted to duplicate code, what you need to do is to share it
between t
On Wed, Feb 24, 2021 at 9:11 PM Paul B Mahol wrote:
>
> Why duplicating code that would give same output as ffprobe?
I was told to here:
http://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/275510.html
Could please show an example on how to achieve this with ffprobe?
__
Why duplicating code that would give same output as ffprobe?
On Wed, Feb 24, 2021 at 9:01 PM Werner Robitza
wrote:
> This adds a new option to the metadata filter that allows outputting CSV
> data.
> The separator can be set via another option.
> Special characters are handled via escaping.
>
>
This adds a new option to the metadata filter that allows outputting CSV data.
The separator can be set via another option.
Special characters are handled via escaping.
Signed-off-by: Werner Robitza
---
doc/filters.texi | 14
libavfilter/f_metadata.c | 155 +
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Tuesday, November 3, 2020 7:46 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Artem Galin
> Subject: [FFmpeg-devel] [PATCH v7 8/8] libavfilter/vf_deinterlace_qsv:
> enabling d3d11va support, added mfxhdlpair
>
> Addin
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Tuesday, November 3, 2020 7:46 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Artem Galin
> Subject: [FFmpeg-devel] [PATCH v7 2/8] libavutil/hwcontext_qsv: supporting
> d3d11va device type
>
> This enables usage of no
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Wednesday, February 24, 2021 4:40 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: [FFmpeg-devel] Proposal of two projects for GSoC
>
>
> Please find the proposal for the fol
Am 24.02.21 um 05:06 schrieb Zane van Iperen:
> As per discussion at [1]. Patches attached.
>
> Patch 1/3 adds /node_modules/ to .gitignore
>
> Patch 2/3 adds the actual key and verification instructions
>
> Patch 3/3 adds a prominent download link for the public key.
> This might be bit obnoxio
Signed-off-by: Paul B Mahol
---
libavcodec/cfhdencdsp.c | 3 +
libavcodec/x86/Makefile | 2 +
libavcodec/x86/cfhdencdsp.asm| 429 +++
libavcodec/x86/cfhdencdsp_init.c | 48
4 files changed, 482 insertions(+)
create mode 100644 libavcode
On Wed, Feb 24, 2021 at 4:47 PM Anton Khirnov wrote:
> Quoting Paul B Mahol (2021-02-23 18:25:09)
> > Signed-off-by: Paul B Mahol
> > ---
> > libavformat/Makefile | 1 +
> > libavformat/allformats.c | 1 +
> > libavformat/sga.c| 388 +++
> > 3
Quoting Paul B Mahol (2021-02-23 18:25:09)
> Signed-off-by: Paul B Mahol
> ---
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/sga.c| 388 +++
> 3 files changed, 390 insertions(+)
> create mode 100644 libavformat/s
Hello,
Please find the proposal for the following two projects for GSoC this year.
The FATE project had been proposed earlier already but I don't know why it
didn't happen.
I previously got the feedback from Thilo Borgmann and would be happy to get
feedback from the community as well.
"
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: 2021年2月24日 22:05
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/v4l2.c: fix build warning
>
> Quoting Guo, Yejun (2021-02-20 08:22:11)
> > Here is the
On 2/24/2021 5:40 AM, Anton Khirnov wrote:
It is simpler and more efficient.
Suggested-by: James Almer
---
libavcodec/lscrdec.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/libavcodec/lscrdec.c b/libavcodec/lscrdec.c
index d5388c22ac..e706dda9da 1006
On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
public API (transform.h is not a public header), yet they are currently
exported because of their name. This commit changes this:
avfilter_transform is renamed to ff_affine_tran
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On Tue, Feb 23, 2021, at 2:47 PM, 殷时友 wrote:
>
> > 2021年2月19日 下午1:28，Jiaxun Yang 写道：
> >
> > Get MMI optimizations build for Loongson-2 again.
> > Tested on Loongson-2 and Loongson-3A.
> >
> > Jiaxun Yang (4):
> > avutil/mips: Use MMI_{L,S}QC1 macro in {SAVE,RECOVER}_REG
> > avutil/mips: Ex
Quoting Michael Niedermayer (2021-02-15 21:31:23)
> Fixes: OOM
> Fixes:
> 27780/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5097985075314688
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer
Signed-off-by: Andreas Rheinhardt
---
libavfilter/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index 359ea7f903..f63b395fbd 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -19,7 +19,6 @@ OBJS = allfil
avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
public API (transform.h is not a public header), yet they are currently
exported because of their name. This commit changes this:
avfilter_transform is renamed to ff_affine_transform; the other
functions are just removed as they
Quoting Guo, Yejun (2021-02-20 08:22:14)
> Part of warning message:
> src/libavformat/dashenc.c: In function ‘flush_init_segment’:
> src/libavformat/dashenc.c:608:49: warning: ‘%s’ directive output may be
> truncated writing up to 1023 bytes into a region of size between 1 and 1024
> [-Wformat-tr
On 2/24/2021 6:33 AM, Anton Khirnov wrote:
Modifying shared state after ff_thread_finish_setup() is not allowed, so
set the encoding parameters directly on the output frame.
Does this also ensure the side data will be present in
show_existing_frame frames? This means the "ret == 0" case when
Quoting Guo, Yejun (2021-02-20 08:22:11)
> Here is the warning message:
> src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’:
> src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be
> truncated writing up to 255 bytes into a region of size 251
> [-Wformat-truncation=]
>
On 2/24/2021 7:03 AM, Anton Khirnov wrote:
---
tests/api/api-band-test.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index 34bed1d6be..717c9441a4 100644
--- a/tests/api/api-band-test.c
+++ b/tests/api/api-band-
On Mon, Feb 22, 2021 at 20:32:14 -0800, Jose Da Silva wrote:
> -for (i = 0; string && string[i]; i++) {
> +if (string == 0)
"if (!string)" is the preferred style for pointers.
But I don't see the advantage - isn't the loop interrupted immediately
anyway if string == NULL? (Same for the ot
On 2/24/2021 7:03 AM, Anton Khirnov wrote:
The encoder may keep a reference to frames that were sent to it, so the
caller cannot modify them without checking first.
---
tests/api/api-flac-test.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/api/api-flac-test.c b/tests/api/api-f
On 2/24/2021 5:23 AM, Anton Khirnov wrote:
Quoting James Almer (2021-02-20 14:21:47)
No buffer will be fetched from the pool after it's uninitialized, so there's
no benefit from waiting until every single buffer has been returned to it
before freeing them all.
This should free some memory in cer
Apple HTTP Live Streaming Sample Encryption:
https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption
Signed-off-by: Nachiket Tarate
---
libavformat/Makefile | 2 +-
libavformat/hls.c| 105 --
libavformat/hls_sample_aes.c |
It makes the intent clearer and avoids calculating the length
separately.
Signed-off-by: Andreas Rheinhardt
---
libavformat/webmdashenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
index 04f8cbe39d..332d0466e1 100
It makes the intent clearer and avoids calculating the length
separately.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskadec.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 1f96b49fc4..c03cd8bd0
It makes the intent clearer and avoids calculating the length
in advance.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/avio.c b/libavformat/avio.c
index fbe07e44bc..8011482e76 100644
--- a/libavforma
It makes the intent clearer and avoids searching for a delimiter
in advance.
Signed-off-by: Andreas Rheinhardt
---
fftools/cmdutils.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 4eb68d2201..fe253d10a4 100644
--- a/fftool
It makes the intent clearer and avoids calculating the length
separately.
Signed-off-by: Andreas Rheinhardt
---
libavutil/spherical.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavutil/spherical.c b/libavutil/spherical.c
index 4a7f3e49ca..ed66344a2f 100644
--- a/li
It makes the intent clearer and avoids calculating the length
separately.
Signed-off-by: Andreas Rheinhardt
---
libavutil/stereo3d.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c
index 6edcdb1796..279fcc1ff3 100644
--- a/liba
It makes the intent clearer and allows to avoid calculating the strlen
separately.
Signed-off-by: Andreas Rheinhardt
---
libavutil/pixdesc.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c
index 827
Signed-off-by: Andreas Rheinhardt
---
libavformat/pcmdec.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c
index cd3e7b2e8f..9b552936ac 100644
--- a/libavformat/pcmdec.c
+++ b/libavformat/pcmdec.c
@@ -
Signed-off-by: Andreas Rheinhardt
---
libavformat/pcmdec.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c
index 395d9ecf92..cd3e7b2e8f 100644
--- a/libavformat/pcmdec.c
+++ b/libavformat/pcmdec.c
@@ -19,6 +19,7 @@
* F
It is undefined behaviour.
Signed-off-by: Andreas Rheinhardt
---
libavformat/pcmdec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c
index e65b535665..395d9ecf92 100644
--- a/libavformat/pcmdec.c
+++ b/libavformat/pcmdec.c
@@ -57
Also make the macro used for the demuxers spec-compliant. The earlier
macro was not, because the ... argument of a variadic macro must not be
left out. GCC and Clang warn about this when using -pedantic.
Signed-off-by: Andreas Rheinhardt
---
libavformat/pcmdec.c | 102 ---
Signed-off-by: Andreas Rheinhardt
---
libavformat/movenc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index cf0e35dd33..8ac5c317b4 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6387,7 +6387,6 @@ static
It only affects the old and deprecated avcodec_decode_(video2|audio4)
API which is no longer used here.
Signed-off-by: Andreas Rheinhardt
---
I am surprised that no one found this before me. Is it because there was
no -Wdeprecated-declarations warning?
fftools/ffmpeg.c | 1 -
fftools/ffplay.c |
Signed-off-by: Andreas Rheinhardt
---
Given that the name of every possible muxer here has a strlen of three
or four one could even replace the strcmp by
AV_RN32(s->oformat->name) == AV_RN32(#muxer).
libavformat/movenc.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
dif
Signed-off-by: Andreas Rheinhardt
---
libavformat/movenc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 545b0885ae..cdfcbd3d76 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6395,7 +6395,6 @@ static int mov_init(AVFormatC
These will be used by HLS demuxer in case of SAMPLE-AES decryption.
Signed-off-by: Nachiket Tarate
---
libavcodec/adts_header.c | 1 +
libavcodec/adts_header.h | 14 ++
libavcodec/adts_parser.c | 28
3 files changed, 43 insertions(+)
diff --git a/libavc
Signed-off-by: Nachiket Tarate
---
libavformat/hls.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index 3cb3853c79..d612ebb185 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2028,23 +2028
AVID streams - currently handled by the AVRN decoder - can be (depending
on extradata contents) either MJPEG or raw video. To decode the MJPEG
variant, the AVRN decoder currently instantiates a MJPEG decoder
internally and forwards decoded frames to the caller (possibly after
cropping them).
This
AVID streams - currently handled by the AVRN decoder - can be (depending
on extradata contents) either MJPEG or raw video. To decode the MJPEG
variant, the AVRN decoder currently instantiates a MJPEG decoder
internally and forwards decoded frames to the caller (possibly after
cropping them).
This
The encoder may keep a reference to frames that were sent to it, so the
caller cannot modify them without checking first.
---
tests/api/api-flac-test.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c
index 3fea3258f3..7c96a4d99e 100644
---
tests/api/api-flac-test.c | 42 +++
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c
index 3d83c56987..b67c3d7363 100644
--- a/tests/api/api-flac-test.c
+++ b/tests/api/api-flac-test.c
@@ -
---
tests/api/api-flac-test.c | 40 +--
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c
index 7c96a4d99e..3d83c56987 100644
--- a/tests/api/api-flac-test.c
+++ b/tests/api/api-flac-test.c
@@ -
It tests deprecated avcodec_copy_context().
---
libavcodec/Makefile| 1 -
libavcodec/tests/options.c | 194 -
tests/fate/libavcodec.mak | 4 -
3 files changed, 199 deletions(-)
delete mode 100644 libavcodec/tests/options.c
diff --git a/libavcodec/
---
tests/api/api-band-test.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index 34bed1d6be..717c9441a4 100644
--- a/tests/api/api-band-test.c
+++ b/tests/api/api-band-test.c
@@ -167,10 +167,8 @@ static int video_de
AVID streams - currently handled by the AVRN decoder - can be (depending
on extradata contents) either MJPEG or raw video. To decode the MJPEG
variant, the AVRN decoder currently instantiates a MJPEG decoder
internally and forwards decoded frames to the caller (possibly after
cropping them).
This
Modifying shared state after ff_thread_finish_setup() is not allowed, so
set the encoding parameters directly on the output frame.
Found-by: James Almer
---
libavcodec/vp9.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/libavcodec/vp9.c b/libavcodec/vp9.
Quoting James Almer (2021-02-19 17:28:57)
> On 5/11/2020 6:32 AM, Anton Khirnov wrote:
> > ---
> > Now the nb_block_structure reset is moved to decode_frame_header(),
> > which fixes block-structure export with frame threading. No idea how I
> > didn't notice this before
>
> Thread sanitizer compl
Quoting James Almer (2021-01-26 18:19:46)
> On 1/26/2021 2:01 PM, Anton Khirnov wrote:
> > These macros are private and should not be used by external callers.
> > ---
> > fftools/ffmpeg_opt.c | 13 -
> > 1 file changed, 13 deletions(-)
> >
> > diff --git a/fftools/ffmpeg_opt.c b/ff
It is simpler and more efficient.
Suggested-by: James Almer
---
libavcodec/lscrdec.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/libavcodec/lscrdec.c b/libavcodec/lscrdec.c
index d5388c22ac..e706dda9da 100644
--- a/libavcodec/lscrdec.c
+++ b/libavcodec/
Quoting James Almer (2021-02-20 15:38:42)
> > +
> > +static void handle_row(LSCRContext *s, AVFrame *frame)
>
> Unused frame argument.
Right, dropped locally.
> > +static int decode_frame_lscr(AVCodecContext *avctx,
> > + void *data, int *got_frame,
> > +
Quoting James Almer (2021-02-20 14:21:47)
> No buffer will be fetched from the pool after it's uninitialized, so there's
> no benefit from waiting until every single buffer has been returned to it
> before freeing them all.
> This should free some memory in certain scenarios, which can be beneficia
74 matches
Mail list logo
