[FFmpeg-devel] [PATCH] avformat/movenc: fix writing dOps atoms

2021-04-14 Thread James Almer
Don't blindly copy all bytes in extradata past ChannelMappingFamily. Instead check if ChannelMappingFamily is not 0 and then only write the correct amount of bytes from ChannelMappingTable, as defined in the spec[1]. Should fix ticket #9190. [1]

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: remove singlejpeg muxer

2021-04-14 Thread Gyan Doshi
On 2021-04-12 21:27, Gyan Doshi wrote: Ping. Plan to push in 24h. On 2021-04-10 20:00, Gyan Doshi wrote: It was added in 51ac1f616f due to ticket #4218, in order to show a single image via ffserver. With ffserver long gone, it serves no purpose. ---   libavformat/Makefile |  1 -  

[FFmpeg-devel] [PATCH] avformat/mpegts: set correct extradata size for Opus streams

2021-04-14 Thread James Almer
map_type 0 is always 19 bytes, whereas map_type 1 and 255 are 21 + channel count bytes. Should fix ticket #9190. Signed-off-by: James Almer --- libavformat/mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6e0d9d7496..5343a14e38

[FFmpeg-devel] [PATCH 5/5] avcodec/vorbis_parser: Improve returned error codes

2021-04-14 Thread Andreas Rheinhardt
av_vorbis_parse_init() doesn't return an error code which is a slight problem in libvorbisenc.c. Fix this by making the internal initialization function behind av_vorbis_parse_init() available. This also avoids allocations and frees (for users inside of this inside libavcodec). Signed-off-by:

[FFmpeg-devel] [PATCH 4/5] avcodec/libvorbisenc: Actually set error upon goto error

2021-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/libvorbisenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libvorbisenc.c b/libavcodec/libvorbisenc.c index b556280a95..061a4e9da7 100644 --- a/libavcodec/libvorbisenc.c +++ b/libavcodec/libvorbisenc.c @@

[FFmpeg-devel] [PATCH 3/5] avcodec/libvorbisenc: Fix memleak upon error

2021-04-14 Thread Andreas Rheinhardt
The vorbis_comment struct used to during codec initialization would leak in case an error happened after its initialization (e.g. if the allocation of extradata failed). This has been fixed. Given that said struct is only used when writing the header, it has also been moved from the context.

[FFmpeg-devel] [PATCH 2/5] avcodec/flacenc: Remove always-true check

2021-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flacenc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 32b2465279..f1e3e1989b 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -1449,12 +1449,11 @@

[FFmpeg-devel] [PATCH 1/5] avcodec: Remove redundant freeing of extradata of encoders

2021-04-14 Thread Andreas Rheinhardt
AVCodecContext.extradata is freed generically by libavformat for encoders, so it is unnecessary for an encoder to do it on its own. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacenc.c | 2 -- libavcodec/huffyuvenc.c| 1 - libavcodec/lclenc.c| 1 -

[FFmpeg-devel] [PATCH] avformat/matroskaenc: Remove unnecessary function calls

2021-04-14 Thread Andreas Rheinhardt
ffio_fill() is used when initially writing unknown length elements; yet it can happen that the amount of bytes written by it is zero in which case it is of course unnecessary to ever call it. Whether it is possible to know this during compiletime depends upon how aggressively the compiler inlines

[FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't allocate+free JPEGLSState for every frame

2021-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsdec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/jpeglsdec.c b/libavcodec/jpeglsdec.c index 69980eaa49..92df81600b 100644 --- a/libavcodec/jpeglsdec.c +++ b/libavcodec/jpeglsdec.c @@ -45,6

[FFmpeg-devel] [PATCH] avformat/utils: Combine identical statements

2021-04-14 Thread Andreas Rheinhardt
This would only make a difference in case the first attempt to initialize the encoder failed and the second succeeded. The only reason I can think of for this to happen is that the options (in particular the codec whitelist) are not used for the second try and that obviously implies that we should

Re: [FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-04-14 Thread Christopher Degawa
On Sat, Apr 10, 2021 at 3:07 PM Christopher Degawa wrote: > ping on this patch again > pong again ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 3/5] avformat/aaxdec: Check avio_seek() in inner loop for failure

2021-04-14 Thread Michael Niedermayer
On Tue, Apr 13, 2021 at 01:09:52PM -0300, James Almer wrote: > On 4/13/2021 12:45 PM, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 32450/clusterfuzz-testcase-minimized-ffmpeg_dem_AAX_fuzzer-4875522262827008 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH 2/2] avutil/cpu: Schedule deprecated functions for removal

2021-04-14 Thread Andreas Rheinhardt
av_set_cpu_flags_mask() has been deprecated in the commit which merged it: 6df42f98746be06c883ce683563e07c9a2af983f; av_parse_cpu_flags() has been deprecated in 4b529edff8934c258af95e5acc51f84deea66262. Signed-off-by: Andreas Rheinhardt --- libavutil/cpu.c | 3 ++- libavutil/cpu.h | 3

[FFmpeg-devel] [PATCH 1/2] Include attributes.h directly

2021-04-14 Thread Andreas Rheinhardt
Some files currently rely on libavutil/cpu.h to include it for them; yet said file won't use include it any more after the currently deprecated functions are removed, so include attributes.h directly. Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/aacpsdsp_init_aarch64.c | 1 +

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-14 Thread Mikhail Nitenko
thank you, i've tried your suggestions and here is what I got (the left column is A53 and the right is A72) current code: pred16x16_top_dc_10_c: 106.093.2 pred16x16_top_dc_10_neon:87.777.5 ld1, add, addv variant: pred16x16_top_dc_10_c: 106.095.5

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-14 Thread chen
Inlined a few comments for ff_pred16x16_top_dc_neon_10, other are similar. At 2021-04-14 20:35:44, "Martin Storsjö" wrote: >On Tue, 13 Apr 2021, Mikhail Nitenko wrote: > >> Benchmarks: >> pred16x16_dc_10_c: 124.0 >> pred16x16_dc_10_neon: 97.2 >> pred16x16_horizontal_10_c: 71.7 >>

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-14 Thread Martin Storsjö
On Tue, 13 Apr 2021, Mikhail Nitenko wrote: Benchmarks: pred16x16_dc_10_c: 124.0 pred16x16_dc_10_neon: 97.2 pred16x16_horizontal_10_c: 71.7 pred16x16_horizontal_10_neon: 66.2 pred16x16_top_dc_10_c: 90.7 pred16x16_top_dc_10_neon: 71.5 pred16x16_vertical_10_c: 64.7 pred16x16_vertical_10_neon:

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Also fetch final partial segment

2021-04-14 Thread Steven Liu
> 2021年4月14日 上午3:42,Matt Robinson 写道: > > On Tue, 6 Apr 2021 at 02:36, Steven Liu wrote: >> >>> 2021年4月6日 上午1:45,Matt Robinson 写道: >>> >>> Currently, the DASH demuxer omits the final segment for a non-live >>> stream (using SegmentTemplate) if it is shorter than the other segments. >>>

[FFmpeg-devel] [PATCH v2 3/4] avcodec/ttmlenc: add initial support for regions and styles

2021-04-14 Thread Jan Ekström
From: Jan Ekström Attempts to utilize the TTML cell resolution as a mapping to the reference resolution, and maps font size to cell size. Additionally sets the display and text alignment according to the ASS alignment number. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 210

[FFmpeg-devel] [PATCH v2 1/4] avcodec/ttmlenc: split header writing into its own function

2021-04-14 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/libavcodec/ttmlenc.c b/libavcodec/ttmlenc.c index 3972b4368c..e3c155fdd1 100644 --- a/libavcodec/ttmlenc.c +++

[FFmpeg-devel] [PATCH v2 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-04-14 Thread Jan Ekström
From: Jan Ekström The ASS margins are utilized to generate percentual values, as the usage of cell-based sizing and offsetting seems to be not too well supported by renderers. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 44 --

[FFmpeg-devel] [PATCH v2 2/4] avformat/ttmlenc: enable writing out additional header values

2021-04-14 Thread Jan Ekström
From: Jan Ekström This way the encoder may pass on the following values to the muxer: 1) Additional root "tt" element attributes, such as the subtitle canvas reference size. 2) Anything before the body element of the document, such as regions in the head element, which can configure

[FFmpeg-devel] [PATCH v2 0/4] Initial region (styling) support for TTML

2021-04-14 Thread Jan Ekström
Now sets alignment, font size, font family and the region's position and size according to the ASS styles passed to the encoder. Regions are relatively important in TTML, since the spec-defined default region is in raster location (similar to the default with HTML) - it starts from the top left