Re: [FFmpeg-devel] [PATCH 17/20] avcodec/twinvqdec: Mark decoder as init-threadsafe

2021-05-10 Thread Andreas Rheinhardt
HouLei: > ? > If you want to ask a question, you should actually ask the question. (If the question is "Why is this decoder init-threadsafe?", the answer is: "Because there is no initialization of anything static going on in its init function (and in function, the decoder in general).".) > 在

Re: [FFmpeg-devel] [PATCH 17/20] avcodec/twinvqdec: Mark decoder as init-threadsafe

2021-05-10 Thread HouLei
? 在 2021/5/7 下午2:46, Andreas Rheinhardt 写道: Signed-off-by: Andreas Rheinhardt --- libavcodec/twinvqdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/twinvqdec.c b/libavcodec/twinvqdec.c index b972facfdd..1fbe0bc32e 100644 --- a/libavcodec/twinvqdec.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-05-10 Thread HouLei
在 2021/4/11 上午5:21, Michael Niedermayer 写道: On Fri, Apr 09, 2021 at 10:59:44PM -0300, James Almer wrote: On 4/7/2021 11:59 AM, Michael Niedermayer wrote: On Wed, Apr 07, 2021 at 12:42:50AM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: out of array read Fixes:

Re: [FFmpeg-devel] [PATCH] GSoC: Support fast guided filter.

2021-05-10 Thread myp...@gmail.com
On Tue, May 11, 2021 at 1:08 PM myp...@gmail.com wrote: > > On Mon, May 10, 2021 at 9:42 PM Xuewei Meng <928826...@qq.com> wrote: > > > > From: Xuewei Meng > > > > Two modes are supported in guided filter, basic mode and fast mode. > > Basic mode is the initial pushed guided filter without

Re: [FFmpeg-devel] [PATCH] GSoC: Support fast guided filter.

2021-05-10 Thread myp...@gmail.com
On Mon, May 10, 2021 at 9:42 PM Xuewei Meng <928826...@qq.com> wrote: > > From: Xuewei Meng > > Two modes are supported in guided filter, basic mode and fast mode. > Basic mode is the initial pushed guided filter without optimization. > Fast mode is implemented based on the basic one by

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters: Update commands doc for amix

2021-05-10 Thread myp...@gmail.com
On Mon, May 10, 2021 at 10:11 PM Gyan Doshi wrote: > > > > On 2021-05-07 18:33, Jun Zhao wrote: > > From: Jun Zhao > > > > commit 95b854dd06 "rename sum option to normalize" missed command > > part docs > > > > Signed-off-by: Jun Zhao > > --- > > doc/filters.texi | 2 +- > > 1 file changed,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_guided: Add missing const

2021-05-10 Thread Steven Liu
> 2021年5月11日 上午6:30,Andreas Rheinhardt 写道: > > Forgotten in f8d910e90f599f338438833dfc92e2f1915ce414. > > Signed-off-by: Andreas Rheinhardt > --- > Will apply soon. > > libavfilter/vf_guided.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_guided.c

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Tue, May 11, 2021 at 03:45:51AM +0200, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> On Tue, May 11, 2021 at 01:27:09AM +0200, Andreas Rheinhardt wrote: lance.lmw...@gmail.com: > On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check for av_frame_get_side_data

2021-05-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2021年5月7日 16:54 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result > check for av_frame_get_side_data > > > > > -Original

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread lance . lmwang
On Tue, May 11, 2021 at 03:45:51AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Tue, May 11, 2021 at 01:27:09AM +0200, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >>> On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote: >

Re: [FFmpeg-devel] [PATCH V2 4/4] dnn/vf_dnn_detect: add tensorflow output parse support

2021-05-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2021年5月10日 14:14 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] dnn/vf_dnn_detect: add > tensorflow output parse support > > > > > -Original Message-

Re: [FFmpeg-devel] [PATCH] avcodec/libxavs: Always use in-band headers

2021-05-10 Thread James Almer
On 5/10/2021 10:52 PM, Andreas Rheinhardt wrote: The code to create global headers is broken and deactivated, so one must not deactivate in-band headers even if the AV_CODEC_FLAG_GLOBAL_HEADER is set; doing otherwise creates unplayable files when this flag is set. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH] avcodec/libxavs: Always use in-band headers

2021-05-10 Thread Andreas Rheinhardt
The code to create global headers is broken and deactivated, so one must not deactivate in-band headers even if the AV_CODEC_FLAG_GLOBAL_HEADER is set; doing otherwise creates unplayable files when this flag is set. Signed-off-by: Andreas Rheinhardt --- libavcodec/libxavs.c | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Tue, May 11, 2021 at 01:27:09AM +0200, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote: lance.lmw...@gmail.com: > From: Limin Wang > > This prevents OOM in case of data buffer

[FFmpeg-devel] [PATCH] avcodec/allcodecs: Don't include libx264 twice in the list of codecs

2021-05-10 Thread Andreas Rheinhardt
Since a247ac640df3da573cd661065bf53f37863e2b46, allcodecs.c contained two lines that matched the regex used by find_filters_extern in configure; as a result, libx264 appeared twice the list of codecs (if enabled). Fix this by using only one matching line by adding a preprocessor define for the

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread lance . lmwang
On Tue, May 11, 2021 at 01:27:09AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >>> From: Limin Wang > >>> > >>> This prevents OOM in case of data buffer size is insufficient. > >>

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> From: Limin Wang >>> >>> This prevents OOM in case of data buffer size is insufficient. >> >> OOM? > Yes, it's invalid Out Of Memory access, not no memory available. >

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread lance . lmwang
On Mon, May 10, 2021 at 09:52:48PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > This prevents OOM in case of data buffer size is insufficient. > > OOM? Yes, it's invalid Out Of Memory access, not no memory available. What's your suggestion? > > > >

[FFmpeg-devel] [PATCH] avfilter/vf_guided: Add missing const

2021-05-10 Thread Andreas Rheinhardt
Forgotten in f8d910e90f599f338438833dfc92e2f1915ce414. Signed-off-by: Andreas Rheinhardt --- Will apply soon. libavfilter/vf_guided.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c index 86c0db5032..20c142337a 100644 ---

Re: [FFmpeg-devel] [PATCH 01/20] avcodec/wma: Remove nonsense volatile

2021-05-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The address of this variable never leaks, so it cannot be modified > by anyone else at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/wma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/wma.c b/libavcodec/wma.c > index

Re: [FFmpeg-devel] [PATCH 01/23] avcodec/ljpegenc: Mark encoder as init-threadsafe

2021-05-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > From: Andreas Rheinhardt > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ljpegenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/ljpegenc.c b/libavcodec/ljpegenc.c > index 80b5e799ed..d820b9a0f5 100644 > --- a/libavcodec/ljpegenc.c > +++

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-10 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > This prevents OOM in case of data buffer size is insufficient. OOM? > > Signed-off-by: Limin Wang > --- > libavformat/hls.c | 4 +++- > libavformat/internal.h | 6 -- > libavformat/rtpdec_latm.c | 6 -- >

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Marton Balint
On Mon, 10 May 2021, Anton Khirnov wrote: Export them in UTC, not the local timezone. This way the output is the same everywhere. The timezone information stored in the file is still ignored, since there seems to be no simple way to export it correctly. Format them according to ISO 8601,

Re: [FFmpeg-devel] [PATCHv3] fate/integer.c: Connect test to fuzzer

2021-05-10 Thread Michael Niedermayer
On Fri, May 07, 2021 at 09:23:09PM +0530, Vedaa wrote: > Hi, > > I have added the inclusion guards and changed the author. > > --- > Makefile | 2 ++ > libavutil/tests/integer.c | 21 ++ > libavutil/tests/integer.h | 45 +++

Re: [FFmpeg-devel] [PATCHv3] fate/integer.c: Connect test to fuzzer

2021-05-10 Thread Michael Niedermayer
On Fri, May 07, 2021 at 09:23:09PM +0530, Vedaa wrote: > Hi, > > I have added the inclusion guards and changed the author. > [...] > @@ -0,0 +1,45 @@ > +/* > + * Copyright (c) 2004 Michael Niedermayer > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can

Re: [FFmpeg-devel] [PATCH 1/2] doc/filters: Update commands doc for amix

2021-05-10 Thread Gyan Doshi
On 2021-05-07 18:33, Jun Zhao wrote: From: Jun Zhao commit 95b854dd06 "rename sum option to normalize" missed command part docs Signed-off-by: Jun Zhao --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-10 Thread Michael Niedermayer
On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > There are no guarantees that all side data types have the same > representation on all platforms. > @@ -65,63 +51,6 @@ static int framecrc_write_packet(struct AVFormatContext > *s, AVPacket *pkt) > pkt->stream_index,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/adpcm_psx: always fetch next byte irregardless of flag

2021-05-10 Thread Zane van Iperen
On 7/5/21 9:17 pm, Zane van Iperen wrote: On 3/5/21 9:31 pm, Zane van Iperen wrote: Even though all samples are meant to be zero (if flag == 0x07), doesn't mean that they aren't there. See No$PSX docs [1]. [1]: https://problemkaputt.de/psx-spx.htm#spuadpcmsamples Ping on this patchset.

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-05-10 Thread hou...@uniontech.com
On Fri, 19 Feb 2021, Nicolas George wrote: > hou...@uniontech.com (12021-02-19): >> From: Hou Lei >> >> Signed-off-by: Hou Lei >> --- >> libavdevice/xcbgrab.c | 11 ++- >> 1 file changed, 10 insertions(+), 1 deletion(-) > > NAK. The correct fix is to use the monotonic clock for syncing.

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-05-10 Thread hou...@uniontech.com
thank you! ---111 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-05-10 Thread hou...@uniontech.com
thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] lavf/mpegts: fix av_log use the uninitialized stream id

2021-05-10 Thread myp...@gmail.com
On Mon, May 10, 2021 at 6:33 AM Marton Balint wrote: > > > > On Fri, 7 May 2021, Jun Zhao wrote: > > > From: Jun Zhao > > > > fix av_log use the uninitialized stream id > > Actually i is not the correct value even if it is initialized because the > loop is executed in full. > > Either remove

[FFmpeg-devel] [PATCH] GSoC: Support fast guided filter.

2021-05-10 Thread Xuewei Meng
From: Xuewei Meng Two modes are supported in guided filter, basic mode and fast mode. Basic mode is the initial pushed guided filter without optimization. Fast mode is implemented based on the basic one by sub-sampling method. The sub-sampling ratio which can be defined by users controls the

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Alexander Strasser
On 2021-05-10 10:22 +0200, Anton Khirnov wrote: > Export them in UTC, not the local timezone. This way the output is > the same everywhere. The timezone information stored in the file is > still ignored, since there seems to be no simple way to export it > correctly. > > Format them according to

[FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Anton Khirnov
Export them in UTC, not the local timezone. This way the output is the same everywhere. The timezone information stored in the file is still ignored, since there seems to be no simple way to export it correctly. Format them according to ISO 8601, which we generally use for exporting dates. --- If

Re: [FFmpeg-devel] [PATCH V2 4/4] dnn/vf_dnn_detect: add tensorflow output parse support

2021-05-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting > Fu > Sent: 2021年5月6日 16:46 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V2 4/4] dnn/vf_dnn_detect: add tensorflow > output parse support > > Testing model is tensorflow offical model in github repo, please