Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-15 Thread zhilizhao(赵志立)
> On Jun 15, 2021, at 3:14 AM, Thilo Borgmann wrote: > > Am 08.06.21 um 18:42 schrieb Thilo Borgmann: >> Hi, >> >> add %{localtime_ms} function to the drawtext filter. Same as %{localtime} >> but with additional millisecond part. > > Ping for a volunteer to actually have a look at the patch

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-15 Thread Steven Liu
> 2021年6月16日 上午9:56,Lingjiang Fang 写道: > > On Tue, 15 Jun 2021 11:42:44 +0800 > Steven Liu wrote: > >> Thilo Borgmann 于2021年6月15日周二 >> 上午3:14写道: >>> >>> Am 08.06.21 um 18:42 schrieb Thilo Borgmann: Hi, add %{localtime_ms} function to the drawtext filter. Same as %{loc

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-15 Thread Lingjiang Fang
On Tue, 15 Jun 2021 11:42:44 +0800 Steven Liu wrote: > Thilo Borgmann ??2021??6??15?? > 3:14?? > > > > Am 08.06.21 um 18:42 schrieb Thilo Borgmann: > > > Hi, > > > > > > add %{localtime_ms} function to the drawtext filter. Same as > > > %{localtime} but with additional millisecond

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-15 Thread Diederick C. Niehorster
On Tue, Jun 15, 2021 at 10:18 AM Michael Niedermayer wrote: > > On Mon, Jun 14, 2021 at 02:50:32PM -0300, James Almer wrote: > > On 6/14/2021 1:56 PM, Michael Niedermayer wrote: > > > On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote: > > > > Enabled discovering a DirectShow dev

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-15 Thread Andreas Rheinhardt
Mohammad Izadi: > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL is taking HDR10+ from AVFrame side data in

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-15 Thread Mohammad Izadi
Thanks, Mohammad On Mon, Jun 14, 2021 at 5:17 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mohammad Izadi: > > On Thu, Jun 10, 2021 at 4:05 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Mohammad Izadi: > >>> HDR10+ metadata is stored in the bit s

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-15 Thread Mohammad Izadi
Thanks, Mohammad On Mon, Jun 14, 2021 at 4:42 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mohammad Izadi: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > different for VP9 and cannot store the metadata in the bit stream. HDR10+ > should be passed to

[FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-15 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

[FFmpeg-devel] [PATCH 05/54] avformat/aaxdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/aaxdec.c | 83 ++-- 1 file changed, 27 insertions(+), 56 deletions(-) diff --git a/libavformat/aaxdec.c b/libavformat/aaxdec.c index 0cbf933dfd..38d57d36c2 100644 -

[FFmpeg-devel] [PATCH 54/54] avformat/xmv: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/xmv.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavformat/xmv.c b/libavformat/xmv.c index 36816ec005..fbe0f484e2 100644 --- a/libavformat/xmv.c +++ b/libavforma

[FFmpeg-devel] [PATCH 53/54] avformat/webvttdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/webvttdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/webvttdec.c b/libavformat/webvttdec.c index a4654034ac..52320ba7d1 100644 --- a/libavformat/webvttdec.c +++ b/l

[FFmpeg-devel] [PATCH 52/54] avformat/wc3movie: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/wc3movie.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/libavformat/wc3movie.c b/libavformat/wc3movie.c index dfb2462072..fe2d0d4245 100644 --- a/

[FFmpeg-devel] [PATCH 51/54] avformat/vplayerdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/vplayerdec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/vplayerdec.c b/libavformat/vplayerdec.c index f6c2b35ea7..8c9ff81163 100644 --- a/libavformat/vplayerdec.c

[FFmpeg-devel] [PATCH 50/54] avformat/vividas: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/vividas.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/vividas.c b/libavformat/vividas.c index a7deab0e51..8d1c1dab29 100644 --- a/libavformat/vividas.c +++ b/libav

[FFmpeg-devel] [PATCH 49/54] avformat/vapoursynth: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/vapoursynth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/vapoursynth.c b/libavformat/vapoursynth.c index 4ec4e77b59..1578a6ac77 100644 --- a/libavformat/vapoursynth.c

[FFmpeg-devel] [PATCH 48/54] avformat/tiertexseq: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/tiertexseq.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/libavformat/tiertexseq.c b/libavformat/tiertexseq.c index 164a75bd53..ecc15e4039 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 47/54] avformat/tedcaptionsdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/tedcaptionsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tedcaptionsdec.c b/libavformat/tedcaptionsdec.c index 8bebaba5c0..4bf93e26e2 100644 --- a/libavformat/tedcap

[FFmpeg-devel] [PATCH 46/54] avformat/subviewer1dec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/subviewer1dec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/subviewer1dec.c b/libavformat/subviewer1dec.c index d1ba99f984..f1267031f8 100644 --- a/libavformat/subv

[FFmpeg-devel] [PATCH 45/54] avformat/subviewerdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/subviewerdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/subviewerdec.c b/libavformat/subviewerdec.c index 9bb7728407..2ef3c088eb 100644 --- a/libavformat/subviewerd

[FFmpeg-devel] [PATCH 44/54] avformat/stldec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/stldec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/stldec.c b/libavformat/stldec.c index 7b7c98577d..48e18d865e 100644 --- a/libavformat/stldec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 43/54] avformat/srtdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/srtdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c index fa52b85566..2f8a677b9f 100644 --- a/libavformat/srtdec.c +++ b/libavformat/s

[FFmpeg-devel] [PATCH 42/54] avformat/sierravmd: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/sierravmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/sierravmd.c b/libavformat/sierravmd.c index 13304b0596..e35faae50d 100644 --- a/libavformat/sierravmd.c +++

[FFmpeg-devel] [PATCH 41/54] avformat/segafilm: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/segafilm.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c index 05b4d9e6a8..ce1166a05b 100644 --- a/libavformat/sega

[FFmpeg-devel] [PATCH 40/54] avformat/sccdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/sccdec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c index 5ad21a1f8b..e59e015bbc 100644 --- a/libavformat/sccdec.c +++ b/libavfo

[FFmpeg-devel] [PATCH 39/54] avformat/samidec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/samidec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/samidec.c b/libavformat/samidec.c index 8f97cb7331..c23335cf4d 100644 --- a/libavformat/samidec.c +++ b/libavform

[FFmpeg-devel] [PATCH 38/54] avformat/rmdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/rmdec.c | 56 - 1 file changed, 20 insertions(+), 36 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 68b5c3b75a..771c1778fa 100644 ---

[FFmpeg-devel] [PATCH 36/54] avformat/pp_bnk: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/pp_bnk.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/libavformat/pp_bnk.c b/libavformat/pp_bnk.c index 9455a575b7..c500ac7d9e 100644 --- a/libavform

[FFmpeg-devel] [PATCH 37/54] avformat/realtextdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/realtextdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c index 22fc58bc99..f3876d4068 100644 --- a/libavformat/realtextdec.c

[FFmpeg-devel] [PATCH 35/54] avformat/pjsdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/pjsdec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/pjsdec.c b/libavformat/pjsdec.c index 40d820a8d6..1fc16831ea 100644 --- a/libavformat/pjsdec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 34/54] avformat/paf: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/paf.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/libavformat/paf.c b/libavformat/paf.c index f48b2e60cd..2d2d7f8dd8 100644 --- a/libavformat/paf.c +++ b/libavfo

[FFmpeg-devel] [PATCH 33/54] avformat/omadec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/omadec.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavformat/omadec.c b/libavformat/omadec.c index 8891cfc4b6..d2f7408709 100644 --- a/libavformat/omad

[FFmpeg-devel] [PATCH 32/54] avformat/oggdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/oggdec.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c index e5ca3272cd..bb289e0756 100644 --- a/libavformat/oggdec.c +++ b/l

[FFmpeg-devel] [PATCH 31/54] avformat/nutdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/nutdec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index e709257135..0ddc552c21 100644 --- a/libavformat/nutdec.c +++ b/li

[FFmpeg-devel] [PATCH 30/54] avformat/nsvdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/nsvdec.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index 7dcc218546..ec73cb7f48 100644 --- a/libavformat/nsvdec.c ++

[FFmpeg-devel] [PATCH 29/54] avformat/mxfdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/mxfdec.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7b40076fb4..16f5052452 100644 --- a/libavformat/mxfde

[FFmpeg-devel] [PATCH 28/54] avformat/mpsubdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/mpsubdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mpsubdec.c b/libavformat/mpsubdec.c index ee53be17d6..abf0e7fb9a 100644 --- a/libavformat/mpsubdec.c +++ b/liba

[FFmpeg-devel] [PATCH 27/54] avformat/mpl2dec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/mpl2dec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpl2dec.c b/libavformat/mpl2dec.c index b99acff157..0beb9ca388 100644 --- a/libavformat/mpl2dec.c +++ b/libavf

[FFmpeg-devel] [PATCH 26/54] avformat/mpeg: Simplify cleanup after reading vobsub header fails

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Furthermore, also remove an unnecessary check for NULL before avformat_close_input(). Signed-off-by: Andreas Rheinhardt --- libavformat/mpeg.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavformat/mpeg.c b/libavfor

[FFmpeg-devel] [PATCH 25/54] avformat/mov: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
By default, a demuxer's read_close function is not called automatically if an error happens when reading the header; instead it is up to the demuxer to clean up after itself in this case. The mov demuxer did this by calling its read_close function when it encountered some errors when reading the he

[FFmpeg-devel] [PATCH 24/54] avformat/mlvdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/mlvdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 998bf42dd6..6a3aa15a4e 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/

[FFmpeg-devel] [PATCH 23/54] avformat/microdvddec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/microdvddec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/microdvddec.c b/libavformat/microdvddec.c index 3c45c72595..e536d12b85 100644 --- a/libavformat/mi

[FFmpeg-devel] [PATCH 22/54] avformat/mccdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/mccdec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/mccdec.c b/libavformat/mccdec.c index a096ac6e93..d206fc2d62 100644 --- a/libavformat/mccdec.c +++ b/libavform

[FFmpeg-devel] [PATCH 21/54] avformat/matroskadec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 356a02339c..10c1641eb7 100644 -

[FFmpeg-devel] [PATCH 20/54] avformat/lrcdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/lrcdec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/lrcdec.c b/libavformat/lrcdec.c index 678b618498..309014d630 100644 --- a/libavformat/lrcdec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 19/54] avformat/libopenmpt: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/libopenmpt.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 628b0939dc..d04aec5471 100644 --- a/libavformat/lib

[FFmpeg-devel] [PATCH 18/54] avformat/libgme: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/libgme.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavformat/libgme.c b/libavformat/libgme.c index 95323002e6..6a145349a7 100644 --- a/libavformat/libgme.c ++

[FFmpeg-devel] [PATCH 13/54] avformat/dashdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/dashdec.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index bc27c96c97..11966f905c 100644 --- a/li

[FFmpeg-devel] [PATCH 17/54] avformat/jvdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/jvdec.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c index 948cab37e5..a044f50831 100644 --- a/libavformat/jvdec.c +++ b/libavfo

[FFmpeg-devel] [PATCH 16/54] avformat/jacosubdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/jacosubdec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubdec.c index c8bded02fe..510219224f 100644 --- a/libavformat/jacosubde

[FFmpeg-devel] [PATCH 15/54] avformat/icodec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/icodec.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/libavformat/icodec.c b/libavformat/icodec.c index 9349582ffc..2e677c78f1 100644 --- a/libavformat/icodec.

[FFmpeg-devel] [PATCH 14/54] avformat/hls: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/hls.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index c2ca23e973..3c1b80f60c 100644 --- a/libavformat/hl

[FFmpeg-devel] [PATCH 12/54] avformat/concatdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. (Btw: concat_read_close() is not idempotent (it frees cat->files, but doesn't reset cat->nb_files), so this demuxer was incompatible with simply calling read_close generically upon read_header failure.) Signed-off-by: Andreas Rheinhardt --- libavformat/c

[FFmpeg-devel] [PATCH 08/54] avformat/aqtitledec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/aqtitledec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavformat/aqtitledec.c b/libavformat/aqtitledec.c index de28097f2f..a37c9bbeaf 100644 --- a/libavformat/aqtitledec

[FFmpeg-devel] [PATCH 11/54] avformat/brstm: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/brstm.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/libavformat/brstm.c b/libavformat/brstm.c index 601f73dd33..338491d9ef 100644 ---

[FFmpeg-devel] [PATCH 07/54] avformat/ape: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/ape.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index a4cfd01807..b6f9be4dbc 100644 --- a/libavformat/ape.c +++ b/liba

[FFmpeg-devel] [PATCH 10/54] avformat/av1dec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/av1dec.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index 8ca804c2a3..f282477ca4 100644 --- a/libavformat/av1dec.c +++ b/l

[FFmpeg-devel] [PATCH 09/54] avformat/assdec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/assdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/assdec.c b/libavformat/assdec.c index 4a9650fe76..5f71fcb024 100644 --- a/libavformat/assdec.c +++ b/libavformat/a

[FFmpeg-devel] [PATCH 06/54] avformat/avidec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/avidec.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 14a2dd6cd7..39039f5bc9 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 04/54] avformat/aadec: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/aadec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavformat/aadec.c b/libavformat/aadec.c index 70df0439bd..247c498147 100644 --- a/libavformat/aadec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 03/54] avformat/4xm: Simplify cleanup after read_header failure

2021-06-15 Thread Andreas Rheinhardt
by setting the FF_FMT_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavformat/4xm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index 427eaaddd0..f918b1fc57 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@ -283,7

[FFmpeg-devel] [PATCH 02/54] avformat: Redo cleanup of demuxers upon read_header() failure

2021-06-15 Thread Andreas Rheinhardt
If reading the header fails, the demuxer's read_close() function (if existing) is not called automatically; instead several demuxers call it via "goto fail" in read_header(). This commit intends to change this by adding an internal flag for demuxers that can be used to set on a per-AVInputFormat b

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-15 Thread Diederick C. Niehorster
On Wed, Jun 16, 2021 at 12:23 AM James Almer wrote: > > I guess a configure option to look for the API used by this patch would > be needed, making this new code optional. No need luckily, i have a workaround for all but the AMCONTROL_COLORINFO_PRESENT symbol. I'll define that one if not already

Re: [FFmpeg-devel] [PATCH 01/54] avformat: Add internal flags for AV(In|Out)putFormat

2021-06-15 Thread Andreas Rheinhardt
James Almer: > On 6/15/2021 8:01 PM, Andreas Rheinhardt wrote: >> Both AVInputFormat and AVOutputFormat currently lack an equivalent to >> AVCodec's caps_internal. E.g. if reading a header fails, each demuxer >> is currently required to clean up manually, which often means to just >> call the demux

Re: [FFmpeg-devel] [PATCH 01/54] avformat: Add internal flags for AV(In|Out)putFormat

2021-06-15 Thread James Almer
On 6/15/2021 8:01 PM, Andreas Rheinhardt wrote: Both AVInputFormat and AVOutputFormat currently lack an equivalent to AVCodec's caps_internal. E.g. if reading a header fails, each demuxer is currently required to clean up manually, which often means to just call the demuxer's read_close function.

Re: [FFmpeg-devel] [PATCH] Fix SPDIF detection score

2021-06-15 Thread Denis Shulyaka
Sorry for not giving the proper description! Here it is: The spdif is based on blocks with fixed length, each block starts with a sync word. It matters how many sync words we find during probe and whether we find them in expected place. The SPDIF_MAX_OFFSET constant is the maximum supported block s

[FFmpeg-devel] [PATCH 01/54] avformat: Add internal flags for AV(In|Out)putFormat

2021-06-15 Thread Andreas Rheinhardt
Both AVInputFormat and AVOutputFormat currently lack an equivalent to AVCodec's caps_internal. E.g. if reading a header fails, each demuxer is currently required to clean up manually, which often means to just call the demuxer's read_close function. This could (and will) be done generically via an

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-15 Thread James Almer
On 6/15/2021 5:18 AM, Michael Niedermayer wrote: On Mon, Jun 14, 2021 at 02:50:32PM -0300, James Almer wrote: On 6/14/2021 1:56 PM, Michael Niedermayer wrote: On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote: Enabled discovering a DirectShow device's color range, space, pri

Re: [FFmpeg-devel] [PATCH] Fix SPDIF detection score

2021-06-15 Thread Hendrik Leppkes
On Tue, Jun 15, 2021 at 12:52 PM Denis Shulyaka wrote: > > Hi! How do I ask for a review? I am new here. > A short explanation of what the problem is and why this change fixes it would help us to understand and evaluate the patch - and generally makes for better patches, as any future reader will

Re: [FFmpeg-devel] libavcodec: r12b decoder + r12b fourcc

2021-06-15 Thread Dennis Fleurbaaij
Ah, good spot Moritz. I found a few more spots where I wasn't consistent with current formatting. Here are the updated patches. Kind regards, Dennis Fleurbaaij On Tue, Jun 15, 2021 at 2:26 PM Moritz Barsnick wrote: > On Wed, Jun 09, 2021 at 19:25:41 +0200, Dennis Fleurbaaij wrote: > > OBJS-$(

Re: [FFmpeg-devel] [PATCH] Fix SPDIF detection score

2021-06-15 Thread Carl Eugen Hoyos
Am So., 11. Apr. 2021 um 15:56 Uhr schrieb Denis Shulyaka : > > This patch fixes the detection score for spdif (IEC61937). > > Signed-off-by: Denis Shulyaka > --- > libavformat/spdifdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/spdifdec.c b/libavformat

Re: [FFmpeg-devel] [PATCH 17/17] avcodec/libavcodec.v: Tighten export whitelist

2021-06-15 Thread Michael Niedermayer
On Tue, Jun 15, 2021 at 12:41:33AM +0200, Andreas Rheinhardt wrote: > Currently every symbol (with external linkage) that starts with "av" is > exported. Yet libaom-av1 has lots of functions that are not meant to be > exported and start with "av1_" (I counted 1236); and libvpx has > average_split_m

Re: [FFmpeg-devel] libavcodec: r12b decoder + r12b fourcc

2021-06-15 Thread Moritz Barsnick
On Wed, Jun 09, 2021 at 19:25:41 +0200, Dennis Fleurbaaij wrote: > OBJS-$(CONFIG_R10K_ENCODER)+= r210enc.o > OBJS-$(CONFIG_R210_DECODER)+= r210dec.o > +OBJS-$(CONFIG_R12B_DECODER)+= r12bdec.o > OBJS-$(CONFIG_R210_ENCODER)+= r210enc.o I'm sure this

Re: [FFmpeg-devel] [PATCH] Fix SPDIF detection score

2021-06-15 Thread Denis Shulyaka
Hi! How do I ask for a review? I am new here. вс, 11 апр. 2021 г. в 16:56, Denis Shulyaka : > This patch fixes the detection score for spdif (IEC61937). > > Signed-off-by: Denis Shulyaka > --- > libavformat/spdifdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-15 Thread Michael Niedermayer
On Mon, Jun 14, 2021 at 02:50:32PM -0300, James Almer wrote: > On 6/14/2021 1:56 PM, Michael Niedermayer wrote: > > On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote: > > > Enabled discovering a DirectShow device's color range, space, primaries, > > > transfer characteristics and