Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: leave full range flag unchanged if unknown

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/rtsp: If the rtcp port is specified in the sdp file, set localrtcpport when creating the RTP stream

--- libavformat/rtsp.c | 8 +++- libavformat/rtsp.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 9869e1b72e..9fa6861c2a 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -586,6 +586,10 @@ static void sdp_parse_line

Re: [FFmpeg-devel] [PATCH 4/6] avfilter/avfilter: Allow to free non-static pads generically

Andreas Rheinhardt (12021-08-17): > Well, this has the problem that it adds code in many places, whereas > static flags for the filter just need code in two places (with zero > marginal cost for making another filter use this feature, whereas a flag > to ff_append_... has a nonzero cost even to use

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libx265: improve full range flag setting logic

On Wed, Aug 18, 2021 at 4:36 AM myp...@gmail.com wrote: > > On Wed, Aug 18, 2021 at 5:01 AM Jan Ekström wrote: > > > > Unlike libx264, libx265 does not have a separate "unspecified"/"auto" > > default for color range, so we do always have to specify it. > > Thus, we are required to handle the RGB

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: leave full range flag unchanged if unknown

On Wed, Aug 18, 2021 at 10:00 AM Paul B Mahol wrote: > > lgtm Thanks, applied as 7ca71b79f2b3256a0eef1a099b857ac9e4017e36 . Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visi

Re: [FFmpeg-devel] [PATCH] get_cabac_inline_x86: Don't inline if 32-bit clang on windows

On Tue, 17 Aug 2021, James Almer wrote: On 8/17/2021 12:35 PM, Christopher Degawa wrote: Fixes https://trac.ffmpeg.org/ticket/8903 relevant https://github.com/msys2/MINGW-packages/discussions/9258 Signed-off-by: Christopher Degawa --- libavcodec/x86/cabac.h | 9 +++-- 1 file changed,

Re: [FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

On Thu, 12 Aug 2021, Martin Storsjö wrote: On Thu, 12 Aug 2021, Hu Weiwen wrote: "frag_start" is redundant, and every occurance can be replaced with cluster[0].dts - start_dts I think I can agree about this, so I think the patch should be fine, thanks for taking the time to study it in deta

Re: [FFmpeg-devel] [PATCH] movenc: Ensure no separate moof written for empty track

On Thu, 12 Aug 2021, Martin Storsjö wrote: On Thu, 12 Aug 2021, Hu Weiwen wrote: track->mdat_buf can be not NULL while the track is still empty if the last packet write failed. Signed-off-by: Hu Weiwen --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

Hi, On Tue, Aug 17, 2021 at 10:13 PM Wu, Jianhua wrote: > The reason why we set the icelake-avx512 as the minimum baseline is that > we don't want FFmpeg run on a processor downclocking heavily, hence, keep > the current flag and add a new AVX512ICL make no sense. > I don't think you can make t

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

Hello, On 2021-08-18 12:40, Ronald S. Bultje wrote: I don't think you can make that decision single-handedly. doesn't it depend on the situation, and shouldn't individual users and/or developers be able to make that decision themselves? I agree, not all AVX512 instructions slow down those

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

Ronald Wrote: > On Tue, Aug 17, 2021 at 10:13 PM Wu, Jianhua intel.com> wrote: > > The reason why we set the icelake-avx512 as the minimum baseline is that > > we don't want FFmpeg run on a processor downclocking heavily, hence, keep > > the

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

tor 2021-08-12 klockan 14:38 +0200 skrev Marc-Antoine Arnaud: @@ -177,6 +179,7 @@ typedef struct { int body_sid; MXFWrappingScheme wrapping; int edit_units_per_packet; /* how many edit units to read at a time (PCM, ClipWrapped) */ +    int* channel_ordering; Is there a maximum numb

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

On 8/17/2021 4:25 PM, Niklas Haas wrote: From: Niklas Haas This could arguably also be a vf, but I decided to put it here since decoders are technically required to apply film grain during the output step, and I would rather want to avoid requiring users insert the correct film grain synthesis

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

18 Aug 2021, 17:41 by jamr...@gmail.com: > On 8/17/2021 4:25 PM, Niklas Haas wrote: > >> From: Niklas Haas >> >> This could arguably also be a vf, but I decided to put it here since >> decoders are technically required to apply film grain during the output >> step, and I would rather want to avoi

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: Correct asegment example

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

On Tue, Aug 17, 2021 at 03:40:28PM -0700, Mohammad Izadi wrote: > From: Gyan Doshi > > The fate test file can be found here: > https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk > The video file needs to be copied to fate-suite/mkv/ > --- > libavcodec/dynamic_hd

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/h264dec: apply H.274 film grain

On Tue, Aug 17, 2021 at 09:24:38PM +0200, Niklas Haas wrote: > On Sun, 15 Aug 2021 19:11:42 +0200 Michael Niedermayer > wrote: > > On Sat, Aug 14, 2021 at 01:36:20PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > Because we need access to ref frames without film grain applied, we

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

On Tue, Aug 17, 2021 at 9:41 PM Gyan Doshi wrote: > > > On 2021-08-18 04:10 am, Mohammad Izadi wrote: > > From: Gyan Doshi > > Can you refresh my memory on how I'm involved? > Don't know. Sent to ffmpeg-devel@ffmpeg.org. > > > > > The fate test file can be found here: > https://drive.google.com

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: use ctx->usage to get default cfg

On Fri, Aug 13, 2021 at 7:11 PM James Zern wrote: > > this prevents some mismatches in config values for realtime and all > intra modes, avoiding failures like: > > [libaom-av1 @ ...] Failed to initialize encoder: Invalid parameter > [libaom-av1 @ ...] Additional information: g_lag_in_frames out

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

On Wed, 18 Aug 2021 12:41:25 -0300 James Almer wrote: > Will this not break compilation with msvc and such? No. Unrecognized or unsupported pragmas are ignored by the implementation (this is specified C behavior). > Also, tree vectorization is know to cause issues in old GCC versions, > and eve

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

> James Almer Wrote: > >> > >> Yes, but we don't want to use AVX512 on hardware that downclocks > heavily. > >> > > > > It's okay. Should I updated the configure file to let the IceLake-AVX512 to > be the minimum baseline or add a new macro name AVX512ICL? > > Update the test in configure to look

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

On 2021-08-19 04:53 am, Mohammad Izadi wrote: On Tue, Aug 17, 2021 at 9:41 PM Gyan Doshi wrote: On 2021-08-18 04:10 am, Mohammad Izadi wrote: From: Gyan Doshi Can you refresh my memory on how I'm involved? Don't know. Sent to ffmpeg-devel@ffmpeg.org. Then remove it from the commit m

Re: [FFmpeg-devel] [PATCH] ffmpeg_hw: make hardware selection for filters more user friendly

On Wed, 2021-08-04 at 05:17 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Haihao Xiang > > Sent: Tuesday, 29 June 2021 03:46 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Haihao Xiang > > Subject: [FFmpeg-devel] [PATCH] ffmpeg_hw: make hardware selectio

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

On Mon, Aug 16, 2021 at 1:49 PM James Almer wrote: > On 8/16/2021 6:27 AM, Wu, Jianhua wrote: > >> > >> Yes, but we don't want to use AVX512 on hardware that downclocks > heavily. > >> > > > > It's okay. Should I updated the configure file to let the IceLake-AVX512 > to be the minimum baseline or