Re: [FFmpeg-devel] [PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

2021-08-20 Thread Gyan Doshi
The RFC was posted 10 days ago. Plan to push tomorrow. On 2021-08-20 05:12 pm, Gyan Doshi wrote: The MOV muxer can store streamids as track ids but they aren't visible when probing the result via lavf/dump or ffprobe due to lack of this flag in the demuxer. --- libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 2/6] libavfilter: Unify Execution Modes in DNN Filters

2021-08-20 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: 2021年8月20日 22:21 > To: ffmpeg-devel@ffmpeg.org > Cc: Shubhanshu Saxena > Subject: [FFmpeg-devel] [PATCH 2/6] libavfilter: Unify Execution Modes in > DNN Filters > > This commit unifies the async and sync

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: use ctx->usage to get default cfg

2021-08-20 Thread James Zern
On Wed, Aug 18, 2021 at 5:00 PM James Zern wrote: > > On Fri, Aug 13, 2021 at 7:11 PM James Zern wrote: > > > > this prevents some mismatches in config values for realtime and all > > intra modes, avoiding failures like: > > > > [libaom-av1 @ ...] Failed to initialize encoder: Invalid parameter >

[FFmpeg-devel] [PATCH 9/9] libavfilter/vf_deinterlace_qsv: enabling d3d11va support, added mfxhdlpair

2021-08-20 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/vf_deinterlace_qsv.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/libavf

[FFmpeg-devel] [PATCH 8/9] libavfilter/vf_scale_qsv: add MFX_MEMTYPE_FROM_VPPOUT flag to frame_type

2021-08-20 Thread Artem Galin
From: Artem Galin In case of DX11 device type, Media SDK is sensitive to these flags. Signed-off-by: Artem Galin --- libavfilter/vf_scale_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index fe8ed37418..2ab04457

[FFmpeg-devel] [PATCH 7/9] libavfilter/vf_scale_qsv: enabling d3d11va support, added mfxhdlpair

2021-08-20 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/vf_scale_qsv.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/libavfilter/v

[FFmpeg-devel] [PATCH 6/9] libavfilter/qsvvpp: add MFX_MEMTYPE_FROM_VPPOUT flag to output frames

2021-08-20 Thread Artem Galin
From: Artem Galin In case of DX11 device type, Media SDK is sensitive to these flags. Signed-off-by: Artem Galin --- libavfilter/qsvvpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 66b8673d4e..135d4c4e36 100644 --- a/li

[FFmpeg-devel] [PATCH 5/9] libavfilter/qsvvpp: enabling d3d11va support, added mfxhdlpair

2021-08-20 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callback with proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavfilter/qsvvpp.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/libavfilter/qsvvpp.

[FFmpeg-devel] [PATCH 4/9] libavutil/hwcontext_d3d11va: adding more texture information to the D3D11 hwcontext API

2021-08-20 Thread Artem Galin
From: Artem Galin Microsoft VideoProcessor requires texture with D3DUSAGE_RENDERTARGET flag as output. There is no way to allocate array of textures with D3D11_BIND_RENDER_TARGET flag and .ArraySize > 2 by ID3D11Device_CreateTexture2D due to the Microsoft limitation. Adding AVD3D11FrameDescript

[FFmpeg-devel] [PATCH 3/9] libavutil/hwcontext_qsv: add usage child_device_type argument to explicitly select d3d11va/DX11 device type

2021-08-20 Thread Artem Galin
From: Artem Galin UPD: Rebase of last patch set over current master and use DX9 as default device type. Makes selection of dxva2/DX9 device type by default as before with explicit d3d11va/DX11 usage to cover more HW configurations. Added warning message to expect changing default device type i

[FFmpeg-devel] [PATCH 2/9] libavutil/hwcontext_qsv: supporting d3d11va device type

2021-08-20 Thread Artem Galin
From: Artem Galin This enables usage of non-powered/headless GPU, better HDR support. Pool of resources is allocated as one texture with array of slices. Signed-off-by: Artem Galin --- libavutil/hwcontext_qsv.c | 326 +++--- 1 file changed, 265 insertions(+), 61

[FFmpeg-devel] [PATCH 1/9] libavcodec/qsv: enabling d3d11va support, added mfxhdlpair

2021-08-20 Thread Artem Galin
From: Artem Galin Adding DX11 relevant device type checks and adjusting callbacks with proper MediaSDK pair type support. Extending structure for proper MediaSDK pair type support. Signed-off-by: Artem Galin --- libavcodec/qsv.c | 53 ++- libavcode

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/aarch64: h264, add chroma loop filters for 10bit

2021-08-20 Thread Martin Storsjö
On Fri, 20 Aug 2021, Mikhail Nitenko wrote: Benchmarks: A53 A72 h264_h_loop_filter_chroma422_10bpp_c: 282.7 114.2 h264_h_loop_filter_chroma422_10bpp_neon: 109.578.5 h264_h_loop_filter_chroma_10bpp_c:

Re: [FFmpeg-devel] [PATCH v3] lavc/aarch64: add pred functions for 10-bit

2021-08-20 Thread Martin Storsjö
On Fri, 20 Aug 2021, Mikhail Nitenko wrote: Benchmarks:A53 A72 pred8x8_dc_10_c: 64.249.5 pred8x8_dc_10_neon:62.053.7 pred8x8_dc_128_10_c: 26.014.0 pred8x8_dc_128_10_neon:30.717.5 pred8x8_horiz

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/dnn_processing: Add TensorRT backend

2021-08-20 Thread Xiaowei Wang
On 2021/7/25 21:04, James Almer wrote: External email: Use caution opening links or attachments On 7/25/2021 8:58 AM, Xiaowei Wang wrote: The backend can be called as: -vf dnn_processing=dnn_backend=tensorrt:model="model":input=:output= As TensorRT provides C++ API rather than C, the TensorRT

Re: [FFmpeg-devel] [PATCH] libavformat/riffenc: handle gray8 format for uncompressed avi

2021-08-20 Thread Michael Niedermayer
On Thu, Aug 19, 2021 at 12:07:33PM +0800, rui.jiang wrote: > add palette data in avi header when the input data is raw gray8 pixel data > and the output data is 8bit uncompressed avi video > > Signed-off-by: rui.jiang <229135...@qq.com> > --- > libavformat/riffenc.c | 9 + > 1 file chang

Re: [FFmpeg-devel] [PATCH v1 0/2] libavformat/protocols.c: avio_enum_protocols(): Cleanup

2021-08-20 Thread Nicolas George
Nicolas George (12021-08-20): > Please do not hijack threads. See the mailing-list FAQ. Please disregard this, I made a mistake. Sorry for wasting everybody's time. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH v1 0/2] libavformat/protocols.c: avio_enum_protocols(): Cleanup

2021-08-20 Thread Nicolas George
Michael Witten (12021-08-20): > This series improves the following function: > > libavformat/protocols.c: avio_enum_protocols() > > There are only 2 commits: > > [1] Quash warning about const-correctness > [2] Refactoring Please do not hijack threads. See the mailing-list FAQ. -- Nico

[FFmpeg-devel] [PATCH v1 2/2] libavformat/protocols.c: avio_enum_protocols(): Refactor

2021-08-20 Thread Michael Witten
Date: Wed, 11 Aug 2021 19:00:00 - This commit is the result of squashing a series of very tiny transformations; it refactors 'avio_enum_protocols()' into 2 functions: * avio_enum_protocols_for_input() * avio_enum_protocols_for_output() Those functions are in turn mostly implemented by thi

[FFmpeg-devel] [PATCH v1 1/2] libavformat/protocols.c: avio_enum_protocols(): Quash warning about const-correctness

2021-08-20 Thread Michael Witten
Date: Wed, 11 Aug 2021 10:15:01 - This quashes a compile-time warning. * 'url_protocols' is an array of const pointers. * The explicit conversion to '(void *)' is okay, because the destination is an "opaque" blob of private data. --- libavformat/protocols.c | 4 ++-- 1 file chang

[FFmpeg-devel] [PATCH v1 0/2] libavformat/protocols.c: avio_enum_protocols(): Cleanup

2021-08-20 Thread Michael Witten
This series improves the following function: libavformat/protocols.c: avio_enum_protocols() There are only 2 commits: [1] Quash warning about const-correctness [2] Refactoring This series is a revision of a previous series; for this revision: * The patch [3] ("Add functions to the API"

Re: [FFmpeg-devel] [PATCH] webp: fix transforms after a palette with pixel packing.

2021-08-20 Thread James Zern
On Thu, Aug 19, 2021 at 12:56 AM Maryla wrote: > > When a color indexing transform with 16 or fewer colors is used, > WebP uses "pixel packing", i.e. storing several pixels in one byte, > which virtually reduces the width of the image (see WebPContext's > reduced_width field). This reduced_width s

[FFmpeg-devel] [PATCH] avfilter/vf_guided: support enhanced guided filter

2021-08-20 Thread Xuewei Meng
From: Xuewei Meng Enhanced guided filter and fast enhanced guided filter are supported. The enhanced guided filter can better preserve edges for denoising tasks. And the box filter operation is optimized. Signed-off-by: Xuewei Meng --- doc/filters.texi| 6 +- libavfilter/vf_guided.c

Re: [FFmpeg-devel] [PATCH] doc/general_contents: Fix dead links

2021-08-20 Thread Mapul Bhola
August 20, 2021 8:05 AM, "Gyan Doshi" wrote: > On 2021-08-16 09:52 pm, Mapul Bhola wrote: > >> The x265 configuration and installation guide has moved to Bitbucket so the >> updated link reflects >> that one. >> >> As the openCV site currently only has docs for opencv3 and the filter in >> li

[FFmpeg-devel] [PATCH 4/4] tools/dvd2concat: use option keyword

2021-08-20 Thread Nicolas George
subfile,,start,X,end,Y,,: is ugly and will be gone some day. Signed-off-by: Nicolas George --- tools/dvd2concat | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 0280838a6b..ef04a87d05 100755 --- a/tools/dvd2concat +++ b/tools/dvd

[FFmpeg-devel] [PATCH 3/4] tools/dvd2concat: document that -protocol_whitelist is needed

2021-08-20 Thread Nicolas George
Signed-off-by: Nicolas George --- tools/dvd2concat | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 8effee86b9..0280838a6b 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -37,7 +37,8 @@ normally contains a directory named B. I

[FFmpeg-devel] [PATCH 2/4] lavf/concatdec: support per-file options

2021-08-20 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 35 ++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 5f18e4551b..eb3351833a 100644 --- a/doc/demuxers.texi +

[FFmpeg-devel] [PATCH 1/4] libavformat/concatdec: remove support for unsafe=-1

2021-08-20 Thread Nicolas George
It only makes sense as the default value, but it is not the default since 689211d5727231c3fe92762d224dbadebdbf4e30. Signed-off-by: Nicolas George --- doc/demuxers.texi | 9 +++-- libavformat/concatdec.c | 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) Second patch update

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

2021-08-20 Thread Nicolas George
Jan Ekström (12021-08-20): > Looks good to me with the dox->doc fixup you've already done in the > commit message. Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-20): > I do not really agree that such simple macros are hard to maintain. But > I am also not concerned about the increased memory usage (or the fact > that 32bit machines probably won't like it). And I like that it allows > to remove several duplicate functions. > If

[FFmpeg-devel] [PATCH 6/6] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-20 Thread Shubhanshu Saxena
Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index fac19ac413..03a355a982 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -9974,7 +9974,7 @@ Note that different backends us

[FFmpeg-devel] [PATCH 5/6] lavfi/dnn: Rename InferenceItem to LastLevelTaskItem

2021-08-20 Thread Shubhanshu Saxena
This patch renames the InferenceItem to LastLevelTaskItem in the three backends to avoid confusion among the meanings of these structs. The following are the renames done in this patch: 1. extract_inference_from_task -> extract_lltask_from_task 2. InferenceItem -> LastLevelTaskItem 3. inference_q

[FFmpeg-devel] [PATCH 4/6] libavfilter: Remove Async Flag from DNN Filter Side

2021-08-20 Thread Shubhanshu Saxena
Remove async flag from filter's perspective after the unification of async and sync modes in the DNN backend. Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 14 -- libavfilter/dnn/dnn_backend_tf.c | 7 +++ libavfilter/dnn_filter_common.c | 7 --- l

[FFmpeg-devel] [PATCH 3/6] libavfilter: Remove synchronous functions from DNN filters

2021-08-20 Thread Shubhanshu Saxena
This commit removes the unused sync mode specific code from the DNN filters since the sync and async mode are now unified from the filters' perspective. Signed-off-by: Shubhanshu Saxena --- libavfilter/vf_dnn_detect.c | 71 +--- libavfilter/vf_dnn_processing.c | 84 +-

[FFmpeg-devel] [PATCH 2/6] libavfilter: Unify Execution Modes in DNN Filters

2021-08-20 Thread Shubhanshu Saxena
This commit unifies the async and sync mode from the DNN filters' perspective. As of this commit, the Native backend only supports synchronous execution mode. Now the user can switch between async and sync mode by using the 'async' option in the backend_configs. The values can be 1 for async and 0

[FFmpeg-devel] [PATCH 1/6] lavfi/dnn: Task-based Inference in Native Backend

2021-08-20 Thread Shubhanshu Saxena
This commit rearranges the code in Native Backend to use the TaskItem for inference. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 176 ++- libavfilter/dnn/dnn_backend_native.h | 2 + 2 files changed, 121 insertions(+), 57 deletions(-) dif

[FFmpeg-devel] [PATCH] fftools/cmdutils: Fix warning for initialization makes integer from pointer without a cast

2021-08-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- fftools/cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2dd035a..ae34118 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -853,7 +853,7 @@ int opt_cpucount(void

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

2021-08-20 Thread Jan Ekström
On Mon, Aug 16, 2021 at 4:07 PM Nicolas George wrote: > > Signed-off-by: Nicolas George > --- Looks good to me with the dox->doc fixup you've already done in the commit message. Generally I've become accustomed to trying to push people to look at the transcode* examples since I've seen people t

Re: [FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

2021-08-20 Thread Andreas Rheinhardt
Nicolas George: > Make AVFilterFormats.formats uint64_t. > They are short-lived lists and usually quite short too. > > Signed-off-by: Nicolas George > --- > > > I think the simplification in formats.c is well worth the cost in > memory: most of the lines removed are hard-to-maintain macro code.

Re: [FFmpeg-devel] Third opinion? (was: lavf/avio: remove support for proto, , opt, val, , syntax.)

2021-08-20 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-08-14): >> I do not really get that: The option passing syntax is restricted to the >> subfile protocol, so I don't know why we allow it for the file protocol >> in dashdec and hls. Unless I am missing something, this could (and >> should) be removed at o

Re: [FFmpeg-devel] [PATCH] doc/general_contents: Fix dead links

2021-08-20 Thread Gyan Doshi
On 2021-08-16 09:52 pm, Mapul Bhola wrote: The x265 configuration and installation guide has moved to Bitbucket so the updated link reflects that one. As the openCV site currently only has docs for opencv3 and the filter in libavfilter is an opencv2 one an archived link to the old cv2 docum

[FFmpeg-devel] [PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

2021-08-20 Thread Gyan Doshi
The MOV muxer can store streamids as track ids but they aren't visible when probing the result via lavf/dump or ffprobe due to lack of this flag in the demuxer. --- libavformat/mov.c | 2 +- tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 2 +- t

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/formats: document the negotiation process

2021-08-20 Thread Nicolas George
Nicolas George (12021-08-19): > + *FIXME: the similarity logic (the ref argument to > + *pick_format()) added in FFmpeg duplicates and > + *overrides the swapping logic added in libav. Better > + *merge them into a scor

[FFmpeg-devel] [PATCH] avfilter/signature: fix integer rounding cast precedence

2021-08-20 Thread Jai Luthra
Co-authored-by: Oscar Signed-off-by: Jai Luthra --- libavfilter/signature_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 977f898049..86dd0c6675 100644 --- a/libavfilter/signature_lookup.c +++

Re: [FFmpeg-devel] Third opinion? (was: lavf/avio: remove support for proto, , opt, val, , syntax.)

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-14): > I do not really get that: The option passing syntax is restricted to the > subfile protocol, so I don't know why we allow it for the file protocol > in dashdec and hls. Unless I am missing something, this could (and > should) be removed at once. It must be lefto

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

2021-08-20 Thread Nicolas George
Nicolas George (12021-08-16): > Signed-off-by: Nicolas George > --- > doc/examples/encode_video.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) I fixed dox → doc in the subject. Will push soon unless somebody comments. Regards, -- Nicolas George signatu

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/formats: Don't set samplerate or channel count on video links

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > This currently happens by accident in a few filters that use > ff_set_common_(samplerates|channel_layouts) like afir (if the response > option is set) or agraphmonitor (due to the default code in > avfiltergraph.c). So change those functions to make sure it does

Re: [FFmpeg-devel] [PATCH 05/10] avfilter/avfilter: Deprecate avfilter_pad_count()

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > It is unnecessary as the number of static inputs and outputs can now > be directly read via AVFilter.nb_(in|out)puts. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.h | 5 + > libavfilter/version.h | 3 +++ > 2 files changed, 8 inserti

Re: [FFmpeg-devel] [PATCH 10/10] avfilter/avfiltergraph: Remove dead checks

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > These checks emit warnings in case the channel layouts lists are > inconsistent; yet since 69f5f6ea375950b4845b241ee27054bfc8f00343 > a function that is called earlier errors out if they are inconsistent. > > Signed-off-by: Andreas Rheinhardt > --- > This relie

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/formats: Avoid redundant counter

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > The ff_set_common_(formats|channel_layouts|samplerates) have to free > their list in case it doesn't have an owner; therefore they tracked > whether they attached it to an owner. But the list's refcount already > contains such a counter, so we don't have to keep

Re: [FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Switch to avfilter_filter_pad_count()

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM but I do not maintain this. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 02/10] avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter

2021-08-20 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-08-15): >> #define OFFSET(x) offsetof(CoreImageContext, x) >> @@ -663,8 +660,8 @@ const AVFilter ff_vf_coreimage = { >> .uninit= uninit, >> .priv_size = sizeof(CoreImageContext), >> .priv_class= &coreimage_class, >> -.i

Re: [FFmpeg-devel] [PATCH 01/10] fftools/cmdutils: Use avfilter_pad_count() for AVFilter's number of pads

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > Besides being nicer code this also has the advantage of not making > assumptions about the internal implementation: While it is documented > that the AVFilter.inputs and AVFilter.outputs arrays are terminated > by a zeroed sentinel, one is not allowed to infer th

[FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

2021-08-20 Thread Nicolas George
Make AVFilterFormats.formats uint64_t. They are short-lived lists and usually quite short too. Signed-off-by: Nicolas George --- I think the simplification in formats.c is well worth the cost in memory: most of the lines removed are hard-to-maintain macro code. Furthermore, it will make easier

Re: [FFmpeg-devel] [PATCH 03/10] avfilter/avfilter: Add avfilter_filter_pad_count()

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > It is intended as replacement for avfilter_pad_count(). In contrast to > the latter, it avoids a loop. > > Signed-off-by: Andreas Rheinhardt > --- > Missing APIchanges entry and version bump. > > libavfilter/avfilter.c | 5 + > libavfilter/avfilter.h | 5

Re: [FFmpeg-devel] [PATCH 02/10] avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-15): > #define OFFSET(x) offsetof(CoreImageContext, x) > @@ -663,8 +660,8 @@ const AVFilter ff_vf_coreimage = { > .uninit= uninit, > .priv_size = sizeof(CoreImageContext), > .priv_class= &coreimage_class, > -.inputs= vf_coreim

Re: [FFmpeg-devel] [PATCH 25/25] avformat/matroskaenc: Redo handling of FlagDefault

2021-08-20 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-01-21): >> Without a new option, one could not distinguish the case where the user >> explicitly wants no dispositions at all and the case where one remuxes from >> a source container that does not have the concept of default streams. >> Furthermore, havi

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/formats: cosmetic: move negotiation stuff at the end

2021-08-20 Thread Nicolas George
Nicolas George (12021-08-19): > Since these three patches are cosmetic and internal documentation, I > will push soon, probably as soon as I have something new to post on top > of them. Series pushed. > Anton and Michael: you are the authors of the redundant similarity > logics in swap and pick_f

Re: [FFmpeg-devel] Implementing FATE tests

2021-08-20 Thread Nicolas George
Paul Buxton (12021-08-20): > Hi, > I am a little unclear how/where to implement a test for my new filter. I > see the makefile for the video filters, but it mostly looks to be command > lines. Should I be adding some reference input/output data somewhere? Look at any commit titled "add fate tests"

[FFmpeg-devel] Implementing FATE tests

2021-08-20 Thread Paul Buxton
Hi, I am a little unclear how/where to implement a test for my new filter. I see the makefile for the video filters, but it mostly looks to be command lines. Should I be adding some reference input/output data somewhere? If anyone is interested in the results of the underwater correction filter.

[FFmpeg-devel] [PATCH 3/4] avformat/matroskadec: Include webm_dash_manifest demuxer only if enabled

2021-08-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index fdfcc86aeb..01104dbda7 100644 --- a/libavformat/matroskadec.c +++ b/libavforma

[FFmpeg-devel] [PATCH 4/4] avformat/matroskaenc: Only compile functions when needed

2021-08-20 Thread Andreas Rheinhardt
Fixes unused function warnings in case e.g. the WebM muxer is disabled. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 52 +++ 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaen

[FFmpeg-devel] [PATCH 2/4] avformat/matroskaenc: Pass dispositions through unchanged by default

2021-08-20 Thread Andreas Rheinhardt
Up until now, the Matroska muxer did not use the dispositions it is given as-is; instead it by default overrode the disposition of the first track of a kind (audio, video, subtitles) if no track of this kind has the default disposition set. And up until recently, it also enforced by default that no

[FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: Allow to set multiple streams as default

2021-08-20 Thread Andreas Rheinhardt
The Matroska specifications have evolved and now allow to mark multiple tracks of the same kind as default (whether this was legal or not before was dubious; e.g. mkvmerge disallowed it). Yet when the Matroska muxer is set to infer default dispositions if absent, it also enforced the now outdated r

Re: [FFmpeg-devel] [PATCH 01/10] fftools/cmdutils: Use avfilter_pad_count() for AVFilter's number of pads

2021-08-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Besides being nicer code this also has the advantage of not making > assumptions about the internal implementation: While it is documented > that the AVFilter.inputs and AVFilter.outputs arrays are terminated > by a zeroed sentinel, one is not allowed to infer that one can jus

Re: [FFmpeg-devel] [PATCH] lavfi/formats: document the negotiation process.

2021-08-20 Thread Nicolas George
Michael Koch (12021-08-20): > I know almost nothing about this stuff, but it doesn't sound right that the > frist > two steps use the same function. Isn't step 2 merge_formats()? Unfortunately not. I wanted to separate them, but it is not quite possible because of the weird partial negotiation s

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Don't use AVClass * for logcontext

2021-08-20 Thread Nicolas George
Andreas Rheinhardt (12021-08-20): > Forgotten in 57fa314090ab006808911fd790053b534749aa53. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfiltergraph.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Ok of course, thanks. Regards, -- Nicolas George sign