Re: [FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's oneVPL

> -Original Message- > From: ffmpeg-devel On Behalf Of Xiang, > Haihao > Sent: Monday, 23 August 2021 06:29 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's > oneVPL > > On Mon, 2021-08-16 at 15:33 +0800, Haihao Xiang wrote: > >

Re: [FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's oneVPL

On Mon, 2021-08-16 at 15:33 +0800, Haihao Xiang wrote: > The oneAPI Video Processing Library (oneVPL) is a single interface for > encode, decode and video processing[1]. oneVPL is a successor to Intel's Media > SDK (MediaSDK), but removed obsolete features. MediaSDK lifetime comes to an > end

Re: [FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: Allow to set multiple streams as default

Andreas Rheinhardt: > The Matroska specifications have evolved and now allow to mark > multiple tracks of the same kind as default (whether this was legal or > not before was dubious; e.g. mkvmerge disallowed it). Yet when the > Matroska muxer is set to infer default dispositions if absent, it

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

Isn't reading already supported? See ff_vorbis_comment in libavformat/oggparsevorbis.c. (These functions use one buffer too much which could be easily avoided.) Ah seems like I missed that. Thanks for pointing that out! Saved me some time trying to figure out if I needed to touch that at all.

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

Jesse Obic: > Hi, > > First time using a mailing list and (properly) working with C, so please > forgive me if I've done something wrong. > > I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 > , and I understand what I need to > do but I'm on

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

On 23/08/2021 12:04 pm, Chad Fraleigh wrote: Would allocating 16M really be a lot, given typically there wouldn't be many of them? That's something I wanted to get clarification on. I've seen ffmpeg's libraries used in embedded hardware / environments with restricted memory; however I'm not

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

On 8/22/2021 4:49 PM, Jesse Obic wrote: I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 , and I understand what I need to do but I'm on the fence about how I should go about doing it. For the OGG container, cover art is embedded into the

Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: allow to use input stream timebase too

Paul B Mahol: > On Sun, Aug 22, 2021 at 2:48 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/bitstream_filters.texi | 5 - >>> libavcodec/setts_bsf.c | 5 - >>> 2 files changed, 8 insertions(+), 2

[FFmpeg-devel] Question regarding ogg cover art implementation

Hi, First time using a mailing list and (properly) working with C, so please forgive me if I've done something wrong. I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 , and I understand what I need to do but I'm on the fence about how I

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: Check for bits left in mjpeg_decode_scan_progressive_ac()

Fixes: Timeout Fixes: 36262/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEGLS_fuzzer-4969052454912000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mjpegdec.c | 3 +++ 1 file

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegbdec: Skip SOS on AVDISCARD_ALL as does mjpeg

Fixes: NULL pointer dereference Fixes: 36342/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEGB_fuzzer-4579188072906752 Fixes: 36344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEGB_fuzzer-5049579300061184 Fixes:

[FFmpeg-devel] FATE coverage for format negotiation

Hi. Apparently, we have almost coverage for cases where the format negotiation in libavfilter is not straightforward. Disabling swap_samplerates() and swap_channel_layouts() (in libavfilter/avfiltergraph.c) does not cause any test to fail. (Disabling swap_sample_fmts() is expected to change

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

On Sun, Aug 22, 2021 at 01:35:26PM -0700, Chad Fraleigh wrote: > On 8/22/2021 11:18 AM, Michael Niedermayer wrote: > > On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: > > > Nicolas George (12021-08-08): > > > > Here is a patch series for fateserver, to fix warnings and enable

[FFmpeg-devel] [PATCH] avfilter/vf_scale: reset color matrix in case of identity & non-RGB

Fixes passing through mismatching metadata from the input side when RGB input (from f.ex. H.264 or HEVC) gets converted to YCbCr. Fixes #9132 --- libavfilter/vf_scale.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

On 8/22/2021 11:18 AM, Michael Niedermayer wrote: On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: Nicolas George (12021-08-08): Here is a patch series for fateserver, to fix warnings and enable Perl's taint checks, thus protecting against a whole class of security issues. I

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

Hi Marton, > On Feb 23, 2021, at 3:07 PM, Dave Rice wrote: > >> On Feb 23, 2021, at 2:42 PM, Marton Balint wrote: >> >> On Sat, 20 Feb 2021, Dave Rice wrote: >> >>> Hi, >>> On Oct 31, 2020, at 5:15 PM, Marton Balint >>> > wrote: On Sat, 31 Oct 2020, Dave

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: > Nicolas George (12021-08-08): > > Here is a patch series for fateserver, to fix warnings and enable Perl's > > taint checks, thus protecting against a whole class of security issues. > > I would appreciate somebody looks at the

Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: allow to use input stream timebase too

On Sun, Aug 22, 2021 at 2:48 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > Signed-off-by: Paul B Mahol > > --- > > doc/bitstream_filters.texi | 5 - > > libavcodec/setts_bsf.c | 5 - > > 2 files changed, 8 insertions(+), 2 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1dec: ff_print_debug_info() does not support WMV3 field_mode

On Sun, Aug 08, 2021 at 09:32:50PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 36331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-5140494328922112.fuzz > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/webp: Check available space in loop in decode_entropy_coded_image()

On Sun, Jul 25, 2021 at 04:01:55PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 35401/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WEBP_fuzzer-5714401821851648 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 6/6] avformat/av1dec: Disallow seeking by bytes

On 8/22/2021 11:37 AM, Andreas Rheinhardt wrote: James Almer: On 8/22/2021 10:25 AM, Andreas Rheinhardt wrote: The low overhead OBU format provides no means to resync after performing a byte-based seek; in other words: Byte based seeking is just not supported. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 2/2] lavi/pixdesc: simplify depth computatoin in get_pix_fmt_score().

Signed-off-by: Nicolas George --- libavutil/pixdesc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index f1898a6a13..967de7dcde 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -2721,10 +2721,10 @@ static int

[FFmpeg-devel] [PATCH 1/2] lavu/pixdesc: remove get_pix_fmt_depth().

Apart from erroring when nb_components == 0, it is dead code. nb_components == 0 only for HW formats, and HW formats are handled earlier in get_pix_fmt_score(). Signed-off-by: Nicolas George --- libavutil/pixdesc.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-)

Re: [FFmpeg-devel] [PATCH 6/6] avformat/av1dec: Disallow seeking by bytes

James Almer: > On 8/22/2021 10:25 AM, Andreas Rheinhardt wrote: >> The low overhead OBU format provides no means to resync after performing >> a byte-based seek; in other words: Byte based seeking is just not >> supported. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> The reason I didn't

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

If nobody wants to review the algorithm being implemented, I'm gonna apply this soon. It looks fine by all I can tell, but I never touched the software version of this filter. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/5] avformat/av1dec: Flush BSF upon seeking

On 8/22/2021 8:29 AM, Andreas Rheinhardt wrote: The av1_merge_frame BSF outputs its cached data when it sees the beginning of a new frame, i.e. when it sees a temporal delimiter OBU. Therefore it typically has a temporal delimiter OBU cached after outputting a packet. This implies that the OBU

Re: [FFmpeg-devel] [PATCH 4/5] avformat/utils: Also set io_repositioned for generic seeking

On 8/22/2021 8:29 AM, Andreas Rheinhardt wrote: It allows demuxers to perform certain tasks after a successful generic seek. Signed-off-by: Andreas Rheinhardt --- This io_repositioned and the flags which contain which type of seeking a format supports are IMO implementation details that are

Re: [FFmpeg-devel] [PATCH 6/6] avformat/av1dec: Disallow seeking by bytes

On 8/22/2021 10:25 AM, Andreas Rheinhardt wrote: The low overhead OBU format provides no means to resync after performing a byte-based seek; in other words: Byte based seeking is just not supported. Signed-off-by: Andreas Rheinhardt --- The reason I didn't disallow this earlier was that there

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/av1_frame_merge_bsf: Passthrough pos in case of no timestamps

On 8/22/2021 8:29 AM, Andreas Rheinhardt wrote: This is needed by the AV1-Annex B and AV1-OBU demuxers. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1_frame_merge_bsf.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/av1_frame_merge_bsf.c

Re: [FFmpeg-devel] [PATCH 2/5] avformat/av1dec: Deduplicate Annex B and low overhead OBU AV1 demuxer

On 8/22/2021 8:29 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/av1dec.c | 133 +++ 1 file changed, 47 insertions(+), 86 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index

Re: [FFmpeg-devel] [PATCH 1/5] avformat/av1dec: Set position of AVPackets given to BSF

On 8/22/2021 8:20 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/av1dec.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index

[FFmpeg-devel] [PATCH 6/6] avformat/av1dec: Disallow seeking by bytes

The low overhead OBU format provides no means to resync after performing a byte-based seek; in other words: Byte based seeking is just not supported. Signed-off-by: Andreas Rheinhardt --- The reason I didn't disallow this earlier was that there is one scenario where such a seek would work: When

Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: allow to use input stream timebase too

Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > doc/bitstream_filters.texi | 5 - > libavcodec/setts_bsf.c | 5 - > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 1900eb4352..b5a0be8ca2 100644 >

[FFmpeg-devel] [PATCH] avcodec/setts_bsf: allow to use input stream timebase too

Signed-off-by: Paul B Mahol --- doc/bitstream_filters.texi | 5 - libavcodec/setts_bsf.c | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 1900eb4352..b5a0be8ca2 100644 --- a/doc/bitstream_filters.texi

Re: [FFmpeg-devel] [PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

Pushed as d905af0c2409c854dcd45a05fe4caf9ac49d82ad On 2021-08-21 10:50 am, Gyan Doshi wrote: The RFC was posted 10 days ago. Plan to push tomorrow. On 2021-08-20 05:12 pm, Gyan Doshi wrote: The MOV muxer can store streamids as track ids but they aren't visible when probing the result via

[FFmpeg-devel] [PATCH 5/5] avformat/av1dec: Flush BSF upon seeking

The av1_merge_frame BSF outputs its cached data when it sees the beginning of a new frame, i.e. when it sees a temporal delimiter OBU. Therefore it typically has a temporal delimiter OBU cached after outputting a packet. This implies that the OBU demuxer must flush its BSF upon seeking because

[FFmpeg-devel] [PATCH 4/5] avformat/utils: Also set io_repositioned for generic seeking

It allows demuxers to perform certain tasks after a successful generic seek. Signed-off-by: Andreas Rheinhardt --- This io_repositioned and the flags which contain which type of seeking a format supports are IMO implementation details that are only public because up until recently there were no

[FFmpeg-devel] [PATCH 3/5] avcodec/av1_frame_merge_bsf: Passthrough pos in case of no timestamps

This is needed by the AV1-Annex B and AV1-OBU demuxers. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1_frame_merge_bsf.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/av1_frame_merge_bsf.c b/libavcodec/av1_frame_merge_bsf.c index

[FFmpeg-devel] [PATCH 2/5] avformat/av1dec: Deduplicate Annex B and low overhead OBU AV1 demuxer

Signed-off-by: Andreas Rheinhardt --- libavformat/av1dec.c | 133 +++ 1 file changed, 47 insertions(+), 86 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index e021615c1f..d5d4548d8b 100644 --- a/libavformat/av1dec.c +++

[FFmpeg-devel] [PATCH 1/5] avformat/av1dec: Set position of AVPackets given to BSF

Signed-off-by: Andreas Rheinhardt --- libavformat/av1dec.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index f6c575069e..e021615c1f 100644 --- a/libavformat/av1dec.c +++

Re: [FFmpeg-devel] [PATCH 1/4] libavformat/concatdec: remove support for unsafe=-1

Nicolas George (12021-08-20): > Second patch updated with Andrea's comments. > Final patch removing the in-protocol option syntax withdrawn for now. > Other patches unchanged. > Will push soon. Series pushed. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264: add user data unregistered SEI encoding

On Saturday, 14 August 2021 9:51:03 AM AEST Brad Hards wrote: > On Friday, 6 August 2021 7:16:33 PM AEST Brad Hards wrote: > > MISB ST 0604 and ST 2101 require user data unregistered SEI messages > > (precision timestamps and sensor identifiers) to be included. That > > currently isn't supported

Re: [FFmpeg-devel] [PATCH v3 02/25] avfilter/avfilter: Allow to free non-static pads generically

Andreas Rheinhardt (12021-08-22): > This can be enabled/disabled on a per-pad basis by setting > the AVFILTERPAD_FLAG_FREE_NAME flag; variants of ff_append_(in|out)pads > that do this for you have been added and will be put to use in the > following commits. This is an even better solution,