在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道：
> On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang
> wrote:
>
> >
> > >
> > > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote:
> > >
> > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang
> > wrote:
> > > >
> > > > Those comfort noise frames and empty frames
On Mon, Sep 06, 2021 at 02:49:47PM +0200, Timo Rothenpieler wrote:
> Series applied.
>
> While testing, I found that constrained encoding for HEVC was not a thing
> until SDK 10.0, so I added the necessary check and compile time guards for
> that.
>
> Also done some other minor style and logic
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Timo Rothenpieler
> Sent: Monday, 6 September 2021 23:13
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] Code Style and Diagnostic Issues
>
> On 06.09.2021 22:17, Soft Works wrote:
> > Hi,
> >
> > I wonder whether
On 06.09.2021 22:17, Soft Works wrote:
Hi,
I wonder whether there’s a commonly agreed set of code issues that should
be checked for, e.g. via clang-diagnostic?
This would help with a number of questions I’m wondering about and for
which it is not possible to derive rules from the existing code
On 9/6/2021 5:29 PM, Andreas Rheinhardt wrote:
The buffer_pkt is always unreferenced after being used and
is therefore always blank when avcodec_send_packet() is called.
It currently is always unreferenced after being used, but to prevent
someone mistakenly breaking that assumption, an
On Sun, Sep 05, 2021 at 09:51:32PM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Fixes: Assertion failure
> > Fixes:
> > 37463/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-4914693494931456
> >
> > Found-by: continuous fuzzing process
> >
The documentation does not require the packet to be blank in this case
(i.e. it can now contain opaque_ref), but it does contain that the
contents will be reset upon success.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/bsf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
The documentation of avcodec_send_packet() states that NULL packets
and packets with data == NULL and size == 0 signal EOS.
Yet avcodec_send_packet() actually used the BSF-definition of EOS:
A packet with no data and no side-data is EOS. This commit fixes this.
Signed-off-by: Andreas Rheinhardt
The buffer_pkt is always unreferenced after being used and
is therefore always blank when avcodec_send_packet() is called.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index
When an empty list bsf is used for passthrough, there is a check
for every packet in bsf_list_filter() before ff_bsf_get_packet_ref()
is called. Directly using the null bsf avoids that.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/bsf.c | 7 +++
1 file changed, 7 insertions(+)
diff
Signed-off-by: Andreas Rheinhardt
---
tools/target_bsf_fuzzer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/target_bsf_fuzzer.c b/tools/target_bsf_fuzzer.c
index 73bf4bdf0e..d6aaee3bd9 100644
--- a/tools/target_bsf_fuzzer.c
+++ b/tools/target_bsf_fuzzer.c
@@
Unneeded since c96904f525afcaba756a5ce8511a3ee1aa9fd2d7
(a bsf-list with zero bsfs is used since that commit).
Signed-off-by: Andreas Rheinhardt
---
I used the (always available) av_bsf_get_null_filter() as the fallback
in target_bsf_fuzzer.c; although I don't think it makes sense fuzzing
it.
Hi,
I wonder whether there’s a commonly agreed set of code issues that should
be checked for, e.g. via clang-diagnostic?
This would help with a number of questions I’m wondering about and for
which it is not possible to derive rules from the existing code base.
For example: should constant local
> On Sep 6, 2021, at 2:28 PM, Andreas Rheinhardt
> wrote:
>
> Paul B Mahol:
>> If audio packet is present in DV stream it have duration of 1 in DV timebase
>> units.
>>
>> Signed-off-by: Paul B Mahol
>> ---
>> libavformat/dv.c | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On Mon, Sep 6, 2021 at 8:29 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Paul B Mahol:
> > If audio packet is present in DV stream it have duration of 1 in DV
> timebase units.
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > libavformat/dv.c | 4
> > 1 file changed, 4
Paul B Mahol:
> If audio packet is present in DV stream it have duration of 1 in DV timebase
> units.
>
> Signed-off-by: Paul B Mahol
> ---
> libavformat/dv.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/dv.c b/libavformat/dv.c
> index d7909683c3..b2b74162df 100644
Signed-off-by: Paul B Mahol
---
libavcodec/mlpdec.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
index 4320cb4524..408ba80cd4 100644
--- a/libavcodec/mlpdec.c
+++ b/libavcodec/mlpdec.c
@@ -73,6 +73,7 @@ typedef struct
If audio packet is present in DV stream it have duration of 1 in DV timebase
units.
Signed-off-by: Paul B Mahol
---
libavformat/dv.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/dv.c b/libavformat/dv.c
index d7909683c3..b2b74162df 100644
--- a/libavformat/dv.c
+++
On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang
wrote:
>
> >
> > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote:
> >
> > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang
> wrote:
> >>
> >> Those comfort noise frames and empty frames should be
> >> considered the correct frame. And
will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Fixes valgrind warnings about use of uninitialised values.
Signed-off-by: James Almer
---
libswscale/swscale.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libswscale/swscale.c b/libswscale/swscale.c
index c233818dcf..b9c9647fcb 100644
--- a/libswscale/swscale.c
+++
On Mon, Aug 30, 2021 at 2:14 PM Jan Ekström wrote:
>
> First patch implements the CMAF specified way of flagging what in FFmpeg
> are are called stream dispositions. Other identifiers such as HTML media track
> kinds are allowed, but if there is a DASH identifier for something, it should
> be
On 8/20/2021 6:48 PM, Artem Galin wrote:
From: Artem Galin
Adding DX11 relevant device type checks and adjusting callbacks with
proper MediaSDK pair type support.
Extending structure for proper MediaSDK pair type support.
Signed-off-by: Artem Galin
---
libavcodec/qsv.c | 53
Series applied.
While testing, I found that constrained encoding for HEVC was not a
thing until SDK 10.0, so I added the necessary check and compile time
guards for that.
Also done some other minor style and logic changes, and renamed the
options to use "-" instead of "_", so the options
Signed-off-by: Andreas Rheinhardt
---
libavcodec/iirfilter.c | 21 -
libavcodec/iirfilter.h | 16
2 files changed, 16 insertions(+), 21 deletions(-)
diff --git a/libavcodec/iirfilter.c b/libavcodec/iirfilter.c
index cd5bbc943a..900893d2ff 100644
---
Possible since 61974537610d82bd35b6e3ac91ccd270c6bdc711.
Signed-off-by: Andreas Rheinhardt
---
libavformat/rtpdec.c | 15 ---
libavformat/rtpdec.h | 10 --
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c
index
Signed-off-by: Andreas Rheinhardt
---
libavformat/rawdec.c | 4 ++--
libavformat/rawdec.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c
index 06406424c8..b7e5a2d966 100644
--- a/libavformat/rawdec.c
+++ b/libavformat/rawdec.c
Possible since 3bab7cd12802dc5abf2c5cc6dec49e9e249ce204.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mov_chan.c | 11 +--
libavformat/mov_chan.h | 9 -
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c
index
Signed-off-by: Andreas Rheinhardt
---
libavcodec/snow_dwt.c | 16
libavcodec/snow_dwt.h | 4
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/libavcodec/snow_dwt.c b/libavcodec/snow_dwt.c
index 25681e7edd..3dca3c6d30 100644
--- a/libavcodec/snow_dwt.c
+++
Only used as an auxiliary function for ff_mqc_flush_to() since
4624656797b667eb6405186682eb04e74dfd90fd.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mqc.h| 1 -
libavcodec/mqcenc.c | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mqc.h
Signed-off-by: Andreas Rheinhardt
---
libavcodec/jpeg2000.c | 8
libavcodec/jpeg2000.h | 1 -
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavcodec/jpeg2000.c b/libavcodec/jpeg2000.c
index 324908d833..2fbdb64280 100644
--- a/libavcodec/jpeg2000.c
+++
It is only an auxiliary function to ff_qsv_print_(error|warning)().
Signed-off-by: Andreas Rheinhardt
---
libavcodec/qsv.c | 11 ++-
libavcodec/qsv_internal.h | 5 -
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
index
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263dec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
index b4aa109601..d7ae8a0727 100644
--- a/libavcodec/h263dec.c
+++ b/libavcodec/h263dec.c
@@ -742,7 +742,7 @@ const
Forgotten in 7c92eaace2b338e0b3acc18e1543b365610578fd.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/cbs.c | 41 +++--
libavcodec/cbs.h | 9 -
2 files changed, 23 insertions(+), 27 deletions(-)
diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c
It is a special BSF that is only available via the av_bsf_list-API;
it is not part of the list generated from the declarations in
bitstream_filters.c and therefore needn't have external linkage.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/bsf.c | 6 +++---
1 file changed, 3 insertions(+),
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Monday, 6 September 2021 08:53
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: Fix hardcoded
> input index
>
> Paul B Mahol
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Monday, 6 September 2021 08:48
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: Fix hardcoded
> input index
>
> On Mon, Sep 6, 2021
Paul B Mahol (12021-09-06):
> Yes. Because .activate fixes numerous issues.
> I see that only scale2ref is still using old way with multiple inputs. It
> probably should be fixed,
> and after that assert should be added in this file so new filters do not
> expose same limitations and mistakes of
On Mon, Sep 6, 2021 at 7:23 AM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Paul B Mahol
> > Sent: Sunday, 5 September 2021 21:51
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH]
40 matches
Mail list logo
