Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Friday, 17 September 2021 06:35 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering > > > > > -Original Message- > > From: ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Thursday, 16 September 2021 19:46 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering > [..] > > - Sparseness. Subtitles

Re: [FFmpeg-devel] [PATCH] avutil/buffer: Avoid allocation of AVBuffer when using buffer pool

2021-09-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Do this by putting an AVBuffer structure into BufferPoolEntry and > reuse it for all subsequent uses of said BufferPoolEntry. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/buffer.c | 44 + > libavutil/buffer_internal.h

[FFmpeg-devel] [PATCH] avfilter/vf_zscale: fix output color_range discrepancy

2021-09-16 Thread Pavel Koshevoy
This filter chain was supposed to convert from narrow range to full range yuv444p, but didn't: buffer=width=1280:height=720:pix_fmt=yuv444p:frame_rate=25/1:\ time_base=1/25:sar=1/1,zscale=min=709:rin=limited:pin=709:\ tin=709:t=linear,format=gbrpf32le,zscale=tin=linear:p=709:m=709:\

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-16 Thread Sun Zhenliang
Ping. Anyone could review this patch? Thx. 在 2021年9月16日 +0800 11:24,sunzhenliang ,写道: > Signed-off-by: sunzhenliang > --- > libavformat/amr.c | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/libavformat/amr.c b/libavformat/amr.c > index

[FFmpeg-devel] [PATCH 12/13] avfilter/vf_elbg: Check call to avpriv_elbg_do()

2021-09-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_elbg.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_elbg.c b/libavfilter/vf_elbg.c index 2c9c861d02..fac3b6f7fe 100644 --- a/libavfilter/vf_elbg.c +++ b/libavfilter/vf_elbg.c @@ -142,7 +142,7

[FFmpeg-devel] [PATCH 10/13] avcodec/cinepakenc: Check all calls to avpriv_elbg_do()

2021-09-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cinepakenc.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index 2984b93de3..d1bcf2b2d5 100644 --- a/libavcodec/cinepakenc.c +++

[FFmpeg-devel] [PATCH 09/13] avcodec/elbg: Also allocate buffers for recursion only once

2021-09-16 Thread Andreas Rheinhardt
This is possible because the number of elements needed in each recursion step decreases geometrically, so the geometric series provides an upper bound for the sum of number of elements of the needed buffers. Signed-off-by: Andreas Rheinhardt --- libavcodec/elbg.c | 38

[FFmpeg-devel] [PATCH 07/13] avcodec/elbg: Move arguments to the context early if possible

2021-09-16 Thread Andreas Rheinhardt
This affects all the arguments that don't change during a call to avpriv_elbg_do(); doing so makes it easily recognizable which arguments change upon recursive calls. Signed-off-by: Andreas Rheinhardt --- libavcodec/elbg.c | 73 +++ 1 file changed, 35

[FFmpeg-devel] [PATCH 13/13] avcodec/elbg: Add flags to avpriv_elbg_do()

2021-09-16 Thread Andreas Rheinhardt
This is currently unused and it is only added to enable changes while maintaining ABI compatibility. The type is uintptr_t in order to potentially accept a pointer argument. Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c | 2 +- libavcodec/cinepakenc.c | 2 +- libavcodec/elbg.c

[FFmpeg-devel] [PATCH 11/13] avcodec/msvideo1enc: Check all calls to avpriv_elbg_do()

2021-09-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/msvideo1enc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavcodec/msvideo1enc.c b/libavcodec/msvideo1enc.c index d43013ba5f..79810ec8c3 100644 --- a/libavcodec/msvideo1enc.c +++

[FFmpeg-devel] [PATCH 08/13] avcodec/elbg: Keep buffers to avoid allocations and frees

2021-09-16 Thread Andreas Rheinhardt
Up until now, each call to avpriv_elbg_do() would result in at least six allocations. And this function is called a lot: A typical FATE run results in 52213653 calls to av_malloc; of these, 34974671 originate from av_malloc_array and from these 34783679 originate from avpriv_elbg_do; the msvideo1

[FFmpeg-devel] [PATCH 04/13] avfilter/vf_elbg: Rename ELBGContext->ELBGFilterContext

2021-09-16 Thread Andreas Rheinhardt
The former name will be used for a context for avpriv_do_elbg(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_elbg.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_elbg.c b/libavfilter/vf_elbg.c index bf78030ffe..79797ee25f 100644

[FFmpeg-devel] [PATCH 06/13] avcodec/elbg: Add persistent ELBGContext

2021-09-16 Thread Andreas Rheinhardt
It will be used in future commits to avoid having to allocate and free all the buffers used. Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c | 8 ++-- libavcodec/cinepakenc.c | 5 - libavcodec/elbg.c| 12 +++- libavcodec/elbg.h| 16

[FFmpeg-devel] [PATCH 03/13] avcodec/elbg: Merge avpriv_init_elbg() into avpriv_do_elbg()

2021-09-16 Thread Andreas Rheinhardt
These functions are always called directly after another with the exact same arguments. This avoids exporting a symbol; it also avoids having to perform two calls for every caller. Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c | 4 libavcodec/cinepakenc.c | 1 -

[FFmpeg-devel] [PATCH 05/13] avcodec/elbg: Rename elbg_data to ELBGContext

2021-09-16 Thread Andreas Rheinhardt
It is in line with our naming conventions for types. Also change numCB to num_cb for the same reason. Signed-off-by: Andreas Rheinhardt --- libavcodec/elbg.c | 84 +++ libavcodec/elbg.h | 4 +-- 2 files changed, 44 insertions(+), 44 deletions(-)

[FFmpeg-devel] [PATCH 02/13] avcodec/elbg: Move avpriv_init_elbg() down

2021-09-16 Thread Andreas Rheinhardt
It will avoid a forward declaration later. Signed-off-by: Andreas Rheinhardt --- libavcodec/elbg.c | 71 +++ 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index 795fc83f16..3ca67b400c 100644 ---

[FFmpeg-devel] [PATCH 01/13] avcodec/elbg: Remove avoidable buffer

2021-09-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/elbg.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index d012d9a384..795fc83f16 100644 --- a/libavcodec/elbg.c +++ b/libavcodec/elbg.c @@ -376,7 +376,6 @@ int

Re: [FFmpeg-devel] [PATCH v3] libavfilter: add a gblur_vulkan filter

2021-09-16 Thread Wu, Jianhua
Ping. > From: Wu, Jianhua > Sent: Thursday, September 9, 2021 1:45 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Jianhua > Subject: [PATCH v3] libavfilter: add a gblur_vulkan filter > > This commit adds a powerful and customizable gblur Vulkan filter, which > provides a maximum 127x127 kernel

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/libsvtav1: support constant quality mode

2021-09-16 Thread lance . lmwang
On Fri, Sep 17, 2021 at 01:10:33AM +0300, Jan Ekström wrote: > On Thu, Sep 16, 2021 at 1:55 PM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > For the record, Christopher Degawa also posted something similar >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/libsvtav1: make intra_refresh_type configurable

2021-09-16 Thread lance . lmwang
On Fri, Sep 17, 2021 at 01:38:46AM +0300, Jan Ekström wrote: > Hi > > On Thu, Sep 16, 2021 at 1:54 PM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > I think something like: > > avcodec/libsvtav1: make coded GOP type configurable > > Might be a bit better as a

[FFmpeg-devel] [PATCH 1/2] avformat/mpegts: use actually read packet size in mpegts_resync special case

2021-09-16 Thread Michael Niedermayer
Fixes: infinite loop Fixes: 37986/clusterfuzz-testcase-minimized-ffmpeg_dem_MPEGTSRAW_fuzzer-5292311517462528 - Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mpegts.c | 4 ++-- 1 file

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/libsvtav1: make intra_refresh_type configurable

2021-09-16 Thread Jan Ekström
Hi On Thu, Sep 16, 2021 at 1:54 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- I think something like: avcodec/libsvtav1: make coded GOP type configurable Might be a bit better as a commit message? > libavcodec/libsvtav1.c | 4 +++- > 1 file changed, 3 insertions(+), 1

[FFmpeg-devel] [PATCH 2/2] avcodec/wmaprodec: Check that the EOF frame was allocated before decoding into it

2021-09-16 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 38125/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5151909422432256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmaprodec.c | 2 +-

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/libsvtav1: support constant quality mode

2021-09-16 Thread Jan Ekström
On Thu, Sep 16, 2021 at 1:55 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- For the record, Christopher Degawa also posted something similar (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210310224859.1726693-1-c...@randomderp.com/), and I finally recently had gotten

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Wednesday, 15 September 2021 11:21 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering > > On Wed, Sep 15, 2021 at 9:39 AM

[FFmpeg-devel] [PATCH v6 11/11] avfilter/stripstyles: Add stripstyles filter

2021-09-16 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 24 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 211 +++ 4

[FFmpeg-devel] [PATCH v6 10/11] avcodec/ass_split: Extend ass dialog parsing

2021-09-16 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/ass_split.c | 12 ++-- libavcodec/ass_split.h | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 05c5453e53..e58585d3da 100644 --- a/libavcodec/ass_split.c +++

[FFmpeg-devel] [PATCH v6 09/11] avfilter/textmod: Add textmod filter

2021-09-16 Thread Soft Works
- textmod {S -> S) Modify subtitle text in a number of ways Signed-off-by: softworkz --- doc/filters.texi | 64 +++ libavfilter/Makefile | 3 + libavfilter/allfilters.c | 1 + libavfilter/sf_textmod.c | 372 +++ 4 files changed, 440

[FFmpeg-devel] [PATCH v6 07/11] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-16 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video

[FFmpeg-devel] [PATCH v6 08/11] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-16 Thread Soft Works
- overlay_textsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure | 2 + doc/filters.texi | 69 libavfilter/Makefile

[FFmpeg-devel] [PATCH v6 06/11] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-16 Thread Soft Works
- overlay_graphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v6 05/11] avfilter/sbuffer: Add sbuffersrv and sbuffersink filters

2021-09-16 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 10 +++--- libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72

[FFmpeg-devel] [PATCH v6 04/11] avfilter/avfilter: Handle subtitle frames

2021-09-16 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 14 ++ libavfilter/formats.h | 3 +++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH v6 03/11] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-09-16 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 61 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v6 02/11] fftools/play, probe: Adjust for subtitle changes

2021-09-16 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 50 +++ fftools/ffprobe.c | 49 ++ 2 files changed, 62 insertions(+), 37 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index

[FFmpeg-devel] [PATCH v6 01/11] global: Prepare AVFrame for subtitle handling

2021-09-16 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct

[FFmpeg-devel] [PATCH v6 00/11] Subtitle Filtering

2021-09-16 Thread Soft Works
v6 Update: - Implements all given feedback from reviews (thanks!) - Add AVSubtitle fields to AVFrame, keeping AVSubtitle unchanged for compatibility and future deprecation - Use subtitle frames internally and for filtering - Retain compatibility with legacy subtitle implementation through a

Re: [FFmpeg-devel] [PATCH] avformat/mvdec: propagate the errors returned by parse_audio_var()

2021-09-16 Thread James Almer
On 9/16/2021 4:39 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/mvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c index 7573087c7c..0b4aa1f18f 100644 --- a/libavformat/mvdec.c +++

Re: [FFmpeg-devel] [PATCH] avformat/mvdec: propagate the errors returned by parse_audio_var()

2021-09-16 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/mvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c > index 7573087c7c..0b4aa1f18f 100644 > --- a/libavformat/mvdec.c > +++ b/libavformat/mvdec.c > @@ -387,7

[FFmpeg-devel] [PATCH] avformat/mvdec: propagate the errors returned by parse_audio_var()

2021-09-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/mvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c index 7573087c7c..0b4aa1f18f 100644 --- a/libavformat/mvdec.c +++ b/libavformat/mvdec.c @@ -387,7 +387,7 @@ static int

Re: [FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Michael Niedermayer
On Thu, Sep 16, 2021 at 01:55:17PM +0200, Nicolas George wrote: > Since it is not healthy to keep everything for myself, here is a summary > of the projects I have in mind for the enhancement of libavfilter. > > The thing is, there are a lot of dependencies between these projects. > Working on

Re: [FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Xiang Xiao
We are facing similar issues after working with libavfilter for more than one year. We are implementing a private solution for: - Partial graph configuration - Partial graph re-configuration - Global running API It's glad to see other people have the same feeling of the shortcoming

Re: [FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Thursday, 16 September 2021 13:55 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] Plans for libavfilter > > > > - Media type negotiation. > > That means that filters that do not care about

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Thursday, 16 September 2021 12:20 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering > > There is another point to

Re: [FFmpeg-devel] [PATCH v2 09/14] avfilter/vf_scale: Honour the AVFilter.init_dict documentation

2021-09-16 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-09-14): >> The documentation states that unrecognized options need to be returned >> (just as av_opt_set_dict() would do). Yet the scale and scale2ref >> filters didn't abide by this: They simply copied all options >> and in case it contained an

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Michael Niedermayer
On Thu, Sep 16, 2021 at 12:20:17PM +0200, Nicolas George wrote: > Hendrik Leppkes (12021-09-15): > > Or perhaps some people have a day job, a life and other obligations > > that prevent them from spending time on FFmpeg every day, especially > > outside the weekend. > > But no, that can't be it,

Re: [FFmpeg-devel] [PATCH 1/5] avformat/sbgdec: Check for t0 overflow in expand_tseq()

2021-09-16 Thread Michael Niedermayer
On Thu, Sep 16, 2021 at 02:52:10PM +0200, Nicolas George wrote: > Michael Niedermayer (12021-09-15): > > Fixes: signed integer overflow: 4611686025627387904 + 4611686025627387904 > > cannot be represented in type 'long' > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mvdec: Do not set invalid sample rate

2021-09-16 Thread Michael Niedermayer
On Thu, Sep 16, 2021 at 05:02:53PM +1000, Peter Ross wrote: > On Wed, Sep 15, 2021 at 10:00:46PM +0200, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -682581959642593728 * 16 cannot be > > represented in type 'long' > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/apedec: Fix integer overflow in intermediate

2021-09-16 Thread Michael Niedermayer
On Wed, Sep 15, 2021 at 10:09:49PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: signed integer overflow: 559334865 * 4 cannot be represented in type > > 'int' > > Fixes: > > 37929/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-6751932295806976 > > > >

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/x86/vf_gblur: fixed the fate-test failed on MacOS

2021-09-16 Thread Zhao Zhili
> On Sep 16, 2021, at 3:48 PM, Wu, Jianhua wrote: > > Jianhua wrote: >> From: Wu, Jianhua >> Sent: Thursday, September 16, 2021 3:34 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Wu, Jianhua >> Subject: [PATCH 1/2] libavfilter/x86/vf_gblur: fixed the fate-test failed on >> MacOS >> >>

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/libsvtav1: Fix redundant setting of caps_internal

2021-09-16 Thread lance . lmwang
On Thu, Sep 16, 2021 at 01:32:00PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/libsvtav1.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libavcodec/libsvtav1.c

[FFmpeg-devel] [PATCH] avcodec/mmaldec: fix decoder freeze when flushing

2021-09-16 Thread Ho Ming Shun
When mmal_flush is called before any packets are sent, enabling/disabling the MMAL ports seems to cause the decoder to not output any packets after flushing. Bug is triggered when using 'mpv --hwdec=mmal --start=1 test.mp4'. Proposed workaround in MPV: https://github.com/mpv-player/mpv/pull/9189

Re: [FFmpeg-devel] regarding hiding AVStream.first_dts member into AVStreamInternal

2021-09-16 Thread James Almer
Chromium could instead keep track of that timestamp in their own code. It's what i did to remove the internal fields usage from our CLI tools. See https://github.com/FFmpeg/FFmpeg/commit/ab4f299e23 On 9/16/2021 8:24 AM, Marek Behún wrote: Hello James, liberato, James, your commit

Re: [FFmpeg-devel] [PATCH v2 01/14] avfilter/vsrc_testsrc: Deduplicate AVClasses

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > Signed-off-by: Andreas Rheinhardt > --- > I am not resending all the deduplication patches; > they can be e.g. found here: > https://github.com/mkver/FFmpeg/commits/avfilter_deduplication > > libavfilter/vsrc_testsrc.c | 47

Re: [FFmpeg-devel] [PATCH v2 09/14] avfilter/vf_scale: Honour the AVFilter.init_dict documentation

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > The documentation states that unrecognized options need to be returned > (just as av_opt_set_dict() would do). Yet the scale and scale2ref > filters didn't abide by this: They simply copied all options > and in case it contained an unrecognized option was among

Re: [FFmpeg-devel] [PATCH v2 13/14] avfilter/avfilter: Don't fail upon options for filter without AVClass

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > Commit 62549f9655c48f0ec061087fa33a96040ce01145 added a check to > (the predecessor of) avfilter_init_str() to error out if options > were provided to a filter without options (or rather, without private > class). This was fine at the time, yet soon afterwards

Re: [FFmpeg-devel] [PATCH v2 12/14] avfilter/avfilter: Honour the short options documentation

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > The documentation for filter arguments states that short options must > precede long options (i.e. those of the form key=value). Yet if > process_options() encounters arguments not abiding by this, it simply > treats short options after a long option as if it

Re: [FFmpeg-devel] [PATCH 1/5] avformat/sbgdec: Check for t0 overflow in expand_tseq()

2021-09-16 Thread Nicolas George
Michael Niedermayer (12021-09-15): > Fixes: signed integer overflow: 4611686025627387904 + 4611686025627387904 > cannot be represented in type 'long' > Fixes: > 35489/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-4862678601433088 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2 11/14] avfilter/avfilter: Use AV_DICT_DONT_STRDUP_(KEY|VAL) when possible

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Nicolas George
Paul B Mahol (12021-09-16): > This is short sighted and irrelevant and also source of confusion for > users. > > I really see no way to tell you to stop insisting on this nonsense. So I > kindly ask you > yet again to stop further work you planned on libavfilter for everyone else > good outcome.

Re: [FFmpeg-devel] [PATCH v2 14/14] avfilter/avfilter: Report all unrecognized options in avfilter_init_str

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Looks ok. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2 05/14] avfilter/af_aresample: Use preinit instead of init_dict

2021-09-16 Thread Nicolas George
Andreas Rheinhardt (12021-09-14): > By using preinit, the SwrContext already exists directly after > allocating the filter, so that the filter's AVClass's child_next > becomes usable for setting options with the AV_OPT_SEARCH_CHILDREN > search flag. This means that it is no longer necessary to use

Re: [FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Paul B Mahol
On Thu, Sep 16, 2021 at 1:55 PM Nicolas George wrote: > Since it is not healthy to keep everything for myself, here is a summary > of the projects I have in mind for the enhancement of libavfilter. > > The thing is, there are a lot of dependencies between these projects. > Working on them in a

[FFmpeg-devel] Plans for libavfilter

2021-09-16 Thread Nicolas George
Since it is not healthy to keep everything for myself, here is a summary of the projects I have in mind for the enhancement of libavfilter. The thing is, there are a lot of dependencies between these projects. Working on them in a proper order would make achieving the goals easier. On the other

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/libsvtav1: Fix redundant setting of caps_internal

2021-09-16 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/libsvtav1.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index fabc4e6..82ae2b9 100644 > --- a/libavcodec/libsvtav1.c >

[FFmpeg-devel] [PATCH 5/5] avcodec/libsvtav1: support constant quality mode

2021-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 7 ++- libavcodec/libsvtav1.c | 10 +- libavcodec/version.h | 2 +- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 64d604e..2300bb9 100644 ---

[FFmpeg-devel] [PATCH 4/5] avcodec/libsvtav1: Fix CQP mode doesn't work as expection

2021-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 8c2c970..1f1f86b 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -208,6 +208,8 @@ static int

[FFmpeg-devel] [PATCH 3/5] doc: update for libsvtav1 encoder

2021-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 44 1 file changed, 44 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 8fccd73..64d604e 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1750,12

[FFmpeg-devel] [PATCH 2/5] avcodec/libsvtav1: make intra_refresh_type configurable

2021-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 82ae2b9..8c2c970 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -210,7 +210,8

[FFmpeg-devel] [PATCH 1/5] avcodec/libsvtav1: Fix redundant setting of caps_internal

2021-09-16 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index fabc4e6..82ae2b9 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -561,12 +561,11

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-16 Thread Nicolas George
Hendrik Leppkes (12021-09-15): > Or perhaps some people have a day job, a life and other obligations > that prevent them from spending time on FFmpeg every day, especially > outside the weekend. > But no, that can't be it, surely we are all just evil. /s > Nothing here is being invented. You are

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

2021-09-16 Thread Tomas Härdin
ons 2021-09-15 klockan 12:14 +0200 skrev Marc-Antoine Arnaud: +static int mxf_read_mca_sub_descriptor(void *arg, AVIOContext *pb, int tag, int size, UID uid, int64_t klv_offset) +{ +    MXFMCASubDescriptor *mca_sub_descriptor = arg; + +    if (IS_KLV_KEY(uid, mxf_mca_prefix)) { +    if

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-09-16 Thread Steven Liu
Nachiket Tarate 于2021年9月1日周三 下午10:39写道: > > These will be used by HLS demuxer in case of sample decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/adts_header.c | 1 + > libavcodec/adts_header.h | 15 +++ > libavcodec/adts_parser.c | 31

Re: [FFmpeg-devel] [PATCH 01/12] lavf/concat: refactor parsing

2021-09-16 Thread Nicolas George
Nicolas George (12021-09-12): > Will push this series soon. Series pushed. ffmpeg + lsdvd + dvd2concat can now encode DVDs reasonably well. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/x86/vf_gblur: fixed the fate-test failed on MacOS

2021-09-16 Thread Wu, Jianhua
Jianhua wrote: > From: Wu, Jianhua > Sent: Thursday, September 16, 2021 3:34 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Jianhua > Subject: [PATCH 1/2] libavfilter/x86/vf_gblur: fixed the fate-test failed on > MacOS > > Signed-off-by: Wu Jianhua > --- Hi Zhili, I have submitted the patches

Re: [FFmpeg-devel] [PATCH 0/3] Detect field_order when probing MP4/H264

2021-09-16 Thread Nicolas Gaullier
>Nicolas Gaullier (3): > avcodec/h264_parser: Set AVCodecContext.framerate > avformat/utils: Use r_frame_rate in compute_frame_duration if > codec_framerate is unknown > avformat/mov: Set AVSTREAM_PARSE_HEADERS flag for H264 Hello, I have received no feedback on this serie I posted last week.

[FFmpeg-devel] [PATCH 2/2] libavfilter/x86/vf_gblur: correct the order of loop step

2021-09-16 Thread Wu Jianhua
The problem was caused by if the width of the processed block minus 1 is a multiple of the aligned number the instruction jle .bscale_scalar would skip the Optimized Loop Step, which will lead to an incorrect sampling when specifying steps more than 1. Move the Optimized Loop Step after

[FFmpeg-devel] [PATCH 1/2] libavfilter/x86/vf_gblur: fixed the fate-test failed on MacOS

2021-09-16 Thread Wu Jianhua
Signed-off-by: Wu Jianhua --- libavfilter/x86/vf_gblur.asm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/x86/vf_gblur.asm b/libavfilter/x86/vf_gblur.asm index c0d57cc82b..64c067538a 100644 --- a/libavfilter/x86/vf_gblur.asm +++

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mvdec: Do not set invalid sample rate

2021-09-16 Thread Peter Ross
On Wed, Sep 15, 2021 at 10:00:46PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -682581959642593728 * 16 cannot be > represented in type 'long' > Fixes: > 37883/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5311691517198336 > > Found-by: continuous fuzzing process