Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread Andreas Rheinhardt
quietvoid: > When muxing to Matroska, write the Block Additional Mapping > if there is AV_PKT_DATA_DOVI_CONF side data present. > Most of the code was implemented by Plex developers. > > Signed-off-by: quietvoid > --- > libavformat/Makefile | 2 +- > libavformat/dovi_isom.c | 45

[FFmpeg-devel] [PATCH v2 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Signed-off-by: quietvoid --- libavformat/mpegts.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..75ef59d186 100644 --- a/libavformat/mpegts.c +++

[FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 51 ++- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
When muxing to Matroska, write the Block Additional Mapping if there is AV_PKT_DATA_DOVI_CONF side data present. Most of the code was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat/dovi_isom.c | 45

[FFmpeg-devel] [PATCH v2 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
The parsing was implemented in a new dovi_isom file for the unification of the mov/mpegts DOVI parsing into one function, in a following patch. Most of the Matroska elements implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +-

[FFmpeg-devel] [PATCH v2 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 ++ libavformat/matroskadec.c | 45 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h

Re: [FFmpeg-devel] [PATCH v2] avdevice/avfoundation: continue to try get packet if not in observed_quit mode

2021-09-22 Thread Steven Liu
> 2021年9月22日 下午7:09,Thilo Borgmann 写道: > > Hi, > > > On 18 Sep 2021, at 3:51, Steven Liu wrote: > >> Signed-off-by: Steven Liu >> --- >> libavdevice/avfoundation.m | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m >> index

Re: [FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread Andreas Rheinhardt
quietvoid: > > On 22/09/2021 22.03, Andreas Rheinhardt wrote: >> quietvoid: >>> +    put_ebml_string(pb, MATROSKA_ID_BLKADDIDNAME, "Dolby Vision >>> configuration"); >>> +    put_ebml_uint(pb, MATROSKA_ID_BLKADDIDTYPE, type); >>> +    put_ebml_binary(pb, MATROSKA_ID_BLKADDIDEXTRADATA,

Re: [FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
On 22/09/2021 22.03, Andreas Rheinhardt wrote: quietvoid: +put_ebml_string(pb, MATROSKA_ID_BLKADDIDNAME, "Dolby Vision configuration"); +put_ebml_uint(pb, MATROSKA_ID_BLKADDIDTYPE, type); +put_ebml_binary(pb, MATROSKA_ID_BLKADDIDEXTRADATA, buf, size); +

Re: [FFmpeg-devel] [PATCH 1/4] libavfilter/x86/vf_hflip: add ff_flip_byte/short_avx512()

2021-09-22 Thread Wu, Jianhua
Ping. Jianhua wrote: > From: ffmpeg-devel On Behalf Of Wu, > Jianhua > Sent: Tuesday, September 14, 2021 1:02 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/4] libavfilter/x86/vf_hflip: add > ff_flip_byte/short_avx512() > > > It

Re: [FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread Andreas Rheinhardt
quietvoid: > When muxing to Matroska, write the Block Additional Mapping > if there is AV_PKT_DATA_DOVI_CONF side data present. > Most of the code was implemented by Plex developers. > > Signed-off-by: quietvoid > --- > libavformat/isom.c| 42 +++ >

Re: [FFmpeg-devel] [PATCH 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-22 Thread Andreas Rheinhardt
quietvoid: > The parsing was implemented in isom, for the unification of > the mov/mpegts DOVI parsing into one function, in a later patch. > Most of the implementation was done by Plex developers. > > Signed-off-by: quietvoid > --- > libavformat/isom.c| 51

Re: [FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
On 22/09/2021 20.55, Andreas Rheinhardt wrote: quietvoid: Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid ---   libavformat/matroska.h    |  7 ++   libavformat/matroskadec.c | 45 +--   2 files changed, 50

Re: [FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread Andreas Rheinhardt
quietvoid: > Most of the implementation was done by the Plex developers. > > Signed-off-by: quietvoid > --- > libavformat/matroska.h| 7 ++ > libavformat/matroskadec.c | 45 +-- > 2 files changed, 50 insertions(+), 2 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_mov_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Signed-off-by: quietvoid --- libavformat/mpegts.c | 41 +++-- 1 file changed, 3 insertions(+), 38 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..19d26ef375 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c

[FFmpeg-devel] [PATCH 4/5] avformat/mov: Refactor DOVI box parsing to use ff_mov_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 48 +-- 1 file changed, 9 insertions(+), 39 deletions(-) diff --git

[FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
When muxing to Matroska, write the Block Additional Mapping if there is AV_PKT_DATA_DOVI_CONF side data present. Most of the code was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/isom.c| 42 +++ libavformat/isom.h|

[FFmpeg-devel] [PATCH 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
The parsing was implemented in isom, for the unification of the mov/mpegts DOVI parsing into one function, in a later patch. Most of the implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/isom.c| 51 +++

[FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 ++ libavformat/matroskadec.c | 45 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h

Re: [FFmpeg-devel] [PATCH v3] lavfi: add nlmeans CUDA filter

2021-09-22 Thread Dylan Fernando
Any feedback for this? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 05:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 11/13] avfilter/stripstyles: Add > stripstyles filter > >>> It crashed at some point, I don't

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

2021-09-22 Thread Marton Balint
On Fri, 17 Sep 2021, Marc-Antoine Arnaud wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 277 ++- 2 files changed, 272 insertions(+), 6 deletions(-) I guess the questionable part of this patch is the internal reordering of audio

Re: [FFmpeg-devel] [PATCH] swscale/yuv2rgb: fix shift values for conversion to X2RGB10

2021-09-22 Thread Manuel Stoeckl
> > > > The variable 'yval' used later in the switch case 30 has range > > [0,255], but the color channel values in X2RGB10 have two more > > bits than 'yval' and can go up to 1023. Increasing (r|g|b)base > > by 2 effectively multiplies yval by 4 and fixes this discrepancy. > > does white have

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: rename sub_descriptors as file_descriptors

2021-09-22 Thread Marton Balint
On Fri, 17 Sep 2021, Marc-Antoine Arnaud wrote: --- libavformat/mxfdec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) Thanks, applied. Regards, Marton diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 34cbd2cd77..c28549f6a9 100644 ---

[FFmpeg-devel] Conversion of Graphic Subtitles to Text Subtitles

2021-09-22 Thread Soft Works
Hi, as some had contacted me off-list about converting graphical subs to text, whether it works and how well it would work, I wanted to drop a few words about the ‘graphicsubs2text’ filter which is part of my latest subtitle filtering patchset. From previous experience with OCR in general I had

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Wednesday, 22 September 2021 11:48 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add > overlay_textsubs and textsubs2video

[FFmpeg-devel] [PATCH 4/4] avformat/mpegts: fix max_packet_size in mpegts payload parsing

2021-09-22 Thread Marton Balint
The maximum allowed useful PES payload data was set to PES_packet_length, but it is in fact smaller by the length of the PES header. This changes how corrupt streams are packetized: - If PES header length is bigger than PES_packet_length then the PES packet payload will be handled as an unbound

[FFmpeg-devel] [PATCH 3/4] avformat/mpegts: rename PES total_size to PES_packet_length

2021-09-22 Thread Marton Balint
This renames PESContext->total_size to PESContext->PES_packet_length and keeps it 0 for unbound packets, so its name and semantics will match the standard. There should be no change in functionality. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 36

[FFmpeg-devel] [PATCH 2/4] avformat/mpegts: delay allocation of PES buffer

2021-09-22 Thread Marton Balint
This allows us to allocate the buffer in a single code path. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index fcb32ecd28..2620e79f57 100644 ---

[FFmpeg-devel] [PATCH 1/4] avformat/mpegts: use named constants for stream_id types

2021-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegts.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..fcb32ecd28 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -1126,7 +1126,7

Re: [FFmpeg-devel] [PATCH] swscale/yuv2rgb: fix shift values for conversion to X2RGB10

2021-09-22 Thread Michael Niedermayer
On Mon, Sep 20, 2021 at 10:21:23PM -0400, Manuel Stoeckl wrote: > This resolves a problem where conversions from YUV to X2RGB10LE > would produce color values a factor 4 too small. > > The variable 'yval' used later in the switch case 30 has range > [0,255], but the color channel values in

Re: [FFmpeg-devel] [PATCH 1/2] avformat/concatdec: Use FAIL() macro instead of direct return in concat_parse_script()

2021-09-22 Thread Michael Niedermayer
On Wed, Sep 22, 2021 at 01:20:16PM +0200, Nicolas George wrote: > Michael Niedermayer (12021-09-22): > > Fixes: memleak > > Fixes: > > 38893/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4785231933079552 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/encoders: Remove redundant setting of AV_PKT_FLAG_KEY

2021-09-22 Thread Andreas Rheinhardt
Paul B Mahol: > Why? Whats wrong with explicitly set flag? > If it's redundant, it can be removed. Just as it already is for audio encoders. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] Mailing list conduct

2021-09-22 Thread Dave Rice
Hello FFmpeg community, I'm writing on behalf of FFmpeg's code of conduct committee to acknowledge that the tone on the mailing list has recently become more discouraging, challenging, and argumentative, notably on subjects related to subtitles from multiple people. We should be able to do

[FFmpeg-devel] [PATCH] avcodec/vqavideo: Decode 15-bit VQA3 files

2021-09-22 Thread Pekka Väänänen
Adds support for 15-bit VQA3 videos used in Westwood Studios' games. Signed-off-by: Pekka Väänänen --- libavcodec/vqavideo.c | 268 - libavformat/westwood_vqa.c | 10 ++ 2 files changed, 248 insertions(+), 30 deletions(-) diff --git

Re: [FFmpeg-devel] 15-bit Westwood VQA3 decoding

2021-09-22 Thread Pekka Väänänen
> Pekka Väänänen: > > 1. Is it possible to preserve the pixels of a frame for easy delta > > updates? > > In that 2009 patch set they used an old "FF_BUFFER_HINTS_PRESERVE" > > flag > > that doesn't exist anymore. > > > > You keep a reference to the earlier frame (use av_frame_ref()). The

[FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-09-22 Thread Pekka Väänänen
High color 15-bit VQA3 video streams contain high level chunks with only codebook updates that shouldn't be considered new frames. Now the demuxer stores a reference to such VQFL chunks and returns them later along with a VQFR chunk with full frame data. --- libavformat/westwood_vqa.c | 48

Re: [FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-09-22 Thread Pekka Väänänen
Thank you for your patience with this patch. > This code also reads the VQFR chunk before seeking back, so this needs > to be changed or accounted for. > > > +ffio_ensure_seekback(pb, wsvqa->vqfl_chunk_size + 512 * 1024); > > +avio_skip(pb, chunk_size + skip_byte);

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/encoders: Remove redundant setting of AV_PKT_FLAG_KEY

2021-09-22 Thread Paul B Mahol
Why? Whats wrong with explicitly set flag? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avformat/concatdec: Use FAIL() macro instead of direct return in concat_parse_script()

2021-09-22 Thread Nicolas George
Michael Niedermayer (12021-09-22): > Fixes: memleak > Fixes: > 38893/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4785231933079552 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH v2] avdevice/avfoundation: continue to try get packet if not in observed_quit mode

2021-09-22 Thread Thilo Borgmann
Hi, On 18 Sep 2021, at 3:51, Steven Liu wrote: Signed-off-by: Steven Liu --- libavdevice/avfoundation.m | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 0cd6e646d5..cd30f48cfe 100644 --- a/libavdevice/avfoundation.m +++

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Nicolas George
Soft Works (12021-09-22): > Be substantial, be polite, like normal humans - if you want me to reply. It depends. Have you decided to acknowledge that I know how lavfi works better than you and to listen to what I have to say? If not, I do not see why I should waste time saying it. You have been

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Paul B Mahol
On Wed, Sep 22, 2021 at 10:17 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > Nicolas > > George > > Sent: Wednesday, 22 September 2021 09:51 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v8 08/13]

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Wednesday, 22 September 2021 09:51 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add > overlay_textsubs and textsubs2video

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Nicolas George
Soft Works (12021-09-22): > Yes, this is intentional Intentional or not, it is wrong. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Wednesday, 22 September 2021 09:44 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add > overlay_textsubs and textsubs2video filters >

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Wednesday, 22 September 2021 09:17 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add > overlay_textsubs and textsubs2video

[FFmpeg-devel] [PATCH 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2021-09-22 Thread Haihao Xiang
Usually a HW decoder is expected when user specifies a HW acceleration method via -hwaccel option, however the current implementation doesn't take HW acceleration method into account, it is possible to select a SW decoder. For example: $> ffmpeg -hwaccel vaapi -i av1.ivf -f null - ... Stream

[FFmpeg-devel] [PATCH 1/2] ffmpeg_opt: select a decoder after getting values for per-stream hwdec options

2021-09-22 Thread Haihao Xiang
After applying this patch, the desired HW acceleration method is known before selecting decoder, so we may take HW acceleration method into account when selecting decoder for input stream in the next commit There should be no functional changes in this patch --- fftools/ffmpeg_opt.c | 116

Re: [FFmpeg-devel] [PATCH v8 08/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-22 Thread Nicolas George
Soft Works (12021-09-21): > - overlay_textsubs {VS -> V) > Overlay text subtitles onto a video stream. > > - textsubs2video {S -> V) > Converts text subtitles to video frames > > Signed-off-by: softworkz > --- > configure | 2 + > doc/filters.texi