Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote: > Does this compile and link with libaom 1.0.0? We unfortunately still >> support that version (despite being unusable speed wise) because distros >> like Debian still ship it. >> > > Just looked it up and yes version 1.0.0 includes the required >

[FFmpeg-devel] [PATCH] libx264: Do not explicitly set X264_API_IMPORTS

2021-10-29 Thread Matt Oliver
Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfig as required since build 158 (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019. So this patch updates configure to requ

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
> > Does this compile and link with libaom 1.0.0? We unfortunately still > support that version (despite being unusable speed wise) because distros > like Debian still ship it. > Just looked it up and yes version 1.0.0 includes the required aom_codec_av1_dx() function (line 37 of aomdx.h for those

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread James Almer
On 10/29/2021 11:43 PM, Matt Oliver wrote: lgtm. Thanks, I will push this assuming no other comments. Does this compile and link with libaom 1.0.0? We unfortunately still support that version (despite being unusable speed wise) because distros like Debian still ship it. _

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
> > lgtm. > Thanks, I will push this assuming no other comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Ronald S. Bultje
Hi Thomas, On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin wrote: > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > +const uint16_t *src = (const uint16_t *)ssrc; > > This is not -fstrict-aliasing safe > I don't believe that is correct. It's true we're not allowed to cast between tw

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 19:43 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > > > wrote: > > > > > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul

Re: [FFmpeg-devel] [PATCH] configure: add initial RISC-V support

2021-10-29 Thread Michael Niedermayer
On Thu, Oct 28, 2021 at 06:13:30PM -0400, Brad Smith wrote: > ping. > > On 8/8/2021 8:48 PM, Brad Smith wrote: > > ping. > > > > On 7/25/2021 6:31 PM, Brad Smith wrote: > > > OpenBSD only supports riscv64 but this is an attempt at adding > > > some of the initial bits for RISC-V support. > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > > wrote: > > > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > > wrote: > > > > > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > > wrote: > > > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > > >

Re: [FFmpeg-devel] [PATCH 7/7] avfilter/vf_nlmeans: add x86 SIMD

2021-10-29 Thread James Almer
On 10/29/2021 12:19 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 3 + libavfilter/vf_nlmeans.h | 1 + libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_nlmeans.asm| 92 +++ libavfilter/x86/

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin > wrote: > > > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > > wrote: > > > > > > > > > +static double get_hx(const uint8_t *src,

Re: [FFmpeg-devel] [PATCH] avfilter: add huesaturation filter

2021-10-29 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 7/7] avfilter/vf_nlmeans: add x86 SIMD

2021-10-29 Thread Michael Niedermayer
On Fri, Oct 29, 2021 at 05:19:03PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_nlmeans.c | 3 + > libavfilter/vf_nlmeans.h | 1 + > libavfilter/x86/Makefile | 2 + > libavfilter/x86/vf_nlmeans.asm| 92 ++

Re: [FFmpeg-devel] [PATCH 1/7] avfilter/vf_nlmeans: use more friendlier 'for (int ...'

2021-10-29 Thread James Almer
On 10/29/2021 12:18 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) You could just use "reduce scope of some variables" for the subject instead. ___

[FFmpeg-devel] [PATCH 7/7] avfilter/vf_nlmeans: add x86 SIMD

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 3 + libavfilter/vf_nlmeans.h | 1 + libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_nlmeans.asm| 92 +++ libavfilter/x86/vf_nlmeans_init.c | 40 ++ 5 files chan

[FFmpeg-devel] [PATCH 6/7] avfilter/vf_nlmeans: split wa struct

2021-10-29 Thread Paul B Mahol
This will make x86 SIMD simpler and faster. Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 43 +++- libavfilter/vf_nlmeans.h | 8 ++-- 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_n

[FFmpeg-devel] [PATCH 4/7] avfilter/vf_nlmeans: avoid if () to help paralellization

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index d5a71291af..af165c861c 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter/vf_nlmeans.c @@ -332,

[FFmpeg-devel] [PATCH 5/7] avfilter/vf_nlmeans: refactor line processing in preparation for x86 SIMD assembly

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 109 ++- libavfilter/vf_nlmeans.h | 14 + 2 files changed, 77 insertions(+), 46 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index af165c861c..93a14bcf19 100644 --

[FFmpeg-devel] [PATCH 2/7] avfilter/vf_nlmeans: make access to pointer to lut faster

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index b8d8bb2ec0..0962056a6e 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter/vf_nlmeans.c @@ -344,6 +344,7 @@

[FFmpeg-devel] [PATCH 3/7] avfilter/vf_nlmeans: no need to print filter options at info level

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index 0962056a6e..d5a71291af 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter/vf_nlmeans.c @@ -526,7 +526,7 @@ st

[FFmpeg-devel] [PATCH 1/7] avfilter/vf_nlmeans: use more friendlier 'for (int ...'

2021-10-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index 74fc3923b3..b8d8bb2ec0 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin wrote: > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > > wrote: > > > > > > > +static double get_hx(const uint8_t *src, int linesize, int w, > > > > int h) > > > > +{ > > > > +int64_t sum

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol: > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin > wrote: > > > > > +static double get_hx(const uint8_t *src, int linesize, int w, > > > int h) > > > +{ > > > +    int64_t sum = 0; > > > + > > > +    for (int y = 0; y < h; y++) { > > > +   

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Paul B Mahol
On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin wrote: > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > > > +FRAMESYNC_DEFINE_CLASS(wpsnr, WPSNRContext, fs); > > + > > +#define COMPUTE_HX(type, stype, depth) \ > > +static void compute_hx##depth(const uint8_t *ssrc, \ > >

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Tomas Härdin
tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > +FRAMESYNC_DEFINE_CLASS(wpsnr, WPSNRContext, fs); > + > +#define COMPUTE_HX(type, stype, depth)   \ > +static void compute_hx##depth(const uint8_t *ssrc,   \ > +  int linesize,  \ > +

Re: [FFmpeg-devel] [PATCH] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16

2021-10-29 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16

2021-10-29 Thread zhilizhao(赵志立)
> On Oct 29, 2021, at 3:49 PM, Zhao Zhili wrote: > > Use PCM_S16 so the codec_id will be updated later according to > bits_per_coded_sample. Here is the sample file: https://yayunhui-1251820392.cos.ap-beijing.myqcloud.com/zhilizhao/sample/mp4/ipcm-s16.mp4 ___

[FFmpeg-devel] [PATCH] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16

2021-10-29 Thread Zhao Zhili
Use PCM_S16 so the codec_id will be updated later according to bits_per_coded_sample. --- libavformat/isom_tags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c index d0400b18fc..62e60470a8 100644 --- a/libavformat/isom_tag