Re: [FFmpeg-devel] [PATCH v1] avformat/aviobuf: ffio_copy_url_options

2021-12-16 Thread Zane van Iperen
Dedup is always good, lgtm. On 15/12/21 10:35, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Refactors save_avio_options() from dashdec.c and hls.c into a common ffio_copy_url_options() in libavformat/aviobuf.c. C

[FFmpeg-devel] [PATCH] avcodec/cdgraphics: fix transparency handling

2021-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cdgraphics.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/cdgraphics.c b/libavcodec/cdgraphics.c index c9e265fa53..06f8392094 100644 --- a/libavcodec/cdgraphics.c +++ b/libavcodec/cdgraphics.c @@ -68,7 +68,

[FFmpeg-devel] [PATCH 1/2] avcodec/cdgraphics: unbreak rendering of vertical scrolling

2021-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cdgraphics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cdgraphics.c b/libavcodec/cdgraphics.c index 731d800666..c9e265fa53 100644 --- a/libavcodec/cdgraphics.c +++ b/libavcodec/cdgraphics.c @@ -218,7 +218,7 @@ static

[FFmpeg-devel] [PATCH 2/2] avcodec/cdgraphics: fix transparency handling

2021-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cdgraphics.c | 13 +- tests/ref/fate/cdgraphics | 398 +++--- 2 files changed, 206 insertions(+), 205 deletions(-) diff --git a/libavcodec/cdgraphics.c b/libavcodec/cdgraphics.c index c9e265fa53..06f8392094 100644 ---

Re: [FFmpeg-devel] [PATCH v5] fftools/cmdutils: Avoid crash when opts could not be allocated

2021-12-16 Thread Andreas Rheinhardt
Yu Yang: > From: Yu Yang > > If 'opts' could not be allocated, exiting the program to avoid crash when > release it. > > Reported-by: TOTE Robot > Signed-off-by: Yu Yang > --- > fftools/cmdutils.c | 2 +- > fftools/cmdutils.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/mpegvideo: Move closed_gop to Mpeg1Context

2021-12-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Only used there and only by the main thread. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12dec.c | 8 +--- > libavcodec/mpegvideo.c | 1 - > libavcodec/mpegvideo.h | 1 - > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/mp

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpegvideo_enc: Combine some checks

2021-12-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo_enc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index d33cf9477d..4adb95eca7 100644 > --- a/libavcodec/mpegvideo_enc.c

Re: [FFmpeg-devel] [PATCH 02/24] ffmpeg: simplify getting output file size

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > Stop calling avio_size()/avio_tell(), which are potentially heavy > operations and may interfere with muxer operation. Use the recently > introduced bytes_written field instead. > --- > fftools/ffmpeg.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff -

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix DNxHD GC container_ul

2021-12-16 Thread Tomas Härdin
tis 2021-12-14 klockan 16:27 +0100 skrev Nicolas Gaullier: > Signed-off-by: Nicolas Gaullier > --- >  libavformat/mxfenc.c  | 2 +- >  tests/ref/lavf/mxf_opatom | 2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index fcd9a

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: fix DNxHD GC element_type

2021-12-16 Thread Tomas Härdin
tis 2021-12-14 klockan 16:27 +0100 skrev Nicolas Gaullier: > The values for the essence element type were updated in the spec > from 0x05/0x06 (ST2019-4 2008) to 0x0C/0x0D (ST2019-4 2009). > > Fixes ticket #6380. > > Thanks-to: Philip de Nier > Thanks-to: Matthieu Bouron > > Signed-off-by: Nic

Re: [FFmpeg-devel] [PATCH 03/24] ffmpeg: remove a redundant assignment of interrupt_callback

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > It is already set in open_output_file(). > --- > fftools/ffmpeg.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index b77531cb7f..fb017a1e37 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -2947,8 +2947,6 @@ static i

[FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-16 Thread James Almer
Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made in the previous set that need to be discussed and hopefully resolved in a call. The proposals so far to extend the API to support either custom labels for channels are, or so

[FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread James Almer
From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just uint64_t bitmasks. Expanded and completed by Vit

[FFmpeg-devel] [PATCH 002/279 v2] fate: add a channel_layout API test

2021-12-16 Thread James Almer
Signed-off-by: James Almer --- Changes since last time: - Added and adapted some tests to cover the new additions to the API. - Now using the AVBPrint variants of some functions. libavutil/Makefile | 1 + libavutil/tests/channel_layout.c | 233 +++

[FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues

2021-12-16 Thread Alan Kelly
--- libswscale/x86/swscale.c | 14 +++--- tests/checkasm/sw_scale.c | 3 +-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 164b06d6ba..c49a05c37b 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.

Re: [FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues

2021-12-16 Thread Alan Kelly
Thanks Lynne for the patch. On Thu, Dec 16, 2021 at 5:05 PM Alan Kelly wrote: > --- > libswscale/x86/swscale.c | 14 +++--- > tests/checkasm/sw_scale.c | 3 +-- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > in

Re: [FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues

2021-12-16 Thread James Almer
On 12/16/2021 1:05 PM, Alan Kelly wrote: --- libswscale/x86/swscale.c | 14 +++--- tests/checkasm/sw_scale.c | 3 +-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 164b06d6ba..c49a05c37b 100644 --- a/libsw

[FFmpeg-devel] [PATCH] x86/scale_avx2: Change asm indent from 2 to 4 spaces.

2021-12-16 Thread Alan Kelly
--- libswscale/x86/scale_avx2.asm | 96 +-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/libswscale/x86/scale_avx2.asm b/libswscale/x86/scale_avx2.asm index 2cd7e968d3..eb472db12f 100644 --- a/libswscale/x86/scale_avx2.asm +++ b/libswscale/x86/sca

Re: [FFmpeg-devel] [PATCH] x86/scale_avx2: Change asm indent from 2 to 4 spaces.

2021-12-16 Thread James Almer
On 12/16/2021 1:27 PM, Alan Kelly wrote: --- libswscale/x86/scale_avx2.asm | 96 +-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/libswscale/x86/scale_avx2.asm b/libswscale/x86/scale_avx2.asm index 2cd7e968d3..eb472db12f 100644 --- a/libsws

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread Paul B Mahol
You can not use '|' as separator for channel layout definition. Use '+' instead. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add deinterlace_videotoolbox (yadif implementation using Metal.framework)

2021-12-16 Thread Paul B Mahol
Shouldn't filters name be yadif_videotoolbox instead? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread James Almer
On 12/16/2021 2:20 PM, Paul B Mahol wrote: You can not use '|' as separator for channel layout definition. Use '+' instead. Is there a technical reason, or just a preference? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread Paul B Mahol
On Thu, Dec 16, 2021 at 7:28 PM James Almer wrote: > > > On 12/16/2021 2:20 PM, Paul B Mahol wrote: > > You can not use '|' as separator for channel layout definition. > > Use '+' instead. > > Is there a technical reason, or just a preference? > Only for cases when you need to provide multiple c

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread James Almer
On 12/16/2021 3:31 PM, Paul B Mahol wrote: On Thu, Dec 16, 2021 at 7:28 PM James Almer wrote: On 12/16/2021 2:20 PM, Paul B Mahol wrote: You can not use '|' as separator for channel layout definition. Use '+' instead. Is there a technical reason, or just a preference? Only for cases

Re: [FFmpeg-devel] [PATCH 23/24] ffmpeg: simplify the use of OutputStream.frame_number

2021-12-16 Thread Michael Niedermayer
On Wed, Dec 15, 2021 at 08:36:25PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-14 22:13:43) > > On Mon, Dec 13, 2021 at 04:20:41PM +0100, Anton Khirnov wrote: > > > It features in limiting the number of output frames (-frames option) and > > > currently can be incremented fro

[FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-16 Thread Martijn van Beurden
This commit makes ffmpeg create FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is because of a feature request to RAWcooked, apparently the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAW

Re: [FFmpeg-devel] [PATCH 17/24] ffmpeg: do not log to the muxer context

2021-12-16 Thread Michael Niedermayer
On Mon, Dec 13, 2021 at 04:20:35PM +0100, Anton Khirnov wrote: > All other logging goes to NULL context. > --- > fftools/ffmpeg.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index d69e4119ef..afd442ff4e 100644 > --- a/fftools/f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: Use 64 bit in timestamp computation

2021-12-16 Thread Michael Niedermayer
On Thu, Dec 16, 2021 at 11:26:23AM +1100, Peter Ross wrote: > On Wed, Dec 15, 2021 at 06:37:13PM +0100, Michael Niedermayer wrote: > > Fixes: division by zero > > Fixes: > > 42198/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5054366405492736.fuzz > > Fixes: > > 4/clusterfuzz-testcase-m

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Adjust threshold for prores

2021-12-16 Thread Michael Niedermayer
On Wed, Dec 15, 2021 at 06:37:12PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 42072/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PRORES_fuzzer-4957999452520448 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

[FFmpeg-devel] [PATCH v3 1/5] avfilter/vf_yadif_cuda: simplify filter definition

2021-12-16 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- libavfilter/vf_yadif_cuda.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/libavfilter/vf_yadif_cuda.c b/libavfilter/vf_yadif_cuda.c index da1ab5a8ff..685b8a2035 100644 --- a/libavfilter/vf_yadif_cuda.c

[FFmpeg-devel] [PATCH v3 2/5] build: detect Metal.framework and build .metal files

2021-12-16 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- .gitignore | 3 +++ configure | 8 +++- ffbuild/common.mak | 9 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 9ed24b542e..1a5bb29ad5 100644 --- a/.gitignore +++ b/.gi

[FFmpeg-devel] [PATCH v3 3/5] avutil: add obj-c helpers into header-only include

2021-12-16 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- libavutil/objc.h | 32 1 file changed, 32 insertions(+) create mode 100644 libavutil/objc.h diff --git a/libavutil/objc.h b/libavutil/objc.h new file mode 100644 index 00..3ca1303394 --- /dev/null +++

[FFmpeg-devel] [PATCH v3 4/5] avfilter: add metal utilities

2021-12-16 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- libavfilter/metal/utils.h | 35 +++ libavfilter/metal/utils.m | 73 +++ 2 files changed, 108 insertions(+) create mode 100644 libavfilter/metal/utils.h create mode 100644 libavfilter/metal/u

[FFmpeg-devel] [PATCH v3 5/5] avfilter: add vf_deinterlace_videotoolbox

2021-12-16 Thread Aman Karmani
From: Aman Karmani deinterlaces CVPixelBuffers, i.e. AV_PIX_FMT_VIDEOTOOLBOX frames currently implements YADIF, but other algorithms could easily be added to the same filter. for example, an interlaced mpeg2 file can be decoded by avcodec, uploaded into a CVPixelBuffer, deinterlaced by metal, a

Re: [FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-16 Thread Paul B Mahol
use wavpack, this is bad patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 06/24] ffmpeg: move writing the trailer to ffmpeg_mux.c

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/ffmpeg.c | 16 +++- > fftools/ffmpeg.h | 1 + > fftools/ffmpeg_mux.c | 21 + > 3 files changed, 25 insertions(+), 13 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index a00fe58063..1fb10869b4 100644 > --

Re: [FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > This is a first step towards making muxers more independent from the > rest of the code. > --- > fftools/Makefile | 11 +- > fftools/ffmpeg.c | 273 ++-- > fftools/ffmpeg.h | 10 ++ > fftools/ffmpeg_mux.c | 293

Re: [FFmpeg-devel] [PATCH 1/4] avformat/4xm: Consider max_streams on reallocating tracks array

2021-12-16 Thread Michael Niedermayer
On Tue, Dec 07, 2021 at 09:14:08AM +0100, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 41595/clusterfuzz-testcase-minimized-ffmpeg_dem_FOURXM_fuzzer-6355979363549184 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: M

Re: [FFmpeg-devel] [PATCH 09/24] ffmpeg_mux: add private muxer context

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > Move header_written into it, which is not (and should not be) used by > any code outside of ffmpeg_mux. > > In the future this context will contain more muxer-private state that > should not be visible to other code. > --- > fftools/ffmpeg.h | 6 -- > fftools/ffmpeg_mux.

Re: [FFmpeg-devel] [PATCH 1/2] avformat/cinedec: Avoid repeatedly allocating packets beyond the input

2021-12-16 Thread Michael Niedermayer
On Sun, Nov 28, 2021 at 07:55:13PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 41025/clusterfuzz-testcase-minimized-ffmpeg_dem_CINE_fuzzer-5540848285122560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/speexdec: Avoid violating the vector_fmul_scalar() API

2021-12-16 Thread Michael Niedermayer
On Tue, Nov 30, 2021 at 08:59:35PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 40054/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEX_fuzzer-6713285764841472 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ff

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mov: Check next offset in mov_read_dref()

2021-12-16 Thread Michael Niedermayer
On Sat, Dec 04, 2021 at 10:32:58PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036200463215 + 1109914409 cannot be > represented in type 'long' > Fixes: > 41480/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6553086177443840 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 11/24] ffmpeg: set want_sdp when initializing the muxer

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > Allows making the variable local to ffmpeg_mux. > --- > fftools/ffmpeg.c | 9 + > fftools/ffmpeg.h | 1 - > fftools/ffmpeg_mux.c | 5 + > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 3ed1201fda..

Re: [FFmpeg-devel] [PATCH v3 4/5] avfilter: add metal utilities

2021-12-16 Thread Marvin Scholz
On 16 Dec 2021, at 21:28, Aman Karmani wrote: From: Aman Karmani Thanks for your work on this! Some comments inline: Signed-off-by: Aman Karmani --- libavfilter/metal/utils.h | 35 +++ libavfilter/metal/utils.m | 73 +++ 2 files chang

Re: [FFmpeg-devel] [PATCH 16/24] ffmpeg: access output file chapters through a wrapper

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > Avoid accessing the muxer context directly, as this will become > forbidden in future commits. > --- > fftools/ffmpeg.c | 15 +-- > fftools/ffmpeg.h | 2 ++ > fftools/ffmpeg_mux.c | 7 +++ > 3 files changed, 18 insertions(+), 6 deletions(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH 19/24] ffmpeg: fix initial muxing queue size

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > It stores pointers to AVPacket, not AVPackets themselves. > --- > fftools/ffmpeg_mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c > index 5a12a1c899..9281e6c94c 100644 > --- a/fftools/ffmpeg_mux.c > +++ b/f

Re: [FFmpeg-devel] [PATCH v3 4/5] avfilter: add metal utilities

2021-12-16 Thread Marvin Scholz
On 16 Dec 2021, at 23:53, Aman Karmani wrote: On Thu, Dec 16, 2021 at 2:45 PM Marvin Scholz wrote: On 16 Dec 2021, at 21:28, Aman Karmani wrote: From: Aman Karmani Thanks for your work on this! Some comments inline: Signed-off-by: Aman Karmani --- libavfilter/metal/utils.h | 35

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread Marton Balint
On Thu, 16 Dec 2021, James Almer wrote: - Added a 16 byte fixed array to AVChannelCustom to give custom labels to channels in Custom order layouts. These labes will be used by the helpers when querying channels by name or describing the layout. I don't think this is a good idea to use th

Re: [FFmpeg-devel] [PATCH 21/24] ffmpeg_mux: split of_write_packet()

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > It is currently called from two places: > - output_packet() in ffmpeg.c, which submits the newly available output > packet to the muxer > - from of_check_init() in ffmpeg_mux.c after the header has been > written, to flush the muxing queue > > Some packets will thus be process

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-16 Thread Marton Balint
On Thu, 16 Dec 2021, James Almer wrote: Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made in the previous set that need to be discussed and hopefully resolved in a call. Can you push the full branch somewhere? The

Re: [FFmpeg-devel] [PATCH v3 4/5] avfilter: add metal utilities

2021-12-16 Thread Marvin Scholz
On 17 Dec 2021, at 2:14, Aman Karmani wrote: > On Thu, Dec 16, 2021 at 3:13 PM Marvin Scholz wrote: > >> >> >> On 16 Dec 2021, at 23:53, Aman Karmani wrote: >> >>> On Thu, Dec 16, 2021 at 2:45 PM Marvin Scholz >>> wrote: >>> On 16 Dec 2021, at 21:28, Aman Karmani wrote: > From: A

Re: [FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file

2021-12-16 Thread Andreas Rheinhardt
Anton Khirnov: > This is a first step towards making muxers more independent from the > rest of the code. > --- > fftools/Makefile | 11 +- > fftools/ffmpeg.c | 273 ++-- > fftools/ffmpeg.h | 10 ++ > fftools/ffmpeg_mux.c | 293

Re: [FFmpeg-devel] [PATCH 001/279 v2] Add a new channel layout API

2021-12-16 Thread James Almer
On 12/16/2021 8:27 PM, Marton Balint wrote: On Thu, 16 Dec 2021, James Almer wrote: - Added a 16 byte fixed array to AVChannelCustom to give custom  labels to channels in Custom order layouts. These labes will  be used by the helpers when querying channels by name or  describing the layout.

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-16 Thread James Almer
On 12/16/2021 9:04 PM, Marton Balint wrote: On Thu, 16 Dec 2021, James Almer wrote: Resending the first two patches only, since this is meant to show the implementation of one of the several suggestions made in the previous set that need to be discussed and hopefully resolved in a call. C

Re: [FFmpeg-devel] [PATCH] Add 32 bit-per-sample capability to FLAC encoder

2021-12-16 Thread Martijn van Beurden
Could you please explain what makes this a bad patch, so I can try to improve it? Wavpack was already suggested, but using FLAC for archival is preferred because the FLAC standard is currently in the process of becoming an IETF RFC. Op do 16 dec. 2021 om 22:09 schreef Paul B Mahol : > > use wavpa