Re: [FFmpeg-devel] [PATCH V2 2/3] libavcodec/vaapi_encode: Change the way to call async to increase performance

2022-01-04 Thread Chen, Wenbin
> Wenbin Chen: > > Fix: #7706. After commit 5fdcf85bbffe7451c2, vaapi encoder's performance > > decrease. The reason is that vaRenderPicture() and vaSyncBuffer() are > > called at the same time (vaRenderPicture() always followed by a > > vaSyncBuffer()). When we encode stream with B frames, we

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc/arm: dont assign hevc_qpel functions for non-multiple of 8 widths

2022-01-04 Thread Andreas Rheinhardt
J. Dekker: > The assembly is written assuming that the width is a multiple of 8. > > However the real issue is the functions were errorneously assigned to > the 2, 4, 6 & 12 widths. This behaviour never broke the decoder as > samples which trigger the functions for these widths have not been

Re: [FFmpeg-devel] [PATCH v2 0/2] avformat/mvdec: make audio stream conditional

2022-01-04 Thread Peter Ross
On Fri, Dec 31, 2021 at 08:11:46PM -0500, John-Paul Stewart wrote: > Changed in v2: > Allocate the audio stream first to maintain consistent behaviour > with prior code. > > Recent discussion on the list led me to realize that libavformat was > unconditionally creating an audio stream for

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-01-04 Thread Xiang, Haihao
On Tue, 2021-11-16 at 02:21 +, Xiang, Haihao wrote: > > On Wed, 2021-09-22 at 15:42 +0800, Haihao Xiang wrote: > > > Usually a HW decoder is expected when user specifies a HW acceleration > > > method via -hwaccel option, however the current implementation doesn't > > > take HW acceleration

Re: [FFmpeg-devel] [PATCH V2 2/3] libavcodec/vaapi_encode: Change the way to call async to increase performance

2022-01-04 Thread Andreas Rheinhardt
Wenbin Chen: > Fix: #7706. After commit 5fdcf85bbffe7451c2, vaapi encoder's performance > decrease. The reason is that vaRenderPicture() and vaSyncBuffer() are > called at the same time (vaRenderPicture() always followed by a > vaSyncBuffer()). When we encode stream with B frames, we need buffer

[FFmpeg-devel] [PATCH] configure: Make nvenc select atsc_a53

2022-01-04 Thread Andreas Rheinhardt
It is the common code (that is compiled depending upon CONFIG_NVENC) that uses ff_alloc_a53_sei(), so it is natural to make nvenc itself select atsc_a53. This fixes compilation errors in case nvenc is enabled (e.g. autodected) with both nvenc-based encoders disabled. (This works in case of static

[FFmpeg-devel] [PATCH] avcodec/Makefile: Add missing mpegaudiodata.o dependency to MPEGAUDIO

2022-01-04 Thread Andreas Rheinhardt
Before 33e6d57f01dd4742a2e25ac5fa072b487d9d02ce all mpegaudio-decoders had an indirect mpegaudiodata dependency via mpegaudioheader, yet now the latter only needs (and therefore provides) mpegaudiotabs. Given that mpegaudiodec_template.c uses stuff from mpegaudiodata, it should always have had a

Re: [FFmpeg-devel] [PATCH v3] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2022-01-04 Thread Lynne
3 Jan 2022, 21:26 by mva...@gmail.com: > +if (pmax > 0) { > +if (lpc_reduction_tries >= 2) > +return 0; > +lpc_reduction_tries++; > +for (int i = 0; i < order; i++) > +coefs[i] = ((int64_t)coefs[i] * INT32_MAX) / pmax; >

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: fix mp2float and mp3 dependencies

2022-01-04 Thread Andreas Rheinhardt
Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > libavcodec/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 7dc4ccb85f..8cd2d6f849 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@

Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2022-01-04 Thread Xiang, Haihao
On Wed, 2022-01-05 at 00:19 -0300, James Almer wrote: > > On 12/27/2021 12:08 AM, Xiang, Haihao wrote: > > On Thu, 2021-12-23 at 14:01 +, Xiang, Haihao wrote: > > > On Fri, 2021-11-26 at 19:29 +, Soft Works wrote: > > > > > -Original Message- > > > > > From: ffmpeg-devel On

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/imf: fix CPL parsing error handling

2022-01-04 Thread Zane van Iperen
On 5/1/22 12:42, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- libavformat/imf_cpl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c index 7055b49ae8..f49469f56e

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-01-04 Thread Leo Izen
On 1/4/22 11:56, Lynne wrote: 4 Jan 2022, 17:26 by leo.i...@gmail.com: This commit adds support to libavcodec to read and parse encoded Jpeg XL images. Jpeg XL is intended to be an extended-life replacement to legacy mjpeg. --- MAINTAINERS| 2 + +Leo Izen (thebombzen)

[FFmpeg-devel] [PATCH] avcodec/Makefile: fix mp2float and mp3 dependencies

2022-01-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 7dc4ccb85f..8cd2d6f849 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -481,8 +481,8 @@

Re: [FFmpeg-devel] [PATCH v4 1/1] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

2022-01-04 Thread James Almer
On 12/27/2021 12:08 AM, Xiang, Haihao wrote: On Thu, 2021-12-23 at 14:01 +, Xiang, Haihao wrote: On Fri, 2021-11-26 at 19:29 +, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Friday, November 26, 2021 8:12 PM To: FFmpeg development

[FFmpeg-devel] [PATCH V2 3/3] libavcodec/vaapi_encode: Add async_depth to vaapi_encoder to increase performance

2022-01-04 Thread Wenbin Chen
Add async_depth to increase encoder's performance. Reuse encode_fifo as async buffer. Encoder puts all reordered frame to HW and then check fifo size. If fifo < async_depth and the top frame is not ready, it will return AVERROR(EAGAIN) to require more frames. 1080p transcoding (no B frames) with

[FFmpeg-devel] [PATCH V2 2/3] libavcodec/vaapi_encode: Change the way to call async to increase performance

2022-01-04 Thread Wenbin Chen
Fix: #7706. After commit 5fdcf85bbffe7451c2, vaapi encoder's performance decrease. The reason is that vaRenderPicture() and vaSyncBuffer() are called at the same time (vaRenderPicture() always followed by a vaSyncBuffer()). When we encode stream with B frames, we need buffer to reorder frames, so

[FFmpeg-devel] [PATCH V2 1/3] libavcodec/vaapi_encode: Add new API adaption to vaapi_encode

2022-01-04 Thread Wenbin Chen
Add vaSyncBuffer to VAAPI encoder. Old version API vaSyncSurface wait surface to complete. When surface is used for multiple operation, it waits all operations to finish. vaSyncBuffer only wait one channel to finish. Add wait param to vaapi_encode_wait() to prepare for the async_depth option.

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix CPL parsing error handling

2022-01-04 Thread Pierre-Anthony Lemieux
On Tue, Jan 4, 2022 at 4:58 PM Zane van Iperen wrote: > > > > On 4/1/22 16:10, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > libavformat/imf_cpl.c | 51 +++ > > 1 file changed, 27

[FFmpeg-devel] [PATCH v2 2/2] avformat/imf: Fix indentation

2022-01-04 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- libavformat/imf_cpl.c | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c index f49469f56e..32e805cdd4 100644 ---

[FFmpeg-devel] [PATCH v2 1/2] avformat/imf: fix CPL parsing error handling

2022-01-04 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- libavformat/imf_cpl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c index 7055b49ae8..f49469f56e 100644 --- a/libavformat/imf_cpl.c +++

Re: [FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

2022-01-04 Thread Lynne
4 Jan 2022, 21:06 by mich...@niedermayer.cc: > maintainer part inspired by IRC comments by lynne > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix bad free() when directory name of the input url is empty

2022-01-04 Thread Zane van Iperen
On 5/1/22 11:44, Pierre-Anthony Lemieux wrote: On Tue, Jan 4, 2022 at 5:39 PM Zane van Iperen wrote: On 4/1/22 01:59, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Found through manual fuzzing. libavformat/imfdec.c |

[FFmpeg-devel] [PATCH] lavfi/libplacebo: support dovi metadata application

2022-01-04 Thread Niklas Haas
From: Niklas Haas libplacebo supports automatic dolby vision application, but it requires us to switch to a new API. Also add some logic to strip the dolby vision metadata from the output frames in any case where we end up changing the colorimetry. The libplacebo dependency bump is justified

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Ming Qian
> -Original Message- > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > Sent: Wednesday, January 5, 2022 6:58 AM > To: Ming Qian > Cc: FFmpeg development discussions and patches > Subject: Re: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: > resume the decoding

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix bad free() when directory name of the input url is empty

2022-01-04 Thread Pierre-Anthony Lemieux
On Tue, Jan 4, 2022 at 5:39 PM Zane van Iperen wrote: > > > > On 4/1/22 01:59, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > > > Notes: > > Found through manual fuzzing. > > > > libavformat/imfdec.c | 6 +- > > 1

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix bad free() when directory name of the input url is empty

2022-01-04 Thread Zane van Iperen
On 4/1/22 01:59, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Found through manual fuzzing. libavformat/imfdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/imfdec.c

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration

2022-01-04 Thread lance . lmwang
On Tue, Jan 04, 2022 at 10:17:17PM -0300, James Almer wrote: > > > On 1/4/2022 10:15 PM, lance.lmw...@gmail.com wrote: > > On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: > > > > > > > On Jan 4, 2022, at 3:43 AM, lance.lmw...@gmail.com wrote: > > > > > > > > From: Limin Wang >

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration

2022-01-04 Thread James Almer
On 1/4/2022 10:15 PM, lance.lmw...@gmail.com wrote: On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: On Jan 4, 2022, at 3:43 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Please reproduced with the following minimal configure command: ./configure --enable-shared

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration

2022-01-04 Thread lance . lmwang
On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: > > > On Jan 4, 2022, at 3:43 AM, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > Please reproduced with the following minimal configure command: > > ./configure --enable-shared --disable-all --enable-avcodec > >

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix CPL parsing error handling

2022-01-04 Thread Zane van Iperen
On 4/1/22 16:10, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- libavformat/imf_cpl.c | 51 +++ 1 file changed, 27 insertions(+), 24 deletions(-) Could you please resend this as two separate

[FFmpeg-devel] [PATCH] Changelog: add IMF demuxer

2022-01-04 Thread Zane van Iperen
Suggested-By: Pierre-Anthony Lemieux Signed-off-by: Zane van Iperen --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index edb4152d0f..8e11fe6d35 100644 --- a/Changelog +++ b/Changelog @@ -44,6 +44,7 @@ version : - yadif_videotoolbox filter -

Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix error CPL root element is absent

2022-01-04 Thread Zane van Iperen
On 4/1/22 16:11, p...@sandflow.com wrote: cpl_element = xmlDocGetRootElement(doc); -if (xmlStrcmp(cpl_element->name, "CompositionPlaylist")) { +if ((!cpl_element) || xmlStrcmp(cpl_element->name, "CompositionPlaylist")) { Nit: Extra set of parens around "!cpl_element".

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration

2022-01-04 Thread Cameron Gutman
> On Jan 4, 2022, at 3:43 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Please reproduced with the following minimal configure command: > ./configure --enable-shared --disable-all --enable-avcodec > --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox > > You'll get below

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:48, Andriy Gelman wrote: > Hi Ming, > > On Tue, 04. Jan 07:51, Ming Qian wrote: > > > > > -Original Message- > > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > > Sent: Monday, January 3, 2022 12:41 AM > > > To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
Hi Ming, On Tue, 04. Jan 07:51, Ming Qian wrote: > > > -Original Message- > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > Sent: Monday, January 3, 2022 12:41 AM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian > > Subject: [EXT] Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH v5 5/7] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > client need to resume the decoding process > after it dequeues the source change event. > no matter what's the return value of v4l2_resolution_changed(). > if the client doesn't resume the decoding process, > the decoder may keep waiting > > in

Re: [FFmpeg-devel] [PATCH v5 3/7] avcodec/v4l2_context: add v4l2_start_decode

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > on dynamic resolution change, > The decoding process must be resumed with either a pair of calls to > VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on the CAPTURE queue, or a call > to VIDIOC_DECODER_CMD() with the V4L2_DEC_CMD_START command. > For the patch

Re: [FFmpeg-devel] [PATCH v5 1/7] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2022-01-04 Thread Andriy Gelman
On Tue, 04. Jan 17:08, Ming Qian wrote: > in the v4l2 stateful video document, we can see the following > description: > During the resolution change sequence, the OUTPUT queue must remain > streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would > abort the sequence and

[FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

2022-01-04 Thread Michael Niedermayer
maintainer part inspired by IRC comments by lynne Signed-off-by: Michael Niedermayer --- doc/developer.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index addee0d8263..eae3ade48a7 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-01-04 Thread Leo Izen
On 1/4/22 11:56, Lynne wrote: 4 Jan 2022, 17:26 by leo.i...@gmail.com: This commit adds support to libavcodec to read and parse encoded Jpeg XL images. Jpeg XL is intended to be an extended-life replacement to legacy mjpeg. --- MAINTAINERS| 2 + +Leo Izen (thebombzen)

Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups

2022-01-04 Thread Gyan Doshi
On 2022-01-04 09:58 pm, Diederick C. Niehorster wrote: Hi Gyan, On Tue, Jan 4, 2022 at 1:05 PM Gyan Doshi wrote: On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi wrote: On 2022-01-04 05:02 am, Roger Pack wrote: These LGTM. Feel free to

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-01-04 Thread Lynne
4 Jan 2022, 17:26 by leo.i...@gmail.com: > This commit adds support to libavcodec to read and parse > encoded Jpeg XL images. Jpeg XL is intended to be an > extended-life replacement to legacy mjpeg. > --- > MAINTAINERS| 2 + > libavcodec/Makefile| 1 + >

Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups

2022-01-04 Thread Diederick C. Niehorster
Hi Gyan, On Tue, Jan 4, 2022 at 1:05 PM Gyan Doshi wrote: > > On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: > > On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi wrote: > >> On 2022-01-04 05:02 am, Roger Pack wrote: > >>> These LGTM. Feel free to add yourself as a dshow maintainer if so > >>>

[FFmpeg-devel] [PATCH v2 5/5] fate/jpegxl: add JPEG XL demux and parse FATE test

2022-01-04 Thread Leo Izen
Add a fate test for the JPEG XL parser in libavcodec and its image2 wrapper inside libavformat. --- tests/fate/image.mak| 10 ++ tests/ref/fate/jxl-parse-codestream | 6 ++ tests/ref/fate/jxl-parse-container | 6 ++ 3 files changed, 22 insertions(+) create mode

[FFmpeg-devel] [PATCH v2 4/5] avformat/image2: add Jpeg XL as image2 format

2022-01-04 Thread Leo Izen
This commit adds support to libavformat for muxing and demuxing Jpeg XL images as image2 streams. --- libavformat/allformats.c | 1 + libavformat/img2.c | 1 + libavformat/img2dec.c| 19 +++ libavformat/img2enc.c| 6 +++--- libavformat/mov.c| 1 +

[FFmpeg-devel] [PATCH v2 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-01-04 Thread Leo Izen
This commit adds encoding support to libavcodec for Jpeg XL images via the external library libjxl. --- configure | 3 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 383 + 4 files changed, 387

[FFmpeg-devel] [PATCH v2 2/5] avcodec/libjxl: add Jpeg XL decoding via libjxl

2022-01-04 Thread Leo Izen
This commit adds decoding support to libavcodec for Jpeg XL images via the external library libjxl. --- MAINTAINERS | 1 + configure | 5 + doc/general_contents.texi | 7 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 +

[FFmpeg-devel] [PATCH v2 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-01-04 Thread Leo Izen
This commit adds support to libavcodec to read and parse encoded Jpeg XL images. Jpeg XL is intended to be an extended-life replacement to legacy mjpeg. --- MAINTAINERS| 2 + libavcodec/Makefile| 1 + libavcodec/codec_desc.c| 9 + libavcodec/codec_id.h | 1

[FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-04 Thread Lynne
Since I couldn't find a codename preference, I went with "Desitter" (even though the correct spelling is "De Sitter"). There's a joke in here that if we mess up and need a 5.1 release quickly, we could codename it "anti-Desitter" :) The release notes go as follows:     FFmpeg 5.0 "Desitter", a

Re: [FFmpeg-devel] Optimize Mpeg4 decoding for loongarch

2022-01-04 Thread Michael Niedermayer
On Mon, Jan 03, 2022 at 07:24:32PM +0800, 殷时友 wrote: > > > 2021年12月29日 下午6:18,Hao Chen 写道: > > > > ./ffmpeg -i 8_mpeg4_1080p_24fps_12Mbps.avi -f rawvideo -y /dev/null -an > > before:376fps > > after :552fps > > > > V2: Revised PATCH 1/3 according to the comments. > > V3: Resubmit these patches

Re: [FFmpeg-devel] Pixel format support fixes in swscale and drawutils

2022-01-04 Thread Michael Niedermayer
On Fri, Dec 24, 2021 at 07:17:10PM +0100, Michael Niedermayer wrote: > On Thu, Dec 23, 2021 at 09:08:48PM -0600, rcombs wrote: > > This patchset is also available as a GitHub pull request for review > > simplicity: > > https://github.com/FFmpeg/FFmpeg/pull/380 > > > > - Reduce hardcoding of

[FFmpeg-devel] [PATCH] avfilter/vf_showinfo: Fix printf format specifier

2022-01-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- The type of nlq_offset was changed in v11 compared to v10, leading to this. Sorry. libavfilter/vf_showinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index

[FFmpeg-devel] [PATCH] Adds DVD protocol

2022-01-04 Thread Lucien Murray-Pitts
Copies the Bluray protocol but uses libdvdnav to add simple DVD protocol support.Since title selection is mandatory, ffprobe cant provide information for the complete disk but a single title only. Chapter information for probe will also be missing. To see a complete disk catalog the

[FFmpeg-devel] [PATCH 2/2] lavfi/showinfo: fix printf precision for dovi metadata

2022-01-04 Thread Niklas Haas
From: Niklas Haas Fix warning caused by this field changing from uint64_t to uint16_t. Signed-off-by: Niklas Haas --- libavfilter/vf_showinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index

[FFmpeg-devel] [PATCH 1/2] lavfi/libplacebo: apply dovi metadata correctly

2022-01-04 Thread Niklas Haas
From: Niklas Haas libplacebo supports dolby vision application, but it requires some help from us to set a sensible default output color space, and also strip the dolby vision metadata from the output frame. Failing to do the latter results in an error inside libplacebo. (It can't encode back

Re: [FFmpeg-devel] [PATCH v3 6/6] lavc/aarch64: add hevc sao band 8x8 tiling

2022-01-04 Thread J. Dekker
On 4 Jan 2022, at 10:41, Martin Storsjö wrote: > On Tue, 4 Jan 2022, J. Dekker wrote: > > [...] > > LGTM, please push. > > // Martin > Thanks, pushed. -- J. Dekker ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups

2022-01-04 Thread Gyan Doshi
On 2022-01-04 04:06 pm, Diederick C. Niehorster wrote: On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi wrote: On 2022-01-04 05:02 am, Roger Pack wrote: These LGTM. Feel free to add yourself as a dshow maintainer if so interested, as well! :) I assume these need to be pushed too. Yes thanks,

Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups

2022-01-04 Thread Diederick C. Niehorster
On Tue, Jan 4, 2022 at 5:10 AM Gyan Doshi wrote: > On 2022-01-04 05:02 am, Roger Pack wrote: > > These LGTM. Feel free to add yourself as a dshow maintainer if so > > interested, as well! :) > > I assume these need to be pushed too. Yes thanks, please push. Would be good to get in before the

Re: [FFmpeg-devel] Build break: VideoToolbox VP9 support breaks H.264-only build

2022-01-04 Thread lance . lmwang
On Mon, Jan 03, 2022 at 01:18:34PM -0600, Cameron Gutman wrote: > I am building minimal ffmpeg libraries for my application using the following > configure command: > > ./configure --enable-shared --disable-all --enable-avcodec > --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox > >

[FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration

2022-01-04 Thread lance . lmwang
From: Limin Wang Please reproduced with the following minimal configure command: ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox You'll get below error: Undefined symbols for architecture x86_64:

Re: [FFmpeg-devel] [PATCH v3 6/6] lavc/aarch64: add hevc sao band 8x8 tiling

2022-01-04 Thread Martin Storsjö
On Tue, 4 Jan 2022, J. Dekker wrote: --bench on AWS Graviton: hevc_sao_band_8x8_8_c: 317.5 hevc_sao_band_8x8_8_neon: 97.5 hevc_sao_band_16x16_8_c: 1115.0 hevc_sao_band_16x16_8_neon: 322.7 hevc_sao_band_32x32_8_c: 4599.2 hevc_sao_band_32x32_8_neon: 1246.2 hevc_sao_band_48x48_8_c: 10021.7

Re: [FFmpeg-devel] [PATCH] avformat/tests/imf: Don't use uninitialized value

2022-01-04 Thread Zane van Iperen
On 4/1/22 19:25, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- I'll apply this pretty soon. lgtm, Please do. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH] doc/encoders.texi Add doc for qsv

2022-01-04 Thread Wenbin Chen
Add doc for qsv decoder. Add more option's introduction to qsv encoder. Signed-off-by: Wenbin Chen --- doc/decoders.texi | 42 doc/encoders.texi | 253 +- 2 files changed, 292 insertions(+), 3 deletions(-) diff --git a/doc/decoders.texi

[FFmpeg-devel] [PATCH] avformat/tests/imf: Don't use uninitialized value

2022-01-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- I'll apply this pretty soon. libavformat/tests/imf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c index 68e4c8b6af..142aa04261 100644 --- a/libavformat/tests/imf.c +++

Re: [FFmpeg-devel] [PATCH v10 6/6] lavc/hevcdec: Parse DOVI RPU NALs

2022-01-04 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > And expose the parsed values as frame side data. Update FATE results to > match. > > It's worth documenting that this relies on the dovi configuration record > being present on the first AVPacket fed to the decoder, which in > practice is the case if if the

Re: [FFmpeg-devel] [PATCH v10 4/6] lavc: Implement Dolby Vision RPU parsing

2022-01-04 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > Based on a mixture of guesswork, partial documentation in patents, and > reverse engineering of real-world samples. Confirmed working for all the > samples I've thrown at it. > > Contains some annoying machinery to persist these values in between > frames,

[FFmpeg-devel] [PATCH v5 5/7] avcodec/v4l2_context: resume the decoding process after source change event received.

2022-01-04 Thread Ming Qian
client need to resume the decoding process after it dequeues the source change event. no matter what's the return value of v4l2_resolution_changed(). if the client doesn't resume the decoding process, the decoder may keep waiting in documentation of v4l2 stateful decoder, we can see the following

[FFmpeg-devel] [PATCH v5 4/7] avcodec/v4l2_context: set resolution change if decoded format changed

2022-01-04 Thread Ming Qian
The dynamic resoltuion change occurs when he decoder detects a coded frame with one or more of the following parameters different from those previously established (and reflected by corresponding queries): 1. coded resolution (OUTPUT width and height) 2. visible resolution (selection rectangles)

[FFmpeg-devel] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-01-04 Thread Ming Qian
there are two proper ways to setup capture queue. 1. client wait the source change event, then setup the capture queue and streamon 2. client setup the capture queue in advance, but to avoid time issues, client should start the capture queue before it enqueue the sequence header to

[FFmpeg-devel] [PATCH v5 3/7] avcodec/v4l2_context: add v4l2_start_decode

2022-01-04 Thread Ming Qian
on dynamic resolution change, The decoding process must be resumed with either a pair of calls to VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on the CAPTURE queue, or a call to VIDIOC_DECODER_CMD() with the V4L2_DEC_CMD_START command. Signed-off-by: Ming Qian --- libavcodec/v4l2_context.c | 18

[FFmpeg-devel] [PATCH v5 6/7] avcodec/v4l2_context: sync v4l2 context status with driver.

2022-01-04 Thread Ming Qian
Check v4l2 context before call VIDIOC_STREAMON() or VIDIOC_STREAMOFF(). Signed-off-by: Ming Qian --- libavcodec/v4l2_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index b7b584dfbef6..8910ae08d3a5 100644 ---

[FFmpeg-devel] [PATCH v5 2/7] avcodec/v4l2_m2m: remove ff_v4l2_m2m_codec_full_reinit

2022-01-04 Thread Ming Qian
ff_v4l2_m2m_codec_full_reinit is not used any more, so remove it. Signed-off-by: Ming Qian --- libavcodec/v4l2_m2m.c | 76 --- libavcodec/v4l2_m2m.h | 10 -- 2 files changed, 86 deletions(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c

[FFmpeg-devel] [PATCH v5 1/7] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2022-01-04 Thread Ming Qian
in the v4l2 stateful video document, we can see the following description: During the resolution change sequence, the OUTPUT queue must remain streaming. Calling VIDIOC_STREAMOFF() on the OUTPUT queue would abort the sequence and initiate a seek. In principle, the OUTPUT queue

Re: [FFmpeg-devel] [PATCH v11] lavu/frame: Add Dolby Vision metadata side data type

2022-01-04 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > Yeah, I think I agree that this is probably the best compromise here. > > Updated documentation (and also changed one unnecessarily-large uint64_t > to uint16_t) > > --- > In order to be able to extend this struct later (as the Dolby Vision RPU > evolves),

Re: [FFmpeg-devel] [PATCH v1] lavc/av1dec: use frame split bsf

2022-01-04 Thread Xiang, Haihao
On Tue, 2021-12-28 at 06:00 +, Xiang, Haihao wrote: > On Wed, 2021-12-15 at 16:06 +0800, Fei Wang wrote: > > Split packed data in case of its contains multiple show frame in some > > non-standard bitstream. This can benefit decoder which can decode > > continuously instead of interrupt with

Re: [FFmpeg-devel] [PATCH v2] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11)

2022-01-04 Thread Xiang, Haihao
On Sun, 2022-01-02 at 03:41 +, ffmpegagent wrote: > From: softworkz > > Commit 8b83dad82512a6948b63408f964463b063ad24c9 introduced a > regression in a way that scaling via vpp_qsv doesn't work any longer > for devices with an MSDK runtime version lower than 1.19. This is true > for older