Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: let avio_read can retry when timeout

2022-01-13 Thread zhilizhao(赵志立)
> On Jan 14, 2022, at 12:50 PM, Wang Chuan wrote: > > I just try to use avio to read stream by http protocol. > > But if the server responds too late, avio_read will return timeout, and the > only way I can do is close it and reopen. > > Of course I can set a large timeout, but it's hard to

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: let avio_read can retry when timeout

2022-01-13 Thread Wang Chuan
I just try to use avio to read stream by http protocol. But if the server responds too late, avio_read will return timeout, and the only way I can do is close it and reopen. Of course I can set a large timeout, but it's hard to decide which timeout value is large enough. On 2022/1/14

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: let avio_read can retry when timeout

2022-01-13 Thread zhilizhao(赵志立)
> On Jan 14, 2022, at 10:42 AM, Wang Chuan wrote: > > If we meet timeout when reading network resource, avio_read will set > [eof_reached] to 1. And this prevent caller to retry since avio_read > do nothing and just return if eof_reached == 1. If timeout was triggered by a small ‘timeout’

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-13 Thread lance . lmwang
On Fri, Jan 14, 2022 at 12:01:26AM +0200, Martin Storsjö wrote: > On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc > > -frames:v 1 -bsf trace_headers -f null - > > > > before the

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-13 Thread lance . lmwang
On Thu, Jan 13, 2022 at 11:57:36PM +0200, Martin Storsjö wrote: > On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > If the version of libopenh264 >= 1.8, we can't configured main profile as > > expected, below is the testing cli: > > > > ffmpeg -y -f lavfi -i

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-13 Thread lance . lmwang
On Thu, Jan 13, 2022 at 11:35:32PM +0200, Martin Storsjö wrote: > On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/libopenh264enc.c | 15 +++ > > 1 file changed, 15 insertions(+) > > > > diff --git

[FFmpeg-devel] [PATCH] avformat/aviobuf: let avio_read can retry when timeout

2022-01-13 Thread Wang Chuan
If we meet timeout when reading network resource, avio_read will set [eof_reached] to 1. And this prevent caller to retry since avio_read do nothing and just return if eof_reached == 1. Signed-off-by: Wang Chuan --- libavformat/aviobuf.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-13 Thread Kyle Swanson
Hi, On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt wrote: > 1. FFmpeg uses the ancient C90 rule that only allows variable > declarations at the beginning of a block (before all statements). You > should actually have received a compiler warning because of the above > code (unless you use

[FFmpeg-devel] [PATCH 24/24] doc/APIchanges: update for subtitle filtering changes

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 24 libavcodec/version.h | 2 +- libavutil/version.h | 2 +- 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 8df0364e4c..c8238fb008 100644 ---

[FFmpeg-devel] [PATCH 23/24] avcodec/webvttenc: convert hard-space tags to

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavcodec/webvttenc.c | 6 ++ tests/ref/fate/sub-webvttenc | 10 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c index c0436f5739..48945dcb8e 100644 ---

[FFmpeg-devel] [PATCH 22/24] avutil/ass_split: Add parsing of hard-space tags (\h)

2022-01-13 Thread ffmpegagent
From: softworkz The \h tag in ASS/SSA is indicating a non-breaking space. See https://github.com/Aegisub/aegisite/blob/master/source/docs/3.2/ ASS_Tags.html.md The ass_split implementation is used by almost all text subtitle encoders and it didn't handle this tag. Interestingly, several tests

[FFmpeg-devel] [PATCH 20/24] avfilter/subfeed: add subtitle feed filter

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_subfeed.c | 366 +++ 3 files changed, 368 insertions(+) create mode 100644 libavfilter/sf_subfeed.c diff --git

[FFmpeg-devel] [PATCH 19/24] avfilter/subscale: Add filter for scaling and/or re-arranging graphical subtitles

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- configure | 1 + doc/filters.texi | 164 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_subscale.c | 884 ++ 5 files changed, 1051

[FFmpeg-devel] [PATCH 18/24] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- configure|1 + doc/filters.texi | 55 ++ libavfilter/Makefile |2 + libavfilter/allfilters.c |1 + libavfilter/sf_graphicsub2text.c | 1132 ++ 5

[FFmpeg-devel] [PATCH 17/24] avfilter/splitcc: Add splitcc filter for closed caption handling

2022-01-13 Thread ffmpegagent
From: softworkz - splitcc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams /ts/CC/NewsStream-608-ac3.ts" -filter_complex "[0:v]splitcc[vid1],

[FFmpeg-devel] [PATCH 16/24] avfilter/stripstyles: Add stripstyles filter

2022-01-13 Thread ffmpegagent
From: softworkz - stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 37 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 209

[FFmpeg-devel] [PATCH 15/24] avfilter/textmod: Add textmod, censor and show_speaker filters

2022-01-13 Thread ffmpegagent
From: softworkz - textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 206

[FFmpeg-devel] [PATCH 14/24] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

2022-01-13 Thread ffmpegagent
From: softworkz - overlaytextsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure| 2 + doc/filters.texi | 113 ++

[FFmpeg-devel] [PATCH 13/24] avfilter/overlaygraphicsubs: Add overlaygraphicsubs and graphicsub2video filters

2022-01-13 Thread ffmpegagent
From: softworkz - overlaygraphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz ---

[FFmpeg-devel] [PATCH 08/24] fftools/play, probe: Adjust for subtitle changes

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 47 + 2 files changed, 77 insertions(+), 72 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e7b20be76b..94286eb678

[FFmpeg-devel] [PATCH 07/24] avcodec/subtitles: Replace deprecated enum values

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavcodec/ass.h | 2 +- libavcodec/assdec.c| 2 +- libavcodec/dvbsubdec.c | 2 +- libavcodec/dvdsubdec.c | 2 +- libavcodec/dvdsubenc.c | 2 +- libavcodec/pgssubdec.c | 2 +- libavcodec/xsubdec.c | 2 +- 7 files changed, 7

[FFmpeg-devel] [PATCH 06/24] avcodec/subtitles: Migrate subtitle encoders to frame-based API

2022-01-13 Thread ffmpegagent
From: softworkz and provide a compatibility shim for the legacy api Signed-off-by: softworkz --- libavcodec/assenc.c| 189 ++--- libavcodec/avcodec.h | 5 +- libavcodec/dvbsubenc.c | 96 ++- libavcodec/dvdsubenc.c | 102

[FFmpeg-devel] [PATCH 12/24] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 54 ++ libavfilter/buffersink.h | 7 libavfilter/buffersrc.c | 72

[FFmpeg-devel] [PATCH 11/24] avfilter/avfilter: Fix hardcoded input index

2022-01-13 Thread ffmpegagent
From: softworkz This fix targets (rare) cases where multiple input pads have a .filter_frame function. ff_request_frame_to_filter needs to call ff_request_frame with the correct input pad instead of the hardcoded first one. Signed-off-by: softworkz --- libavfilter/avfilter.c | 18

[FFmpeg-devel] [PATCH 05/24] avcodec, avutil: Move ass helper functions to avutil as avpriv_ and extend ass dialog parsing

2022-01-13 Thread ffmpegagent
From: softworkz Also add - hard_space callback (for upcoming fix) - extensible callback (for future extension) Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++ libavcodec/ass.h | 144 ++ libavcodec/assdec.c

[FFmpeg-devel] [PATCH 10/24] avfilter/avfilter: Handle subtitle frames

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfilter.h | 11 +++ libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 22 ++ libavfilter/formats.h | 3 +++ libavfilter/internal.h

[FFmpeg-devel] [PATCH 09/24] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2022-01-13 Thread ffmpegagent
From: softworkz Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH 04/24] avfilter/subtitles: Update vf_subtitles to use new decoding api

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavfilter/vf_subtitles.c | 56 +- 1 file changed, 43 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index 3fc4eeb63d..25e217e845 100644 ---

[FFmpeg-devel] [PATCH 03/24] avcodec/subtitles: Introduce new frame-based subtitle decoding API

2022-01-13 Thread ffmpegagent
From: softworkz - Add avcodec_decode_subtitle3 which takes subtitle frames, serving as compatibility shim to legacy subtitle decoding - Add additional methods for conversion between old and new API Signed-off-by: softworkz --- libavcodec/avcodec.h| 8 +- libavcodec/codec_desc.c | 11

[FFmpeg-devel] [PATCH 02/24] avutil/frame: Prepare AVFrame for subtitle handling

2022-01-13 Thread ffmpegagent
From: softworkz Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame -

[FFmpeg-devel] [PATCH 01/24] avcodec, avutil: Move enum AVSubtitleType to avutil, add new and deprecate old values

2022-01-13 Thread ffmpegagent
From: softworkz Signed-off-by: softworkz --- libavcodec/avcodec.h | 19 + libavutil/Makefile | 1 + libavutil/subfmt.h | 68 libavutil/version.h | 1 + 4 files changed, 71 insertions(+), 18 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH 00/24] Subtitle Filtering 2022

2022-01-13 Thread ffmpegagent
Subtitle Filtering 2022 === This is a substantial update to the earlier subtitle filtering patch series. A primary goal has been to address others' concerns as much as possible on one side and to provide more clarity and control over the way things are working. Clarity is is

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-13 Thread Martin Storsjö
On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null - before the patch: entropy_coding_mode_flag0 = 1 after the patch:

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-13 Thread Martin Storsjö
On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing cli: ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -frames:v 1 test.ts It'll report: [libopenh264 @

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-13 Thread Martin Storsjö
On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..a55bef8 100644 ---

Re: [FFmpeg-devel] [PATCH 277/281] ffmpeg: convert to new channel layout-API

2022-01-13 Thread James Almer
On 1/13/2022 3:40 PM, James Almer wrote: On 1/13/2022 3:29 PM, Michael Niedermayer wrote: On Wed, Jan 12, 2022 at 11:09:09PM -0300, James Almer wrote: Signed-off-by: James Almer ---   fftools/cmdutils.c    | 42 +++-   fftools/cmdutils.h    |  8 -  

Re: [FFmpeg-devel] [PATCH 31/35] lavu/threadmessage: switch to new FIFO API

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > --- > libavutil/threadmessage.c | 34 +- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c > index 764b7fb813..39d3525a78 100644 > --- a/libavutil/threadmessage.c > +++

Re: [FFmpeg-devel] [PATCH 26/35] lavf/udp: switch to new FIFO API

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > --- > libavformat/udp.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/libavformat/udp.c b/libavformat/udp.c > index 83c042d079..4c8f104d9d 100644 > --- a/libavformat/udp.c > +++ b/libavformat/udp.c > @@ -500,7 +500,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/rawvideodec: check packet size

2022-01-13 Thread Michael Niedermayer
On Fri, Jan 07, 2022 at 05:51:11PM +0100, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: integer overflow > Fixes: > 43347/clusterfuzz-testcase-minimized-ffmpeg_dem_V210X_fuzzer-5846911637127168 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 277/281] ffmpeg: convert to new channel layout-API

2022-01-13 Thread James Almer
On 1/13/2022 3:29 PM, Michael Niedermayer wrote: On Wed, Jan 12, 2022 at 11:09:09PM -0300, James Almer wrote: Signed-off-by: James Almer --- fftools/cmdutils.c| 42 +++- fftools/cmdutils.h| 8 - fftools/ffmpeg.c | 47

Re: [FFmpeg-devel] [PATCH 277/281] ffmpeg: convert to new channel layout-API

2022-01-13 Thread Michael Niedermayer
On Wed, Jan 12, 2022 at 11:09:09PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/cmdutils.c| 42 +++- > fftools/cmdutils.h| 8 - > fftools/ffmpeg.c | 47 -- > fftools/ffmpeg.h

Re: [FFmpeg-devel] [PATCH 12/35] lavc/avcodec: switch to new FIFO API

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > --- > libavcodec/avcodec.c | 15 ++- > libavcodec/decode.c | 22 -- > 2 files changed, 14 insertions(+), 23 deletions(-) > > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c > index c00a9b2af8..a75bbe721f 100644 > ---

Re: [FFmpeg-devel] [PATCH 09/35] lavu/fifo: add a flag for automatically growing the FIFO as needed

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > This will not increase the FIFO beyond 1MB, unless the caller explicitly > specifies otherwise. > --- > doc/APIchanges | 3 ++- > libavutil/fifo.c | 41 +++-- > libavutil/fifo.h | 15 ++- > 3 files changed, 55 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 08/35] lavu/fifo: add new FIFO read/peek functions

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > As for writing, use separate functions for reading to a buffer and a > callback. Allow the callbacks to limit the amount of data read, > similarly to what is done for writing. > > Consistently use size_t for sizes. > --- > doc/APIchanges | 3 ++- > libavutil/fifo.c | 68

Re: [FFmpeg-devel] [PATCH 07/35] lavu/fifo: add new FIFO writing functions

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > Use separate functions for writing from a buffer and a callback, since > the overwhelming majority of callers use a buffer and should not be > forced to pass extra NULL parameters or use a longer name. > > Consistently use size_t for sizes. > --- > doc/APIchanges | 2 +- >

Re: [FFmpeg-devel] [PATCH 05/35] lavu/fifo: add a new FIFO grow function

2022-01-13 Thread James Almer
On 1/11/2022 5:45 PM, Anton Khirnov wrote: Consistently use size_t for sizes. Unlike av_fifo_grow(), which addds to the currently used size, this function adds to the allocated size. No new function is provided for a generic realloc, since the current code only supports increasing the FIFO

Re: [FFmpeg-devel] [PATCH 03/35] lavu/fifo: introduce the notion of element size

2022-01-13 Thread James Almer
On 1/11/2022 5:45 PM, Anton Khirnov wrote: +/** + * Allocate and initialize an AVFifoBuffer with a given element size. + * + * @param f pointer to the newly-allocated FIFO will be written here on success + * @param nb_elems initial number of elements that can be stored in the FIFO + * @param

Re: [FFmpeg-devel] [PATCH 03/35] lavu/fifo: introduce the notion of element size

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > Many AVFifoBuffer users operate on fixed-size elements (e.g. pointers), > but the current FIFO API deals exclusively in bytes, requiring extra > complexity in all these callers. > > Add a new AVFifoBuffer constructor creating a FIFO with an element size > that may be larger than

[FFmpeg-devel] [PATCH] avutil/fifo: Use av_fifo_generic_peek_at() for av_fifo_generic_peek()

2022-01-13 Thread Andreas Rheinhardt
Avoids code duplication. It furthermore properly checks for buf_size to be > 0 before doing anything. Signed-off-by: Andreas Rheinhardt --- It also avoids having to update yet another function when the FIFO implementation is updated. I pondered changing av_fifo_generic_read() to int ret =

Re: [FFmpeg-devel] [PATCH 01/35] lavu/fifo: disallow overly large fifo sizes

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2022-01-13 14:59:49) >> Anton Khirnov: >>> The API currently allows creating FIFOs up to >>> - UINT_MAX: av_fifo_alloc(), av_fifo_realloc(), av_fifo_grow() >>> - SIZE_MAX: av_fifo_alloc_array() >>> However the usable limit is determined by >>> -

Re: [FFmpeg-devel] [PATCH 01/35] lavu/fifo: disallow overly large fifo sizes

2022-01-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-01-13 14:59:49) > Anton Khirnov: > > The API currently allows creating FIFOs up to > > - UINT_MAX: av_fifo_alloc(), av_fifo_realloc(), av_fifo_grow() > > - SIZE_MAX: av_fifo_alloc_array() > > However the usable limit is determined by > > - rndx/wndx being uint32_t

Re: [FFmpeg-devel] [PATCH 02/35] lavu/fifo: make the contents of AVFifoBuffer private on next major bump

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > There should be no good reason for the callers to access any of its > contents. > > Define a new type for the internal struct that currently matches > AVFifoBuffer. This will allow adding new private fields without waiting > for the major bump and will be useful in the following

Re: [FFmpeg-devel] [PATCH 13/35] lavc/amfenc: switch to new FIFO API

2022-01-13 Thread Michael Niedermayer
On Wed, Jan 12, 2022 at 08:29:54PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-01-12 15:46:45) > > On Tue, Jan 11, 2022 at 09:45:48PM +0100, Anton Khirnov wrote: > > > --- > > > fftools/ffmpeg_mux.c | 22 +++--- > > > > This doesnt seem to apply to git master

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-13 Thread Lynne
13 Jan 2022, 02:49 by jamr...@gmail.com: > From: Anton Khirnov > > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with

Re: [FFmpeg-devel] [PATCH 01/35] lavu/fifo: disallow overly large fifo sizes

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > The API currently allows creating FIFOs up to > - UINT_MAX: av_fifo_alloc(), av_fifo_realloc(), av_fifo_grow() > - SIZE_MAX: av_fifo_alloc_array() > However the usable limit is determined by > - rndx/wndx being uint32_t > - av_fifo_[size,space] returning int > so no FIFO should be

Re: [FFmpeg-devel] 5.0 blocking issues

2022-01-13 Thread James Almer
On 1/13/2022 1:02 AM, Xiang, Haihao wrote: On Wed, 2022-01-12 at 21:35 +, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Wednesday, January 12, 2022 5:31 PM To: FFmpeg development discussions and patches Subject: Re:

Re: [FFmpeg-devel] [PATCH 24/28] ffmpeg_mux: drop a useless check and reduce indentation

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > do_video_stats() is only ever called for video. > --- > fftools/ffmpeg_mux.c | 42 -- > 1 file changed, 20 insertions(+), 22 deletions(-) > > diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c > index 76d9d4b9c4..8a64661c9c 100644 >

Re: [FFmpeg-devel] [PATCH 17/28] ffmpeg: move the mux queue into muxer private data

2022-01-13 Thread Andreas Rheinhardt
Anton Khirnov: > The muxing queue currently lives in OutputStream, which is a very large > struct storing the state for both encoding and muxing. The muxing queue > is only used by the code in ffmpeg_mux, so it makes sense to restrict it > to that file. > > This makes the first step towards

[FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

2022-01-13 Thread lance . lmwang
From: Limin Wang ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null - before the patch: entropy_coding_mode_flag0 = 1 after the patch: entropy_coding_mode_flag

[FFmpeg-devel] [PATCH 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

2022-01-13 Thread lance . lmwang
From: Limin Wang If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing cli: ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -frames:v 1 test.ts It'll report: [libopenh264 @ 0x5638300] Unsupported profile, select EProfileIdc

[FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information

2022-01-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..a55bef8 100644 --- a/libavcodec/libopenh264enc.c +++

Re: [FFmpeg-devel] [PATCH V3 4/4] libavcodec/qsvenc: Add transform skip to hevc_qsv

2022-01-13 Thread Chen, Wenbin
> On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > > Add transform_skip option to hevc_qsv. By enabling this option, > > the transform_skip_enabled_flag in PPS will be set to 1. > > This option is supported on the platform equal or newer than CNL. > > > > Signed-off-by: Wenbin Chen > > ---

Re: [FFmpeg-devel] [PATCH V3 2/4] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv

2022-01-13 Thread Chen, Wenbin
> On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > > Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can > > disable deblocking. > > > > Signed-off-by: Wenbin Chen > > --- > > doc/encoders.texi | 6 ++ > > libavcodec/qsvenc.c | 8 > > libavcodec/qsvenc.h