Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc_hevc: add -pic_timing_sei option

2022-01-17 Thread Xiang, Haihao
On Wed, 2022-01-12 at 12:50 +0800, Haihao Xiang wrote: > The SDK may insert picture timing SEI for hevc and the code to set mfx > parameter has been added in qsvenc, however the corresponding option is > missing in the hevc option array > > Reviewed-by: Limin Wang > Signed-off-by: Haihao Xiang >

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add encode support for screen content coding extension

2022-01-17 Thread Xiang, Haihao
On Wed, 2022-01-12 at 16:36 +0800, Haihao Xiang wrote: > Enables HEVC Screen Content Coding extension support on ICL+ platform > > Signed-off-by: Haihao Xiang > --- > v2: rebased it against the latest master and added scc to the doc > > doc/encoders.texi| 3 +++ > libavcodec/qsvenc.c

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9

2022-01-17 Thread Xiang, Haihao
On Thu, 2022-01-13 at 13:45 +0800, Haihao Xiang wrote: > Add -tile_rows and -tile_cols options to specify the number of tile > rows and columns > > Signed-off-by: Haihao Xiang > --- > v2: add option descriptions in the doc > > doc/encoders.texi | 6 ++ > libavcodec/qsvenc.c | 4

Re: [FFmpeg-devel] [PATCH] lavu/videotoolbox: add support for memory mapping frames

2022-01-17 Thread Anton Khirnov
Quoting Cameron Gutman (2022-01-10 09:17:37) > > > On Jan 9, 2022, at 3:24 AM, Anton Khirnov wrote: > > > > Quoting Cameron Gutman (2022-01-03 01:33:19) > >> Signed-off-by: Cameron Gutman > >> --- > >> libavutil/hwcontext_videotoolbox.c | 25 + > >> 1 file changed, 25 ins

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9

2022-01-17 Thread myp...@gmail.com
On Mon, Jan 17, 2022 at 4:30 PM Xiang, Haihao wrote: > > On Thu, 2022-01-13 at 13:45 +0800, Haihao Xiang wrote: > > Add -tile_rows and -tile_cols options to specify the number of tile > > rows and columns > > > > Signed-off-by: Haihao Xiang > > --- > > v2: add option descriptions in the doc > > >

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9

2022-01-17 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > myp...@gmail.com > Sent: Monday, January 17, 2022 11:36 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support > for VP9 > > On Mon, Jan 17, 2022 at 4:

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9

2022-01-17 Thread myp...@gmail.com
On Mon, Jan 17, 2022 at 6:57 PM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > myp...@gmail.com > > Sent: Monday, January 17, 2022 11:36 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: a

Re: [FFmpeg-devel] http: honor response headers in redirect caching

2022-01-17 Thread Ronald S. Bultje
Hi, On Tue, Jan 11, 2022 at 9:43 AM Eran Kornblau wrote: > Hi all, > > Recently I’ve submitted a patch that adds a config option to disable the > caching of http redirects. > We planned this as a workaround to the fact there’s a limit on the > expiration that can be set on S3 pre-signed URLs. >

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9

2022-01-17 Thread James Almer
On 1/17/2022 7:57 AM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of myp...@gmail.com Sent: Monday, January 17, 2022 11:36 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 On

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/16/2022 7:54 PM, Marton Balint wrote: On Sun, 16 Jan 2022, Nicolas George wrote: James Almer (12022-01-12): From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/16/2022 8:27 AM, Nicolas George wrote: James Almer (12022-01-12): From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate th

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > And they can if they want to. It has a very specific purpose and it fulfills > it. Just be clearer in the documentation. > Please, stop asking for this. It's an incredibly niche usecase you want for > libavfilter, so you can and should implement it there. The API is t

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
Marton Balint (12022-01-16): > Should the serializaton and unserialization functions store/parse both the > channel label and the channel designation? As far as I see right now it is > kind of inconsistent: av_channel_layout_describe_print() prints the label > (if exists), not the designation, but

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 10:53 AM, Nicolas George wrote: Marton Balint (12022-01-16): Should the serializaton and unserialization functions store/parse both the channel label and the channel designation? As far as I see right now it is kind of inconsistent: av_channel_layout_describe_print() prints the l

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > Yes, which is why I'll make describe() stop looking at the name field. Unacceptable. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 10:56 AM, Nicolas George wrote: James Almer (12022-01-17): Yes, which is why I'll make describe() stop looking at the name field. Unacceptable. Either that, or the field is removed. The opaque field is more than enough for your usecase. lavfi can and should use it to do ever

[FFmpeg-devel] [PATCH] avformat/imfdec: Use proper logcontext

2022-01-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/imfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 566a0fb792..d67c9b8898 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -200,7 +200,7 @@ static int parse

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 10:51 AM, Nicolas George wrote: James Almer (12022-01-17): And they can if they want to. It has a very specific purpose and it fulfills it. Just be clearer in the documentation. Please, stop asking for this. It's an incredibly niche usecase you want for libavfilter, so you ca

Re: [FFmpeg-devel] [PATCH] Website release notes for 5.0

2022-01-17 Thread Lynne
15 Jan 2022, 01:48 by d...@lynne.ee: > 14 Jan 2022, 20:39 by d...@lynne.ee: > > Okay, the release will be officially out on 16:00 UTC+1 (CET) on Monday, the > 17th, > so I'll push the update to the webpage then. > Website updated, so I think that makes the release officially announced. _

Re: [FFmpeg-devel] [FFmpeg-cvslog] [ffmpeg-web] branch master updated. a23b3fe Website release notes for 5.0

2022-01-17 Thread Gyan Doshi
On 2022-01-17 08:30 pm, ffmpeg-...@ffmpeg.org wrote: The branch, master has been updated via a23b3fe406dcabfbed5f5b31f3f07362173a10cb (commit) from c362eec3ccd1ebe4dafc8500b70238d96aa4ba64 (commit) - Log - commi

Re: [FFmpeg-devel] [FFmpeg-cvslog] [ffmpeg-web] branch master updated. a23b3fe Website release notes for 5.0

2022-01-17 Thread Lynne
17 Jan 2022, 16:04 by ffm...@gyani.pro: > > > On 2022-01-17 08:30 pm, ffmpeg-...@ffmpeg.org wrote: > >> The branch, master has been updated >> via a23b3fe406dcabfbed5f5b31f3f07362173a10cb (commit) >> from c362eec3ccd1ebe4dafc8500b70238d96aa4ba64 (commit) >> >> >> - Log

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > -map_channel works perfectly with the current bitmask API, and the new one. Not if there are several times the same channel with different labels. It should. -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > Either that, or the field is removed. Are we discussing together to design the best API possible or are you a dictator making threats? The label field stays, and the parse and stringify functions must be reciprocal of each other. The API is unacceptable otherwise. --

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 1:48 PM, Nicolas George wrote: James Almer (12022-01-17): -map_channel works perfectly with the current bitmask API, and the new one. Not if there are several times the same channel with different labels. It should. Patches are always welcome for new or updated functionality.

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 1:50 PM, Nicolas George wrote: James Almer (12022-01-17): Either that, or the field is removed. Are we discussing together to design the best API possible or are you a dictator making threats? Like you said below, the functions must be reciprocal, so they can't take that fie

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > Like you said below, the functions must be reciprocal, so they can't take > that field into account. A serializaion function is supposed to serialize the whole structure. I will not accept less. -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 1:54 PM, Nicolas George wrote: James Almer (12022-01-17): Like you said below, the functions must be reciprocal, so they can't take that field into account. A serializaion function is supposed to serialize the whole structure. I will not accept less. It will print the whole s

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > It will print the whole structure, what makes you think it wont? It doesn't > need custom names to be set to do that. If it prints the whole structure, including the names, and if the parsing function parses the whole result, including the names, it is good. Anything e

[FFmpeg-devel] [PATCH 001/289 v4] Add a new channel layout API

2022-01-17 Thread James Almer
From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just uint64_t bitmasks. Expanded and completed by Vit

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, James Almer wrote: You're still thinking there's a distinction, when i already told you that there is none. I added the name field because people wanted to give non standard channel names, and maybe also change the standard ones too. It's not a label to go alongside

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread James Almer
On 1/17/2022 5:18 PM, Marton Balint wrote: On Mon, 17 Jan 2022, James Almer wrote: You're still thinking there's a distinction, when i already told you that there is none. I added the name field because people wanted to give non standard channel names, and maybe also change the standar

Re: [FFmpeg-devel] [PATCH 001/289 v4] Add a new channel layout API

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, James Almer wrote: [...] -static const char *get_channel_name(int channel_id) +static const char *get_channel_name(enum AVChannel channel_id) { -if (channel_id < 0 || channel_id >= FF_ARRAY_ELEMS(channel_names)) +if ((unsigned) channel_id >= FF_ARRAY_ELEMS(channe

[FFmpeg-devel] [PATCH 001/289 v5] Add a new channel layout API

2022-01-17 Thread James Almer
From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just uint64_t bitmasks. Expanded and completed by Vit

[FFmpeg-devel] avfilter/adelay - interactive commands

2022-01-17 Thread deiwo deiwo
Hello, I would like to ask if it makes sense to implement ZeroMQ interactive commands for the adelay filter, from the performance and memory point of view. If it does make sense then is it possible to malloc/free/realloc memory within the command processing function? Can it cause noticeable delays

Re: [FFmpeg-devel] [PATCH 17/28] ffmpeg: move the mux queue into muxer private data

2022-01-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-01-13 11:50:48) > > My objections to adding a separately allocated muxing context and to > this MuxStream have not changed. Both incur unnecessary allocations > and indirections and (in case of the latter) loops; I cannot imagine any remotely real situation where

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Check size before subtraction

2022-01-17 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775808 - 8 cannot be represented in type 'long' Fixes: 43542/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5237670148702208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: Avoid signed integer overflow in coeff

2022-01-17 Thread Michael Niedermayer
Fixes: signed integer overflow: 15244032 * 256 cannot be represented in type 'int' Fixes: 43504/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-4865014842916864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [RFC] Next release and regressions

2022-01-17 Thread Michael Niedermayer
Hi Trac lists 162 non closed bugs with keyword regression https://trac.ffmpeg.org/query?status=new&status=open&status=reopened&keywords=~regression Our next major release maybe will be next december I suggest we try to reduce the number of regression bugs, and also to add fate tests for as many

Re: [FFmpeg-devel] [RFC] Next release and regressions

2022-01-17 Thread Jean-Baptiste Kempf
Heya, On Mon, 17 Jan 2022, at 23:39, Michael Niedermayer wrote: > Trac lists 162 non closed bugs with keyword regression > https://trac.ffmpeg.org/query?status=new&status=open&status=reopened&keywords=~regression > > Our next major release maybe will be next december When is 5.1.0 ? June/July? If

Re: [FFmpeg-devel] [RFC] Next release and regressions

2022-01-17 Thread Michael Niedermayer
On Mon, Jan 17, 2022 at 11:46:24PM +0100, Jean-Baptiste Kempf wrote: > Heya, > > On Mon, 17 Jan 2022, at 23:39, Michael Niedermayer wrote: > > Trac lists 162 non closed bugs with keyword regression > > https://trac.ffmpeg.org/query?status=new&status=open&status=reopened&keywords=~regression > > >

Re: [FFmpeg-devel] [RFC] Next release and regressions

2022-01-17 Thread Marton Balint
On Mon, 17 Jan 2022, Michael Niedermayer wrote: Hi Trac lists 162 non closed bugs with keyword regression https://trac.ffmpeg.org/query?status=new&status=open&status=reopened&keywords=~regression Our next major release maybe will be next december I suggest we try to reduce the number of re

Re: [FFmpeg-devel] [PATCH] lavu/videotoolbox: add support for memory mapping frames

2022-01-17 Thread Cameron Gutman
> On Jan 17, 2022, at 3:07 AM, Anton Khirnov wrote: > > Quoting Cameron Gutman (2022-01-10 09:17:37) >> >>> On Jan 9, 2022, at 3:24 AM, Anton Khirnov wrote: >>> >>> Quoting Cameron Gutman (2022-01-03 01:33:19) Signed-off-by: Cameron Gutman --- libavutil/hwcontext_videotoolbo