Re: [FFmpeg-devel] configure error: pkg not found even though it is available

2022-01-25 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2022-01-26 02:36, Gyan Doshi wrote: > Confirm that /Users/Shared/ffmpeg/sw/include/libvmaf has current header > which declares vmaf_init() Yes, the header file exists in the directory and the function vmaf_init() is declared. The vmaf version

Re: [FFmpeg-devel] configure error: pkg not found even though it is available

2022-01-25 Thread Gyan Doshi
On 2022-01-26 12:55 pm, Helmut K. C. Tessarek wrote: Hello, I compile the static binaries for macOS and just got a configure error: ERROR: libvmaf >= 2.0.0 not found using pkg-config The file looks as follows: $ cat libvmaf.pc prefix=/Users/Shared/ffmpeg/sw libdir=${prefix}/lib

[FFmpeg-devel] configure error: pkg not found even though it is available

2022-01-25 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello, I compile the static binaries for macOS and just got a configure error: ERROR: libvmaf >= 2.0.0 not found using pkg-config The file looks as follows: $ cat libvmaf.pc prefix=/Users/Shared/ffmpeg/sw libdir=${prefix}/lib

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor

2022-01-25 Thread Lynne
25 Jan 2022, 18:17 by one...@gmail.com: > On Tue, Jan 25, 2022 at 11:46 AM Lynne wrote: > >> 21 Jan 2022, 09:51 by d...@lynne.ee: >> >> > 21 Jan 2022, 09:33 by d...@lynne.ee: >> > >> >> This commit rewrites the internal transform code into a constructor >> >> that stitches transforms (codelets).

Re: [FFmpeg-devel] [PATCH V5 1/2] libavcodec/vaapi_decode: fix the problem that init_pool_size < nb_surface

2022-01-25 Thread Xiang, Haihao
On Tue, 2022-01-11 at 14:55 +0800, Wenbin Chen wrote: > For vaapi if the init_pool_size is not zero, the pool size is fixed. > This means max surfaces is init_pool_size, but when mapping vaapi > frame to qsv frame, the init_pool_size < nb_surface. The cause is that > vaapi_decode_make_config()

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

2022-01-25 Thread lance . lmwang
On Tue, Jan 25, 2022 at 04:28:33PM -0800, Chad Fraleigh wrote: > Since apparently linux will auto-detect (as mentioned by Marton Balint), > based on the optlen parameter, just using unsigned char in all cases seems to > be the cleanest. However, I would advise including a comment in the code to

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

2022-01-25 Thread Brad Smith
On 1/25/2022 7:28 PM, Chad Fraleigh wrote: Since apparently linux will auto-detect (as mentioned by Marton Balint), based on the optlen parameter, just using unsigned char in all cases seems to be the cleanest. However, I would advise including a comment in the code to that effect which says

Re: [FFmpeg-devel] [PATCH] Fix setsockopt IP_MULTICAST_TTL on OpenBSD

2022-01-25 Thread Chad Fraleigh
Since apparently linux will auto-detect (as mentioned by Marton Balint), based on the optlen parameter, just using unsigned char in all cases seems to be the cleanest. However, I would advise including a comment in the code to that effect which says to ignore the [outdated] linux documentation

[FFmpeg-devel] [PATCH 21/21] avcodec/mpegvideo: Move frame_rate_index to (Mpeg1|MPEG12Enc)Context

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 15 --- libavcodec/mpeg12enc.c | 11 ++- libavcodec/mpegvideo.h | 1 - 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 0c5eddb7f1..4a7bd6d466

[FFmpeg-devel] [PATCH 20/21] avcodec/speedhqenc: Add SpeedHQEncContext and move slice_start to it

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 3 --- libavcodec/speedhqenc.c | 19 ++- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index e5a4cc9b81..9243edefce 100644 ---

[FFmpeg-devel] [PATCH 19/21] avcodec/mpegvideo_enc: Move H.263p? encoders to ituh263enc.c

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c| 72 ++ libavcodec/mpegvideo_enc.c | 72 -- 2 files changed, 72 insertions(+), 72 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c

[FFmpeg-devel] [PATCH 18/21] avcodec/mpegvideo_enc: Move msmpeg4/wmv1 encoders to msmpeg4enc.c

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 42 -- libavcodec/msmpeg4enc.c| 42 ++ 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH 17/21] avcodec/mpegvideo: Move gop_picture_number to MPEG12EncContext

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 9 ++--- libavcodec/mpegvideo.h | 1 - 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index bec522d8e7..eaab968425 100644 --- a/libavcodec/mpeg12enc.c +++

[FFmpeg-devel] [PATCH 16/21] avcodec/mpegvideo_enc: Don't sync gop_picture_number among slice threads

2022-01-25 Thread Andreas Rheinhardt
It is only used by the main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 35f0f79d4e..93deded66c 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 15/21] avcodec/mpegvideo: Move timecode_frame_start to Mpeg1Context

2022-01-25 Thread Andreas Rheinhardt
It is only used there and only by the main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 11 ++- libavcodec/mpegvideo.h | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index

[FFmpeg-devel] [PATCH 14/21] avcodec/mpegvideo: Move aspect_ratio_info to Mpeg1Context

2022-01-25 Thread Andreas Rheinhardt
Only used there and only by the main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 23 --- libavcodec/mpegvideo.h | 1 - 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index

[FFmpeg-devel] [PATCH 13/21] avcodec/mpeg4videodec: Use stack variable for aspect_ratio_info

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videodec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 00bf7b6c4a..bdd320b1df 100644 --- a/libavcodec/mpeg4videodec.c +++

[FFmpeg-devel] [PATCH 12/21] avcodec/ituh263dec: Use stack variable for aspect_ratio_info

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c index 0a032ea54c..7d7a1f01a2 100644 --- a/libavcodec/ituh263dec.c +++ b/libavcodec/ituh263dec.c @@ -1222,8

[FFmpeg-devel] [PATCH 11/21] avcodec/ituh263enc: Use stack variable for aspect_ratio_info

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index 069c6a9acf..bd2deba210 100644 --- a/libavcodec/ituh263enc.c +++ b/libavcodec/ituh263enc.c @@ -193,13

[FFmpeg-devel] [PATCH 10/21] avcodec/mpeg4videoenc: Use stack variable for aspect_ratio_info

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index b3e697daf7..27e16c3b72 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH 09/21] avcodec/mpeg12enc: Reindent after the previous commit

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 255 - 1 file changed, 127 insertions(+), 128 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index e30e41027c..bec522d8e7 100644 --- a/libavcodec/mpeg12enc.c +++

[FFmpeg-devel] [PATCH 08/21] avcodec/mpeg12enc: Return early if no Sequence Header is written

2022-01-25 Thread Andreas Rheinhardt
Allows to avoid one level of indentation. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index a19100a42d..e30e41027c 100644 --- a/libavcodec/mpeg12enc.c

[FFmpeg-devel] [PATCH 07/21] avcodec/mpeg12enc: Use stack variable for aspect_ratio_info

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index e28aa809d2..a19100a42d 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -273,6 +273,7 @@

[FFmpeg-devel] [PATCH 06/21] avcodec/ituh263enc: Use stack variable for custom_pcf

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index 5a779e..069c6a9acf 100644 --- a/libavcodec/ituh263enc.c +++ b/libavcodec/ituh263enc.c @@ -106,6

[FFmpeg-devel] [PATCH 05/21] avcodec/mpeg4?video: Move vo_type to Mpeg4DecContext

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4video.h| 2 ++ libavcodec/mpeg4videodec.c | 16 libavcodec/mpegvideo.h | 1 - 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h index

[FFmpeg-devel] [PATCH 04/21] avcodec/mpeg4videodec: Keep vo_type in sync between threads

2022-01-25 Thread Andreas Rheinhardt
Otherwise one can get outdated values when setting FF_DEBUG_PICT_INFO. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videodec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 162048b604..33a0c97ba8 100644 ---

[FFmpeg-devel] [PATCH 03/21] avcodec/mpeg4videoenc: Use stack variable for vo_type

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg4videoenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index 8871d83281..b3e697daf7 100644 --- a/libavcodec/mpeg4videoenc.c +++

[FFmpeg-devel] [PATCH 02/21] avcodec/h263: Move decoding-only stuff to a new header h263dec.h

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Soon to be followed by a H263DecContext. libavcodec/flvdec.c| 2 +- libavcodec/h263.h | 40 --- libavcodec/h263dec.c | 1 + libavcodec/h263dec.h | 65 ++

[FFmpeg-devel] [PATCH 01/21] avcodec/h263: Remove declaration for inexistent function

2022-01-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/h263.h b/libavcodec/h263.h index 982e545491..31836ebb95 100644 --- a/libavcodec/h263.h +++ b/libavcodec/h263.h @@ -68,7 +68,6 @@ void ff_h263_encode_init(MpegEncContext *s);

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor

2022-01-25 Thread Paul B Mahol
On Tue, Jan 25, 2022 at 11:46 AM Lynne wrote: > 21 Jan 2022, 09:51 by d...@lynne.ee: > > > 21 Jan 2022, 09:33 by d...@lynne.ee: > > > >> This commit rewrites the internal transform code into a constructor > >> that stitches transforms (codelets). > >> This allows for transforms to reuse

Re: [FFmpeg-devel] [PATCH] fix bs2b parameter description

2022-01-25 Thread Gyan Doshi
On 2022-01-25 03:25 pm, Yue Wang wrote: Can someone review and approve this change? it's pretty trivial Needs changes in doc/filters.texi too. Since this is an ext library option, a link to reference is helpful. Regards, Gyan On Sat, Jan 15, 2022 at 11:45 PM Yue Wang wrote: From

Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor

2022-01-25 Thread Lynne
21 Jan 2022, 09:51 by d...@lynne.ee: > 21 Jan 2022, 09:33 by d...@lynne.ee: > >> This commit rewrites the internal transform code into a constructor >> that stitches transforms (codelets). >> This allows for transforms to reuse arbitrary parts of other >> transforms, and allows transforms to be

[FFmpeg-devel] [PATCH 1/2] avutil/random_seed: Speed up fate test

2022-01-25 Thread Michael Niedermayer
This decreases the quality of the seeds during the test, it does not affect the seeds outside the test. There is a small chance that this causes test failures, if that happens the threshold needs adjusting Testing on an idle x86_64 system shows that this passes even with the test strength

[FFmpeg-devel] [PATCH 2/2] libavutil/random_seed: Skip testing generic seed twice

2022-01-25 Thread Michael Niedermayer
If no platform specific random seed is supported then the generic code was tested twice, this is unneeded Signed-off-by: Michael Niedermayer --- libavutil/random_seed.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index

Re: [FFmpeg-devel] [PATCH] fix bs2b parameter description

2022-01-25 Thread Yue Wang
Can someone review and approve this change? it's pretty trivial On Sat, Jan 15, 2022 at 11:45 PM Yue Wang wrote: > From f0fdf5360ecd52d5f4031af9165b94c211defa03 Mon Sep 17 00:00:00 2001 > From: Yue Wang > Date: Sat, 15 Jan 2022 10:14:17 +0900 > Subject: [PATCH] fix bs2b parameter description.