Re: [FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow

2022-01-27 Thread Lynne
28 Jan 2022, 08:07 by d...@lynne.ee: > 28 Jan 2022, 03:08 by l...@chinaffmpeg.org: > >> From: Steven Liu >> >> Fix CID: 1497864 >> The control flow should return ENOSYS if nb_cd_matches is 0 at before >> and the ret equal AVERROR(ENOMEM) or goto end label, so remove the last >> control flow if

Re: [FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow

2022-01-27 Thread Lynne
28 Jan 2022, 03:08 by l...@chinaffmpeg.org: > From: Steven Liu > > Fix CID: 1497864 > The control flow should return ENOSYS if nb_cd_matches is 0 at before > and the ret equal AVERROR(ENOMEM) or goto end label, so remove the last > control flow if (ret >= 0) before end label. > > Signed-off-by:

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Curses, Apple Mail is broken, too. Using git imap-send instead. libavformat/mp3dec.c | 86

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Curses, Apple Mail is broken, too. Using git imap-send instead. If this doesn't work, I haven't a damn clue how to send

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- Let's see if I can get Apple Mail to do what Canary Mail cannot: Send an .eml without removing all the "extraneous"

[FFmpeg-devel] [PATCH 2/2] libavformat/mov: fix udta reading in trak box

2022-01-27 Thread Wang Chuan
if we are reading udta in trak box, the data should go to metadata of current stream. Signed-off-by: Wang Chuan --- libavformat/mov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1437d160f8..cb983defb3 100644 ---

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: fix type of 'Title of the content' in udta box

2022-01-27 Thread Wang Chuan
The type of 'Title of the content' should be "\xa9nam"(type begin with \xa9 means the following text is defined to be international text) not "name"(which means 'Name of object'). And when we try to decode mov header, we recognize "\xa9nam" as title in mov_read_udta_string(mov.c) Signed-off-by:

[FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-27 Thread Christopher Snowhill
Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, and also add the expected test results for the implementation. Signed-off-by: Christopher Snowhill --- libavformat/mp3dec.c | 86 ++- tests/fate/gapless.mak | 3 ++ tests/ref/fate/gapless-mp3-itunes

[FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow

2022-01-27 Thread Steven Liu
From: Steven Liu Fix CID: 1497864 The control flow should return ENOSYS if nb_cd_matches is 0 at before and the ret equal AVERROR(ENOMEM) or goto end label, so remove the last control flow if (ret >= 0) before end label. Signed-off-by: Steven Liu --- libavutil/tx.c | 3 --- 1 file changed, 3

[FFmpeg-devel] [PATCH 2/2] avutil/tx: add null pointer check after av_mallocz

2022-01-27 Thread Steven Liu
From: Steven Liu Fix CID: 1497863 there will get null pointer in attempt to initialize each if alloc memory failed. Signed-off-by: Steven Liu --- libavutil/tx.c | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/tx.c b/libavutil/tx.c index 50616adba7..79c9477d7f 100644 ---

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/metal: fix build with pre-10.11 deployment targets

2022-01-27 Thread Alex
Can you tell me more where this come from ? extern char ff_vf_yadif_videotoolbox_metallib_data[]; extern unsigned int ff_vf_yadif_videotoolbox_metallib_len; 22 December 2021, 02:15:23, by "rcombs" : - Ensure the yadif .metal compiles when targeting any Metal runtime version - Use some

[FFmpeg-devel] [PATCH] libavformat/utils: Check codec whitelist

2022-01-27 Thread Eric Juteau
Modified the function av_find_best_stream() such that, when a list of allowed codecs is supplied in the format context, and when the caller is requesting a decoder be returned, the function will select the best stream that has a decoder in the allowed decoders list. Signed-off-by: Eric Juteau

[FFmpeg-devel] [PATCH] avcodec/h264_ps, h264dec: Remove ALLOW_INTERLACED cruft

2022-01-27 Thread Andreas Rheinhardt
Since e1027aba680c4382c103fd1100cc5567a1530abc, ALLOW_INTERLACED is no longer defined in h264_ps.c, leading to a warning when encountering an SPS compatible with MBAFF. This warning was always nonsense, because ff_h264_decode_seq_parameter_set() is also used by the parser and it makes no sense for

Re: [FFmpeg-devel] [PATCH 1/2] lavf/udp: set ttl upper bound to 255

2022-01-27 Thread myp...@gmail.com
On Thu, Jan 27, 2022 at 1:09 PM "zhilizhao(赵志立)" wrote: > > > > > On Jan 27, 2022, at 12:22 AM, Zhao Zhili wrote: > > > > --- > > libavformat/udp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/udp.c b/libavformat/udp.c > > index 83c042d079..b441d2ea0d

Re: [FFmpeg-devel] [PATCH 090/281] lxfdec: convert to new channel layout API

2022-01-27 Thread Tomas Härdin
ons 2022-01-12 klockan 22:55 -0300 skrev James Almer: > From: Vittorio Giovara > > Signed-off-by: Vittorio Giovara > Signed-off-by: James Almer > --- >  libavformat/lxfdec.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/lxfdec.c b/libavformat/lxfdec.c

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Move preparations to main thread, fix race

2022-01-27 Thread Andreas Rheinhardt
jpeg2000_decode_tile() (which is run concurrently by several threads when using slice threading) currently modifies some joint values before doing its actual work. This is a data race that happens to work because all threads set the same values; but it is nevertheless undefined behaviour. Fix

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-01-27 Thread Nicolas George
Looking only at the changes in channel_layout.h: James Almer (12022-01-24): > diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > index d39ae1177a..51e4ea3804 100644 > --- a/libavutil/channel_layout.h > +++ b/libavutil/channel_layout.h > @@ -23,6 +23,10 @@ > #define

Re: [FFmpeg-devel] [PATCH 30/33] avcodec/mpegpicture: Add function to completely free MPEG-Picture

2022-01-27 Thread Andreas Rheinhardt
James Almer: > > > On 1/26/2022 6:34 PM, Andreas Rheinhardt wrote: >> Also use said function in mpegvideo.c and mpegvideo_enc.c; >> and make ff_free_picture_tables() static as it isn't needed anymore >> outside of mpegpicture.c. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> The new_picture

Re: [FFmpeg-devel] [PATCH 30/33] avcodec/mpegpicture: Add function to completely free MPEG-Picture

2022-01-27 Thread James Almer
On 1/26/2022 6:34 PM, Andreas Rheinhardt wrote: Also use said function in mpegvideo.c and mpegvideo_enc.c; and make ff_free_picture_tables() static as it isn't needed anymore outside of mpegpicture.c. Signed-off-by: Andreas Rheinhardt --- The new_picture is actually only used by encoders;

Re: [FFmpeg-devel] [PATCH 24/33] avcodec/mpegvideo: Fix off-by-one error when decoding >8 bit MPEG-4

2022-01-27 Thread Kieran Kunhya
On Wed, 26 Jan 2022 at 21:35, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Fixes visual corruptions on two macroblocks from two frames from > > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH v2] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread zhilizhao(赵志立)
> On Jan 27, 2022, at 5:07 PM, Lynne wrote: > > 27 Jan 2022, 09:38 by quinkbl...@foxmail.com: > >> MoltenVK doesn't reset instance when CreateInstance() failed, >> then DestroyInstance() leads to segmentation fault. MoltenVK's bug >> has been fixed by [1], which doesn't available on homebrew

Re: [FFmpeg-devel] [PATCH v2] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread Lynne
27 Jan 2022, 09:38 by quinkbl...@foxmail.com: > MoltenVK doesn't reset instance when CreateInstance() failed, > then DestroyInstance() leads to segmentation fault. MoltenVK's bug > has been fixed by [1], which doesn't available on homebrew yet. > Regardless MoltenVK's bug, we shouldn't call

Re: [FFmpeg-devel] [PATCH v2] configure: add libplacebo to help message

2022-01-27 Thread Lynne
27 Jan 2022, 09:43 by ffm...@gyani.pro: > > > On 2022-01-27 10:31 am, Zhao Zhili wrote: > >> --- >> configure | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configure b/configure >> index 493493b4c5..5b19a35f59 100755 >> --- a/configure >> +++ b/configure >> @@ -255,6 +255,7 @@

Re: [FFmpeg-devel] [PATCH v2] configure: add libplacebo to help message

2022-01-27 Thread Gyan Doshi
On 2022-01-27 10:31 am, Zhao Zhili wrote: --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 493493b4c5..5b19a35f59 100755 --- a/configure +++ b/configure @@ -255,6 +255,7 @@ External library support: --enable-libopenvino enable OpenVINO

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread zhilizhao(赵志立)
> On Jan 27, 2022, at 4:18 PM, Wu, Jianhua > wrote: > > Zhao Zhili wrote: >> Sent: Thursday, January 27, 2022 4:11 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround >> MoltenVK's bug which leads to segmentation fault >> >>

[FFmpeg-devel] [PATCH v2] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread Zhao Zhili
MoltenVK doesn't reset instance when CreateInstance() failed, then DestroyInstance() leads to segmentation fault. MoltenVK's bug has been fixed by [1], which doesn't available on homebrew yet. Regardless MoltenVK's bug, we shouldn't call DestroyInstance() in the case of CreateInstance() failed, so

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread Wu, Jianhua
Zhao Zhili wrote: > Sent: Thursday, January 27, 2022 4:11 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround > MoltenVK's bug which leads to segmentation fault > > MoltenVK doesn't reset instance pointer when CreateInstance() failed,

[FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault

2022-01-27 Thread Zhao Zhili
MoltenVK doesn't reset instance pointer when CreateInstance() failed, then DestroyInstance() leads to segmentation fault. MoltenVK's bug has been fixed by [1], which doesn't available on homebrew yet. Regardless MoltenVK's bug, we shouldn't call DestroyInstance() in the case of CreateInstance()