[FFmpeg-devel] [PATCH 41/41] avcodec/mpegvideo: Move frame_skip_(exp|cmp) to MPVMainEncContext

Only used by the main encoding thread. Signed-off-by: Andreas Rheinhardt --- frame_skip_factor/threshold are used by slice threads; they (and several other fields) could be moved by adding a pointer to the const MPVMainContext. I intend to do this in the future. libavcodec/mpegvideo.h | 2

[FFmpeg-devel] [PATCH 40/41] avcodec/mpegvideo: Move dummy dst for depr. opts to MPVMainEncContext

Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc.c | 2 +- libavcodec/mpegvideo.h| 4 libavcodec/mpegvideoenc.h | 8 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index a8efe72231..064562e6c5 100644 ---

[FFmpeg-devel] [PATCH 39/41] avcodec/mpegvideo: Move scenechange_threshold to MPVMainEncContext

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 4 ++-- libavcodec/mpegvideoenc.h | 4 +++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index 201ca81621..5c7654230a 100644 ---

[FFmpeg-devel] [PATCH 38/41] avcodec/mpegvideo_enc: Avoid allocations for q_int(er|ra)_matrix tables

Do this by making them part of an MPVMainEncContext; the MPVEncContexts still retain their pointers to access them. (These tables are quite big, so that putting them in the MpegEncContext would have been very wasteful for all the decoders using said structure. But this is no longer a problem:

[FFmpeg-devel] [PATCH 37/41] avcodec/mpegvideo_enc: Initialize non-JPEG q-matrices only once

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 892115b68f..7b55e9c17d 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 36/41] avcodec/mpegvideo: Move encoder-only base-arrays to MPVMainEncContext

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 10 libavcodec/mpegvideo_enc.c | 48 +++--- libavcodec/mpegvideoenc.h | 11 + libavcodec/ratecontrol.c | 4 ++-- 4 files changed, 37 insertions(+), 36 deletions(-) diff --git

[FFmpeg-devel] [PATCH 35/41] avcodec/mpegvideo: Allocate encoder-only tables in mpegvideo_enc.c

This commit moves the encoder-only allocations of the tables owned solely by the main encoder context to mpegvideo_enc.c. This avoids checks in mpegvideo.c for whether we are dealing with an encoder; it also improves modularity (if encoders are disabled, this code will no longer be included in the

[FFmpeg-devel] [PATCH 34/41] avcodec/mpegvideo: Move ratecontrol parameters to MPVMainEncContext

All except vbv_ignore_qmax are only ever used by the main encoding thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 13 - libavcodec/mpegvideo_enc.c | 4 ++-- libavcodec/mpegvideoenc.h | 31 ++- libavcodec/ratecontrol.c | 38

[FFmpeg-devel] [PATCH 33/41] avcodec/mpegvideo: Move brd_scale to MPVMainEncContext

Only used by the main encoding thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 6 +++--- libavcodec/mpegvideoenc.h | 5 +++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo.h

[FFmpeg-devel] [PATCH 32/41] avcodec/mpegvideo: Move vbv_delay to Mpeg1Context

Only used there and only by the main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 5 +++-- libavcodec/mpegvideo.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 4c53451d8c..631582fd61 100644

[FFmpeg-devel] [PATCH 31/41] avcodec/mpegvideo_enc: Remove unused parameter from encode_mb_hq()

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 61f8e20006..b90eb43399 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 30/41] avcodec/mpegvideo_enc: Remove unused function parameters

Seems to have been always unused since these functions were introduced in 1f0cd30fd9b656122436ecd625656a04f6235fb3. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH 29/41] avcodec/mpegvideo: Move header_bits to MPVMainEncContext

The header is always written by the main thread, so it is not surprising that header_bits can be moved to MPVMainEncContext as well. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc.c | 14 -- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 6 +++---

[FFmpeg-devel] [PATCH 28/41] avcodec/mpegvideo: Move last-pic information to MPVMainEncContext

last_pict_type, last_non_b_pict_type and last_lambda_for are only used by the encoder's main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 3 --- libavcodec/mpegvideo_enc.c | 16 libavcodec/mpegvideoenc.h | 4 libavcodec/msmpeg4enc.c| 5

[FFmpeg-devel] [PATCH 27/41] avcodec/mpegvideo: Remove write-only [fb]_code

Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c| 1 - libavcodec/mpeg12enc.c | 5 - libavcodec/mpeg4videoenc.c | 8 libavcodec/mpegvideo.h | 2 -- libavcodec/mpegvideo_enc.c | 8 5 files changed, 24 deletions(-) diff --git

[FFmpeg-devel] [PATCH 26/41] avcodec/mpegvideo: Move input_picture list to MPVMainEncContext

Also avoid an allocation while doing so. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 60 ++ libavcodec/mpegvideoenc.h | 2 ++ 3 files changed, 31 insertions(+), 32 deletions(-) diff --git

[FFmpeg-devel] [PATCH 25/41] avcodec/mpegvideo: Move pts and dts fields to MPVMainEncContext

user_specified_pts, dts_delta and reordered_pts are only used by the main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 10 -- libavcodec/mpegvideo_enc.c | 22 +++--- libavcodec/mpegvideoenc.h | 11 +++ 3 files changed, 22

[FFmpeg-devel] [PATCH 24/41] avcodec/mpegvideo: Move picture_in_gop_number to MPVMainEncContext

Only ever used by the main encoding thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 14 +++--- libavcodec/mpegvideoenc.h | 1 + 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegvideo.h

[FFmpeg-devel] [PATCH 23/41] avcodec/mpegvideo_enc: Don't set picture_in_gop_number for slice threads

They don't ever read this value. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 785aeb2aee..5f3bc93da7 100644 --- a/libavcodec/mpegvideo_enc.c +++

[FFmpeg-devel] [PATCH 22/41] avcodec/mpegvideo: Move gop_size to MPVMainEncContext

Only used by the main encoding thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 14 +++--- libavcodec/mpegvideoenc.h | 2 ++ libavcodec/ratecontrol.c | 2 +- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git

[FFmpeg-devel] [PATCH 21/41] avcodec/mpegvideo: Move me_pre and me_penalty_compensation to enc-ctx

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 2 -- libavcodec/mpegvideo_enc.c | 8 libavcodec/mpegvideoenc.h | 7 +-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index c9467f0752..7089160765

[FFmpeg-devel] [PATCH 20/41] avcodec/mpegvideoenc: Move ratecontrol to MPVMainEncContext

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 8 libavcodec/mpegvideo_enc.c | 38 +++--- libavcodec/mpegvideoenc.h | 8 libavcodec/ratecontrol.c | 31 +++ libavcodec/snowenc.c | 8

[FFmpeg-devel] [PATCH 18/41] avcodec/mpegvideoenc: Add proper MPVMainEncContext

This is in preparation for moving fields only used by the main encoder thread from MPVContext to MPVMainEncContext. Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 302 +++-- libavcodec/flvenc.c| 3 +- libavcodec/h261enc.c | 15

[FFmpeg-devel] [PATCH 19/41] avcodec/mpegvideoenc: Move tmp bframes to MPVMainEncContext

Also move b_frame_strategy and b_sensitivity; they are all only used by an encoder's main thread. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 5 libavcodec/mpegvideo_enc.c | 55 +++--- libavcodec/mpegvideoenc.h | 13 ++--- 3

[FFmpeg-devel] [PATCH 17/41] avcodec/mpegvideo_enc: Don't find encoder by ID

mpegvideo-based encoders supporting bframes implement this by opening encoders of their own to test how long the chains of bframes are supposed to be. The needed AVCodec was obtained via avcodec_find_encoder(). This is complicated, as the current encoder can be directly obtained. And it also is

[FFmpeg-devel] [PATCH 15/41] avcodec/speedhqenc: Add SpeedHQEncContext and move slice_start to it

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 3 --- libavcodec/speedhqenc.c | 19 ++- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index 18d2d0902f..8f65f53c2a 100644 ---

[FFmpeg-devel] [PATCH 14/41] avcodec/avcodec: Avoid MpegEncContext in AVHWAccel.decode_mb

Use an opaque pointer to void instead. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h| 6 +- libavcodec/mpegvideo_xvmc.c | 3 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ec1a0566a4..918753fd0e

[FFmpeg-devel] [PATCH 13/41] avcodec/mpegvideo: Move encoder-only stuff to a new header

Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 1 + libavcodec/flvdec.c | 1 + libavcodec/flvenc.c | 1 + libavcodec/h261enc.c| 1 + libavcodec/h263enc.h| 2 +- libavcodec/intelh263dec.c | 1 +

[FFmpeg-devel] [PATCH 10/41] avcodec/msmpeg4.h: Move encoder-only stuff to a new header

Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- libavcodec/msmpeg4.h | 15 - libavcodec/msmpeg4enc.c| 1 + libavcodec/msmpeg4enc.h| 45 ++ libavcodec/wmv2enc.c | 1 + 5 files changed, 48

[FFmpeg-devel] [PATCH 12/41] avcodec/h263.h: Move encoder-only stuff to a new header h263enc.h

Signed-off-by: Andreas Rheinhardt --- libavcodec/h263.h | 99 libavcodec/h263enc.h | 130 + libavcodec/ituh263enc.c| 1 + libavcodec/mpeg4videodec.c | 1 + libavcodec/mpeg4videoenc.c | 1 +

[FFmpeg-devel] [PATCH 11/41] avcodec/msmpegenc: Add MSMPEG4EncContext and move ac_stats to it

Also avoid the allocation by making it part of the context. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.h | 2 -- libavcodec/mpegvideo_enc.c | 7 --- libavcodec/msmpeg4enc.c| 26 +++--- libavcodec/msmpeg4enc.h| 8

[FFmpeg-devel] [PATCH 09/41] avcodec/wmv2: Split Wmv2Context into decoder and encoder context

Signed-off-by: Andreas Rheinhardt --- libavcodec/wmv2.c| 6 ++--- libavcodec/wmv2.h| 26 +++--- libavcodec/wmv2dec.c | 64 +++- libavcodec/wmv2enc.c | 29 +++- 4 files changed, 73 insertions(+), 52 deletions(-) diff

[FFmpeg-devel] [PATCH 08/41] avcodec/wmv2: Move initializing abt_scantables to the decoder

They are not used by the encoder at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/wmv2.c| 6 -- libavcodec/wmv2dec.c | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/wmv2.c b/libavcodec/wmv2.c index fd64a0938f..57e1267782 100644 ---

[FFmpeg-devel] [PATCH 07/41] avcodec/idctdsp: Constify the permutation parameter of ff_init_scantable

Signed-off-by: Andreas Rheinhardt --- libavcodec/idctdsp.c | 2 +- libavcodec/idctdsp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/idctdsp.c b/libavcodec/idctdsp.c index 71bd03c606..d07dc29207 100644 --- a/libavcodec/idctdsp.c +++ b/libavcodec/idctdsp.c @@

[FFmpeg-devel] [PATCH 06/41] avcodec/h261enc: Pass PutBitContext directly in h261_encode_motion()

Signed-off-by: Andreas Rheinhardt --- libavcodec/h261enc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/h261enc.c b/libavcodec/h261enc.c index 13fe5bbfb2..7e3af1ff9e 100644 --- a/libavcodec/h261enc.c +++ b/libavcodec/h261enc.c @@ -140,13 +140,12 @@

[FFmpeg-devel] [PATCH 05/41] avcodec/h261: Separate decode and encode contexts

Signed-off-by: Andreas Rheinhardt --- libavcodec/h261.c| 2 +- libavcodec/h261.h| 8 -- libavcodec/h261dec.c | 59 +++- libavcodec/h261enc.c | 54 +--- 4 files changed, 72 insertions(+), 51 deletions(-)

[FFmpeg-devel] [PATCH 04/41] avcodec/mpegvideo: Enable private contexts

MpegEncContext is used by many different codecs and every one of these uses just a subset of its fields. If one tries to separate this and e.g. add a real MpegContext and extension structures (say MpegDecContext and MpegEncContext), one runs into two difficulties: a) Some code is shared between

[FFmpeg-devel] [PATCH 03/41] avcodec/mjpegenc: Fix files with slices > 1, but threads == 1

In the aforementioned case mpegvideo_enc.c calls ff_mjpeg_encode_stuffing() at the end of every line which pads the output to byte-alignment and escapes it; yet it does not write the restart-markers (and also not the DRI marker when writing the header) and so the output files are broken. Fix this

[FFmpeg-devel] [PATCH 02/41] avcodec/mjpegenc: Remove nonsense assert

Writing optimal huffman tables is incompatible with using slices and hence commit 884506dfe2e29a5b2bd2905ca4f17e277e32acb1 that added writing optimal huffman tables also added an assert that the slice context count is always 1. Yet this was always wrong: a) The MJPEG-encoder has (and had) the

[FFmpeg-devel] [PATCH 01/41] avcodec/mpegvideo_enc: Allow slices only for slice-thread-able codecs

One can use slices without slice-threading. The results for mpegvideo-encoders are abysmal: AMV, SpeedHQ, H.263, RV10, RV20, MSMPEG4v2, MSMPEG4v3 and WMV1 produce broken files. WMV2 meanwhile expects the MpegEncContext given to ff_wmv2_encode_mb() to be at the beginning of a Wmv2Context (a

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashdec: avoid calling strlen multiple times

On Mon, Jan 24, 2022 at 11:48:22AM +0800, Steven Liu wrote: > 于2022年1月23日周日 11:52写道： > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/dashdec.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/dashdec.c

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/qsv: allow to add more parameter buffers to QSV frame

On Sat, 2022-01-29 at 15:41 +0100, Timo Rothenpieler wrote: > On 29.01.2022 15:30, Timo Rothenpieler wrote: > > On 27.01.2022 06:37, Xiang, Haihao wrote: > > > Will apply > > > > > > -Haihao > > > > > > > Something in this patchset broke build on Windows: > >

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

Le sam. 29 janv. 2022 à 14:42, Andreas Rheinhardt a écrit : > > Romain Beauxis: > > Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : > >> > >> > >> > >> On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > >> > >> Hi, thanks for the patch. I've not done a full code review yet, just a > >> few

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

Romain Beauxis: > Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : >> >> >> >> On 19 Jan 2022, at 15:42, Romain Beauxis wrote: >> >> Hi, thanks for the patch. I've not done a full code review yet, just a >> few >> initial remarks below: >> >>> This patch adds support for a new,

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

Quoting Brad Smith (2022-01-29 19:15:46) > On 1/29/2022 4:54 AM, Hendrik Leppkes wrote: > > > On Sat, Jan 29, 2022 at 5:45 AM Brad Smith > > wrote: > >> libatomic is dropped by --as-needed since it is not necessary. > >> > > Thats what this solution relies on, and thus there is no harm in adding

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : > > > > On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > > Hi, thanks for the patch. I've not done a full code review yet, just a > few > initial remarks below: > > > This patch adds support for a new, audio-specific input device using > >

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

On 1/29/2022 4:54 AM, Hendrik Leppkes wrote: On Sat, Jan 29, 2022 at 5:45 AM Brad Smith wrote: libatomic is dropped by --as-needed since it is not necessary. Thats what this solution relies on, and thus there is no harm in adding it. But it doesn't work, and the generated pkg-config files

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option

29 Jan 2022, 13:34 by toq...@outlook.com: > Ping. > >> From: Wu, Jianhua >> Sent: 2022年1月21日 19:42 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Wu, Jianhua >> Subject: [FFmpeg-devel] [PATCH v1]

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/qsv: allow to add more parameter buffers to QSV frame

On 29.01.2022 15:30, Timo Rothenpieler wrote: On 27.01.2022 06:37, Xiang, Haihao wrote: Will apply -Haihao Something in this patchset broke build on Windows: https://github.com/BtbN/FFmpeg-Builds/runs/4991054208#step:4:9491 Seems like it really was the typo gcc suggests. Pushed a fix for

Re: [FFmpeg-devel] [PATCH v2 1/3] lavc/qsv: allow to add more parameter buffers to QSV frame

On 27.01.2022 06:37, Xiang, Haihao wrote: Will apply -Haihao Something in this patchset broke build on Windows: https://github.com/BtbN/FFmpeg-Builds/runs/4991054208#step:4:9491 smime.p7s Description: S/MIME Cryptographic Signature ___

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option

Ping. > From: Wu, Jianhua > Sent: 2022年1月21日 19:42 > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Jianhua > Subject: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option > > [PATCH

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

On Sat, Jan 29, 2022 at 5:45 AM Brad Smith wrote: > > libatomic is dropped by --as-needed since it is not necessary. > Thats what this solution relies on, and thus there is no harm in adding it. - Hendrik ___ ffmpeg-devel mailing list