Re: [FFmpeg-devel] [PATCH] libavcodec/hevc_mp4toannexb_bsf: insert extradata before non-AUD unit

2022-03-21 Thread Xiang, Haihao
On Thu, 2022-03-17 at 14:35 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > It is possible that an IRAP frame in input AVPacket contains VPS, SPS > and PPS, and these headers should take effect. However the prepended > extradata might override these headers. This patch inserts extradata >

[FFmpeg-devel] [PATCH] avcodec/bsf: Add FFBitStreamFilter, hide internals of BSFs

2022-03-21 Thread Andreas Rheinhardt
This patch is analogous to 20f972701806be20a77f808db332d9489343bb78: It hides the internal part of AVBitStreamFilter by adding a new internal structure FFBitStreamFilter (declared in bsf_internal.h) that has an AVBitStreamFilter as its first member; the internal part of AVBitStreamFilter is moved

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-21 Thread Martin Storsjö
On Mon, 21 Mar 2022, Ben Avison wrote: On 19/03/2022 23:06, Martin Storsjö wrote: As you are writing assembly for these functions, I would very much appreciate if you could add checkasm tests for all the functions you're implementing. I see that there exists a test for the blockdsp

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-21 Thread James Almer
On 3/21/2022 6:12 PM, Andreas Rheinhardt wrote: James Almer: channels is deprecated on all supported raw demuxers. Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Check count in mxf_read_strong_ref_array()

2022-03-21 Thread Michael Niedermayer
On Mon, Mar 21, 2022 at 11:06:14AM +0100, Tomas Härdin wrote: > sön 2022-03-20 klockan 15:06 +0100 skrev Michael Niedermayer: > > On Sun, Mar 20, 2022 at 02:05:41PM +0100, Tomas Härdin wrote: > > > lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer: > > [...] > > > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split_bsf: Check in size

2022-03-21 Thread Michael Niedermayer
On Mon, Mar 21, 2022 at 09:59:00PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Mar 19, 2022 at 06:38:08PM +0100, Michael Niedermayer wrote: > >> On Fri, Mar 18, 2022 at 06:56:19PM +0100, Andreas Rheinhardt wrote: > >>> Michael Niedermayer: > Fixes: Out of array read >

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-21 Thread Andreas Rheinhardt
James Almer: > channels is deprecated on all supported raw demuxers. > > Signed-off-by: James Almer > --- > fftools/ffmpeg_opt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 720a3cc46a..213a34eadc 100644 > ---

Re: [FFmpeg-devel] [PATCH v2] lavf/mpegenc: fix memory leak in the fifo since the new API

2022-03-21 Thread Andreas Rheinhardt
Nicolas Gaullier: > The older av_fifo_realloc2 implemented an auto grow that should be ported as > such. > > This introduces a limitation in the buffer size. > AUTO_GROW_DEFAULT_BYTES is currently 1MB which seems reasonable here. > > Fix regressing since ea511196a6c85eb433e10cdbecb0b2c722faf20d

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-21 Thread Andreas Rheinhardt
James Almer: > On 3/21/2022 4:51 AM, Anton Khirnov wrote: >> Quoting Hendrik Leppkes (2022-03-21 08:37:43) >>> On Mon, Mar 21, 2022 at 12:38 AM Andreas Rheinhardt >>> wrote: James Almer: > The function is not meant to clear codec parameters, and the lavf > demux code >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs

2022-03-21 Thread Michael Niedermayer
On Mon, Mar 21, 2022 at 09:48:40PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: member access within null pointer of type 'const FFCodec' (aka > > 'const struct FFCodec') > > Fixes: > > 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: Check tile_cols

2022-03-21 Thread James Almer
On 2/1/2022 3:52 PM, Michael Niedermayer wrote: Fixes: division by zero Fixes: 43769/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5392562205097984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split_bsf: Check in size

2022-03-21 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Mar 19, 2022 at 06:38:08PM +0100, Michael Niedermayer wrote: >> On Fri, Mar 18, 2022 at 06:56:19PM +0100, Andreas Rheinhardt wrote: >>> Michael Niedermayer: Fixes: Out of array read Fixes:

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs

2022-03-21 Thread Andreas Rheinhardt
James Almer: > > > On 3/21/2022 5:19 PM, Michael Niedermayer wrote: >> Fixes: member access within null pointer of type 'const FFCodec' (aka >> 'const struct FFCodec') >> Fixes: >> 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 >> >> >> Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: Check tile_cols

2022-03-21 Thread Michael Niedermayer
On Tue, Feb 01, 2022 at 07:52:39PM +0100, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: > 43769/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5392562205097984 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs

2022-03-21 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: member access within null pointer of type 'const FFCodec' (aka 'const > struct FFCodec') > Fixes: > 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-21 Thread Andreas Rheinhardt
Vignesh Venkatasubramanian: > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > > Sample usage for animated AVIF image: >

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-21 Thread Martin Storsjö
On Mon, 21 Mar 2022, Ben Avison wrote: On 18/03/2022 19:10, Andreas Rheinhardt wrote: Ben Avison: +static int vc1_unescape_buffer_neon(const uint8_t *src, int size, uint8_t *dst) +{ +/* Dealing with starting and stopping, and removing escape bytes, are + * comparatively less

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs

2022-03-21 Thread James Almer
On 3/21/2022 5:19 PM, Michael Niedermayer wrote: Fixes: member access within null pointer of type 'const FFCodec' (aka 'const struct FFCodec') Fixes: 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 5/5] avcodec/exr: Avoid signed overflow in displayWindow

2022-03-21 Thread Michael Niedermayer
The inputs are unused except for this computation so wraparound does not give an attacker any extra values as they are already fully controlled Fixes: signed integer overflow: 0 - -2147483648 cannot be represented in type 'int' Fixes:

[FFmpeg-devel] [PATCH 4/5] avcodec/diracdec: avoid signed integer overflow in global mv

2022-03-21 Thread Michael Niedermayer
Fixes: signed integer overflow: -128275513086 * -76056576 cannot be represented in type 'long' Fixes: 45818/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5129799149944832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 3/5] avcodec/vmdaudio: Fix channels count bug

2022-03-21 Thread Michael Niedermayer
Fixes: division by zero Fixes: 45811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMDAUDIO_fuzzer-6412592581574656 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vmdaudio.c | 2 +- 1

[FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs

2022-03-21 Thread Michael Niedermayer
Fixes: member access within null pointer of type 'const FFCodec' (aka 'const struct FFCodec') Fixes: 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/5] avcodec/vp9_superframe_bsf: Check in size

2022-03-21 Thread Michael Niedermayer
Fixes: Out of array read Fixes: 45722/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_SUPERFRAME_fuzzer-5173378975137792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp9_superframe_bsf.c | 2

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: ensure channel count in the private context and decoder context are consistent

2022-03-21 Thread Michael Niedermayer
On Thu, Mar 17, 2022 at 10:07:29PM -0300, James Almer wrote: > avctx->ch_layout will be reinitialized using channel_mask later in the > function. > > Signed-off-by: James Almer > --- > libavcodec/wmaprodec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp9_superframe_split_bsf: Check in size

2022-03-21 Thread Michael Niedermayer
On Sun, Mar 13, 2022 at 04:03:42PM -0300, James Almer wrote: > > > On 3/12/2022 8:52 PM, Michael Niedermayer wrote: > > Fixes: Out of array read > > Fixes: > > 45137/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_SUPERFRAME_SPLIT_fuzzer-4984270639202304 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split_bsf: Check in size

2022-03-21 Thread Michael Niedermayer
On Sat, Mar 19, 2022 at 06:38:08PM +0100, Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 06:56:19PM +0100, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: Out of array read > > > Fixes: > > >

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-21 Thread Ben Avison
Hi Martin, Thanks very much for taking a look. On 19/03/2022 23:06, Martin Storsjö wrote: As you are writing assembly for these functions, I would very much appreciate if you could add checkasm tests for all the functions you're implementing. I see that there exists a test for the blockdsp

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-21 Thread Vignesh Venkatasubramanian
On Tue, Mar 15, 2022 at 8:59 AM Vignesh Venkatasubramanian wrote: > > On Thu, Mar 10, 2022 at 10:14 AM Vignesh Venkatasubramanian > wrote: > > > > On Thu, Mar 10, 2022 at 8:01 AM Andreas Rheinhardt > > wrote: > > > > > > Vignesh Venkatasubramanian: > > > > Add an AVIF muxer by re-using the

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-21 Thread Ben Avison
On 18/03/2022 19:10, Andreas Rheinhardt wrote: Ben Avison: +static int vc1_unescape_buffer_neon(const uint8_t *src, int size, uint8_t *dst) +{ +/* Dealing with starting and stopping, and removing escape bytes, are + * comparatively less time-sensitive, so are more clearly expressed

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-21 Thread James Almer
On 3/21/2022 4:51 AM, Anton Khirnov wrote: Quoting Hendrik Leppkes (2022-03-21 08:37:43) On Mon, Mar 21, 2022 at 12:38 AM Andreas Rheinhardt wrote: James Almer: The function is not meant to clear codec parameters, and the lavf demux code relies on this behavior. Regression since

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't free AVOption settable fields in avcodec_close()

2022-03-21 Thread James Almer
On 3/20/2022 9:46 PM, Andreas Rheinhardt wrote: James Almer: On 3/20/2022 8:34 PM, Andreas Rheinhardt wrote: James Almer: On 3/20/2022 8:26 PM, Andreas Rheinhardt wrote: James Almer: It can uninitialize fields that may still be used after the context was closed, so do it instead in

[FFmpeg-devel] [GAS-PP PATCH] Handle the aarch64 tbnz intruction in the same way as tbz, for armasm64

2022-03-21 Thread Martin Storsjö
--- I'll apply in a couple days if there's no comments. --- gas-preprocessor.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 67b130e..59c93c1 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -943,7 +943,7 @@

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Check count in mxf_read_strong_ref_array()

2022-03-21 Thread Tomas Härdin
sön 2022-03-20 klockan 15:06 +0100 skrev Michael Niedermayer: > On Sun, Mar 20, 2022 at 02:05:41PM +0100, Tomas Härdin wrote: > > lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer: > [...] > > > > > > > > > > > > > > > + > > > > > +    //avio_read() used int > > > > > +    if (c >

[FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: enable LowDelayBRC and MaxFrameSizeI/MaxFrameSizeP for more accurate bitrate control

2022-03-21 Thread He, Fan F
Feature introduction of LowDelayBRC, MaxFrameSizeI and MaxFrameSizeP could be found here: https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md Signed-off-by: Dmitry Ermilov Signed-off-by: Fan F He --- doc/encoders.texi | 26 ++

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable LowDelayBRC and MaxFrameSizeI/MaxFrameSizeP for more accurate bitrate control

2022-03-21 Thread He, Fan F
> -Original Message- > From: ffmpeg-devel On Behalf Of > "zhilizhao(???)" > Sent: Monday, March 21, 2022 1:18 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: enable > LowDelayBRC and MaxFrameSizeI/MaxFrameSizeP for more

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-21 Thread Anton Khirnov
Quoting Hendrik Leppkes (2022-03-21 08:37:43) > On Mon, Mar 21, 2022 at 12:38 AM Andreas Rheinhardt > wrote: > > > > James Almer: > > > The function is not meant to clear codec parameters, and the lavf demux > > > code > > > relies on this behavior. > > > Regression since

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-21 Thread Hendrik Leppkes
On Mon, Mar 21, 2022 at 12:38 AM Andreas Rheinhardt wrote: > > James Almer: > > The function is not meant to clear codec parameters, and the lavf demux code > > relies on this behavior. > > Regression since 327efa66331ebdc0087c6b656059a8df2f404019. > > > > Signed-off-by: James Almer > > --- > >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/hls: Check target_duration

2022-03-21 Thread Michael Niedermayer
On Mon, Mar 21, 2022 at 09:40:46AM +0800, Steven Liu wrote: > Michael Niedermayer 于2022年3月21日周一 07:31写道: > > > > Fixes: signed integer overflow: 77 * 100 cannot be > > represented in type 'long long' > > Fixes: > >

Re: [FFmpeg-devel] [EXT] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-03-21 Thread Ming Qian
Hi Andriy, What do you think of this patch? The Initialization flow defined in linux/Documentation/userspace-api/media/v4l/dev-decoder.rst 1. Set the coded format on OUTPUT via VIDIOC_S_FMT(). 2. Allocate source (bytestream) buffers via VIDIOC_REQBUFS() on OUTPUT. 3. Start streaming on

Re: [FFmpeg-devel] [PATCH 2/2] fate/h264: add test case for h264-loss_packet_for_prev_frame_num_offset

2022-03-21 Thread Steven Liu
> 2022年2月16日 下午4:54,Steven Liu 写道: > > > >> 2022年2月16日 下午4:51,Steven Liu 写道: >> >> From: Steven Liu >> >> Signed-off-by: Steven Liu >> --- >> tests/fate/h264.mak | 2 ++ >> ...h264-loss_packet_for_prev_frame_num_offset | 23 +++ >> 2 files

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_time_delta to cut segment at before hls_time

2022-03-21 Thread Steven Liu
"zhilizhao(赵志立)" 于2022年3月21日周一 11:55写道: > > > > > On Mar 18, 2022, at 8:20 PM, Steven Liu wrote: > > > > From: Steven Liu > > > > There have some video stream usually cannot get precise duration, > > for example: > > > > command: > > ffmpeg -i input.mp4 -c copy -copyts -f hls -hls_time 5